)]}'
{"tripleo_ansible/roles/tripleo-time/tasks/main.yml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"4bb4c5ed341e0b713e13762abd9f68ea720fc567","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  notify:"},{"line_number":39,"context_line":"    - Restart time services"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"- name: Run ptp tasks"},{"line_number":42,"context_line":"  include_tasks: tripleo_ptp.yml"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- name: Run phc2sys tasks"},{"line_number":45,"context_line":"  include_tasks: tripleo_phc2sys.yml"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_8dd6b04e","line":45,"range":{"start_line":41,"start_character":0,"end_line":45,"end_character":36},"updated":"2019-08-06 20:52:01.000000000","message":"these should be configurable such that they only are enabled if ptp support is enabled. I missed that this is mixing timezone \u0026 ptp.","commit_id":"c1e098de6d8e3936e379bc82215338fdc715e5dd"}],"tripleo_ansible/roles/tripleo-time/tasks/tripleo_ntp_stop.yml":[{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"c291f38a5f05923864abb64d133cd7664be6a13c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: Check NTP service state"},{"line_number":19,"context_line":"  systemd:"},{"line_number":20,"context_line":"    name: ntpd"},{"line_number":21,"context_line":"  register: ntpd_service_state"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_8cda5d75","line":18,"updated":"2019-07-17 18:06:54.000000000","message":"Is the initial check to overcome potential issues if ntpd is not installed?","commit_id":"7f6402baeaf7c17a1d518ef8a384a8b9f1cf7ad8"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"d0dffbbac9e728bf6882d0affe64133fadaf0d9f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: Check NTP service state"},{"line_number":19,"context_line":"  systemd:"},{"line_number":20,"context_line":"    name: ntpd"},{"line_number":21,"context_line":"  register: ntpd_service_state"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_a8b7f3f4","line":18,"in_reply_to":"7faddb67_8cda5d75","updated":"2019-07-18 15:28:48.000000000","message":"yes, I didn\u0027t want the service stop to fail in the case where the service was not even installed.","commit_id":"7f6402baeaf7c17a1d518ef8a384a8b9f1cf7ad8"},{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"c291f38a5f05923864abb64d133cd7664be6a13c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"- name: Stop NTP service"},{"line_number":25,"context_line":"  systemd:"},{"line_number":26,"context_line":"    name: ntpd"},{"line_number":27,"context_line":"    enabled: false"},{"line_number":28,"context_line":"  when:"},{"line_number":29,"context_line":"    - ntpd_service_state is success"},{"line_number":30,"context_line":"    - ((ntpd_service_state.status[\u0027SubState\u0027] | lower) \u003d\u003d \u0027running\u0027) or"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_cc7ff563","line":27,"updated":"2019-07-17 18:06:54.000000000","message":"Wouldn\u0027t we also need a `state: stopped`?","commit_id":"7f6402baeaf7c17a1d518ef8a384a8b9f1cf7ad8"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"d0dffbbac9e728bf6882d0affe64133fadaf0d9f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"- name: Stop NTP service"},{"line_number":25,"context_line":"  systemd:"},{"line_number":26,"context_line":"    name: ntpd"},{"line_number":27,"context_line":"    enabled: false"},{"line_number":28,"context_line":"  when:"},{"line_number":29,"context_line":"    - ntpd_service_state is success"},{"line_number":30,"context_line":"    - ((ntpd_service_state.status[\u0027SubState\u0027] | lower) \u003d\u003d \u0027running\u0027) or"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_68cd7b83","line":27,"in_reply_to":"7faddb67_cc7ff563","updated":"2019-07-18 15:28:48.000000000","message":"yes, good catch. fixing.","commit_id":"7f6402baeaf7c17a1d518ef8a384a8b9f1cf7ad8"}],"tripleo_ansible/roles/tripleo-time/tasks/tripleo_ptp.yml":[{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"c291f38a5f05923864abb64d133cd7664be6a13c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  block:"},{"line_number":34,"context_line":"    - name: Relax rp filter"},{"line_number":35,"context_line":"      sysctl:"},{"line_number":36,"context_line":"        name: \"net.ipv4.conf.{{ item }}.rp_filter\""},{"line_number":37,"context_line":"        value: 2"},{"line_number":38,"context_line":"        sysctl_set: true"},{"line_number":39,"context_line":"        sysctl_file: /etc/sysctl.d/99-tripleo-ptp.conf"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_ec3991a3","line":36,"updated":"2019-07-17 18:06:54.000000000","message":"In the future, we could potentially revisit this once the Heat template for the \"kernel\" sysctl settings has been converted into an Ansible role and re-use the functionality of that.\nhttps://github.com/openstack/tripleo-heat-templates/blob/master/deployment/kernel/kernel-baremetal-puppet.yaml","commit_id":"7f6402baeaf7c17a1d518ef8a384a8b9f1cf7ad8"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"d0dffbbac9e728bf6882d0affe64133fadaf0d9f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  block:"},{"line_number":34,"context_line":"    - name: Relax rp filter"},{"line_number":35,"context_line":"      sysctl:"},{"line_number":36,"context_line":"        name: \"net.ipv4.conf.{{ item }}.rp_filter\""},{"line_number":37,"context_line":"        value: 2"},{"line_number":38,"context_line":"        sysctl_set: true"},{"line_number":39,"context_line":"        sysctl_file: /etc/sysctl.d/99-tripleo-ptp.conf"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_a8acd39e","line":36,"in_reply_to":"7faddb67_ec3991a3","updated":"2019-07-18 15:28:48.000000000","message":"+1 I will make a note for that.","commit_id":"7f6402baeaf7c17a1d518ef8a384a8b9f1cf7ad8"}]}