)]}'
{"doc/source/roles/role-tripleo-upgrade-hiera.rst":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"fdae0292ec33c6e2bfcb8c9dfc9454873e6b5497","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":".. ansibleautoplugin::"},{"line_number":6,"context_line":"  :role: tripleo_ansible/roles/tripleo-upgrade-hiera"}],"source_content_type":"text/x-rst","patch_set":20,"id":"7faddb67_fb97acea","line":6,"updated":"2019-08-09 07:15:21.000000000","message":"_love this_ https://logs.opendev.org/64/673364/20/check/tripleo-ansible-docs/f26bff5/html/roles/role-tripleo-upgrade-hiera.html","commit_id":"d9d41ac016435f30e9669cf4818a2bd1a4243444"}],"tripleo_ansible/roles/tripleo-hieradata/defaults/main.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"864de5f3f72611f445b58a72fcbb21be6016d7fd","unresolved":false,"context_lines":[{"line_number":34,"context_line":"#   other_hierafile:"},{"line_number":35,"context_line":"#     foo: bar"},{"line_number":36,"context_line":"#"},{"line_number":37,"context_line":"# hieradata_content needs to be formed an hash where each key is a datafile"},{"line_number":38,"context_line":"# and the value is the hieradata to write in this datafile."},{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"# Example:"},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# extraconfig:"},{"line_number":43,"context_line":"#   foo: bar"},{"line_number":44,"context_line":"#   foo2: bar2"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_d1192188","line":41,"range":{"start_line":37,"start_character":2,"end_line":41,"end_character":1},"updated":"2019-07-30 07:46:07.000000000","message":"duplicate?","commit_id":"6389e140cf8efa6f90c0c981813d672f6628c0c2"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"b0a61bcae761896b9a8e47a53c90a86fd0887805","unresolved":false,"context_lines":[{"line_number":34,"context_line":"#   other_hierafile:"},{"line_number":35,"context_line":"#     foo: bar"},{"line_number":36,"context_line":"#"},{"line_number":37,"context_line":"# hieradata_content needs to be formed an hash where each key is a datafile"},{"line_number":38,"context_line":"# and the value is the hieradata to write in this datafile."},{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"# Example:"},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# extraconfig:"},{"line_number":43,"context_line":"#   foo: bar"},{"line_number":44,"context_line":"#   foo2: bar2"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_a08683b8","line":41,"range":{"start_line":37,"start_character":2,"end_line":41,"end_character":1},"in_reply_to":"7faddb67_c5e874b4","updated":"2019-07-30 17:34:33.000000000","message":"reading this again, i can see how this comment could be confusing, I will reword it.","commit_id":"6389e140cf8efa6f90c0c981813d672f6628c0c2"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"10fa6454b93f15d8ba7ae51b89e19fed9e5549ab","unresolved":false,"context_lines":[{"line_number":34,"context_line":"#   other_hierafile:"},{"line_number":35,"context_line":"#     foo: bar"},{"line_number":36,"context_line":"#"},{"line_number":37,"context_line":"# hieradata_content needs to be formed an hash where each key is a datafile"},{"line_number":38,"context_line":"# and the value is the hieradata to write in this datafile."},{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"# Example:"},{"line_number":41,"context_line":"#"},{"line_number":42,"context_line":"# extraconfig:"},{"line_number":43,"context_line":"#   foo: bar"},{"line_number":44,"context_line":"#   foo2: bar2"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_c5e874b4","line":41,"range":{"start_line":37,"start_character":2,"end_line":41,"end_character":1},"in_reply_to":"7faddb67_d1192188","updated":"2019-07-30 14:08:42.000000000","message":"Just a second example. The hieradata template can contain both host based config and global config so I wanted to doc both.","commit_id":"6389e140cf8efa6f90c0c981813d672f6628c0c2"}],"tripleo_ansible/roles/tripleo-hieradata/molecule/default/mock-hieradata.j2.yaml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"e634a189ec7008395cc920595304158f14174631","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"7faddb67_671bbdc9","updated":"2019-07-30 21:08:16.000000000","message":"mock data comes from standalone deployments. this is used to ensure we\u0027re able to test using molecule the various code path\u0027s we\u0027d expect to be available in a typical deployment.","commit_id":"d468bafba728bb8ae48119c7bd23649fed9263b3"}],"tripleo_ansible/roles/tripleo-hieradata/tasks/per_host.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"673cb72ce77f1c4cf862ad84b33374ada08bcbdf","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    content: \"{{ hieradata_content[inventory_hostname][\u0027datafiles\u0027][item] }}\""},{"line_number":22,"context_line":"  loop: \"{{ hieradata_content[inventory_hostname][\u0027datafiles\u0027] | list }}\""},{"line_number":23,"context_line":"  loop_control:"},{"line_number":24,"context_line":"    label: \"{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"7faddb67_09b16644","line":24,"range":{"start_line":24,"start_character":4,"end_line":24,"end_character":9},"updated":"2019-08-06 06:34:56.000000000","message":"nice thanks I didn\u0027t know about that https://docs.ansible.com/ansible/latest/user_guide/playbooks_loops.html#limiting-loop-output-with-label\n\ni noticed its a bit different than the original https://github.com/openstack/tripleo-common/blob/a1bd494fc79d3ad06c53a9c324ce293ce2803b15/roles/tripleo-hieradata/tasks/per_host.yaml#L8\n\nbut then, if you\u0027re not using it to choose a particular field of item (item.name like in the example at docs) what is the purpose of it here?","commit_id":"3d391b0fb80adce82e18c636b44045f8e1dfcfa0"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"8bf2b0ba8092f93ae0eac8d6856a19167a49689f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    content: \"{{ hieradata_content[inventory_hostname][\u0027datafiles\u0027][item] }}\""},{"line_number":22,"context_line":"  loop: \"{{ hieradata_content[inventory_hostname][\u0027datafiles\u0027] | list }}\""},{"line_number":23,"context_line":"  loop_control:"},{"line_number":24,"context_line":"    label: \"{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"7faddb67_8e09d42b","line":24,"range":{"start_line":24,"start_character":4,"end_line":24,"end_character":9},"in_reply_to":"7faddb67_09b16644","updated":"2019-08-06 12:47:40.000000000","message":"this is just limiting the output so we dont see a massive json output in the terminal per round.","commit_id":"3d391b0fb80adce82e18c636b44045f8e1dfcfa0"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c4fccdeb63df41114530eb28e18ab616018dcc8b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    content: \"{{ hieradata_content[inventory_hostname][\u0027datafiles\u0027][item] }}\""},{"line_number":22,"context_line":"  loop: \"{{ hieradata_content[inventory_hostname][\u0027datafiles\u0027] | list }}\""},{"line_number":23,"context_line":"  loop_control:"},{"line_number":24,"context_line":"    label: \"{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"7faddb67_cea80522","line":24,"range":{"start_line":24,"start_character":4,"end_line":24,"end_character":9},"in_reply_to":"7faddb67_8e09d42b","updated":"2019-08-08 07:09:11.000000000","message":"right my understanding from those docs was that instead of getting {{ item }} dumped on each iteration, the point of using label is to limit that, say to just the name of item like label: {{ item.name }}\n\nso my question was if you\u0027re using it but not constraining then what does it give us","commit_id":"3d391b0fb80adce82e18c636b44045f8e1dfcfa0"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"fdae0292ec33c6e2bfcb8c9dfc9454873e6b5497","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    content: \"{{ hieradata_content[inventory_hostname][\u0027datafiles\u0027][item] }}\""},{"line_number":22,"context_line":"  loop: \"{{ hieradata_content[inventory_hostname][\u0027datafiles\u0027] | list }}\""},{"line_number":23,"context_line":"  loop_control:"},{"line_number":24,"context_line":"    label: \"{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"7faddb67_fbc9ec24","line":24,"range":{"start_line":24,"start_character":15,"end_line":24,"end_character":19},"updated":"2019-08-09 07:15:21.000000000","message":"so will you use item.name as per discussion in https://review.opendev.org/#/c/673364/18..20/tripleo_ansible/roles/tripleo-hieradata/tasks/per_host.yml  i thought that\u0027s what you meant with \"fair point, I will get that updated on the next review. I need to rebase this change anyway.\"","commit_id":"d9d41ac016435f30e9669cf4818a2bd1a4243444"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"2201993381e531a298dc14a1ba6d87863ed3b7e5","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    content: \"{{ hieradata_content[inventory_hostname][\u0027datafiles\u0027][item] }}\""},{"line_number":22,"context_line":"  loop: \"{{ hieradata_content[inventory_hostname][\u0027datafiles\u0027] | list }}\""},{"line_number":23,"context_line":"  loop_control:"},{"line_number":24,"context_line":"    label: \"{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"7faddb67_5f6b4284","line":24,"range":{"start_line":24,"start_character":15,"end_line":24,"end_character":19},"in_reply_to":"7faddb67_3f3a0698","updated":"2019-08-09 15:32:41.000000000","message":"Done","commit_id":"d9d41ac016435f30e9669cf4818a2bd1a4243444"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"1c14d30b535b90c7115000cfd0a4492e1b3bb7d5","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    content: \"{{ hieradata_content[inventory_hostname][\u0027datafiles\u0027][item] }}\""},{"line_number":22,"context_line":"  loop: \"{{ hieradata_content[inventory_hostname][\u0027datafiles\u0027] | list }}\""},{"line_number":23,"context_line":"  loop_control:"},{"line_number":24,"context_line":"    label: \"{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"7faddb67_3f3a0698","line":24,"range":{"start_line":24,"start_character":15,"end_line":24,"end_character":19},"in_reply_to":"7faddb67_fbc9ec24","updated":"2019-08-09 15:30:34.000000000","message":"opps. i failed to remove this on the last rebase...","commit_id":"d9d41ac016435f30e9669cf4818a2bd1a4243444"}],"zuul.d/layout.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d3efc5c91b491b92186a623a1d5f3ea81c161a22","unresolved":false,"context_lines":[{"line_number":40,"context_line":"          files: \u0026containers_multinode"},{"line_number":41,"context_line":"          - ^tripleo_ansible/roles/tripleo-hieradata/.*"},{"line_number":42,"context_line":"          - ^tripleo_ansible/roles/tripleo-upgrade-hiera/.*"},{"line_number":43,"context_line":"          irrelevant-files: *irrelevant_scenario_files"},{"line_number":44,"context_line":"    gate:"},{"line_number":45,"context_line":"      jobs:"},{"line_number":46,"context_line":"      - openstack-tox-linters"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7faddb67_58ff7faa","line":43,"updated":"2019-07-31 06:43:00.000000000","message":"these look good .. lets also add tripleo-ci-centos-7-standalone-upgrade (ideally we want tripleo-ci-centos-7-standalone-upgrade-stein cos that one is voting but obviously we can\u0027t have it here)","commit_id":"bae97bf8ba7f2f3d5d128e767b5d315775b3c89e"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"6afa75057a7791c0334a071c9197e4781f14ba40","unresolved":false,"context_lines":[{"line_number":40,"context_line":"          files: \u0026containers_multinode"},{"line_number":41,"context_line":"          - ^tripleo_ansible/roles/tripleo-hieradata/.*"},{"line_number":42,"context_line":"          - ^tripleo_ansible/roles/tripleo-upgrade-hiera/.*"},{"line_number":43,"context_line":"          irrelevant-files: *irrelevant_scenario_files"},{"line_number":44,"context_line":"    gate:"},{"line_number":45,"context_line":"      jobs:"},{"line_number":46,"context_line":"      - openstack-tox-linters"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7faddb67_4b07a483","line":43,"in_reply_to":"7faddb67_58ff7faa","updated":"2019-07-31 11:59:55.000000000","message":"Done","commit_id":"bae97bf8ba7f2f3d5d128e767b5d315775b3c89e"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"385be33bee52fc4ebf56c3caf235962d09f1761b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"          files:"},{"line_number":42,"context_line":"          - ^tripleo_ansible/.*octavia.*"},{"line_number":43,"context_line":"          irrelevant-files: *irrelevant_scenario_files"},{"line_number":44,"context_line":"      - tripleo-ci-centos-7-standalone-upgrade: \u0026standalone_upgrade"},{"line_number":45,"context_line":"          files:"},{"line_number":46,"context_line":"          - ^tripleo_ansible/roles/tripleo-hieradata/.*"},{"line_number":47,"context_line":"          - ^tripleo_ansible/roles/tripleo-upgrade-hiera/.*"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7faddb67_b7b8eb10","line":44,"updated":"2019-08-01 08:39:50.000000000","message":"at this point would be great if we could use the template but that would also bring standalone-upgrade-stein and i think that would fail here (but otherwise its the same stuff you have - though you are also overriding files)\nhttps://github.com/openstack/tripleo-ci/blob/master/zuul.d/standalone-jobs.yaml#L117-L428","commit_id":"3de3b676202410e27304cfcadcbf6b80ded1af48"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"2bb4719aa145615b044a5c6157fcd92446e5bdfb","unresolved":false,"context_lines":[{"line_number":41,"context_line":"          files:"},{"line_number":42,"context_line":"          - ^tripleo_ansible/.*octavia.*"},{"line_number":43,"context_line":"          irrelevant-files: *irrelevant_scenario_files"},{"line_number":44,"context_line":"      - tripleo-ci-centos-7-standalone-upgrade: \u0026standalone_upgrade"},{"line_number":45,"context_line":"          files:"},{"line_number":46,"context_line":"          - ^tripleo_ansible/roles/tripleo-hieradata/.*"},{"line_number":47,"context_line":"          - ^tripleo_ansible/roles/tripleo-upgrade-hiera/.*"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7faddb67_abbba20c","line":44,"in_reply_to":"7faddb67_b7b8eb10","updated":"2019-08-01 13:18:26.000000000","message":"Done","commit_id":"3de3b676202410e27304cfcadcbf6b80ded1af48"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"385be33bee52fc4ebf56c3caf235962d09f1761b","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      - tripleo-ci-centos-7-scenario003-standalone: *scenario003"},{"line_number":57,"context_line":"      - tripleo-ci-centos-7-scenario004-standalone: *scenario004"},{"line_number":58,"context_line":"      - tripleo-ci-centos-7-scenario010-standalone: *scenario010"},{"line_number":59,"context_line":"      - tripleo-ci-centos-7-standalone-upgrade: *standalone_upgrade"},{"line_number":60,"context_line":"    post:"},{"line_number":61,"context_line":"      jobs:"},{"line_number":62,"context_line":"      - publish-openstack-python-branch-tarball"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7faddb67_97bb6f0d","line":59,"range":{"start_line":59,"start_character":19,"end_line":59,"end_character":25},"updated":"2019-08-01 08:39:50.000000000","message":"we don\u0027t want that in the gate its non voting","commit_id":"3de3b676202410e27304cfcadcbf6b80ded1af48"}]}