)]}'
{"tripleo_ansible/roles/tripleo-ceph-common/defaults/main.yml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"17edc2c705607495a6344ac268e78d099b0261d5","unresolved":false,"context_lines":[{"line_number":144,"context_line":"pools: []"},{"line_number":145,"context_line":"ntp_service_enabled: false"},{"line_number":146,"context_line":"generate_fsid: false"},{"line_number":147,"context_line":"calling_ansible_environment_variables: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_d789996e","line":147,"range":{"start_line":147,"start_character":0,"end_line":147,"end_character":37},"updated":"2019-08-06 19:19:05.000000000","message":"I see the molecule test failed with [1]\n\nThe conditional check \u0027ceph_ansible_inherits_calling_ansible_environment\u0027 failed. The error was: error while evaluating conditional (ceph_ansible_inherits_calling_ansible_environment): \u0027ceph_ansible_inherits_calling_ansible_environment\u0027 is undefined\n\nThat\u0027s because I didn\u0027t use the same name here!\n\nSame problem with 004 [2]\n\n[1] https://logs.opendev.org/06/674706/1/check/tripleo-ansible-centos-7-molecule-tripleo-ceph-run-ansible/1c31949/reports.html\n\n[2] https://logs.opendev.org/06/674706/1/check/tripleo-ci-centos-7-scenario004-standalone/7a4c3bc/logs/undercloud/home/zuul/undercloud-ansible-8EYhCR/ansible.log.txt.gz#_2019-08-05_22_47_14_427","commit_id":"2bda0c8eefae02be49b46d349926657ba6c2413d"}],"tripleo_ansible/roles/tripleo-ceph-common/tasks/main.yml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"46b5aff579f5dbfe42bce2eac529e6df4b24d6a1","unresolved":false,"context_lines":[{"line_number":51,"context_line":"- when: ceph_ansible_inherits_calling_ansible_environment"},{"line_number":52,"context_line":"  block:"},{"line_number":53,"context_line":"    - name: get all ansible environment variables"},{"line_number":54,"context_line":"      shell: \"env | grep ANSIBLE_\""},{"line_number":55,"context_line":"      register: env_shell_output"},{"line_number":56,"context_line":"      ignore_errors: true"},{"line_number":57,"context_line":"    - name: set calling_ansible_environment_variables"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_3be3d6a2","line":54,"range":{"start_line":54,"start_character":25,"end_line":54,"end_character":34},"updated":"2020-02-05 15:56:43.000000000","message":"I think this needs to be grep \"^ANSIBLE_\"","commit_id":"eca6cd03e794a18fb748a166cf0558df3a2b7325"}],"tripleo_ansible/roles/tripleo-ceph-run-ansible/tasks/main.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"e7717f2e2b5051b964bef5b331a5033c36eca34a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        - env_shell_output.rc is defined"},{"line_number":41,"context_line":"        - env_shell_output.rc \u003d\u003d 0"},{"line_number":42,"context_line":"        - env_shell_output.stdout_lines is defined"},{"line_number":43,"context_line":"        - env_shell_output.stdout_lines|length \u003e 0"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"- name: set ceph-ansible command list"},{"line_number":46,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_5696204e","line":43,"range":{"start_line":43,"start_character":10,"end_line":43,"end_character":46},"updated":"2019-08-05 22:27:02.000000000","message":"I think this should be wrapped in parenthesis, which will ensure the filter is applied to the list prior to the expression being evaluated.","commit_id":"2bda0c8eefae02be49b46d349926657ba6c2413d"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"17edc2c705607495a6344ac268e78d099b0261d5","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        - env_shell_output.rc is defined"},{"line_number":41,"context_line":"        - env_shell_output.rc \u003d\u003d 0"},{"line_number":42,"context_line":"        - env_shell_output.stdout_lines is defined"},{"line_number":43,"context_line":"        - env_shell_output.stdout_lines|length \u003e 0"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"- name: set ceph-ansible command list"},{"line_number":46,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_173df1b9","line":43,"range":{"start_line":43,"start_character":10,"end_line":43,"end_character":46},"in_reply_to":"7faddb67_5696204e","updated":"2019-08-06 19:19:05.000000000","message":"Done","commit_id":"2bda0c8eefae02be49b46d349926657ba6c2413d"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"e7717f2e2b5051b964bef5b331a5033c36eca34a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"- name: set ceph-ansible command list"},{"line_number":46,"context_line":"  set_fact:"},{"line_number":47,"context_line":"    ceph_ansible_command_list:"},{"line_number":48,"context_line":"      - \"{{ calling_ansible_environment_variables|join(\u0027 \u0027) }}\""},{"line_number":49,"context_line":"      - ANSIBLE_ACTION_PLUGINS\u003d/usr/share/ceph-ansible/plugins/actions/"},{"line_number":50,"context_line":"      - ANSIBLE_CALLBACK_PLUGINS\u003d/usr/share/ceph-ansible/plugins/callback/"},{"line_number":51,"context_line":"      - ANSIBLE_ROLES_PATH\u003d/usr/share/ceph-ansible/roles/"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_767a3c24","line":48,"updated":"2019-08-05 22:27:02.000000000","message":"This would become a space separated string. are we needing a second fact to concatenate `env_shell_output.stdout_lines` and `ceph_ansible_command_list`?","commit_id":"2bda0c8eefae02be49b46d349926657ba6c2413d"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"17edc2c705607495a6344ac268e78d099b0261d5","unresolved":false,"context_lines":[{"line_number":45,"context_line":"- name: set ceph-ansible command list"},{"line_number":46,"context_line":"  set_fact:"},{"line_number":47,"context_line":"    ceph_ansible_command_list:"},{"line_number":48,"context_line":"      - \"{{ calling_ansible_environment_variables|join(\u0027 \u0027) }}\""},{"line_number":49,"context_line":"      - ANSIBLE_ACTION_PLUGINS\u003d/usr/share/ceph-ansible/plugins/actions/"},{"line_number":50,"context_line":"      - ANSIBLE_CALLBACK_PLUGINS\u003d/usr/share/ceph-ansible/plugins/callback/"},{"line_number":51,"context_line":"      - ANSIBLE_ROLES_PATH\u003d/usr/share/ceph-ansible/roles/"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_77854559","line":48,"in_reply_to":"7faddb67_767a3c24","updated":"2019-08-06 19:19:05.000000000","message":"I\u0027d prefer to make an extra fact to keep the code more modular. I don\u0027t want to add env_shell_output.stdout_lines here unless I know it\u0027s passed the when conditions under which I set that fact. I\u0027m setting it to a default on line 26 so that the join will always succeed.","commit_id":"2bda0c8eefae02be49b46d349926657ba6c2413d"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"0d99207436ba579d9445b5a5f045f526cc8b6994","unresolved":false,"context_lines":[{"line_number":45,"context_line":"- name: set ceph-ansible command list"},{"line_number":46,"context_line":"  set_fact:"},{"line_number":47,"context_line":"    ceph_ansible_command_list:"},{"line_number":48,"context_line":"      - \"{{ calling_ansible_environment_variables|join(\u0027 \u0027) }}\""},{"line_number":49,"context_line":"      - ANSIBLE_ACTION_PLUGINS\u003d/usr/share/ceph-ansible/plugins/actions/"},{"line_number":50,"context_line":"      - ANSIBLE_CALLBACK_PLUGINS\u003d/usr/share/ceph-ansible/plugins/callback/"},{"line_number":51,"context_line":"      - ANSIBLE_ROLES_PATH\u003d/usr/share/ceph-ansible/roles/"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_e660a103","line":48,"in_reply_to":"7faddb67_77854559","updated":"2019-08-07 01:24:04.000000000","message":"++","commit_id":"2bda0c8eefae02be49b46d349926657ba6c2413d"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"025d163ae839e4755b294889c754644fc8dfa48b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"- name: set ceph-ansible command list"},{"line_number":46,"context_line":"  set_fact:"},{"line_number":47,"context_line":"    ceph_ansible_command_list:"},{"line_number":48,"context_line":"      - \"{{ calling_ansible_environment_variables|join(\u0027 \u0027) }}\""},{"line_number":49,"context_line":"      - ANSIBLE_ACTION_PLUGINS\u003d/usr/share/ceph-ansible/plugins/actions/"},{"line_number":50,"context_line":"      - ANSIBLE_CALLBACK_PLUGINS\u003d/usr/share/ceph-ansible/plugins/callback/"},{"line_number":51,"context_line":"      - ANSIBLE_ROLES_PATH\u003d/usr/share/ceph-ansible/roles/"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_70877d14","line":48,"updated":"2019-08-07 14:31:43.000000000","message":"we could do this with the nodes-uuid playbook too and share the piece of code above maybe?","commit_id":"99374ae9069f12ac1404c371b2f3608481bb05c1"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"9a34ea4de1f62460d2c1aefa227f94bed2c356b1","unresolved":false,"context_lines":[{"line_number":41,"context_line":"      - \u0027{% if ceph_ansible_private_key_file is defined %}--private-key {{ ceph_ansible_private_key_file }}{% endif %}\u0027"},{"line_number":42,"context_line":"      - \u0027{% if ansible_python_interpreter is defined %}-e ansible_python_interpreter\u003d{{ ansible_python_interpreter }}{% endif %}\u0027"},{"line_number":43,"context_line":"      - \u0027-{%- for number in range(0, ceph_ansible_playbook_verbosity) -%}v{% endfor %}\u0027"},{"line_number":44,"context_line":"     - \u0027{% if ceph_ansible_skip_tags is defined and ceph_ansible_skip_tags|length \u003e 0%}--skip-tags {{ ceph_ansible_skip_tags }}{% endif %}\u0027"},{"line_number":45,"context_line":"      - \u0027-i\u0027"},{"line_number":46,"context_line":"      - \u0027{{ playbook_dir }}/ceph-ansible/inventory.yml\u0027"},{"line_number":47,"context_line":"      - \u0027--extra-vars\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_31d819ef","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":5},"updated":"2019-08-08 10:42:08.000000000","message":"I think you accidentally break the alignment here","commit_id":"3b82b8fb2999ea5c9878c1f2fe497129cbae013e"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"7090df67d7cde6b8c8f200fed7c1f8ed059a0f51","unresolved":false,"context_lines":[{"line_number":41,"context_line":"      - \u0027{% if ceph_ansible_private_key_file is defined %}--private-key {{ ceph_ansible_private_key_file }}{% endif %}\u0027"},{"line_number":42,"context_line":"      - \u0027{% if ansible_python_interpreter is defined %}-e ansible_python_interpreter\u003d{{ ansible_python_interpreter }}{% endif %}\u0027"},{"line_number":43,"context_line":"      - \u0027-{%- for number in range(0, ceph_ansible_playbook_verbosity) -%}v{% endfor %}\u0027"},{"line_number":44,"context_line":"     - \u0027{% if ceph_ansible_skip_tags is defined and ceph_ansible_skip_tags|length \u003e 0%}--skip-tags {{ ceph_ansible_skip_tags }}{% endif %}\u0027"},{"line_number":45,"context_line":"      - \u0027-i\u0027"},{"line_number":46,"context_line":"      - \u0027{{ playbook_dir }}/ceph-ansible/inventory.yml\u0027"},{"line_number":47,"context_line":"      - \u0027--extra-vars\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_118dddd2","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":5},"in_reply_to":"7faddb67_31d819ef","updated":"2019-08-08 10:46:32.000000000","message":"ah, thank you. i will fix","commit_id":"3b82b8fb2999ea5c9878c1f2fe497129cbae013e"}]}