)]}'
{"tripleo_ansible/roles/tripleo-cellv2/molecule/default/verify.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"cb68d3f0bad2aded0511990f741a3a0a63e522b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7faddb67_dbe21703","updated":"2019-08-22 14:48:44.000000000","message":"lets delete this file if its not needed.","commit_id":"74487107bab2573d6c22925fa95975f13b9f3b15"}],"tripleo_ansible/roles/tripleo-cellv2/tasks/add_internalapi_hosts_entries.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"fb8087eea79ad74785b536dfd996c4f97a58ebdd","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  lineinfile:"},{"line_number":20,"context_line":"    dest\u003d/etc/hosts"},{"line_number":21,"context_line":"    regexp\u003d\u0027.*{{ hostvars[item][\u0027internal_api_hostname\u0027] }}.*$\u0027"},{"line_number":22,"context_line":"    line\u003d\"{{ hostvars[item][\u0027internal_api_ip\u0027] }} {{ hostvars[item][\u0027internal_api_hostname\u0027] }} {{ hostvars[item][\u0027internal_api_hostname\u0027].split(\u0027.\u0027)[:2] | join(\u0027.\u0027) }}\""},{"line_number":23,"context_line":"    insertafter\u003d\"# HEAT_HOSTS_END\""},{"line_number":24,"context_line":"    state\u003dpresent"},{"line_number":25,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_127089da","line":22,"updated":"2019-08-22 20:57:08.000000000","message":"This makes the linters unhappy \n\n    2019-08-22 15:32:34.693486 | ubuntu-bionic | \u001b[1;31m[204]\u001b[0m \u001b[0;31mLines should be no longer than 160 chars\u001b[0m\n    2019-08-22 15:32:34.693608 | ubuntu-bionic | \u001b[0;34m/home/zuul/src/opendev.org/openstack/tripleo-ansible/tripleo_ansible/roles/tripleo-cellv2/tasks/add_internalapi_hosts_entries.yml\u001b[0m:\u001b[0;36m22\u001b[0m\n    2019-08-22 15:32:34.693751 | ubuntu-bionic | \u001b[0;35m    line\u003d\"{{ hostvars[item][\u0027internal_api_ip\u0027] }} {{ hostvars[item][\u0027internal_api_hostname\u0027] }} {{ hostvars[item][\u0027internal_api_hostname\u0027].split(\u0027.\u0027)[:2] | join(\u0027.\u0027) }}\"\u001b[0m\n\n\nWe might need to figure out a way to make this go with some line breaks.","commit_id":"4d42ff972e00f46726438fca4cccd5da2d43c21e"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"7c2dbff5f38e88a3cb7fedcd679c6f752d0ec2a6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"- name: Add CellController internalapi to control plan controller"},{"line_number":18,"context_line":"  become: true"},{"line_number":19,"context_line":"  lineinfile:"},{"line_number":20,"context_line":"    dest\u003d/etc/hosts"},{"line_number":21,"context_line":"    regexp\u003d\u0027.*{{ hostvars[item][\u0027internal_api_hostname\u0027] }}.*$\u0027"},{"line_number":22,"context_line":"    line\u003d\"{{ hostvars[item][\u0027internal_api_ip\u0027] }} {{ hostvars[item][\u0027internal_api_hostname\u0027] }} {{ hostvars[item][\u0027internal_api_hostname\u0027].split(\u0027.\u0027)[:2] | join(\u0027.\u0027) }}\""},{"line_number":23,"context_line":"    insertafter\u003d\"# HEAT_HOSTS_END\""},{"line_number":24,"context_line":"    state\u003dpresent"},{"line_number":25,"context_line":"  when:"},{"line_number":26,"context_line":"    - hostvars[item][\u0027internal_api_ip\u0027] is defined"},{"line_number":27,"context_line":"    - hostvars[item][\u0027internal_api_hostname\u0027] is defined"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_523cc1e0","line":24,"range":{"start_line":20,"start_character":0,"end_line":24,"end_character":17},"updated":"2019-08-22 20:59:34.000000000","message":"I think if we turn this task into yaml format we can use a carrot to shorten up the lines. Something like this should work: \n\n\n    - name: Add CellController internalapi to control plan controller\n      become: true\n      lineinfile:\n        dest: \"/etc/hosts\"\n        regexp: \".*{{ hostvars[item][\u0027internal_api_hostname\u0027] }}.*$\"\n        line: \u003e-\n          {{ hostvars[item][\u0027internal_api_ip\u0027] }} \n          {{ hostvars[item][\u0027internal_api_hostname\u0027] }} \n          {{ hostvars[item][\u0027internal_api_hostname\u0027].split(\u0027.\u0027)[:2] | join(\u0027.\u0027) }}\n        insertafter: \"# HEAT_HOSTS_END\"\n        state: \"present\"\n      when:\n        - hostvars[item][\u0027internal_api_ip\u0027] is defined\n        - hostvars[item][\u0027internal_api_hostname\u0027] is defined\n      with_items: \"{{ tripleo_cellv2_cellcontroller_group }}\"\n      register: hosts_result\n      notify:\n        - nova restart podman\n        - nova restart docker\n      tags:\n        - hosts\n        - create","commit_id":"4d42ff972e00f46726438fca4cccd5da2d43c21e"}],"tripleo_ansible/roles/tripleo-cellv2/tasks/check_cell_exist.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"cb68d3f0bad2aded0511990f741a3a0a63e522b0","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    become: true"},{"line_number":24,"context_line":"    shell: \u003e-"},{"line_number":25,"context_line":"      {{ tripleo_cellv2_containercli }} exec -i -u root nova_api"},{"line_number":26,"context_line":"      /usr/bin/nova-manage "},{"line_number":27,"context_line":"      {% if (tripleo_cellv2_debug | bool) %}"},{"line_number":28,"context_line":"      --debug"},{"line_number":29,"context_line":"      {% endif %}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_bbe95be4","line":26,"range":{"start_line":26,"start_character":26,"end_line":26,"end_character":27},"updated":"2019-08-22 14:48:44.000000000","message":"white space.","commit_id":"74487107bab2573d6c22925fa95975f13b9f3b15"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"cb68d3f0bad2aded0511990f741a3a0a63e522b0","unresolved":false,"context_lines":[{"line_number":27,"context_line":"      {% if (tripleo_cellv2_debug | bool) %}"},{"line_number":28,"context_line":"      --debug"},{"line_number":29,"context_line":"      {% endif %}"},{"line_number":30,"context_line":"      cell_v2 list_cells | grep {{ tripleo_cellv2_cell_name }}"},{"line_number":31,"context_line":"    ignore_errors: yes"},{"line_number":32,"context_line":"    register: cell_check_result"},{"line_number":33,"context_line":"  - name: Fail if cell already exist"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_3bac8b9e","line":30,"range":{"start_line":30,"start_character":25,"end_line":30,"end_character":26},"updated":"2019-08-22 14:48:44.000000000","message":"because we\u0027re using a pipe here, we should set pipefail, maybe something like so:\n\n    shell: |-\n      set -o pipefail\n      {{ tripleo_cellv2_containercli }} exec -i -u root nova_api /usr/bin/nova-manage {{ (tripleo_cellv2_debug | bool) | ternary(\u0027--debug\u0027, \u0027\u0027) }} cell_v2 list_cells | grep {{ tripleo_cellv2_cell_name }}","commit_id":"74487107bab2573d6c22925fa95975f13b9f3b15"},{"author":{"_account_id":17216,"name":"Martin Schuppert","email":"mschuppert@redhat.com","username":"mcschupp"},"change_message_id":"4bedd7258164f9a214c735d186bcd8b50ed2a4e5","unresolved":false,"context_lines":[{"line_number":27,"context_line":"      {% if (tripleo_cellv2_debug | bool) %}"},{"line_number":28,"context_line":"      --debug"},{"line_number":29,"context_line":"      {% endif %}"},{"line_number":30,"context_line":"      cell_v2 list_cells | grep {{ tripleo_cellv2_cell_name }}"},{"line_number":31,"context_line":"    ignore_errors: yes"},{"line_number":32,"context_line":"    register: cell_check_result"},{"line_number":33,"context_line":"  - name: Fail if cell already exist"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_dbf53786","line":30,"range":{"start_line":30,"start_character":25,"end_line":30,"end_character":26},"in_reply_to":"7faddb67_3bac8b9e","updated":"2019-08-22 15:11:27.000000000","message":"\u003e because we\u0027re using a pipe here, we should set pipefail, maybe\n \u003e something like so:\n \u003e \n \u003e shell: |-\n \u003e set -o pipefail\n \u003e {{ tripleo_cellv2_containercli }} exec -i -u root nova_api\n \u003e /usr/bin/nova-manage {{ (tripleo_cellv2_debug | bool) |\n \u003e ternary(\u0027--debug\u0027, \u0027\u0027) }} cell_v2 list_cells | grep {{\n \u003e tripleo_cellv2_cell_name }}\n\nack thx","commit_id":"74487107bab2573d6c22925fa95975f13b9f3b15"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"53602f0ae3819dcb3e3c35a7a3fb5b788c23bf6d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    become: true"},{"line_number":24,"context_line":"    shell: |-"},{"line_number":25,"context_line":"      set -o pipefail"},{"line_number":26,"context_line":"      {{ tripleo_cellv2_containercli }} exec -i -u root nova_api /usr/bin/nova-manage {{ (tripleo_cellv2_debug | bool) | ternary(\u0027--debug\u0027, \u0027\u0027) }} cell_v2 list_cells | grep {{ tripleo_cellv2_cell_name }}"},{"line_number":27,"context_line":"    ignore_errors: yes"},{"line_number":28,"context_line":"    register: cell_check_result"},{"line_number":29,"context_line":"  - name: Fail if cell already exist"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_52eb6177","line":26,"updated":"2019-08-22 20:52:58.000000000","message":"sadly this makes the linter angry\n\n    2019-08-22 15:32:34.693825 | ubuntu-bionic | \u001b[1;31m[204]\u001b[0m \u001b[0;31mLines should be no longer than 160 chars\u001b[0m\n    2019-08-22 15:32:34.693938 | ubuntu-bionic | \u001b[0;34m/home/zuul/src/opendev.org/openstack/tripleo-ansible/tripleo_ansible/roles/tripleo-cellv2/tasks/check_cell_exist.yml\u001b[0m:\u001b[0;36m26\u001b[0m\n    2019-08-22 15:32:34.694105 | ubuntu-bionic | \u001b[0;35m      {{ tripleo_cellv2_containercli }} exec -i -u root nova_api /usr/bin/nova-manage {{ (tripleo_cellv2_debug | bool) | ternary(\u0027--debug\u0027, \u0027\u0027) }} cell_v2 list_cells | grep {{ tripleo_cellv2_cell_name }}\u001b[0m\n\nI think we\u0027re going need to use a couple line breaks to make that go.","commit_id":"4d42ff972e00f46726438fca4cccd5da2d43c21e"}],"tripleo_ansible/roles/tripleo-cellv2/tasks/create_cell.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"cb68d3f0bad2aded0511990f741a3a0a63e522b0","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  - name: List Cells"},{"line_number":24,"context_line":"    shell: \"{{ tripleo_cellv2_containercli }} exec -i -u root nova_api nova-manage cell_v2 list_cells\""},{"line_number":25,"context_line":"    register: cells"},{"line_number":26,"context_line":"  "},{"line_number":27,"context_line":"  - debug: var\u003dcells.stdout_lines"},{"line_number":28,"context_line":"  tags:"},{"line_number":29,"context_line":"    - create"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_9b9a5f6d","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":2},"updated":"2019-08-22 14:48:44.000000000","message":"whitespace.","commit_id":"74487107bab2573d6c22925fa95975f13b9f3b15"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"703456d096fd21d6505ee3d56ff04fd5c6d2f27d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Create new Cell"},{"line_number":18,"context_line":"  become: true"},{"line_number":19,"context_line":"  block:"},{"line_number":20,"context_line":"  - name: Create Cell"},{"line_number":21,"context_line":"    shell: \u003e"},{"line_number":22,"context_line":"      \"{{ tripleo_cellv2_containercli }} exec -i -u root nova_api"},{"line_number":23,"context_line":"        nova-manage cell_v2 create_cell --name {{ tripleo_cellv2_cell_name }}"},{"line_number":24,"context_line":"        --database_connection \\\"{scheme}://{username}:{password}@{{ tripleo_cellv2_cell_database_vip }}/nova?{query}\\\""},{"line_number":25,"context_line":"        --transport-url \\\"{{ tripleo_cellv2_cell_transport_url }}\\\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  - name: List Cells"},{"line_number":28,"context_line":"    shell: \u003e"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_94fb0614","line":25,"range":{"start_line":17,"start_character":0,"end_line":25,"end_character":68},"updated":"2019-08-22 21:01:35.000000000","message":"Something like this might work here:\n\n    - name: Create new Cell\n      become: true\n      block:\n        - name: Create Cell\n          shell: \u003e-\n            {{ tripleo_cellv2_containercli }} exec -i -u root \n            nova_api nova-manage cell_v2 create_cell\n            --name {{ tripleo_cellv2_cell_name }}\n            --database_connection \"{scheme}://{username}:{password}@{{ tripleo_cellv2_cell_database_vip }}/nova?{query}\"\n            --transport-url \"{{ tripleo_cellv2_cell_transport_url }}\"","commit_id":"4d42ff972e00f46726438fca4cccd5da2d43c21e"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"86585c52ed5f742bd7cdfa53c14aa1a75b88c8a4","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  block:"},{"line_number":20,"context_line":"  - name: Create Cell"},{"line_number":21,"context_line":"    shell: \u003e"},{"line_number":22,"context_line":"      \"{{ tripleo_cellv2_containercli }} exec -i -u root nova_api"},{"line_number":23,"context_line":"        nova-manage cell_v2 create_cell --name {{ tripleo_cellv2_cell_name }}"},{"line_number":24,"context_line":"        --database_connection \\\"{scheme}://{username}:{password}@{{ tripleo_cellv2_cell_database_vip }}/nova?{query}\\\""},{"line_number":25,"context_line":"        --transport-url \\\"{{ tripleo_cellv2_cell_transport_url }}\\\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  - name: List Cells"},{"line_number":28,"context_line":"    shell: \u003e"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_72ba1d72","line":25,"range":{"start_line":22,"start_character":6,"end_line":25,"end_character":68},"updated":"2019-08-22 20:54:59.000000000","message":"with the carrot, I don\u0027t think we need the extra quotes around the shell command and escape quotes in the command.","commit_id":"4d42ff972e00f46726438fca4cccd5da2d43c21e"}]}