)]}'
{"tripleo_ansible/roles/backup-and-restore/database/handlers/main.yml":[{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"f8255e7fb1c4a3cd7528126c973b15fe122d1987","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# handlers file for cloudstash"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5faad753_e67dca6e","line":1,"updated":"2019-09-09 16:03:37.000000000","message":"removed if empty","commit_id":"c21abaef8b6e2f405b8824430aeb33106886b184"}],"tripleo_ansible/roles/backup-and-restore/database/tasks/main.yml":[{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"f8255e7fb1c4a3cd7528126c973b15fe122d1987","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  when: backup_mysql \u003d\u003d \"1\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- include_tasks: redis_backup.yml"},{"line_number":7,"context_line":"  when: backup_redis \u003d\u003d \"1\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5faad753_66e6ba47","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":20},"updated":"2019-09-09 16:03:37.000000000","message":"variables should be namespaced i.e. tripleo_backup_and_restore_xxx where for example xxx might be dump_redis or something similar","commit_id":"c21abaef8b6e2f405b8824430aeb33106886b184"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"f8255e7fb1c4a3cd7528126c973b15fe122d1987","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5faad753_c6944e8e","line":8,"updated":"2019-09-09 16:03:37.000000000","message":"this needs to be added to the molecule test","commit_id":"c21abaef8b6e2f405b8824430aeb33106886b184"}],"tripleo_ansible/roles/backup-and-restore/database/tasks/mysql_backup.yml":[{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"f8255e7fb1c4a3cd7528126c973b15fe122d1987","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Create a backup for each database into seperate files."},{"line_number":3,"context_line":"- name: MySQL service database backup."},{"line_number":4,"context_line":"  vars:"},{"line_number":5,"context_line":"    - exclude_db:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5faad753_c6c20e86","line":2,"range":{"start_line":2,"start_character":41,"end_line":2,"end_character":49},"updated":"2019-09-09 16:03:37.000000000","message":"nit","commit_id":"c21abaef8b6e2f405b8824430aeb33106886b184"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"f8255e7fb1c4a3cd7528126c973b15fe122d1987","unresolved":false,"context_lines":[{"line_number":13,"context_line":"      become: true"},{"line_number":14,"context_line":"      tags:"},{"line_number":15,"context_line":"       - overcloud_nodes"},{"line_number":16,"context_line":"      "},{"line_number":17,"context_line":"    - name: Get all database names."},{"line_number":18,"context_line":"      shell: \u0027mysql -u root -p{{ mysql_password }} -e \"show databases;\" \u0027"},{"line_number":19,"context_line":"      register: dblist"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5faad753_a6c59290","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":6},"updated":"2019-09-09 16:03:37.000000000","message":"remove","commit_id":"c21abaef8b6e2f405b8824430aeb33106886b184"}],"tripleo_ansible/roles/backup-and-restore/database/tasks/redis_backup.yml":[{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"f8255e7fb1c4a3cd7528126c973b15fe122d1987","unresolved":false,"context_lines":[{"line_number":2,"context_line":"---"},{"line_number":3,"context_line":"- name: Get the Redis masterauth password"},{"line_number":4,"context_line":"  shell: |"},{"line_number":5,"context_line":"    /bin/hiera -c /etc/puppet/hiera.yaml redis::masterauth"},{"line_number":6,"context_line":"  when: redis_masterauth_password is undefined"},{"line_number":7,"context_line":"  register: redis_masterauth_password_cmd_output"},{"line_number":8,"context_line":"  become: true"},{"line_number":9,"context_line":"  no_log: true"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Get the Redis VIP"},{"line_number":12,"context_line":"  shell: |"},{"line_number":13,"context_line":"    /bin/hiera -c /etc/puppet/hiera.yaml redis_vip"},{"line_number":14,"context_line":"  when: redis_vip is undefined"},{"line_number":15,"context_line":"  register: redis_vip_cmd_output"},{"line_number":16,"context_line":"  become: true"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: Convert the Redis VIP if unknown"},{"line_number":19,"context_line":"  set_fact:"},{"line_number":20,"context_line":"    redis_vip: \"{{ redis_vip_cmd_output.stdout_lines[0] }}\""},{"line_number":21,"context_line":"  when: redis_vip is undefined"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Run the redis backup command"},{"line_number":24,"context_line":"  command: /bin/redis-cli -h {{ redis_vip }} -a {{ redis_masterauth_password }} save"},{"line_number":25,"context_line":"  no_log: true"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- name: Copy the Redis dump"},{"line_number":28,"context_line":"  copy:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5faad753_e6406a0a","line":25,"range":{"start_line":5,"start_character":10,"end_line":25,"end_character":14},"updated":"2019-09-09 16:03:37.000000000","message":"variables should be namespaced","commit_id":"c21abaef8b6e2f405b8824430aeb33106886b184"}],"tripleo_ansible/roles/backup-and-restore/database/vars/main.yml":[{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"f8255e7fb1c4a3cd7528126c973b15fe122d1987","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5faad753_c6476e1d","line":3,"updated":"2019-09-09 16:03:37.000000000","message":"removed if empty","commit_id":"c21abaef8b6e2f405b8824430aeb33106886b184"}],"tripleo_ansible/roles/backup-and-restore/service_manager/tasks/container_service_manager.yml":[{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"f8255e7fb1c4a3cd7528126c973b15fe122d1987","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Gather Container Service Name"},{"line_number":2,"context_line":"  shell: \"docker ps -a --format \u0027{{.Names}}\u0027\""},{"line_number":3,"context_line":"  args:"},{"line_number":4,"context_line":"    excutable: \"/bin/bash\""},{"line_number":5,"context_line":"  register: container_services"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5faad753_2660c2a5","line":2,"range":{"start_line":2,"start_character":10,"end_line":2,"end_character":16},"updated":"2019-09-09 16:03:37.000000000","message":"no docker in master","commit_id":"c21abaef8b6e2f405b8824430aeb33106886b184"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"f8255e7fb1c4a3cd7528126c973b15fe122d1987","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  with_items: \"{{ container_services.stdout_lines }}\""},{"line_number":13,"context_line":"  tags:"},{"line_number":14,"context_line":"    - stop_services"},{"line_number":15,"context_line":"  "},{"line_number":16,"context_line":"- name: Start Service Container"},{"line_number":17,"context_line":"  docker_container: "},{"line_number":18,"context_line":"    name: \"{{ items }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5faad753_4665beb4","line":15,"updated":"2019-09-09 16:03:37.000000000","message":"nit remove extra spaces","commit_id":"c21abaef8b6e2f405b8824430aeb33106886b184"}],"tripleo_ansible/roles/backup-and-restore/service_manager/tasks/main.yml":[{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"f8255e7fb1c4a3cd7528126c973b15fe122d1987","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"- include_tasks: service_manager.yml"},{"line_number":4,"context_line":"  when: service_type \u003d\u003d \"standard\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- include_tasks: container_service_manager.yml"},{"line_number":7,"context_line":"  when: service_type \u003d\u003d \"containerized\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5faad753_c670ce75","line":7,"range":{"start_line":3,"start_character":0,"end_line":7,"end_character":31},"updated":"2019-09-09 16:03:37.000000000","message":"namespaced variables","commit_id":"c21abaef8b6e2f405b8824430aeb33106886b184"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"419e1e3890e9d145680658322fca4e0ee4d9dd30","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":"# Call to podman to list running containers then commit all starte to "},{"line_number":17,"context_line":"# disk. Once services have been "},{"line_number":18,"context_line":"# "},{"line_number":19,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_b4ab5373","line":16,"range":{"start_line":16,"start_character":60,"end_line":16,"end_character":66},"updated":"2019-10-07 18:50:14.000000000","message":"start?","commit_id":"8baa6d9e895b23a04f49f09bf9db5a87d5549052"},{"author":{"_account_id":11085,"name":"Toure Dunnon","email":"toure@redhat.com","username":"Toure"},"change_message_id":"0341541e193e009dcd2b8d9996fcbe7cf5298b5f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":"# Call to podman to list running containers then commit all starte to "},{"line_number":17,"context_line":"# disk. Once services have been "},{"line_number":18,"context_line":"# "},{"line_number":19,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_8f4f2469","line":16,"range":{"start_line":16,"start_character":60,"end_line":16,"end_character":66},"in_reply_to":"3fa7e38b_b4ab5373","updated":"2019-10-07 19:31:28.000000000","message":"Thanks for the catch, that should be \"state\"","commit_id":"8baa6d9e895b23a04f49f09bf9db5a87d5549052"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"419e1e3890e9d145680658322fca4e0ee4d9dd30","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":"# Call to podman to list running containers then commit all starte to "},{"line_number":17,"context_line":"# disk. Once services have been "},{"line_number":18,"context_line":"# "},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Gather Container Service Name"},{"line_number":21,"context_line":"  shell: \"podman ps --format \u0027{{.ID}} {{.Names}}\u0027\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_74b71bda","line":18,"updated":"2019-10-07 18:50:14.000000000","message":"fix the trailing spaces","commit_id":"8baa6d9e895b23a04f49f09bf9db5a87d5549052"},{"author":{"_account_id":11085,"name":"Toure Dunnon","email":"toure@redhat.com","username":"Toure"},"change_message_id":"0341541e193e009dcd2b8d9996fcbe7cf5298b5f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":"# Call to podman to list running containers then commit all starte to "},{"line_number":17,"context_line":"# disk. Once services have been "},{"line_number":18,"context_line":"# "},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Gather Container Service Name"},{"line_number":21,"context_line":"  shell: \"podman ps --format \u0027{{.ID}} {{.Names}}\u0027\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_6f9ae8c5","line":18,"in_reply_to":"3fa7e38b_74b71bda","updated":"2019-10-07 19:31:28.000000000","message":"ack.","commit_id":"8baa6d9e895b23a04f49f09bf9db5a87d5549052"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"419e1e3890e9d145680658322fca4e0ee4d9dd30","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# "},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Gather Container Service Name"},{"line_number":21,"context_line":"  shell: \"podman ps --format \u0027{{.ID}} {{.Names}}\u0027\""},{"line_number":22,"context_line":"  register: container_services"},{"line_number":23,"context_line":"  changed_when: false"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_f4a1cb96","line":21,"range":{"start_line":21,"start_character":10,"end_line":21,"end_character":16},"updated":"2019-10-07 18:50:14.000000000","message":"imho we should be using the {{ container_cli }} variable already in tripleo","commit_id":"8baa6d9e895b23a04f49f09bf9db5a87d5549052"},{"author":{"_account_id":11085,"name":"Toure Dunnon","email":"toure@redhat.com","username":"Toure"},"change_message_id":"0341541e193e009dcd2b8d9996fcbe7cf5298b5f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# "},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Gather Container Service Name"},{"line_number":21,"context_line":"  shell: \"podman ps --format \u0027{{.ID}} {{.Names}}\u0027\""},{"line_number":22,"context_line":"  register: container_services"},{"line_number":23,"context_line":"  changed_when: false"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_4f5cccec","line":21,"range":{"start_line":21,"start_character":10,"end_line":21,"end_character":16},"in_reply_to":"3fa7e38b_f4a1cb96","updated":"2019-10-07 19:31:28.000000000","message":"Thanks.","commit_id":"8baa6d9e895b23a04f49f09bf9db5a87d5549052"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"beb5a5a85c4849771c2de5c18d03412feae82c8e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# Call to podman to list running containers then commit all state to "},{"line_number":18,"context_line":"# disk. Once services state has been flushed dump the database then allow"},{"line_number":19,"context_line":"# the backup to start."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_b2f9b5c5","line":17,"range":{"start_line":17,"start_character":68,"end_line":17,"end_character":69},"updated":"2019-11-21 16:58:55.000000000","message":"nit trailing whitespace.","commit_id":"f76cf36a0d37fd1a78786a4e3ee5ad2e7274368b"},{"author":{"_account_id":11085,"name":"Toure Dunnon","email":"toure@redhat.com","username":"Toure"},"change_message_id":"9aedbffb942b9e534dce815be9342e259edae635","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# Call to podman to list running containers then commit all state to "},{"line_number":18,"context_line":"# disk. Once services state has been flushed dump the database then allow"},{"line_number":19,"context_line":"# the backup to start."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_117c44e9","line":17,"range":{"start_line":17,"start_character":68,"end_line":17,"end_character":69},"in_reply_to":"3fa7e38b_b2f9b5c5","updated":"2019-11-21 20:08:07.000000000","message":"Done","commit_id":"f76cf36a0d37fd1a78786a4e3ee5ad2e7274368b"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"beb5a5a85c4849771c2de5c18d03412feae82c8e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# the backup to start."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- name: Gather Container Service Name"},{"line_number":22,"context_line":"  shell: \"{{ tripleo_container_cli }} ps --format \u0027{{.ID}} {{.Names}}\u0027\""},{"line_number":23,"context_line":"  register: container_services"},{"line_number":24,"context_line":"  changed_when: false"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_52bc01db","line":22,"range":{"start_line":22,"start_character":50,"end_line":22,"end_character":70},"updated":"2019-11-21 16:58:55.000000000","message":"this may get picked up as a jinja2 expansion, is there any other way to write that?","commit_id":"f76cf36a0d37fd1a78786a4e3ee5ad2e7274368b"},{"author":{"_account_id":11085,"name":"Toure Dunnon","email":"toure@redhat.com","username":"Toure"},"change_message_id":"9aedbffb942b9e534dce815be9342e259edae635","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# the backup to start."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- name: Gather Container Service Name"},{"line_number":22,"context_line":"  shell: \"{{ tripleo_container_cli }} ps --format \u0027{{.ID}} {{.Names}}\u0027\""},{"line_number":23,"context_line":"  register: container_services"},{"line_number":24,"context_line":"  changed_when: false"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_f161683a","line":22,"range":{"start_line":22,"start_character":50,"end_line":22,"end_character":70},"in_reply_to":"3fa7e38b_52bc01db","updated":"2019-11-21 20:08:07.000000000","message":"unfortunately the docker/podman command line util requires that format.","commit_id":"f76cf36a0d37fd1a78786a4e3ee5ad2e7274368b"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"beb5a5a85c4849771c2de5c18d03412feae82c8e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  changed_when: false"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"- name: Commit state info to disk."},{"line_number":27,"context_line":"  shell: \"{{ tripleo_container_cli }} commit -p {{item}}\""},{"line_number":28,"context_line":"  with_items: container_services"},{"line_number":29,"context_line":"  when:  mysql not in item"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_7231fda1","line":27,"range":{"start_line":27,"start_character":48,"end_line":27,"end_character":56},"updated":"2019-11-21 16:58:55.000000000","message":"space between brackets \n\n  {{ item }}","commit_id":"f76cf36a0d37fd1a78786a4e3ee5ad2e7274368b"},{"author":{"_account_id":11085,"name":"Toure Dunnon","email":"toure@redhat.com","username":"Toure"},"change_message_id":"9aedbffb942b9e534dce815be9342e259edae635","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  changed_when: false"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"- name: Commit state info to disk."},{"line_number":27,"context_line":"  shell: \"{{ tripleo_container_cli }} commit -p {{item}}\""},{"line_number":28,"context_line":"  with_items: container_services"},{"line_number":29,"context_line":"  when:  mysql not in item"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_f1c64816","line":27,"range":{"start_line":27,"start_character":48,"end_line":27,"end_character":56},"in_reply_to":"3fa7e38b_7231fda1","updated":"2019-11-21 20:08:07.000000000","message":"thanks for catching that.","commit_id":"f76cf36a0d37fd1a78786a4e3ee5ad2e7274368b"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"beb5a5a85c4849771c2de5c18d03412feae82c8e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  when:  mysql not in item"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- name: Pause containers for database backup."},{"line_number":32,"context_line":"  shell: \"{{ tripleo_container_cli }} pause {{item}}\""},{"line_number":33,"context_line":"  with_items: container_services"},{"line_number":34,"context_line":"  when: mysql not in item"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_52d3a138","line":32,"range":{"start_line":32,"start_character":46,"end_line":32,"end_character":50},"updated":"2019-11-21 16:58:55.000000000","message":"as above.","commit_id":"f76cf36a0d37fd1a78786a4e3ee5ad2e7274368b"},{"author":{"_account_id":11085,"name":"Toure Dunnon","email":"toure@redhat.com","username":"Toure"},"change_message_id":"9aedbffb942b9e534dce815be9342e259edae635","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  when:  mysql not in item"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- name: Pause containers for database backup."},{"line_number":32,"context_line":"  shell: \"{{ tripleo_container_cli }} pause {{item}}\""},{"line_number":33,"context_line":"  with_items: container_services"},{"line_number":34,"context_line":"  when: mysql not in item"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_11ca0419","line":32,"range":{"start_line":32,"start_character":46,"end_line":32,"end_character":50},"in_reply_to":"3fa7e38b_52d3a138","updated":"2019-11-21 20:08:07.000000000","message":"Done","commit_id":"f76cf36a0d37fd1a78786a4e3ee5ad2e7274368b"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"beb5a5a85c4849771c2de5c18d03412feae82c8e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  include_tasks: database_management/mysql_backup.yml"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: Resume containers"},{"line_number":40,"context_line":"  shell: \"{{ tripleo_container_cli }} unpause {{item}}\""},{"line_number":41,"context_line":"  with_items: container_services"},{"line_number":42,"context_line":"  when: mysql not in item"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_72d6dd29","line":40,"range":{"start_line":40,"start_character":48,"end_line":40,"end_character":52},"updated":"2019-11-21 16:58:55.000000000","message":"as above.","commit_id":"f76cf36a0d37fd1a78786a4e3ee5ad2e7274368b"},{"author":{"_account_id":11085,"name":"Toure Dunnon","email":"toure@redhat.com","username":"Toure"},"change_message_id":"9aedbffb942b9e534dce815be9342e259edae635","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  include_tasks: database_management/mysql_backup.yml"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: Resume containers"},{"line_number":40,"context_line":"  shell: \"{{ tripleo_container_cli }} unpause {{item}}\""},{"line_number":41,"context_line":"  with_items: container_services"},{"line_number":42,"context_line":"  when: mysql not in item"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_b1cc5034","line":40,"range":{"start_line":40,"start_character":48,"end_line":40,"end_character":52},"in_reply_to":"3fa7e38b_72d6dd29","updated":"2019-11-21 20:08:07.000000000","message":"Done","commit_id":"f76cf36a0d37fd1a78786a4e3ee5ad2e7274368b"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"beb5a5a85c4849771c2de5c18d03412feae82c8e","unresolved":false,"context_lines":[{"line_number":39,"context_line":"- name: Resume containers"},{"line_number":40,"context_line":"  shell: \"{{ tripleo_container_cli }} unpause {{item}}\""},{"line_number":41,"context_line":"  with_items: container_services"},{"line_number":42,"context_line":"  when: mysql not in item"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_f2cacd6b","line":42,"range":{"start_line":42,"start_character":8,"end_line":42,"end_character":25},"updated":"2019-11-21 16:58:55.000000000","message":"I generally prefer when conditions in list format, even when there\u0027s only one condition. \n\n  when:\n    - mysql not in item","commit_id":"f76cf36a0d37fd1a78786a4e3ee5ad2e7274368b"},{"author":{"_account_id":11085,"name":"Toure Dunnon","email":"toure@redhat.com","username":"Toure"},"change_message_id":"9aedbffb942b9e534dce815be9342e259edae635","unresolved":false,"context_lines":[{"line_number":39,"context_line":"- name: Resume containers"},{"line_number":40,"context_line":"  shell: \"{{ tripleo_container_cli }} unpause {{item}}\""},{"line_number":41,"context_line":"  with_items: container_services"},{"line_number":42,"context_line":"  when: mysql not in item"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_31e06097","line":42,"range":{"start_line":42,"start_character":8,"end_line":42,"end_character":25},"in_reply_to":"3fa7e38b_f2cacd6b","updated":"2019-11-21 20:08:07.000000000","message":"Done","commit_id":"f76cf36a0d37fd1a78786a4e3ee5ad2e7274368b"}],"tripleo_ansible/roles/backup-and-restore/service_manager/tasks/service_manager.yml":[{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"f8255e7fb1c4a3cd7528126c973b15fe122d1987","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Service Management playbook."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"- name: Gather service list"},{"line_number":5,"context_line":"  shell: \"systemctl list-unit-files --state\u003denabled --type\u003dservice | awk \u0027/^{{ item }}.* enabled$/ {print $1}\u0027\""},{"line_number":6,"context_line":"  args:"},{"line_number":7,"context_line":"    executable: \"/bin/bash\""},{"line_number":8,"context_line":"  loop: \"{{ service_map | subelements(\u0027systemd_unit\u0027, skip_missing\u003dTrue) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5faad753_a6f832c4","line":5,"range":{"start_line":5,"start_character":2,"end_line":5,"end_character":7},"updated":"2019-09-09 16:03:37.000000000","message":"use command instead of shell","commit_id":"c21abaef8b6e2f405b8824430aeb33106886b184"},{"author":{"_account_id":11085,"name":"Toure Dunnon","email":"toure@redhat.com","username":"Toure"},"change_message_id":"0341541e193e009dcd2b8d9996fcbe7cf5298b5f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Service Management playbook."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"- name: Gather service list"},{"line_number":5,"context_line":"  shell: \"systemctl list-unit-files --state\u003denabled --type\u003dservice | awk \u0027/^{{ item }}.* enabled$/ {print $1}\u0027\""},{"line_number":6,"context_line":"  args:"},{"line_number":7,"context_line":"    executable: \"/bin/bash\""},{"line_number":8,"context_line":"  loop: \"{{ service_map | subelements(\u0027systemd_unit\u0027, skip_missing\u003dTrue) }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5faad753_05f48585","line":5,"range":{"start_line":5,"start_character":2,"end_line":5,"end_character":7},"in_reply_to":"5faad753_a6f832c4","updated":"2019-10-07 19:31:28.000000000","message":"shell module is needed here as there is a pipe, the command module will error.","commit_id":"c21abaef8b6e2f405b8824430aeb33106886b184"}],"tripleo_ansible/roles/backup-and-restore/service_manager/vars/main.yml":[{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"f8255e7fb1c4a3cd7528126c973b15fe122d1987","unresolved":false,"context_lines":[{"line_number":6,"context_line":"      - openstack-aodh-evaluator"},{"line_number":7,"context_line":"      - openstack-aodh-listener"},{"line_number":8,"context_line":"      - openstack-aodh-notifier"},{"line_number":9,"context_line":"  barbican:"},{"line_number":10,"context_line":"    systemd_unit:"},{"line_number":11,"context_line":"      - openstack-barbican-api"},{"line_number":12,"context_line":"  ceilometer:"},{"line_number":13,"context_line":"  ceilometer-agent:"},{"line_number":14,"context_line":"    systemd_unit:"},{"line_number":15,"context_line":"      - openstack-ceilometer-central"},{"line_number":16,"context_line":"      - openstack-ceilometer-compute"},{"line_number":17,"context_line":"      - openstack-ceilometer-polling"},{"line_number":18,"context_line":"      - openstack-ceilometer-ipmi"},{"line_number":19,"context_line":"      - openstack-ceilometer-notification"},{"line_number":20,"context_line":"  cinder:"},{"line_number":21,"context_line":"    systemd_unit:"},{"line_number":22,"context_line":"      - openstack-cinder-api"},{"line_number":23,"context_line":"      - openstack-cinder-scheduler"},{"line_number":24,"context_line":"      - openstack-cinder-volume"},{"line_number":25,"context_line":"  congress:"},{"line_number":26,"context_line":"    systemd_unit:"},{"line_number":27,"context_line":"      - openstack-congress-server"},{"line_number":28,"context_line":"  glance:"},{"line_number":29,"context_line":"    systemd_unit:"},{"line_number":30,"context_line":"      - openstack-glance-api"},{"line_number":31,"context_line":"  gnocchi:"},{"line_number":32,"context_line":"    systemd_unit:"},{"line_number":33,"context_line":"      - openstack-gnocchi-api"},{"line_number":34,"context_line":"  haproxy:"},{"line_number":35,"context_line":"    systemd_unit:"},{"line_number":36,"context_line":"      - haproxy"},{"line_number":37,"context_line":"  heat:"},{"line_number":38,"context_line":"    systemd_unit:"},{"line_number":39,"context_line":"      - openstack-heat-api"},{"line_number":40,"context_line":"      - openstack-heat-engine"},{"line_number":41,"context_line":"      - openstack-heat-api-cfn"},{"line_number":42,"context_line":"  horizon:"},{"line_number":43,"context_line":"    systemd_unit: \"\""},{"line_number":44,"context_line":"    container_name:"},{"line_number":45,"context_line":"      - horizon"},{"line_number":46,"context_line":"  ironic:"},{"line_number":47,"context_line":"    systemd_unit:"},{"line_number":48,"context_line":"      - openstack-ironic-api"},{"line_number":49,"context_line":"      - openstack-ironic-conductor"},{"line_number":50,"context_line":"  keepalived:"},{"line_number":51,"context_line":"    systemd_unit:"},{"line_number":52,"context_line":"      - keepalived"},{"line_number":53,"context_line":"  keystone:"},{"line_number":54,"context_line":"    systemd_unit: \"\""},{"line_number":55,"context_line":"  manila:"},{"line_number":56,"context_line":"    systemd_unit:"},{"line_number":57,"context_line":"      - openstack-manila-scheduler"},{"line_number":58,"context_line":"      - openstack-manila-share"},{"line_number":59,"context_line":"  mistral:"},{"line_number":60,"context_line":"    systemd_unit:"},{"line_number":61,"context_line":"      - openstack-mistral-api"},{"line_number":62,"context_line":"      - openstack-mistral-engine"},{"line_number":63,"context_line":"      - openstack-mistral-event-engine"},{"line_number":64,"context_line":"      - openstack-mistral-executor"},{"line_number":65,"context_line":"  memcached:"},{"line_number":66,"context_line":"    systemd_unit:"},{"line_number":67,"context_line":"      - memcached"},{"line_number":68,"context_line":"  mysql:"},{"line_number":69,"context_line":"    systemd_unit: mariadb"},{"line_number":70,"context_line":"  neutron:"},{"line_number":71,"context_line":"    systemd_unit: \"\""},{"line_number":72,"context_line":"  nova-compute:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5faad753_0614a6f4","line":69,"range":{"start_line":9,"start_character":11,"end_line":69,"end_character":25},"updated":"2019-09-09 16:03:37.000000000","message":"this is dynamic, and based on what the customer deployed, we need to find a way to calculate this.","commit_id":"c21abaef8b6e2f405b8824430aeb33106886b184"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"f15a4e5e7773f1d1245a3ef22e5bea25ec14f3c1","unresolved":false,"context_lines":[{"line_number":6,"context_line":"      - openstack-aodh-evaluator"},{"line_number":7,"context_line":"      - openstack-aodh-listener"},{"line_number":8,"context_line":"      - openstack-aodh-notifier"},{"line_number":9,"context_line":"  barbican:"},{"line_number":10,"context_line":"    systemd_unit:"},{"line_number":11,"context_line":"      - openstack-barbican-api"},{"line_number":12,"context_line":"  ceilometer:"},{"line_number":13,"context_line":"  ceilometer-agent:"},{"line_number":14,"context_line":"    systemd_unit:"},{"line_number":15,"context_line":"      - openstack-ceilometer-central"},{"line_number":16,"context_line":"      - openstack-ceilometer-compute"},{"line_number":17,"context_line":"      - openstack-ceilometer-polling"},{"line_number":18,"context_line":"      - openstack-ceilometer-ipmi"},{"line_number":19,"context_line":"      - openstack-ceilometer-notification"},{"line_number":20,"context_line":"  cinder:"},{"line_number":21,"context_line":"    systemd_unit:"},{"line_number":22,"context_line":"      - openstack-cinder-api"},{"line_number":23,"context_line":"      - openstack-cinder-scheduler"},{"line_number":24,"context_line":"      - openstack-cinder-volume"},{"line_number":25,"context_line":"  congress:"},{"line_number":26,"context_line":"    systemd_unit:"},{"line_number":27,"context_line":"      - openstack-congress-server"},{"line_number":28,"context_line":"  glance:"},{"line_number":29,"context_line":"    systemd_unit:"},{"line_number":30,"context_line":"      - openstack-glance-api"},{"line_number":31,"context_line":"  gnocchi:"},{"line_number":32,"context_line":"    systemd_unit:"},{"line_number":33,"context_line":"      - openstack-gnocchi-api"},{"line_number":34,"context_line":"  haproxy:"},{"line_number":35,"context_line":"    systemd_unit:"},{"line_number":36,"context_line":"      - haproxy"},{"line_number":37,"context_line":"  heat:"},{"line_number":38,"context_line":"    systemd_unit:"},{"line_number":39,"context_line":"      - openstack-heat-api"},{"line_number":40,"context_line":"      - openstack-heat-engine"},{"line_number":41,"context_line":"      - openstack-heat-api-cfn"},{"line_number":42,"context_line":"  horizon:"},{"line_number":43,"context_line":"    systemd_unit: \"\""},{"line_number":44,"context_line":"    container_name:"},{"line_number":45,"context_line":"      - horizon"},{"line_number":46,"context_line":"  ironic:"},{"line_number":47,"context_line":"    systemd_unit:"},{"line_number":48,"context_line":"      - openstack-ironic-api"},{"line_number":49,"context_line":"      - openstack-ironic-conductor"},{"line_number":50,"context_line":"  keepalived:"},{"line_number":51,"context_line":"    systemd_unit:"},{"line_number":52,"context_line":"      - keepalived"},{"line_number":53,"context_line":"  keystone:"},{"line_number":54,"context_line":"    systemd_unit: \"\""},{"line_number":55,"context_line":"  manila:"},{"line_number":56,"context_line":"    systemd_unit:"},{"line_number":57,"context_line":"      - openstack-manila-scheduler"},{"line_number":58,"context_line":"      - openstack-manila-share"},{"line_number":59,"context_line":"  mistral:"},{"line_number":60,"context_line":"    systemd_unit:"},{"line_number":61,"context_line":"      - openstack-mistral-api"},{"line_number":62,"context_line":"      - openstack-mistral-engine"},{"line_number":63,"context_line":"      - openstack-mistral-event-engine"},{"line_number":64,"context_line":"      - openstack-mistral-executor"},{"line_number":65,"context_line":"  memcached:"},{"line_number":66,"context_line":"    systemd_unit:"},{"line_number":67,"context_line":"      - memcached"},{"line_number":68,"context_line":"  mysql:"},{"line_number":69,"context_line":"    systemd_unit: mariadb"},{"line_number":70,"context_line":"  neutron:"},{"line_number":71,"context_line":"    systemd_unit: \"\""},{"line_number":72,"context_line":"  nova-compute:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5faad753_1f754464","line":69,"range":{"start_line":9,"start_character":11,"end_line":69,"end_character":25},"in_reply_to":"5faad753_0614a6f4","updated":"2019-09-16 06:42:32.000000000","message":"I agree with Carlos, maybe something like https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/backup-and-restore/setup_rear/tasks/main.yml#L58\nOtherwise we will need to update the service list all the time.\nThe only problem I can think of is how to stop just some services.","commit_id":"c21abaef8b6e2f405b8824430aeb33106886b184"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"099ba2443e063c112b8a66eeb6396a8a91720b19","unresolved":false,"context_lines":[{"line_number":6,"context_line":"      - openstack-aodh-evaluator"},{"line_number":7,"context_line":"      - openstack-aodh-listener"},{"line_number":8,"context_line":"      - openstack-aodh-notifier"},{"line_number":9,"context_line":"  barbican:"},{"line_number":10,"context_line":"    systemd_unit:"},{"line_number":11,"context_line":"      - openstack-barbican-api"},{"line_number":12,"context_line":"  ceilometer:"},{"line_number":13,"context_line":"  ceilometer-agent:"},{"line_number":14,"context_line":"    systemd_unit:"},{"line_number":15,"context_line":"      - openstack-ceilometer-central"},{"line_number":16,"context_line":"      - openstack-ceilometer-compute"},{"line_number":17,"context_line":"      - openstack-ceilometer-polling"},{"line_number":18,"context_line":"      - openstack-ceilometer-ipmi"},{"line_number":19,"context_line":"      - openstack-ceilometer-notification"},{"line_number":20,"context_line":"  cinder:"},{"line_number":21,"context_line":"    systemd_unit:"},{"line_number":22,"context_line":"      - openstack-cinder-api"},{"line_number":23,"context_line":"      - openstack-cinder-scheduler"},{"line_number":24,"context_line":"      - openstack-cinder-volume"},{"line_number":25,"context_line":"  congress:"},{"line_number":26,"context_line":"    systemd_unit:"},{"line_number":27,"context_line":"      - openstack-congress-server"},{"line_number":28,"context_line":"  glance:"},{"line_number":29,"context_line":"    systemd_unit:"},{"line_number":30,"context_line":"      - openstack-glance-api"},{"line_number":31,"context_line":"  gnocchi:"},{"line_number":32,"context_line":"    systemd_unit:"},{"line_number":33,"context_line":"      - openstack-gnocchi-api"},{"line_number":34,"context_line":"  haproxy:"},{"line_number":35,"context_line":"    systemd_unit:"},{"line_number":36,"context_line":"      - haproxy"},{"line_number":37,"context_line":"  heat:"},{"line_number":38,"context_line":"    systemd_unit:"},{"line_number":39,"context_line":"      - openstack-heat-api"},{"line_number":40,"context_line":"      - openstack-heat-engine"},{"line_number":41,"context_line":"      - openstack-heat-api-cfn"},{"line_number":42,"context_line":"  horizon:"},{"line_number":43,"context_line":"    systemd_unit: \"\""},{"line_number":44,"context_line":"    container_name:"},{"line_number":45,"context_line":"      - horizon"},{"line_number":46,"context_line":"  ironic:"},{"line_number":47,"context_line":"    systemd_unit:"},{"line_number":48,"context_line":"      - openstack-ironic-api"},{"line_number":49,"context_line":"      - openstack-ironic-conductor"},{"line_number":50,"context_line":"  keepalived:"},{"line_number":51,"context_line":"    systemd_unit:"},{"line_number":52,"context_line":"      - keepalived"},{"line_number":53,"context_line":"  keystone:"},{"line_number":54,"context_line":"    systemd_unit: \"\""},{"line_number":55,"context_line":"  manila:"},{"line_number":56,"context_line":"    systemd_unit:"},{"line_number":57,"context_line":"      - openstack-manila-scheduler"},{"line_number":58,"context_line":"      - openstack-manila-share"},{"line_number":59,"context_line":"  mistral:"},{"line_number":60,"context_line":"    systemd_unit:"},{"line_number":61,"context_line":"      - openstack-mistral-api"},{"line_number":62,"context_line":"      - openstack-mistral-engine"},{"line_number":63,"context_line":"      - openstack-mistral-event-engine"},{"line_number":64,"context_line":"      - openstack-mistral-executor"},{"line_number":65,"context_line":"  memcached:"},{"line_number":66,"context_line":"    systemd_unit:"},{"line_number":67,"context_line":"      - memcached"},{"line_number":68,"context_line":"  mysql:"},{"line_number":69,"context_line":"    systemd_unit: mariadb"},{"line_number":70,"context_line":"  neutron:"},{"line_number":71,"context_line":"    systemd_unit: \"\""},{"line_number":72,"context_line":"  nova-compute:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_15915353","line":69,"range":{"start_line":9,"start_character":11,"end_line":69,"end_character":25},"in_reply_to":"5faad753_1f754464","updated":"2019-09-17 07:42:10.000000000","message":"I think we should build the list something like:\n- Start with []\n- We add all services in the node.\n- We remove those specific in order to be sure the dataplane wont break.\n- We call the Ansible role to stop services passing the list.","commit_id":"c21abaef8b6e2f405b8824430aeb33106886b184"}],"tripleo_ansible/roles/backup-and-restore/tasks/main.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"beb5a5a85c4849771c2de5c18d03412feae82c8e","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"- name: Service management"},{"line_number":42,"context_line":"  import_tasks: ../service_manager/tasks/main.yml"},{"line_number":43,"context_line":"  when: tripleo_backup_and_restore_service_manager \u003d\u003d 1"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"- name: Create recovery images with ReaR"},{"line_number":46,"context_line":"  import_tasks: ../backup/tasks/main.yml"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_12a769be","line":43,"updated":"2019-11-21 16:58:55.000000000","message":"nit: write conditions in list format.","commit_id":"f76cf36a0d37fd1a78786a4e3ee5ad2e7274368b"}],"tripleo_ansible/roles/backup_and_restore/backup/tasks/main.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"334796041e4a178c0eaee5d0618cbc891ef9b405","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  become: true"},{"line_number":37,"context_line":"  command: rear {{ \u0027-s \u0027 if tripleo_backup_and_restore_rear_simulate else \u0027\u0027 }}-d -v mkbackup"},{"line_number":38,"context_line":"  register: tripleo_backup_and_restore_rear_output"},{"line_number":39,"context_line":"  when: tripleo_backup_and_restore_rear_output is not defined"},{"line_number":40,"context_line":"  tags:"},{"line_number":41,"context_line":"    - bar_create_recover_image"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3fa7e38b_5a0357be","line":39,"range":{"start_line":39,"start_character":50,"end_line":39,"end_character":61},"updated":"2020-02-03 13:59:53.000000000","message":"we can use \"undefined\" here.","commit_id":"4e1a6ad6ca350c0b602051feb2726890758b24eb"}],"tripleo_ansible/roles/backup_and_restore/database/tasks/main.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"334796041e4a178c0eaee5d0618cbc891ef9b405","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"3fa7e38b_7abe53b0","updated":"2020-02-03 13:59:53.000000000","message":"I would like to keep our task files in the tasks folder. Ansible doesn\u0027t have the concept of multiple tasks workflows in a given role, so putting this into a sub directory and including using the relative path is likely going to create confusion in the future, especially as we move toward collections.\n\nI recommend using descriptive naming and prefixing the task files so that their pseudo unique. Something like: \n\n  tasks/db_information.yml\n\nGiven this task file seems to retrieve db information that name would be easily recognizable for future maintainers.","commit_id":"4e1a6ad6ca350c0b602051feb2726890758b24eb"}],"tripleo_ansible/roles/backup_and_restore/defaults/main.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"334796041e4a178c0eaee5d0618cbc891ef9b405","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# All variables intended for modification should be placed in this file."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Set the container command line entry-point"},{"line_number":21,"context_line":"tripleo_container_cli: \"{{ podman | default(\u0027docker\u0027) }}\""},{"line_number":22,"context_line":"# Stop and start all running services before backup is ran."},{"line_number":23,"context_line":"tripleo_backup_and_restore_service_manager: true"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3fa7e38b_1aa95f8e","line":21,"range":{"start_line":21,"start_character":23,"end_line":21,"end_character":57},"updated":"2020-02-03 13:59:53.000000000","message":"this would default to docker when the var `podman` is undefined. I would recommend setting this like so:\n\n  tripleo_container_cli: \"{{ container_cli | default(\u0027docker\u0027) }}\"\n\nthe `container_cli` var is something that we inherit from THT and is used elsewhere, example [0]. If we want this to default to podman I would recommend setting this to simply the string value \"podman\".\n\n\nhttps://github.com/openstack/tripleo-ansible/blob/1d2714309cd220521f1f7525bdd0eeb0edb16445/tripleo_ansible/roles/tripleo_container_rm/defaults/main.yml#L20-L29","commit_id":"4e1a6ad6ca350c0b602051feb2726890758b24eb"}],"tripleo_ansible/roles/backup_and_restore/service_manager/tasks/pause.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"334796041e4a178c0eaee5d0618cbc891ef9b405","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"3fa7e38b_fadfa308","updated":"2020-02-03 13:59:53.000000000","message":"same comment as before, I would like us to keep all task files in the one tasks directory.","commit_id":"4e1a6ad6ca350c0b602051feb2726890758b24eb"}],"tripleo_ansible/roles/backup_and_restore/service_manager/tasks/unpause.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"334796041e4a178c0eaee5d0618cbc891ef9b405","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"3fa7e38b_bac92b53","updated":"2020-02-03 13:59:53.000000000","message":"same comment as before, I would like us to keep all task files in the one tasks directory.","commit_id":"4e1a6ad6ca350c0b602051feb2726890758b24eb"}],"tripleo_ansible/roles/backup_and_restore/setup_rear/tasks/main.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"334796041e4a178c0eaee5d0618cbc891ef9b405","unresolved":false,"context_lines":[{"line_number":50,"context_line":"- name: Set bootstrap nodeid"},{"line_number":51,"context_line":"  become: true"},{"line_number":52,"context_line":"  set_fact:"},{"line_number":53,"context_line":"    tripleo_backup_and_restore_bootstrap_nodeid: \"{{ lookup(\u0027hiera\u0027, \u0027bootstrap_nodeid _hierarchy_file\u003d/etc/puppet/hiera.yml\u0027) }}\""},{"line_number":54,"context_line":"  tags:"},{"line_number":55,"context_line":"    - bar_setup_rear"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3fa7e38b_9a946f43","line":53,"range":{"start_line":53,"start_character":53,"end_line":53,"end_character":67},"updated":"2020-02-03 13:59:53.000000000","message":"nice use of the hiera lookup: https://docs.ansible.com/ansible/latest/plugins/lookup/hiera.html\n\nTIL.","commit_id":"4e1a6ad6ca350c0b602051feb2726890758b24eb"}],"tripleo_ansible/roles/backup_and_restore/tasks/main.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"334796041e4a178c0eaee5d0618cbc891ef9b405","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  import_tasks: ../setup_rear/tasks/main.yml"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"- name: Service management"},{"line_number":42,"context_line":"  import_tasks: ../service_manager/tasks/pause.yml"},{"line_number":43,"context_line":"  when:"},{"line_number":44,"context_line":"    - tripleo_backup_and_restore_service_manager"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3fa7e38b_7ad3b303","line":42,"range":{"start_line":42,"start_character":16,"end_line":42,"end_character":34},"updated":"2020-02-03 13:59:53.000000000","message":"same comment as before, I would like us to keep all task files in the one tasks directory.","commit_id":"4e1a6ad6ca350c0b602051feb2726890758b24eb"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"334796041e4a178c0eaee5d0618cbc891ef9b405","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    - tripleo_backup_and_restore_service_manager"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- name: Backup the database"},{"line_number":47,"context_line":"  import_tasks: ../database/tasks/main.yml"},{"line_number":48,"context_line":"  when:"},{"line_number":49,"context_line":"    - tripleo_backup_and_restore_service_manager"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3fa7e38b_dac66742","line":47,"range":{"start_line":47,"start_character":15,"end_line":47,"end_character":27},"updated":"2020-02-03 13:59:53.000000000","message":"same comment as before, I would like us to keep all task files in the one tasks directory.","commit_id":"4e1a6ad6ca350c0b602051feb2726890758b24eb"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"334796041e4a178c0eaee5d0618cbc891ef9b405","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  import_tasks: ../backup/tasks/main.yml"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"- name: Service management"},{"line_number":55,"context_line":"  import_tasks: ../service_manager/tasks/unpause.yml"},{"line_number":56,"context_line":"  when:"},{"line_number":57,"context_line":"    - tripleo_backup_and_restore_service_manager"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3fa7e38b_9ad0eff6","line":55,"range":{"start_line":55,"start_character":16,"end_line":55,"end_character":34},"updated":"2020-02-03 13:59:53.000000000","message":"same comment as before, I would like us to keep all task files in the one tasks directory.","commit_id":"4e1a6ad6ca350c0b602051feb2726890758b24eb"}]}