)]}'
{"tripleo_ansible/roles/tripleo-podman/tasks/tripleo_docker_stop.yml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"106c02e7211b67c126ca735bad41be771d5cd6c8","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    - system_upgrade_prepare"},{"line_number":22,"context_line":"  become: true"},{"line_number":23,"context_line":"  block:"},{"line_number":24,"context_line":"    - name: Check if docker is enabled in the system "},{"line_number":25,"context_line":"      command: \"command -v docker\""},{"line_number":26,"context_line":"      register: check_docker_cli"},{"line_number":27,"context_line":"      failed_when: false"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5faad753_c21d0874","line":24,"range":{"start_line":24,"start_character":52,"end_line":24,"end_character":53},"updated":"2019-09-10 11:01:38.000000000","message":"spaces","commit_id":"c453832e7a80bc24111fae811f9eb6a1025a2873"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"106c02e7211b67c126ca735bad41be771d5cd6c8","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  become: true"},{"line_number":23,"context_line":"  block:"},{"line_number":24,"context_line":"    - name: Check if docker is enabled in the system "},{"line_number":25,"context_line":"      command: \"command -v docker\""},{"line_number":26,"context_line":"      register: check_docker_cli"},{"line_number":27,"context_line":"      failed_when: false"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5faad753_220e5c3b","line":25,"range":{"start_line":25,"start_character":14,"end_line":25,"end_character":34},"updated":"2019-09-10 11:01:38.000000000","message":"It checks for command present, but not for service running. I suppose it\u0027s ok enough for this task.","commit_id":"c453832e7a80bc24111fae811f9eb6a1025a2873"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"106c02e7211b67c126ca735bad41be771d5cd6c8","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    - name: Stop all services by stopping all Docker containers"},{"line_number":30,"context_line":"      command: docker ps -aq"},{"line_number":31,"context_line":"      register: running_containers"},{"line_number":32,"context_line":"      when: check_docker_cli.rc \u003d\u003d 0 "},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    - name: Stop a container"},{"line_number":35,"context_line":"      docker_container:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5faad753_b6fff1ff","line":32,"range":{"start_line":32,"start_character":36,"end_line":32,"end_character":37},"updated":"2019-09-10 11:01:38.000000000","message":"spaces","commit_id":"c453832e7a80bc24111fae811f9eb6a1025a2873"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"106c02e7211b67c126ca735bad41be771d5cd6c8","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        name: \"{{ item }}\""},{"line_number":37,"context_line":"        state: stopped"},{"line_number":38,"context_line":"      loop: \"{{ running_containers.stdout_lines | default([]) }}\""},{"line_number":39,"context_line":"      when: check_docker_cli.rc \u003d\u003d 0 "}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5faad753_3613015f","line":39,"range":{"start_line":39,"start_character":36,"end_line":39,"end_character":37},"updated":"2019-09-10 11:01:38.000000000","message":"spaces","commit_id":"c453832e7a80bc24111fae811f9eb6a1025a2873"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"2900be201b1e2a3bb487287abac4c3eafc6de6d6","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  become: true"},{"line_number":23,"context_line":"  block:"},{"line_number":24,"context_line":"    - name: Check if docker is enabled in the system"},{"line_number":25,"context_line":"      command: \"command -v docker\""},{"line_number":26,"context_line":"      register: check_docker_cli"},{"line_number":27,"context_line":"      failed_when: false"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5faad753_4a77ead5","line":25,"updated":"2019-09-10 13:43:55.000000000","message":"Not a good check because podman-docker gets installed by default on the overcloud.  You\u0027ll want to check for the docker socket.  We do this over in THT","commit_id":"5472cb0e887a452537919920e086fce1def0672d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c00263ee217b460b6bbb2238756b9ebe4cfc81a9","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  become: true"},{"line_number":23,"context_line":"  block:"},{"line_number":24,"context_line":"    - name: Check if docker is enabled in the system"},{"line_number":25,"context_line":"      command: \"command -v docker\""},{"line_number":26,"context_line":"      register: check_docker_cli"},{"line_number":27,"context_line":"      failed_when: false"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5faad753_3eb50fce","line":25,"in_reply_to":"5faad753_4a77ead5","updated":"2019-09-10 15:46:24.000000000","message":"Correction, it was paunch.\n\nhttps://review.opendev.org/#/c/679081/1/paunch/builder/base.py\n\nWe were having idempotency issues because the docker command existed even though it was supposed to be podman.","commit_id":"5472cb0e887a452537919920e086fce1def0672d"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"5d24fb61b92a43ab076a874d9e9b1625b5714630","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        name: \"{{ item }}\""},{"line_number":38,"context_line":"        state: stopped"},{"line_number":39,"context_line":"      loop: \"{{ running_containers.stdout_lines | default([]) }}\""},{"line_number":40,"context_line":"      when: check_docker.stat.exists"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5faad753_e63cb8c0","line":40,"range":{"start_line":40,"start_character":12,"end_line":40,"end_character":36},"updated":"2019-09-11 12:18:49.000000000","message":"NIT: I generally like these things to be cast to `bool`. Additionally I find it better to write conditions as a list, even if there\u0027s only one condition.","commit_id":"282adce74bba7f13d7d0c45a27163ad24f2347c1"}]}