)]}'
{"tripleo_ansible/ansible_plugins/modules/paunch.py":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"fb5793622031d1fcb28c7da0fd877a2bc278cbd4","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        stdout, stderr \u003d [\"\\n\".join(i) for i in (stdout_list, stderr_list)]"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        # Test paunch idempotency how we can."},{"line_number":159,"context_line":"        changed_strings \u003d [\u0027rm -f\u0027, \u0027Completed\u0027, \u0027Created\u0027]"},{"line_number":160,"context_line":"        if any(s in stdout for s in changed_strings):"},{"line_number":161,"context_line":"            self.results[\u0027changed\u0027] \u003d True"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_7cb4d235","line":159,"updated":"2019-09-23 02:32:14.000000000","message":"this is used to figure out if the module changed something or not.","commit_id":"fb050e6ef9eda3f273bf3298ebe7450522d9ebf6"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"72c184a34908feddea9d71862afec71ab7d412ea","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        stdout, stderr \u003d [\"\\n\".join(i) for i in (stdout_list, stderr_list)]"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        # Test paunch idempotency how we can."},{"line_number":159,"context_line":"        changed_strings \u003d [\u0027rm -f\u0027, \u0027Completed\u0027, \u0027Created\u0027]"},{"line_number":160,"context_line":"        if any(s in stdout for s in changed_strings):"},{"line_number":161,"context_line":"            self.results[\u0027changed\u0027] \u003d True"},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_bc680a21","line":159,"in_reply_to":"3fa7e38b_7cb4d235","updated":"2019-09-23 05:31:48.000000000","message":"yes, but it can be known only after a possible change. In check mode you need to know about that before, not after","commit_id":"fb050e6ef9eda3f273bf3298ebe7450522d9ebf6"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"82e74bf5077ed1d108a480b9267652db87e6d87c","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    )"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    if module.check_mode:"},{"line_number":184,"context_line":"        return results"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    PaunchManager(module, results)"},{"line_number":187,"context_line":"    module.exit_json(**results)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_862a9f8d","line":184,"range":{"start_line":184,"start_character":8,"end_line":184,"end_character":22},"updated":"2019-09-22 18:22:57.000000000","message":"instead of \"return results\":\n  module.exit_json(**results)","commit_id":"fb050e6ef9eda3f273bf3298ebe7450522d9ebf6"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"72c184a34908feddea9d71862afec71ab7d412ea","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    )"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    if module.check_mode:"},{"line_number":184,"context_line":"        return results"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    PaunchManager(module, results)"},{"line_number":187,"context_line":"    module.exit_json(**results)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_3c665a53","line":184,"range":{"start_line":184,"start_character":8,"end_line":184,"end_character":22},"in_reply_to":"3fa7e38b_5cb9d62b","updated":"2019-09-23 05:31:48.000000000","message":"Well, we don\u0027t check if change is needed, we know this postfactum and always run the command. So either we send changed\u003dtrue in check mode or we don\u0027t support it really.","commit_id":"fb050e6ef9eda3f273bf3298ebe7450522d9ebf6"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"fb5793622031d1fcb28c7da0fd877a2bc278cbd4","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    )"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    if module.check_mode:"},{"line_number":184,"context_line":"        return results"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    PaunchManager(module, results)"},{"line_number":187,"context_line":"    module.exit_json(**results)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_5cb9d62b","line":184,"range":{"start_line":184,"start_character":8,"end_line":184,"end_character":22},"in_reply_to":"3fa7e38b_61c0ad7c","updated":"2019-09-23 02:32:14.000000000","message":"i disagree, see my comment above ^","commit_id":"fb050e6ef9eda3f273bf3298ebe7450522d9ebf6"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"ffda8584d6646ac54863744515d6b123f68a5332","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    )"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    if module.check_mode:"},{"line_number":184,"context_line":"        return results"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    PaunchManager(module, results)"},{"line_number":187,"context_line":"    module.exit_json(**results)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_61c0ad7c","line":184,"range":{"start_line":184,"start_character":8,"end_line":184,"end_character":22},"in_reply_to":"3fa7e38b_862a9f8d","updated":"2019-09-22 21:17:37.000000000","message":"Actually this module always changes things, so it should be:\n\n  module.exit_json(changed\u003dTrue)","commit_id":"fb050e6ef9eda3f273bf3298ebe7450522d9ebf6"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"82e74bf5077ed1d108a480b9267652db87e6d87c","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        return results"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    PaunchManager(module, results)"},{"line_number":187,"context_line":"    module.exit_json(**results)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_662f63a1","line":187,"range":{"start_line":187,"start_character":4,"end_line":187,"end_character":30},"updated":"2019-09-22 18:22:57.000000000","message":"I think this should be above","commit_id":"fb050e6ef9eda3f273bf3298ebe7450522d9ebf6"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"fb5793622031d1fcb28c7da0fd877a2bc278cbd4","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        return results"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    PaunchManager(module, results)"},{"line_number":187,"context_line":"    module.exit_json(**results)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_1cea7e0e","line":187,"range":{"start_line":187,"start_character":4,"end_line":187,"end_character":30},"in_reply_to":"3fa7e38b_662f63a1","updated":"2019-09-23 02:32:14.000000000","message":"where? push over if you want","commit_id":"fb050e6ef9eda3f273bf3298ebe7450522d9ebf6"}]}