)]}'
{"tripleo_ansible/ansible_plugins/filter/helpers.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"fb9c14452bb4a308a4f811c397d4926da96e7dc6","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                continue"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"            # Build c_facts so it can be compared later with config_data"},{"line_number":130,"context_line":"            c_facts \u003d c_facts[0] if len(c_facts) \u003d\u003d 1 else {}"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"            # 0 was picked since it\u0027s the null_value for the subsort filter."},{"line_number":133,"context_line":"            # When a container config doesn\u0027t provide the start_order, it\u0027ll be"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_f5065b21","line":130,"updated":"2020-01-06 08:49:33.000000000","message":"not really familiar with this code but c_facts[0] will include c_name if i understand correctly is that ok? before it was doing c_facts[0].get(c_name)","commit_id":"dfb622795d933dc1b7eb1d7ba4507b55a666dc3c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"79cb9eb939b5bf77509e414ee456aab892fdcee3","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                continue"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"            # Build c_facts so it can be compared later with config_data"},{"line_number":130,"context_line":"            c_facts \u003d c_facts[0] if len(c_facts) \u003d\u003d 1 else {}"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"            # 0 was picked since it\u0027s the null_value for the subsort filter."},{"line_number":133,"context_line":"            # When a container config doesn\u0027t provide the start_order, it\u0027ll be"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_07bbbfbd","line":130,"in_reply_to":"3fa7e38b_0a8bd1c0","updated":"2020-01-07 06:58:16.000000000","message":"ack thanks for checking","commit_id":"dfb622795d933dc1b7eb1d7ba4507b55a666dc3c"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e974be2a590f153430fe62eace92c3209f1c64ec","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                continue"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"            # Build c_facts so it can be compared later with config_data"},{"line_number":130,"context_line":"            c_facts \u003d c_facts[0] if len(c_facts) \u003d\u003d 1 else {}"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"            # 0 was picked since it\u0027s the null_value for the subsort filter."},{"line_number":133,"context_line":"            # When a container config doesn\u0027t provide the start_order, it\u0027ll be"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_0a8bd1c0","line":130,"in_reply_to":"3fa7e38b_f5065b21","updated":"2020-01-06 15:51:55.000000000","message":"no because the config_data will only contain the value of the dict and not the key:\nhttps://review.opendev.org/#/c/701120/3/tripleo_ansible/roles/tripleo-container-manage/tasks/podman/create.yml\n\nWhich is what we want to compare (see later)","commit_id":"dfb622795d933dc1b7eb1d7ba4507b55a666dc3c"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e974be2a590f153430fe62eace92c3209f1c64ec","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"            # TODO(emilien) double check the comparing here and see if"},{"line_number":140,"context_line":"            # types are accurate (string vs dict, etc)"},{"line_number":141,"context_line":"            if c_facts !\u003d json.dumps(config_data):"},{"line_number":142,"context_line":"                to_delete +\u003d [c_name]"},{"line_number":143,"context_line":"                continue"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_caba996f","line":141,"updated":"2020-01-06 15:51:55.000000000","message":"here we want to compare the values of config_data without their container name.","commit_id":"dfb622795d933dc1b7eb1d7ba4507b55a666dc3c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"79cb9eb939b5bf77509e414ee456aab892fdcee3","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"            # TODO(emilien) double check the comparing here and see if"},{"line_number":140,"context_line":"            # types are accurate (string vs dict, etc)"},{"line_number":141,"context_line":"            if c_facts !\u003d json.dumps(config_data):"},{"line_number":142,"context_line":"                to_delete +\u003d [c_name]"},{"line_number":143,"context_line":"                continue"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_e7bd43b2","line":141,"in_reply_to":"3fa7e38b_caba996f","updated":"2020-01-07 06:58:16.000000000","message":"thanks","commit_id":"dfb622795d933dc1b7eb1d7ba4507b55a666dc3c"}],"tripleo_ansible/tests/plugins/filter/test_helpers.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"79cb9eb939b5bf77509e414ee456aab892fdcee3","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            # config_data didn\u0027t change: no restart"},{"line_number":343,"context_line":"            \u0027swift\u0027: {\u0027foo\u0027: \u0027bar\u0027},"},{"line_number":344,"context_line":"            # config_data changed: restart needed"},{"line_number":345,"context_line":"            \u0027heat\u0027: {\u0027start_order\u0027: 1},"},{"line_number":346,"context_line":"        }"},{"line_number":347,"context_line":"        expected_list \u003d [\u0027rabbitmq\u0027, \u0027haproxy\u0027, \u0027heat\u0027]"},{"line_number":348,"context_line":"        result \u003d self.filters.needs_delete(container_infos\u003ddata,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_a702eb70","line":345,"updated":"2020-01-07 06:58:16.000000000","message":"hm is there something wrong with the tests? or i don\u0027t understand them. I see you use                         \u0027config_data\u0027: \"{\\\"start_order\\\": 0}\",\non line 302 above. should it be the same here? or maybe this isn\u0027t testing the config data just matching on the config_id (i.e. step1?)","commit_id":"5d61d7940481d524ff29b9d6d9a6c1455bbdb82f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0fcc9cecb59ce25dbe640869e312fafadad69e9b","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            # config_data didn\u0027t change: no restart"},{"line_number":343,"context_line":"            \u0027swift\u0027: {\u0027foo\u0027: \u0027bar\u0027},"},{"line_number":344,"context_line":"            # config_data changed: restart needed"},{"line_number":345,"context_line":"            \u0027heat\u0027: {\u0027start_order\u0027: 1},"},{"line_number":346,"context_line":"        }"},{"line_number":347,"context_line":"        expected_list \u003d [\u0027rabbitmq\u0027, \u0027haproxy\u0027, \u0027heat\u0027]"},{"line_number":348,"context_line":"        result \u003d self.filters.needs_delete(container_infos\u003ddata,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_db657eb1","line":345,"in_reply_to":"3fa7e38b_a702eb70","updated":"2020-01-07 12:32:47.000000000","message":"I mocked the data return by \"podman inspect\" which is originally populated by ansible in: https://review.opendev.org/#/c/701120/5/tripleo_ansible/roles/tripleo-container-manage/tasks/podman/create.yml@45\n\n  config_data: \"{{ lookup(\u0027dict\u0027, container_data).value | to_json }}\"\n\nCheck on your local deployment, you\u0027ll see that the config_data JSON blob from podman inspect returns this syntax.\nHowever, the data that is in /var/lib/tripleo-config is proper json. I\u0027ll put that in my TODO to investigate further this week; but I wouldn\u0027t block on that please.","commit_id":"5d61d7940481d524ff29b9d6d9a6c1455bbdb82f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c63ad67d27a760978b946f2d3dc6bcccc8a456a8","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            # config_data didn\u0027t change: no restart"},{"line_number":343,"context_line":"            \u0027swift\u0027: {\u0027foo\u0027: \u0027bar\u0027},"},{"line_number":344,"context_line":"            # config_data changed: restart needed"},{"line_number":345,"context_line":"            \u0027heat\u0027: {\u0027start_order\u0027: 1},"},{"line_number":346,"context_line":"        }"},{"line_number":347,"context_line":"        expected_list \u003d [\u0027rabbitmq\u0027, \u0027haproxy\u0027, \u0027heat\u0027]"},{"line_number":348,"context_line":"        result \u003d self.filters.needs_delete(container_infos\u003ddata,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_7b0c8aea","line":345,"in_reply_to":"3fa7e38b_db657eb1","updated":"2020-01-07 12:34:16.000000000","message":"ack thanks for checking","commit_id":"5d61d7940481d524ff29b9d6d9a6c1455bbdb82f"}]}