)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7f833873c94ddb0836a54c53f8680e738ad8bd2b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Rework fact to support legacy jinja"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change will allow the fact `containers_changed` to function when run"},{"line_number":10,"context_line":"under all versions of jinja 2."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie88a49b990edd619ea89f952f2dd0a64fe6d3863"},{"line_number":13,"context_line":"Signed-off-by: Kevin Carter \u003ckecarter@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_7ddfdb37","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":30},"updated":"2020-01-21 10:04:33.000000000","message":"Which version of jinja was an issue, and which part of the filter set was the issue?","commit_id":"34d2ed3190b137c431e1b6e405c12e589408fd4f"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7bb75cdf081460356e8808b0c05e5168369d9f46","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Rework fact to support legacy jinja"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change will allow the fact `containers_changed` to function when run"},{"line_number":10,"context_line":"under all versions of jinja 2."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie88a49b990edd619ea89f952f2dd0a64fe6d3863"},{"line_number":13,"context_line":"Signed-off-by: Kevin Carter \u003ckecarter@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_bec8e61f","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":30},"in_reply_to":"3fa7e38b_69aabdd3","updated":"2020-01-21 15:36:21.000000000","message":"\u0027equalto\u0027 is used all over tripleo-ansible - perhaps everywhere needs reworking to support legacy jinja2?\n\nAlso, perhaps we should make a note in-line to revert this once we no longer care about jinja versions \u003c 2.8?","commit_id":"34d2ed3190b137c431e1b6e405c12e589408fd4f"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"425dee47cd8765d28be65e81c44d4ba13899e045","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Rework fact to support legacy jinja"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change will allow the fact `containers_changed` to function when run"},{"line_number":10,"context_line":"under all versions of jinja 2."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie88a49b990edd619ea89f952f2dd0a64fe6d3863"},{"line_number":13,"context_line":"Signed-off-by: Kevin Carter \u003ckecarter@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_69aabdd3","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":30},"in_reply_to":"3fa7e38b_7ddfdb37","updated":"2020-01-21 13:32:33.000000000","message":"anything before 2.8 will fail due to the \"equalto\" function not being found.","commit_id":"34d2ed3190b137c431e1b6e405c12e589408fd4f"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"8e961ebfd5e5c51c34f79df2aefd35b04a2820e6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Rework fact to support legacy jinja"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change will allow the fact `containers_changed` to function when run"},{"line_number":10,"context_line":"under all versions of jinja 2."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie88a49b990edd619ea89f952f2dd0a64fe6d3863"},{"line_number":13,"context_line":"Signed-off-by: Kevin Carter \u003ckecarter@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_74512d63","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":30},"in_reply_to":"3fa7e38b_bec8e61f","updated":"2020-01-21 17:03:39.000000000","message":"Im going to abandon this review and will add the package dependency for python2-jinja2. it seems there are two packages that provide for the same thing and the base package we use is python-jinja2, which gives us 2.7, which is too old.","commit_id":"34d2ed3190b137c431e1b6e405c12e589408fd4f"}],"tripleo_ansible/roles/tripleo-container-manage/tasks/podman/create.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7f833873c94ddb0836a54c53f8680e738ad8bd2b","unresolved":false,"context_lines":[{"line_number":80,"context_line":"- name: \"Create a list of containers which changed\""},{"line_number":81,"context_line":"  set_fact:"},{"line_number":82,"context_line":"    containers_changed: |-"},{"line_number":83,"context_line":"      {% set container_datas \u003d [] %}"},{"line_number":84,"context_line":"      {% for item in create_async_results.results %}"},{"line_number":85,"context_line":"      {%   if (item.get(\u0027changed\u0027, false) | bool) and (\u0027container_data\u0027 in item) %}"},{"line_number":86,"context_line":"      {%     set _ \u003d container_datas.append(item[\u0027container_data\u0027]) %}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_fd374bae","line":83,"range":{"start_line":83,"start_character":6,"end_line":83,"end_character":8},"updated":"2020-01-21 10:04:33.000000000","message":"I think you may find that the result is a string due to the leading spaces? To resolve that, change all these leading \u0027{%\u0027 to \u0027{%-\u0027 and do the same with the last line, making it lead with \u0027{{-\u0027.","commit_id":"34d2ed3190b137c431e1b6e405c12e589408fd4f"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7bb75cdf081460356e8808b0c05e5168369d9f46","unresolved":false,"context_lines":[{"line_number":80,"context_line":"- name: \"Create a list of containers which changed\""},{"line_number":81,"context_line":"  set_fact:"},{"line_number":82,"context_line":"    containers_changed: |-"},{"line_number":83,"context_line":"      {% set container_datas \u003d [] %}"},{"line_number":84,"context_line":"      {% for item in create_async_results.results %}"},{"line_number":85,"context_line":"      {%   if (item.get(\u0027changed\u0027, false) | bool) and (\u0027container_data\u0027 in item) %}"},{"line_number":86,"context_line":"      {%     set _ \u003d container_datas.append(item[\u0027container_data\u0027]) %}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_5ecf7253","line":83,"range":{"start_line":83,"start_character":6,"end_line":83,"end_character":8},"in_reply_to":"3fa7e38b_fd374bae","updated":"2020-01-21 15:36:21.000000000","message":"I see that the result is always a list, so you may find that there are empty values in the list.","commit_id":"34d2ed3190b137c431e1b6e405c12e589408fd4f"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7f833873c94ddb0836a54c53f8680e738ad8bd2b","unresolved":false,"context_lines":[{"line_number":86,"context_line":"      {%     set _ \u003d container_datas.append(item[\u0027container_data\u0027]) %}"},{"line_number":87,"context_line":"      {%   endif %}"},{"line_number":88,"context_line":"      {% endfor %}"},{"line_number":89,"context_line":"      {{ container_datas | list_of_keys }}"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"- name: Block for container commands"},{"line_number":92,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_bdb23304","line":89,"range":{"start_line":89,"start_character":9,"end_line":89,"end_character":39},"updated":"2020-01-21 10:04:33.000000000","message":"It\u0027s the first I see this custom filter, and I wonder why it exists when it\u0027s possible to just do:\n\n{{ container_datas.keys() | list }}","commit_id":"34d2ed3190b137c431e1b6e405c12e589408fd4f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"569f01f4c3ee7c8ff0619d14f3326388816fa6e2","unresolved":false,"context_lines":[{"line_number":86,"context_line":"      {%     set _ \u003d container_datas.append(item[\u0027container_data\u0027]) %}"},{"line_number":87,"context_line":"      {%   endif %}"},{"line_number":88,"context_line":"      {% endfor %}"},{"line_number":89,"context_line":"      {{ container_datas | list_of_keys }}"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"- name: Block for container commands"},{"line_number":92,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_899b7962","line":89,"range":{"start_line":89,"start_character":9,"end_line":89,"end_character":39},"in_reply_to":"3fa7e38b_5dc77f47","updated":"2020-01-21 13:51:45.000000000","message":"I created that filter because there is no filter to return a list of keys from a list of dictionaries","commit_id":"34d2ed3190b137c431e1b6e405c12e589408fd4f"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"7bb75cdf081460356e8808b0c05e5168369d9f46","unresolved":false,"context_lines":[{"line_number":86,"context_line":"      {%     set _ \u003d container_datas.append(item[\u0027container_data\u0027]) %}"},{"line_number":87,"context_line":"      {%   endif %}"},{"line_number":88,"context_line":"      {% endfor %}"},{"line_number":89,"context_line":"      {{ container_datas | list_of_keys }}"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"- name: Block for container commands"},{"line_number":92,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_5e3d3227","line":89,"range":{"start_line":89,"start_character":9,"end_line":89,"end_character":39},"in_reply_to":"3fa7e38b_899b7962","updated":"2020-01-21 15:36:21.000000000","message":"Interesting, thanks for the background. I expect that jmespath (json_query filter) could be used instead, but it won\u0027t be as succinct I don\u0027t think.","commit_id":"34d2ed3190b137c431e1b6e405c12e589408fd4f"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"ab82e5f2a4247bc7e01a6c234a0080a4072f7775","unresolved":false,"context_lines":[{"line_number":86,"context_line":"      {%     set _ \u003d container_datas.append(item[\u0027container_data\u0027]) %}"},{"line_number":87,"context_line":"      {%   endif %}"},{"line_number":88,"context_line":"      {% endfor %}"},{"line_number":89,"context_line":"      {{ container_datas | list_of_keys }}"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"- name: Block for container commands"},{"line_number":92,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_5dc77f47","line":89,"range":{"start_line":89,"start_character":9,"end_line":89,"end_character":39},"in_reply_to":"3fa7e38b_bdb23304","updated":"2020-01-21 10:10:05.000000000","message":"See https://docs.ansible.com/ansible/latest/user_guide/playbooks_python_version.html for some guidance.","commit_id":"34d2ed3190b137c431e1b6e405c12e589408fd4f"}]}