)]}'
{"tripleo_ansible/roles/tripleo-ssh-known-hosts/tasks/main.yml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"43fdd93dccd2fca9bf7af9c07a1623aaffc8d8df","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        ssh_known_hosts_lines: |-"},{"line_number":50,"context_line":"          {% for host in (groups[\u0027overcloud\u0027] | intersect(play_hosts)) %}"},{"line_number":51,"context_line":"          {%   set hostdata \u003d hostvars[host] %}"},{"line_number":52,"context_line":"          {%   if (\u0027ansible_ssh_host_key_rsa_public\u0027 in hostdata) or (ansible_ssh_host_key_rsa_public is defined) %}"},{"line_number":53,"context_line":"          {%     if (cloud_domain is defined) and (hostdata[\u0027ctlplane_ip\u0027] is defined) %}"},{"line_number":54,"context_line":"          {%       set line \u003d \u0027[\u0027 ~ hostdata[\u0027ctlplane_ip\u0027] ~ \u0027]*,[\u0027 ~ host ~ \u0027.\u0027 ~ cloud_domain ~ \u0027]*,[\u0027 ~ host ~ \u0027]*\u0027 %}"},{"line_number":55,"context_line":"          {%       set role_networks \u003d hostdata[\u0027role_networks\u0027] | default([]) %}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_916cfb9d","line":52,"range":{"start_line":52,"start_character":70,"end_line":52,"end_character":101},"updated":"2020-01-21 15:56:19.000000000","message":"@cloudnull - why fall back to this?","commit_id":"4c1e483fcf12a1bc761c725de2262550a637324e"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"785939f5d543a9d3323d1f6b3c269eb4cb58ed03","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        ssh_known_hosts_lines: |-"},{"line_number":50,"context_line":"          {% for host in (groups[\u0027overcloud\u0027] | intersect(play_hosts)) %}"},{"line_number":51,"context_line":"          {%   set hostdata \u003d hostvars[host] %}"},{"line_number":52,"context_line":"          {%   if (\u0027ansible_ssh_host_key_rsa_public\u0027 in hostdata) or (ansible_ssh_host_key_rsa_public is defined) %}"},{"line_number":53,"context_line":"          {%     if (cloud_domain is defined) and (hostdata[\u0027ctlplane_ip\u0027] is defined) %}"},{"line_number":54,"context_line":"          {%       set line \u003d \u0027[\u0027 ~ hostdata[\u0027ctlplane_ip\u0027] ~ \u0027]*,[\u0027 ~ host ~ \u0027.\u0027 ~ cloud_domain ~ \u0027]*,[\u0027 ~ host ~ \u0027]*\u0027 %}"},{"line_number":55,"context_line":"          {%       set role_networks \u003d hostdata[\u0027role_networks\u0027] | default([]) %}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_b17b3729","line":52,"range":{"start_line":52,"start_character":70,"end_line":52,"end_character":101},"in_reply_to":"3fa7e38b_916cfb9d","updated":"2020-01-21 16:01:10.000000000","message":"one is a host variable and the other is a global fact, so we\u0027re checking if either are defined.","commit_id":"4c1e483fcf12a1bc761c725de2262550a637324e"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"70fa6140433d9e49c106a6228b281832f0e348e6","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        ssh_known_hosts_lines: |-"},{"line_number":50,"context_line":"          {% for host in (groups[\u0027overcloud\u0027] | intersect(play_hosts)) %}"},{"line_number":51,"context_line":"          {%   set hostdata \u003d hostvars[host] %}"},{"line_number":52,"context_line":"          {%   if (\u0027ansible_ssh_host_key_rsa_public\u0027 in hostdata) or (ansible_ssh_host_key_rsa_public is defined) %}"},{"line_number":53,"context_line":"          {%     if (cloud_domain is defined) and (hostdata[\u0027ctlplane_ip\u0027] is defined) %}"},{"line_number":54,"context_line":"          {%       set line \u003d \u0027[\u0027 ~ hostdata[\u0027ctlplane_ip\u0027] ~ \u0027]*,[\u0027 ~ host ~ \u0027.\u0027 ~ cloud_domain ~ \u0027]*,[\u0027 ~ host ~ \u0027]*\u0027 %}"},{"line_number":55,"context_line":"          {%       set role_networks \u003d hostdata[\u0027role_networks\u0027] | default([]) %}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_117a4bef","line":52,"range":{"start_line":52,"start_character":70,"end_line":52,"end_character":101},"in_reply_to":"3fa7e38b_b17b3729","updated":"2020-01-21 16:09:06.000000000","message":"but isn\u0027t the global fact wrong?","commit_id":"4c1e483fcf12a1bc761c725de2262550a637324e"},{"author":{"_account_id":19619,"name":"Michal Pryc","email":"mpryc@redhat.com","username":"migi"},"change_message_id":"d7c70bbdbdc4bc92cc3d1051222125a91e0e6337","unresolved":false,"context_lines":[{"line_number":77,"context_line":"      blockinfile:"},{"line_number":78,"context_line":"        path: \"{{ ssh_known_hosts_tmp.path }}\""},{"line_number":79,"context_line":"        block: \"{{ ssh_known_hosts_lines }}\""},{"line_number":80,"context_line":"        create: true"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    # Workaround https://bugs.launchpad.net/tripleo/+bug/1810932"},{"line_number":83,"context_line":"    # Ansible modules perform a replace instead of in-place modification."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_d1fcb372","line":80,"updated":"2020-01-21 16:04:54.000000000","message":"For easier readibility it could be:\n    marker: \"# {mark} ADDED BY tripleo-ssh-known-hosts ROLE\"","commit_id":"4c1e483fcf12a1bc761c725de2262550a637324e"},{"author":{"_account_id":19619,"name":"Michal Pryc","email":"mpryc@redhat.com","username":"migi"},"change_message_id":"2cf07cd4e71e292ae9e845bf76f3eee60a5b1f2e","unresolved":false,"context_lines":[{"line_number":77,"context_line":"      blockinfile:"},{"line_number":78,"context_line":"        path: \"{{ ssh_known_hosts_tmp.path }}\""},{"line_number":79,"context_line":"        block: \"{{ ssh_known_hosts_lines }}\""},{"line_number":80,"context_line":"        create: true"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    # Workaround https://bugs.launchpad.net/tripleo/+bug/1810932"},{"line_number":83,"context_line":"    # Ansible modules perform a replace instead of in-place modification."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_71093f30","line":80,"in_reply_to":"3fa7e38b_d1fcb372","updated":"2020-01-21 16:31:14.000000000","message":"You are right it will (just checked with simple ansible task), so the proper solution here is to remove everything within the marker is found and then re-add this to hosts, but it\u0027s bigger change and not relevant to this one.","commit_id":"4c1e483fcf12a1bc761c725de2262550a637324e"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"c3a8ea4c48a08db5d1a741ba3ce723147ac65994","unresolved":false,"context_lines":[{"line_number":77,"context_line":"      blockinfile:"},{"line_number":78,"context_line":"        path: \"{{ ssh_known_hosts_tmp.path }}\""},{"line_number":79,"context_line":"        block: \"{{ ssh_known_hosts_lines }}\""},{"line_number":80,"context_line":"        create: true"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    # Workaround https://bugs.launchpad.net/tripleo/+bug/1810932"},{"line_number":83,"context_line":"    # Ansible modules perform a replace instead of in-place modification."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_9165db4b","line":80,"in_reply_to":"3fa7e38b_d1fcb372","updated":"2020-01-21 16:09:44.000000000","message":"can we change the marker now? Wouldn\u0027t that result in duplicate blocks?","commit_id":"4c1e483fcf12a1bc761c725de2262550a637324e"}]}