)]}'
{"tripleo_ansible/roles/tripleo_hieradata/templates/vip_data.j2":[{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"6203cb011248a04a74a081972bab0573d17f4efa","unresolved":false,"context_lines":[{"line_number":19,"context_line":"{%   if network \u003d\u003d \u0027StorageDashboard\u0027 %}"},{"line_number":20,"context_line":"{%     set _ \u003d vip_data.__setitem__(\u0027ceph_grafana_vip\u0027, (net_vip_map.storage_dashboard)) %}"},{"line_number":21,"context_line":"{%   else %}"},{"line_number":22,"context_line":"{%     set _ \u003d vip_data.__setitem__(\u0027ceph_grafana_vip\u0027, (net_vip_map.storage)) %}"},{"line_number":23,"context_line":"{%   endif %}"},{"line_number":24,"context_line":"{% endfor %}"},{"line_number":25,"context_line":"{# public_virtual_ip and controller_virtual_ip are needed in both HAproxy \u0026 keepalived. #}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3fa7e38b_4ee45d0b","line":22,"range":{"start_line":22,"start_character":69,"end_line":22,"end_character":76},"updated":"2020-01-27 12:59:46.000000000","message":"does this exist or I need to refer to the storage network using the `net_vip_map[networks[\u0027Storage\u0027][\u0027name_lower\u0027]]` form?","commit_id":"4af10562a5b00c0d5bd2a9395d3e4100136d495b"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"6203cb011248a04a74a081972bab0573d17f4efa","unresolved":false,"context_lines":[{"line_number":44,"context_line":"{% for service in enabled_services %}"},{"line_number":45,"context_line":"{%   if service_net_map.get(service ~ \u0027_network\u0027, \u0027noop\u0027) in net_vip_map %}"},{"line_number":46,"context_line":"{# we set explicit vips for these services, no need to calculate them dynamically #}"},{"line_number":47,"context_line":"{%     if service not in [\u0027ovn_dbs\u0027, \u0027redis\u0027, \u0027ganesha\u0027, \u0027keystone_admin_api_vip\u0027, \u0027keystone_public_api_vip\u0027, \u0027ceph_grafana\u0027] %}"},{"line_number":48,"context_line":"{%       set _ \u003d vip_data.__setitem__((service ~ \u0027_vip\u0027), (net_vip_map[service_net_map[service ~ \u0027_network\u0027]])) %}"},{"line_number":49,"context_line":"{%     endif %}"},{"line_number":50,"context_line":"{# we set the ovn_dbs_vip to the per-network VIP *if* we detect that there is no separate ovn_dbs VIP set (I.e. THT patch for separate OVN VIP is missing) #}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3fa7e38b_0ed3c538","line":47,"range":{"start_line":47,"start_character":111,"end_line":47,"end_character":123},"updated":"2020-01-27 12:59:46.000000000","message":"should we need to remove this?","commit_id":"4af10562a5b00c0d5bd2a9395d3e4100136d495b"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"62e8689d69dffc4ecd85bbb80f3fdcee99c5b476","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{%   endif %}"},{"line_number":19,"context_line":"{%   if network \u003d\u003d \u0027StorageDashboard\u0027 %}"},{"line_number":20,"context_line":"{%     set _ \u003d vip_data.__setitem__(\u0027ceph_dashboard_vip\u0027, (net_vip_map.storage_dashboard)) %}"},{"line_number":21,"context_line":"{%   else %}"},{"line_number":22,"context_line":"{%     set _ \u003d vip_data.__setitem__(\u0027ceph_dashboard_vip\u0027, (net_vip_map.ctlplane)) %}"},{"line_number":23,"context_line":"{%   endif %}"},{"line_number":24,"context_line":"{% endfor %}"},{"line_number":25,"context_line":"{# public_virtual_ip and controller_virtual_ip are needed in both HAproxy \u0026 keepalived. #}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_bb2ded45","line":22,"range":{"start_line":21,"start_character":0,"end_line":22,"end_character":84},"updated":"2020-01-29 10:00:59.000000000","message":"Maybe this is not necessary because if ceph_dashboard_vip is not set haproxy fallback on the ctlplane vip","commit_id":"66833642c9e9c6bac8d8fcfbb9769913f016bb6f"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"62e8689d69dffc4ecd85bbb80f3fdcee99c5b476","unresolved":false,"context_lines":[{"line_number":17,"context_line":"{%     set _ \u003d vip_data.__setitem__(\u0027ganesha_vip\u0027, (net_vip_map[networks[\u0027StorageNFS\u0027][\u0027name_lower\u0027]])) %}"},{"line_number":18,"context_line":"{%   endif %}"},{"line_number":19,"context_line":"{%   if network \u003d\u003d \u0027StorageDashboard\u0027 %}"},{"line_number":20,"context_line":"{%     set _ \u003d vip_data.__setitem__(\u0027ceph_dashboard_vip\u0027, (net_vip_map.storage_dashboard)) %}"},{"line_number":21,"context_line":"{%   else %}"},{"line_number":22,"context_line":"{%     set _ \u003d vip_data.__setitem__(\u0027ceph_dashboard_vip\u0027, (net_vip_map.ctlplane)) %}"},{"line_number":23,"context_line":"{%   endif %}"},{"line_number":24,"context_line":"{% endfor %}"},{"line_number":25,"context_line":"{# public_virtual_ip and controller_virtual_ip are needed in both HAproxy \u0026 keepalived. #}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3fa7e38b_9bb4b1d5","line":22,"range":{"start_line":20,"start_character":0,"end_line":22,"end_character":84},"updated":"2020-01-29 10:00:59.000000000","message":"\"ceph_dashboard\" service doesn\u0027t exist because the dashboard we expose here is just a plugin of the ceph mgr service.\nSince we can have N plugins bound to ceph_mgr service (e.g., prometheus, alertmanager, etc ..), we need to explicitly set the \"ceph_dashboard_vip\" variable.\nMaybe the else statement could be avoided since we rely on the default (which is ctlplane network) here [1], but here we will make sure we have the variable on vip_data.json.\n\n[1] https://review.opendev.org/#/c/702839/8/manifests/haproxy.pp@1074","commit_id":"82dfb329e22edcb64391b2b207f6464ae684c76c"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"fe84d11aab069b3f28636c01e4dbe43ea41059aa","unresolved":false,"context_lines":[{"line_number":17,"context_line":"{%     set _ \u003d vip_data.__setitem__(\u0027ganesha_vip\u0027, (net_vip_map[networks[\u0027StorageNFS\u0027][\u0027name_lower\u0027]])) %}"},{"line_number":18,"context_line":"{%   endif %}"},{"line_number":19,"context_line":"{%   if network \u003d\u003d \u0027StorageDashboard\u0027 %}"},{"line_number":20,"context_line":"{%     set _ \u003d vip_data.__setitem__(\u0027ceph_dashboard_vip\u0027, (net_vip_map.storage_dashboard)) %}"},{"line_number":21,"context_line":"{%   else %}"},{"line_number":22,"context_line":"{%     set _ \u003d vip_data.__setitem__(\u0027ceph_dashboard_vip\u0027, (net_vip_map.ctlplane)) %}"},{"line_number":23,"context_line":"{%   endif %}"},{"line_number":24,"context_line":"{% endfor %}"},{"line_number":25,"context_line":"{# public_virtual_ip and controller_virtual_ip are needed in both HAproxy \u0026 keepalived. #}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3fa7e38b_5e0cd595","line":22,"range":{"start_line":20,"start_character":0,"end_line":22,"end_character":84},"in_reply_to":"3fa7e38b_53260e6d","updated":"2020-01-30 10:57:09.000000000","message":"++ and thanks, I\u0027ll remove the else statement in the next PS","commit_id":"82dfb329e22edcb64391b2b207f6464ae684c76c"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"3c2f393c8164450948e1038592e719c4fa266612","unresolved":false,"context_lines":[{"line_number":17,"context_line":"{%     set _ \u003d vip_data.__setitem__(\u0027ganesha_vip\u0027, (net_vip_map[networks[\u0027StorageNFS\u0027][\u0027name_lower\u0027]])) %}"},{"line_number":18,"context_line":"{%   endif %}"},{"line_number":19,"context_line":"{%   if network \u003d\u003d \u0027StorageDashboard\u0027 %}"},{"line_number":20,"context_line":"{%     set _ \u003d vip_data.__setitem__(\u0027ceph_dashboard_vip\u0027, (net_vip_map.storage_dashboard)) %}"},{"line_number":21,"context_line":"{%   else %}"},{"line_number":22,"context_line":"{%     set _ \u003d vip_data.__setitem__(\u0027ceph_dashboard_vip\u0027, (net_vip_map.ctlplane)) %}"},{"line_number":23,"context_line":"{%   endif %}"},{"line_number":24,"context_line":"{% endfor %}"},{"line_number":25,"context_line":"{# public_virtual_ip and controller_virtual_ip are needed in both HAproxy \u0026 keepalived. #}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3fa7e38b_53260e6d","line":22,"range":{"start_line":20,"start_character":0,"end_line":22,"end_character":84},"in_reply_to":"3fa7e38b_9bb4b1d5","updated":"2020-01-30 09:30:12.000000000","message":"ack but we should get it from the endpoint_map","commit_id":"82dfb329e22edcb64391b2b207f6464ae684c76c"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"62e8689d69dffc4ecd85bbb80f3fdcee99c5b476","unresolved":false,"context_lines":[{"line_number":44,"context_line":"{% for service in enabled_services %}"},{"line_number":45,"context_line":"{%   if service_net_map.get(service ~ \u0027_network\u0027, \u0027noop\u0027) in net_vip_map %}"},{"line_number":46,"context_line":"{# we set explicit vips for these services, no need to calculate them dynamically #}"},{"line_number":47,"context_line":"{%     if service not in [\u0027ovn_dbs\u0027, \u0027redis\u0027, \u0027ganesha\u0027, \u0027keystone_admin_api_vip\u0027, \u0027keystone_public_api_vip\u0027] %}"},{"line_number":48,"context_line":"{%       set _ \u003d vip_data.__setitem__((service ~ \u0027_vip\u0027), (net_vip_map[service_net_map[service ~ \u0027_network\u0027]])) %}"},{"line_number":49,"context_line":"{%     endif %}"},{"line_number":50,"context_line":"{# we set the ovn_dbs_vip to the per-network VIP *if* we detect that there is no separate ovn_dbs VIP set (I.e. THT patch for separate OVN VIP is missing) #}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3fa7e38b_7ba695c1","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":112},"updated":"2020-01-29 10:00:59.000000000","message":"removing \"ceph_grafana\" means we rely on the defaults, so my expectation is to see a ceph_grafana_vip on the storage network (according to the previously defined CephGrafanaNetwork mapping)","commit_id":"82dfb329e22edcb64391b2b207f6464ae684c76c"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"3c2f393c8164450948e1038592e719c4fa266612","unresolved":false,"context_lines":[{"line_number":44,"context_line":"{% for service in enabled_services %}"},{"line_number":45,"context_line":"{%   if service_net_map.get(service ~ \u0027_network\u0027, \u0027noop\u0027) in net_vip_map %}"},{"line_number":46,"context_line":"{# we set explicit vips for these services, no need to calculate them dynamically #}"},{"line_number":47,"context_line":"{%     if service not in [\u0027ovn_dbs\u0027, \u0027redis\u0027, \u0027ganesha\u0027, \u0027keystone_admin_api_vip\u0027, \u0027keystone_public_api_vip\u0027] %}"},{"line_number":48,"context_line":"{%       set _ \u003d vip_data.__setitem__((service ~ \u0027_vip\u0027), (net_vip_map[service_net_map[service ~ \u0027_network\u0027]])) %}"},{"line_number":49,"context_line":"{%     endif %}"},{"line_number":50,"context_line":"{# we set the ovn_dbs_vip to the per-network VIP *if* we detect that there is no separate ovn_dbs VIP set (I.e. THT patch for separate OVN VIP is missing) #}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3fa7e38b_131ad66a","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":112},"in_reply_to":"3fa7e38b_7ba695c1","updated":"2020-01-30 09:30:12.000000000","message":"+1","commit_id":"82dfb329e22edcb64391b2b207f6464ae684c76c"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"76bd17b0ac9972e8b4c6b1892468d91809f3675a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"{%     set _ \u003d vip_data.__setitem__(\u0027ganesha_vip\u0027, (net_vip_map[networks[\u0027StorageNFS\u0027][\u0027name_lower\u0027]])) %}"},{"line_number":18,"context_line":"{%   endif %}"},{"line_number":19,"context_line":"{%   if network \u003d\u003d \u0027StorageDashboard\u0027 %}"},{"line_number":20,"context_line":"{%     set _ \u003d vip_data.__setitem__(\u0027ceph_dashboard_vip\u0027, (net_vip_map.storage_dashboard)) %}"},{"line_number":21,"context_line":"{%   endif %}"},{"line_number":22,"context_line":"{% endfor %}"},{"line_number":23,"context_line":"{# public_virtual_ip and controller_virtual_ip are needed in both HAproxy \u0026 keepalived. #}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_8e5d3ced","line":20,"updated":"2020-01-30 13:16:08.000000000","message":"[networks[\u0027StorageDashboard\u0027][\u0027name_lower\u0027]]","commit_id":"f0cfefd5220de4decee1b98dacad283be1a58cbf"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"9804c6596941934bbf57d9a0a4da67d6a961e05c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"{% for service in enabled_services %}"},{"line_number":43,"context_line":"{%   if service_net_map.get(service ~ \u0027_network\u0027, \u0027noop\u0027) in net_vip_map %}"},{"line_number":44,"context_line":"{# we set explicit vips for these services, no need to calculate them dynamically #}"},{"line_number":45,"context_line":"{%     if service not in [\u0027ovn_dbs\u0027, \u0027redis\u0027, \u0027ganesha\u0027, \u0027keystone_admin_api_vip\u0027, \u0027keystone_public_api_vip\u0027] %}"},{"line_number":46,"context_line":"{%       set _ \u003d vip_data.__setitem__((service ~ \u0027_vip\u0027), (net_vip_map[service_net_map[service ~ \u0027_network\u0027]])) %}"},{"line_number":47,"context_line":"{%     endif %}"},{"line_number":48,"context_line":"{# we set the ovn_dbs_vip to the per-network VIP *if* we detect that there is no separate ovn_dbs VIP set (I.e. THT patch for separate OVN VIP is missing) #}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_19e2f79d","line":45,"updated":"2020-01-30 12:03:10.000000000","message":"so we do let ceph_graphana_vip to be set after the service_net map config which looks fine","commit_id":"f0cfefd5220de4decee1b98dacad283be1a58cbf"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"d41ebfedc321dd33f4962c0d943125cd44b9521a","unresolved":false,"context_lines":[{"line_number":42,"context_line":"{% for service in enabled_services %}"},{"line_number":43,"context_line":"{%   if service_net_map.get(service ~ \u0027_network\u0027, \u0027noop\u0027) in net_vip_map %}"},{"line_number":44,"context_line":"{# we set explicit vips for these services, no need to calculate them dynamically #}"},{"line_number":45,"context_line":"{%     if service not in [\u0027ovn_dbs\u0027, \u0027redis\u0027, \u0027ganesha\u0027, \u0027keystone_admin_api_vip\u0027, \u0027keystone_public_api_vip\u0027] %}"},{"line_number":46,"context_line":"{%       set _ \u003d vip_data.__setitem__((service ~ \u0027_vip\u0027), (net_vip_map[service_net_map[service ~ \u0027_network\u0027]])) %}"},{"line_number":47,"context_line":"{%     endif %}"},{"line_number":48,"context_line":"{# we set the ovn_dbs_vip to the per-network VIP *if* we detect that there is no separate ovn_dbs VIP set (I.e. THT patch for separate OVN VIP is missing) #}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_6be1d231","line":45,"in_reply_to":"3fa7e38b_19e2f79d","updated":"2020-01-30 12:25:49.000000000","message":"exactly, using this approach it\u0027s set according to service_net_map[\u0027ceph_grafana_network_value\u0027] which is the storage network according to [1]\n\n[1] https://github.com/openstack/tripleo-heat-templates/blob/master/network/service_net_map.j2.yaml#L77","commit_id":"f0cfefd5220de4decee1b98dacad283be1a58cbf"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"554d9de8309abf814ba5dfe03509ebac488020b0","unresolved":false,"context_lines":[{"line_number":42,"context_line":"{% for service in enabled_services %}"},{"line_number":43,"context_line":"{%   if service_net_map.get(service ~ \u0027_network\u0027, \u0027noop\u0027) in net_vip_map %}"},{"line_number":44,"context_line":"{# we set explicit vips for these services, no need to calculate them dynamically #}"},{"line_number":45,"context_line":"{%     if service not in [\u0027ovn_dbs\u0027, \u0027redis\u0027, \u0027ganesha\u0027, \u0027keystone_admin_api_vip\u0027, \u0027keystone_public_api_vip\u0027] %}"},{"line_number":46,"context_line":"{%       set _ \u003d vip_data.__setitem__((service ~ \u0027_vip\u0027), (net_vip_map[service_net_map[service ~ \u0027_network\u0027]])) %}"},{"line_number":47,"context_line":"{%     endif %}"},{"line_number":48,"context_line":"{# we set the ovn_dbs_vip to the per-network VIP *if* we detect that there is no separate ovn_dbs VIP set (I.e. THT patch for separate OVN VIP is missing) #}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_ae4cb840","line":45,"in_reply_to":"3fa7e38b_2baafa6c","updated":"2020-01-30 13:15:46.000000000","message":"ok, it works anyway because ceph_dashboard service doesn\u0027t exist (enabled_service doesn\u0027t contain a ceph_dashboard service), so it will work. We need to override only if the StorageDashboard composable network exists.","commit_id":"f0cfefd5220de4decee1b98dacad283be1a58cbf"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"43cc921cba12829653b8c498f9108c94e1448e7d","unresolved":false,"context_lines":[{"line_number":42,"context_line":"{% for service in enabled_services %}"},{"line_number":43,"context_line":"{%   if service_net_map.get(service ~ \u0027_network\u0027, \u0027noop\u0027) in net_vip_map %}"},{"line_number":44,"context_line":"{# we set explicit vips for these services, no need to calculate them dynamically #}"},{"line_number":45,"context_line":"{%     if service not in [\u0027ovn_dbs\u0027, \u0027redis\u0027, \u0027ganesha\u0027, \u0027keystone_admin_api_vip\u0027, \u0027keystone_public_api_vip\u0027] %}"},{"line_number":46,"context_line":"{%       set _ \u003d vip_data.__setitem__((service ~ \u0027_vip\u0027), (net_vip_map[service_net_map[service ~ \u0027_network\u0027]])) %}"},{"line_number":47,"context_line":"{%     endif %}"},{"line_number":48,"context_line":"{# we set the ovn_dbs_vip to the per-network VIP *if* we detect that there is no separate ovn_dbs VIP set (I.e. THT patch for separate OVN VIP is missing) #}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_2baafa6c","line":45,"in_reply_to":"3fa7e38b_6be1d231","updated":"2020-01-30 12:42:12.000000000","message":"this will fix ceph_grafana_vip and now it will use the storage.\nSince the [1] defines CephDashboardNetwork, for the same logic removing the \"else\" statement on L20 I think we will find the ceph_dashboard_vip on the storage network as well.\nGiulio wdyt?\n\n[1] https://review.opendev.org/#/c/702846/","commit_id":"f0cfefd5220de4decee1b98dacad283be1a58cbf"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"cf2f3cc5f3b4490b7b84ee579557d973f9e5b93f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"{%     set _ \u003d vip_data.__setitem__(\u0027ganesha_vip\u0027, (net_vip_map[networks[\u0027StorageNFS\u0027][\u0027name_lower\u0027]])) %}"},{"line_number":18,"context_line":"{%   endif %}"},{"line_number":19,"context_line":"{%   if network \u003d\u003d \u0027StorageDashboard\u0027 %}"},{"line_number":20,"context_line":"{%     set _ \u003d vip_data.__setitem__(\u0027ceph_grafana_vip\u0027, (net_vip_map.storage_dashboard)) %}"},{"line_number":21,"context_line":"{%   endif %}"},{"line_number":22,"context_line":"{% endfor %}"},{"line_number":23,"context_line":"{# public_virtual_ip and controller_virtual_ip are needed in both HAproxy \u0026 keepalived. #}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"3fa7e38b_804160aa","side":"PARENT","line":20,"range":{"start_line":20,"start_character":37,"end_line":20,"end_character":53},"updated":"2020-02-03 15:31:33.000000000","message":"Was this used by anything previously? If yes, then we\u0027d need to dupe the data so we don\u0027t break things","commit_id":"dac34d302c336192f9f5fa13d2723b991d78ec12"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8caf59b71c1f4c26f45f4173cd378c2ac1344550","unresolved":false,"context_lines":[{"line_number":17,"context_line":"{%     set _ \u003d vip_data.__setitem__(\u0027ganesha_vip\u0027, (net_vip_map[networks[\u0027StorageNFS\u0027][\u0027name_lower\u0027]])) %}"},{"line_number":18,"context_line":"{%   endif %}"},{"line_number":19,"context_line":"{%   if network \u003d\u003d \u0027StorageDashboard\u0027 %}"},{"line_number":20,"context_line":"{%     set _ \u003d vip_data.__setitem__(\u0027ceph_grafana_vip\u0027, (net_vip_map.storage_dashboard)) %}"},{"line_number":21,"context_line":"{%   endif %}"},{"line_number":22,"context_line":"{% endfor %}"},{"line_number":23,"context_line":"{# public_virtual_ip and controller_virtual_ip are needed in both HAproxy \u0026 keepalived. #}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"3fa7e38b_03ca5a18","side":"PARENT","line":20,"range":{"start_line":20,"start_character":37,"end_line":20,"end_character":53},"in_reply_to":"3fa7e38b_23dbd64e","updated":"2020-02-03 16:22:42.000000000","message":"Yea I was wondering if this hiera key was already in use","commit_id":"dac34d302c336192f9f5fa13d2723b991d78ec12"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"d371cd8331ede4289b8e49d8b1f0d11a01a820b8","unresolved":false,"context_lines":[{"line_number":17,"context_line":"{%     set _ \u003d vip_data.__setitem__(\u0027ganesha_vip\u0027, (net_vip_map[networks[\u0027StorageNFS\u0027][\u0027name_lower\u0027]])) %}"},{"line_number":18,"context_line":"{%   endif %}"},{"line_number":19,"context_line":"{%   if network \u003d\u003d \u0027StorageDashboard\u0027 %}"},{"line_number":20,"context_line":"{%     set _ \u003d vip_data.__setitem__(\u0027ceph_grafana_vip\u0027, (net_vip_map.storage_dashboard)) %}"},{"line_number":21,"context_line":"{%   endif %}"},{"line_number":22,"context_line":"{% endfor %}"},{"line_number":23,"context_line":"{# public_virtual_ip and controller_virtual_ip are needed in both HAproxy \u0026 keepalived. #}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"3fa7e38b_23dbd64e","side":"PARENT","line":20,"range":{"start_line":20,"start_character":37,"end_line":20,"end_character":53},"in_reply_to":"3fa7e38b_804160aa","updated":"2020-02-03 16:07:53.000000000","message":"Hi Alex,\nthanks for checking this.\nBasically in the old release we exposed grafana with a VIP on the ctlplane network (unless StorageDashoard was defined with the related role [1]), but now as you can see here [2] we\u0027re not exposing it anymore but we still need to have a VIP in the CephGrafanaNetwork (which is the storage one).\nFor this reason I removed the condition on L45 and moved the vip on the service we\u0027re going to expose to the end user (the CephDashboard on the 8444).\nUsing this config I\u0027m pretty sure we don\u0027t break things.\n\n[1] https://github.com/openstack/tripleo-heat-templates/blob/master/network_data_dashboard.yaml#L121\n[2] https://review.opendev.org/#/c/702839","commit_id":"dac34d302c336192f9f5fa13d2723b991d78ec12"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"f23dec352f0f8fc1d3ef1f6b61a675144adb8f9e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"{%     set _ \u003d vip_data.__setitem__(\u0027ganesha_vip\u0027, (net_vip_map[networks[\u0027StorageNFS\u0027][\u0027name_lower\u0027]])) %}"},{"line_number":18,"context_line":"{%   endif %}"},{"line_number":19,"context_line":"{%   if network \u003d\u003d \u0027StorageDashboard\u0027 %}"},{"line_number":20,"context_line":"{%     set _ \u003d vip_data.__setitem__(\u0027ceph_grafana_vip\u0027, (net_vip_map.storage_dashboard)) %}"},{"line_number":21,"context_line":"{%   endif %}"},{"line_number":22,"context_line":"{% endfor %}"},{"line_number":23,"context_line":"{# public_virtual_ip and controller_virtual_ip are needed in both HAproxy \u0026 keepalived. #}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"3fa7e38b_635eaee9","side":"PARENT","line":20,"range":{"start_line":20,"start_character":37,"end_line":20,"end_character":53},"in_reply_to":"3fa7e38b_804160aa","updated":"2020-02-03 16:04:59.000000000","message":"we\u0027re purposely moving grafana_vip out of the condition because it\u0027s not supposed to be (ever) on StorageDashboard network anymore","commit_id":"dac34d302c336192f9f5fa13d2723b991d78ec12"}]}