)]}'
{"ansible-requirements.txt":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2e9fbd8ea0557c7736574dccbea4489974e2b118","unresolved":false,"context_lines":[{"line_number":1,"context_line":"ansible\u003e\u003d2.8"},{"line_number":2,"context_line":"metalsmith\u003e\u003d0.13.0 # Apache-2.0"},{"line_number":3,"context_line":"jsonschema  # MIT"}],"source_content_type":"text/plain","patch_set":19,"id":"1fa4df85_e92e8390","line":3,"updated":"2020-03-05 10:34:02.000000000","message":"We should probably provide some minimum, esp since jsonschema has had a breaking change recently.","commit_id":"253f4cbbaaa81191fca13793c91d533506b8d117"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"22355e60f3e0e98b5273335bf2b7c84293ca8efb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"ansible\u003e\u003d2.8"},{"line_number":2,"context_line":"metalsmith\u003e\u003d0.13.0 # Apache-2.0"},{"line_number":3,"context_line":"jsonschema  # MIT"}],"source_content_type":"text/plain","patch_set":19,"id":"1fa4df85_cba132fa","line":3,"in_reply_to":"1fa4df85_e92e8390","updated":"2020-11-10 03:00:30.000000000","message":"I had assumed that we should always just replicate the entry in openstack/requirements/global-requirements.txt","commit_id":"253f4cbbaaa81191fca13793c91d533506b8d117"}],"molecule-requirements.txt":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2e9fbd8ea0557c7736574dccbea4489974e2b118","unresolved":false,"context_lines":[{"line_number":22,"context_line":"doc8\u003e\u003d0.8.0 # Apache-2.0"},{"line_number":23,"context_line":"bashate\u003e\u003d0.6.0 # Apache-2.0"},{"line_number":24,"context_line":"metalsmith\u003e\u003d0.13.0 # Apache-2.0"},{"line_number":25,"context_line":"jsonschema  # MIT"}],"source_content_type":"text/plain","patch_set":19,"id":"1fa4df85_a9596b35","line":25,"updated":"2020-03-05 10:34:02.000000000","message":"ditto","commit_id":"253f4cbbaaa81191fca13793c91d533506b8d117"}],"tripleo_ansible/ansible_plugins/modules/tripleo_baremetal_expand_roles.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2e9fbd8ea0557c7736574dccbea4489974e2b118","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    - present"},{"line_number":56,"context_line":"    - absent"},{"line_number":57,"context_line":"    - all"},{"line_number":58,"context_line":"  baremetal_deployment:"},{"line_number":59,"context_line":"    description:"},{"line_number":60,"context_line":"      - Data describing roles and baremetal node instances to provision for"},{"line_number":61,"context_line":"        those roles"}],"source_content_type":"text/x-python","patch_set":19,"id":"1fa4df85_a90bab21","line":58,"range":{"start_line":58,"start_character":2,"end_line":58,"end_character":12},"updated":"2020-03-05 10:34:02.000000000","message":"Any reason to keep the baremetal_ prefix?","commit_id":"253f4cbbaaa81191fca13793c91d533506b8d117"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"22355e60f3e0e98b5273335bf2b7c84293ca8efb","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    - present"},{"line_number":56,"context_line":"    - absent"},{"line_number":57,"context_line":"    - all"},{"line_number":58,"context_line":"  baremetal_deployment:"},{"line_number":59,"context_line":"    description:"},{"line_number":60,"context_line":"      - Data describing roles and baremetal node instances to provision for"},{"line_number":61,"context_line":"        those roles"}],"source_content_type":"text/x-python","patch_set":19,"id":"1fa4df85_6b7b5e7a","line":58,"range":{"start_line":58,"start_character":2,"end_line":58,"end_character":12},"in_reply_to":"1fa4df85_a90bab21","updated":"2020-11-10 03:00:30.000000000","message":"I think \"deployment\" by itself might be a bit too ambiguous in the context of tripleo, where \"overcloud deploy\" means something different.","commit_id":"253f4cbbaaa81191fca13793c91d533506b8d117"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2e9fbd8ea0557c7736574dccbea4489974e2b118","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        type: str"},{"line_number":79,"context_line":"      count:"},{"line_number":80,"context_line":"        description:"},{"line_number":81,"context_line":"          -"},{"line_number":82,"context_line":"        type: int"},{"line_number":83,"context_line":"        default: 1"},{"line_number":84,"context_line":"      defaults:"}],"source_content_type":"text/x-python","patch_set":19,"id":"1fa4df85_49147744","line":81,"updated":"2020-03-05 10:34:02.000000000","message":"Missing description","commit_id":"253f4cbbaaa81191fca13793c91d533506b8d117"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"22355e60f3e0e98b5273335bf2b7c84293ca8efb","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        type: str"},{"line_number":79,"context_line":"      count:"},{"line_number":80,"context_line":"        description:"},{"line_number":81,"context_line":"          -"},{"line_number":82,"context_line":"        type: int"},{"line_number":83,"context_line":"        default: 1"},{"line_number":84,"context_line":"      defaults:"}],"source_content_type":"text/x-python","patch_set":19,"id":"1fa4df85_2b99e6c2","line":81,"in_reply_to":"1fa4df85_49147744","updated":"2020-11-10 03:00:30.000000000","message":"Done","commit_id":"253f4cbbaaa81191fca13793c91d533506b8d117"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"8549a1caae232527e1f40af06062212168f50b05","unresolved":false,"context_lines":[{"line_number":231,"context_line":"                expand_provisioned\u003dFalse,"},{"line_number":232,"context_line":"                default_image\u003dmodule.params[\u0027default_image\u0027],"},{"line_number":233,"context_line":"            )"},{"line_number":234,"context_line":"            env \u003d {}"},{"line_number":235,"context_line":"        if state \u003d\u003d \u0027present\u0027:"},{"line_number":236,"context_line":"            instances \u003d present"},{"line_number":237,"context_line":"        elif state \u003d\u003d \u0027absent\u0027:"}],"source_content_type":"text/x-python","patch_set":21,"id":"1f621f24_8d787ec4","line":234,"range":{"start_line":234,"start_character":12,"end_line":234,"end_character":20},"updated":"2020-11-10 01:56:41.000000000","message":"Should the \u0027absent\u0027, \u0027all\u0027 clause be moved up?\n\nIf state \u003d\u003d \u0027all\u0027 the first bd.expand() call set env, then the after the second we reset env to {} ? Is that correct?","commit_id":"603660efe81a0a2c2c8aa7cfe81e6efe8c5bc874"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"22355e60f3e0e98b5273335bf2b7c84293ca8efb","unresolved":false,"context_lines":[{"line_number":231,"context_line":"                expand_provisioned\u003dFalse,"},{"line_number":232,"context_line":"                default_image\u003dmodule.params[\u0027default_image\u0027],"},{"line_number":233,"context_line":"            )"},{"line_number":234,"context_line":"            env \u003d {}"},{"line_number":235,"context_line":"        if state \u003d\u003d \u0027present\u0027:"},{"line_number":236,"context_line":"            instances \u003d present"},{"line_number":237,"context_line":"        elif state \u003d\u003d \u0027absent\u0027:"}],"source_content_type":"text/x-python","patch_set":21,"id":"1f621f24_68e51009","line":234,"range":{"start_line":234,"start_character":12,"end_line":234,"end_character":20},"in_reply_to":"1f621f24_8d787ec4","updated":"2020-11-10 03:00:30.000000000","message":"Only the provision playbook consumes the environment, and it only ever sets state\u003dpresent.\n\nstate\u003dall is for the unprovision --all case where you want to delete every node in the overcloud without having to change the yaml.\n\nIf there is ever a situation where a populated environment is useful for state\u003dall or state\u003dabsent then we could change this here, but I don\u0027t think that is the case currently.","commit_id":"603660efe81a0a2c2c8aa7cfe81e6efe8c5bc874"}]}