)]}'
{"tripleo_ansible/ansible_plugins/modules/metalsmith_instances.py":[{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"815ff798d2434eafa2b5f5918bc7a4a3bb856581","unresolved":false,"context_lines":[{"line_number":42,"context_line":"---"},{"line_number":43,"context_line":"module: metalsmith_instances"},{"line_number":44,"context_line":"short_description: Manage baremetal instances with metalsmith"},{"line_number":45,"context_line":"version_added: \"2.0\""},{"line_number":46,"context_line":"author: \"Steve Baker (@stevebaker)\""},{"line_number":47,"context_line":"description:"},{"line_number":48,"context_line":"  - Provision and unprovision ironic baremetal instances using metalsmith,"}],"source_content_type":"text/x-python","patch_set":16,"id":"1fa4df85_8529149c","line":45,"updated":"2020-03-03 19:32:39.000000000","message":"nit: I would adjust this to be the version of Ansible you are testing against / what is used in master.","commit_id":"08de75902baf14b82dafbef7eac6956156a1c284"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"51a56ed08ee15cb1907b1b6a91c898e9485f7ce3","unresolved":false,"context_lines":[{"line_number":42,"context_line":"---"},{"line_number":43,"context_line":"module: metalsmith_instances"},{"line_number":44,"context_line":"short_description: Manage baremetal instances with metalsmith"},{"line_number":45,"context_line":"version_added: \"2.0\""},{"line_number":46,"context_line":"author: \"Steve Baker (@stevebaker)\""},{"line_number":47,"context_line":"description:"},{"line_number":48,"context_line":"  - Provision and unprovision ironic baremetal instances using metalsmith,"}],"source_content_type":"text/x-python","patch_set":16,"id":"1fa4df85_7f17bd46","line":45,"in_reply_to":"1fa4df85_8529149c","updated":"2020-03-04 01:37:00.000000000","message":"Done","commit_id":"08de75902baf14b82dafbef7eac6956156a1c284"},{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"815ff798d2434eafa2b5f5918bc7a4a3bb856581","unresolved":false,"context_lines":[{"line_number":241,"context_line":"    nodes \u003d []"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    # no limit on concurrency, create a worker for every instance"},{"line_number":244,"context_line":"    if concurrency \u003c 1:"},{"line_number":245,"context_line":"        concurrency \u003d len(instances)"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    # if concurrency is less than instances, need to wait for"}],"source_content_type":"text/x-python","patch_set":16,"id":"1fa4df85_8817e945","line":244,"updated":"2020-03-03 19:32:39.000000000","message":"I wonder if there would be a performance/stability impact on this if the instance count is too high. Since this is configurable, it\u0027s not a blocking concern.","commit_id":"08de75902baf14b82dafbef7eac6956156a1c284"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"51a56ed08ee15cb1907b1b6a91c898e9485f7ce3","unresolved":false,"context_lines":[{"line_number":241,"context_line":"    nodes \u003d []"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    # no limit on concurrency, create a worker for every instance"},{"line_number":244,"context_line":"    if concurrency \u003c 1:"},{"line_number":245,"context_line":"        concurrency \u003d len(instances)"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    # if concurrency is less than instances, need to wait for"}],"source_content_type":"text/x-python","patch_set":16,"id":"1fa4df85_88dfe9d4","line":244,"in_reply_to":"1fa4df85_8817e945","updated":"2020-03-04 01:37:00.000000000","message":"The default concurrency is 20, and there will be scaling considerations at every level if they choose to disable it. I think making this possible is only useful for scale testing of an environment, but that is still a valid use case.","commit_id":"08de75902baf14b82dafbef7eac6956156a1c284"}]}