)]}'
{"tripleo_ansible/playbooks/cli-overcloud-node-provision.yaml":[{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"b8bb4368a2bb19bf338ce358b1d03a2226dcb096","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        msg: \u003e"},{"line_number":31,"context_line":"          `stack_name`, `baremetal_deployment` and"},{"line_number":32,"context_line":"          `baremetal_deployed_path` are required inputs but"},{"line_number":33,"context_line":"          currently undefined. Check you inputs and try again."},{"line_number":34,"context_line":"      when:"},{"line_number":35,"context_line":"        - stack_name is undefined"},{"line_number":36,"context_line":"        - baremetal_deployment is undefined"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1fa4df85_908d0333","line":33,"updated":"2020-02-28 17:43:51.000000000","message":"nit: ditto","commit_id":"64f7ea8b8f97b65d9ecc32770d3f60f0b61e8b80"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"0bf4f107bca052b8b0082bba0c1638d776b192cd","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    - name: Write environment to {{ baremetal_deployed_path }}"},{"line_number":80,"context_line":"      copy:"},{"line_number":81,"context_line":"        dest: \"{{ baremetal_deployed_path }}\""},{"line_number":82,"context_line":"        content: \"{{ baremetal_environment.environment | to_nice_yaml(indent\u003d2) }}\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"1fa4df85_80d80b7b","line":82,"updated":"2020-03-04 21:17:18.000000000","message":"ansible-lint is erroring on undefined baremetal_environment.environment even though it will always be defined during playbook execution. I guess a default filter will be needed just to get the linter to pass","commit_id":"c38b19ba1402920c7a44aaaa08a1f64d517f57d0"}],"tripleo_ansible/playbooks/cli-overcloud-node-unprovision.yaml":[{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"b8bb4368a2bb19bf338ce358b1d03a2226dcb096","unresolved":false,"context_lines":[{"line_number":28,"context_line":"      fail:"},{"line_number":29,"context_line":"        msg: \u003e"},{"line_number":30,"context_line":"          `stack_name` and `baremetal_deployment` are required inputs but"},{"line_number":31,"context_line":"          currently undefined. Check you inputs and try again."},{"line_number":32,"context_line":"      when:"},{"line_number":33,"context_line":"        - stack_name is undefined"},{"line_number":34,"context_line":"        - baremetal_deployment is undefined"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1fa4df85_b09eff60","line":31,"updated":"2020-02-28 17:43:51.000000000","message":"nit: \"you\" should be \"your\". Actually, for technical docs, you normally want to avoid addressing the reader. The sentence might want to be something like \"Check the inputs and try again.\"","commit_id":"64f7ea8b8f97b65d9ecc32770d3f60f0b61e8b80"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"e5cee4d7cfc44eb0b4f1e8e45fe3f4c346470c07","unresolved":false,"context_lines":[{"line_number":28,"context_line":"      fail:"},{"line_number":29,"context_line":"        msg: \u003e"},{"line_number":30,"context_line":"          `stack_name` and `baremetal_deployment` are required inputs but"},{"line_number":31,"context_line":"          currently undefined. Check you inputs and try again."},{"line_number":32,"context_line":"      when:"},{"line_number":33,"context_line":"        - stack_name is undefined"},{"line_number":34,"context_line":"        - baremetal_deployment is undefined"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1fa4df85_b19357a3","line":31,"in_reply_to":"1fa4df85_b09eff60","updated":"2020-03-01 20:12:47.000000000","message":"I copied this from another playbook, and actually don\u0027t like the wording at all. I\u0027ll come up with something else.\n\nRelated, the default playbook run doesn\u0027t actually run these pre_tasks, how do I trigger them?","commit_id":"64f7ea8b8f97b65d9ecc32770d3f60f0b61e8b80"},{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"e23631c5a1e99e6ff32e0083d4547feb9d1d2664","unresolved":false,"context_lines":[{"line_number":28,"context_line":"      fail:"},{"line_number":29,"context_line":"        msg: \u003e"},{"line_number":30,"context_line":"          `stack_name` and `baremetal_deployment` are required inputs but"},{"line_number":31,"context_line":"          currently undefined. Check you inputs and try again."},{"line_number":32,"context_line":"      when:"},{"line_number":33,"context_line":"        - stack_name is undefined"},{"line_number":34,"context_line":"        - baremetal_deployment is undefined"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1fa4df85_284fd56b","line":31,"in_reply_to":"1fa4df85_b19357a3","updated":"2020-03-03 19:35:36.000000000","message":"The playbook should always run `pre_tasks` and before `tasks`. This leads me to believe that the `when` conditions are being evaluated as `False`.","commit_id":"64f7ea8b8f97b65d9ecc32770d3f60f0b61e8b80"}]}
