)]}'
{"tripleo_ansible/roles/tripleo_bootstrap/tasks/main.yml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"559075e79e6a6290e009c84424c7a99d6c339827","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  register: result"},{"line_number":66,"context_line":"  failed_when:"},{"line_number":67,"context_line":"    - result.rc !\u003d 0"},{"line_number":68,"context_line":"    - \"\u0027cannot overwrite directory\u0027 not in result.stderr\""},{"line_number":69,"context_line":"  tags:"},{"line_number":70,"context_line":"    - skip_ansible_lint"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_aa757901","line":68,"updated":"2020-02-18 09:32:13.000000000","message":"shouldn\u0027t we recreate it from scratch instead?","commit_id":"ed86161d72f78df3d2214ae68ef598d620ab1db3"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"fcd822f7a499722542727d8e228be4a1fa9acb58","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  register: result"},{"line_number":66,"context_line":"  failed_when:"},{"line_number":67,"context_line":"    - result.rc !\u003d 0"},{"line_number":68,"context_line":"    - \"\u0027cannot overwrite directory\u0027 not in result.stderr\""},{"line_number":69,"context_line":"  tags:"},{"line_number":70,"context_line":"    - skip_ansible_lint"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_22f0c5db","line":68,"in_reply_to":"3fa7e38b_aa757901","updated":"2020-02-18 17:34:10.000000000","message":"We get into this situation when using upload-puppet-modules to patch puppet on overcloud nodes. It overwrites the symlinks in /etc/puppet/modules with a full copy of the (patched) puppet code. This all works fine the first time, but subsequent stack updates fail when this task wants to generate a fresh set of symlinks.\n\nI\u0027m sure we could add tasks to properly handle directories, but bear in mind the whole purpose of this task doing a global symlink is to improve performance (see [1]). Adding tasks to accommodate side effects of using upload-puppet-modules (mainly a dev tool) would be counterproductive.\n\n[1] https://review.opendev.org/683277","commit_id":"ed86161d72f78df3d2214ae68ef598d620ab1db3"}]}