)]}'
{"tripleo_ansible/roles/tripleo_ceph_common/defaults/main.yml":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"6935c6141e3162e7f0734f7f14b1e8a08a3d738b","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  fsid: b8df929e-7c29-11e9-b1bd-244253215215"},{"line_number":48,"context_line":"  generate_fsid: false"},{"line_number":49,"context_line":"  ip_version: ipv4"},{"line_number":50,"context_line":"  keys:"},{"line_number":51,"context_line":"    - caps:"},{"line_number":52,"context_line":"        mgr: allow *"},{"line_number":53,"context_line":"        mon: profile rbd"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"1fa4df85_c75c1080","line":50,"updated":"2020-03-02 12:26:53.000000000","message":"remove?","commit_id":"2b9464fc6d33ecd8faed065341ab42e541a7c2ac"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"44a751277a154511d0637e9e3d860268b0ee47f1","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  fsid: b8df929e-7c29-11e9-b1bd-244253215215"},{"line_number":48,"context_line":"  generate_fsid: false"},{"line_number":49,"context_line":"  ip_version: ipv4"},{"line_number":50,"context_line":"  keys:"},{"line_number":51,"context_line":"    - caps:"},{"line_number":52,"context_line":"        mgr: allow *"},{"line_number":53,"context_line":"        mon: profile rbd"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"1fa4df85_42a79ca8","line":50,"in_reply_to":"1fa4df85_c75c1080","updated":"2020-03-03 09:42:58.000000000","message":"Thanks Giulio. Right, this default is not needed anymore since the keys structure is moved in `ceph_keys` dict","commit_id":"2b9464fc6d33ecd8faed065341ab42e541a7c2ac"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"6935c6141e3162e7f0734f7f14b1e8a08a3d738b","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  monitor_address_block: 192.168.24.0/24"},{"line_number":76,"context_line":"  ntp_service_enabled: false"},{"line_number":77,"context_line":"  openstack_config: true"},{"line_number":78,"context_line":"  openstack_keys:"},{"line_number":79,"context_line":"    - caps:"},{"line_number":80,"context_line":"        mgr: allow *"},{"line_number":81,"context_line":"        mon: profile rbd"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"1fa4df85_07630844","line":78,"updated":"2020-03-02 12:26:53.000000000","message":"sounds like we need to remove this?","commit_id":"2b9464fc6d33ecd8faed065341ab42e541a7c2ac"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"44a751277a154511d0637e9e3d860268b0ee47f1","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  monitor_address_block: 192.168.24.0/24"},{"line_number":76,"context_line":"  ntp_service_enabled: false"},{"line_number":77,"context_line":"  openstack_config: true"},{"line_number":78,"context_line":"  openstack_keys:"},{"line_number":79,"context_line":"    - caps:"},{"line_number":80,"context_line":"        mgr: allow *"},{"line_number":81,"context_line":"        mon: profile rbd"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"1fa4df85_02bf64b0","line":78,"in_reply_to":"1fa4df85_07630844","updated":"2020-03-03 09:42:58.000000000","message":"yeah, same as the keys structure above","commit_id":"2b9464fc6d33ecd8faed065341ab42e541a7c2ac"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"6935c6141e3162e7f0734f7f14b1e8a08a3d738b","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    enabled: true"},{"line_number":134,"context_line":"    extra_pools: []"},{"line_number":135,"context_line":"  backup_pool: \u0027backups\u0027"},{"line_number":136,"context_line":"  extra_pools: []"},{"line_number":137,"context_line":"  pg_num: 128"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"manila_pools:"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"1fa4df85_8a3cddc8","line":136,"updated":"2020-03-02 12:26:53.000000000","message":"probably worth trying override on the default pools pg_num to make sure it works","commit_id":"2b9464fc6d33ecd8faed065341ab42e541a7c2ac"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"44a751277a154511d0637e9e3d860268b0ee47f1","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    enabled: true"},{"line_number":134,"context_line":"    extra_pools: []"},{"line_number":135,"context_line":"  backup_pool: \u0027backups\u0027"},{"line_number":136,"context_line":"  extra_pools: []"},{"line_number":137,"context_line":"  pg_num: 128"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"manila_pools:"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"1fa4df85_a2af707b","line":136,"in_reply_to":"1fa4df85_8a3cddc8","updated":"2020-03-03 09:42:58.000000000","message":"++ agree","commit_id":"2b9464fc6d33ecd8faed065341ab42e541a7c2ac"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"6935c6141e3162e7f0734f7f14b1e8a08a3d738b","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    extra_pools: []"},{"line_number":135,"context_line":"  backup_pool: \u0027backups\u0027"},{"line_number":136,"context_line":"  extra_pools: []"},{"line_number":137,"context_line":"  pg_num: 128"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"manila_pools:"},{"line_number":140,"context_line":"  data: \u0027manila_data\u0027"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"1fa4df85_c783b0cb","line":137,"updated":"2020-03-02 12:26:53.000000000","message":"32 like it used to be?","commit_id":"2b9464fc6d33ecd8faed065341ab42e541a7c2ac"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"44a751277a154511d0637e9e3d860268b0ee47f1","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    extra_pools: []"},{"line_number":135,"context_line":"  backup_pool: \u0027backups\u0027"},{"line_number":136,"context_line":"  extra_pools: []"},{"line_number":137,"context_line":"  pg_num: 128"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"manila_pools:"},{"line_number":140,"context_line":"  data: \u0027manila_data\u0027"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"1fa4df85_c2b4ecd3","line":137,"in_reply_to":"1fa4df85_c783b0cb","updated":"2020-03-03 09:42:58.000000000","message":"s/128/32\n\nThanks, that\u0027s the old value :/","commit_id":"2b9464fc6d33ecd8faed065341ab42e541a7c2ac"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"310f8972345bb0b40701526de430df9eaf213d61","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"ceph_pools:"},{"line_number":72,"context_line":"  gnocchi_pool:"},{"line_number":73,"context_line":"    name: \u0027metrics\u0027"},{"line_number":74,"context_line":"  nova_pool:"},{"line_number":75,"context_line":"    name: \u0027vms\u0027"},{"line_number":76,"context_line":"    enabled: true"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"1fa4df85_4c3d65c2","line":73,"updated":"2020-03-05 11:21:47.000000000","message":"following up on my comment in https://review.opendev.org/#/c/709297/16/deployment/ceph-ansible/ceph-base.yaml ; this would also receive \"enabled:\"","commit_id":"0267c2afe97098604f5741e7a4bf447ef26e1d43"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"2ef60263103767da2701cc5f4d8832b08541f18f","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"ceph_pools:"},{"line_number":72,"context_line":"  gnocchi_pool:"},{"line_number":73,"context_line":"    name: \u0027metrics\u0027"},{"line_number":74,"context_line":"  nova_pool:"},{"line_number":75,"context_line":"    name: \u0027vms\u0027"},{"line_number":76,"context_line":"    enabled: true"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"1fa4df85_2cb3494f","line":73,"in_reply_to":"1fa4df85_4c3d65c2","updated":"2020-03-05 11:26:58.000000000","message":"++, updating here as well","commit_id":"0267c2afe97098604f5741e7a4bf447ef26e1d43"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"310f8972345bb0b40701526de430df9eaf213d61","unresolved":false,"context_lines":[{"line_number":89,"context_line":"      name: altrbd"},{"line_number":90,"context_line":"      pg_num: 1"},{"line_number":91,"context_line":"      rule_name: replicated_rule"},{"line_number":92,"context_line":"  pg_num: 32"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"manila_pools:"},{"line_number":95,"context_line":"  data: \u0027manila_data\u0027"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"1fa4df85_a9bacb6a","line":92,"updated":"2020-03-05 11:21:47.000000000","message":"isn\u0027t this wrongly indented?","commit_id":"0267c2afe97098604f5741e7a4bf447ef26e1d43"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"2ef60263103767da2701cc5f4d8832b08541f18f","unresolved":false,"context_lines":[{"line_number":89,"context_line":"      name: altrbd"},{"line_number":90,"context_line":"      pg_num: 1"},{"line_number":91,"context_line":"      rule_name: replicated_rule"},{"line_number":92,"context_line":"  pg_num: 32"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"manila_pools:"},{"line_number":95,"context_line":"  data: \u0027manila_data\u0027"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"1fa4df85_2c8ca97d","line":92,"in_reply_to":"1fa4df85_a9bacb6a","updated":"2020-03-05 11:26:58.000000000","message":"I don\u0027t think so, it\u0027s under ceph_pools, which is set here: https://review.opendev.org/#/c/709297/16/deployment/ceph-ansible/ceph-base.yaml@586, so I can access the variable using \"ceph_pools.pg_num\"","commit_id":"0267c2afe97098604f5741e7a4bf447ef26e1d43"}],"tripleo_ansible/roles/tripleo_ceph_work_dir/tasks/build_keys.yml":[{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"3a82edcc45182595fa827d7439e8e3ff31f539f2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: gather hiera metadata"},{"line_number":3,"context_line":"  shell: hiera -c /etc/puppet/hiera.yaml enabled_services"},{"line_number":4,"context_line":"  register: enabled_services"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: reset profiles string to avoid complex string manipulation"},{"line_number":7,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"1fa4df85_40e27403","line":4,"range":{"start_line":2,"start_character":0,"end_line":4,"end_character":28},"updated":"2020-02-27 11:34:05.000000000","message":"same of the comment left on build_pools.yml","commit_id":"bb27b9a23efe5af1315f2cace5c36702919c79f4"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"3a82edcc45182595fa827d7439e8e3ff31f539f2","unresolved":false,"context_lines":[{"line_number":16,"context_line":"      current: \"{{ item.name }}\""},{"line_number":17,"context_line":"     with_items: \"{{ openstack_pools.openstack_pools }}\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"   - name: set openstack client caps"},{"line_number":20,"context_line":"     set_fact:"},{"line_number":21,"context_line":"      osp_client_caps: { \u0027mgr\u0027: \u0027allow *\u0027, \u0027mon\u0027: \u0027profile rbd\u0027, \u0027osd\u0027: \"{{ profiles | regex_replace(\u0027\\\\, $\u0027, \u0027\u0027) }}\" }"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"   - name: set openstack client key"},{"line_number":24,"context_line":"     set_fact:"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"1fa4df85_c0bf44ce","line":21,"range":{"start_line":19,"start_character":2,"end_line":21,"end_character":119},"updated":"2020-02-27 11:34:05.000000000","message":"I could avoid this task but it makes the code more readable","commit_id":"bb27b9a23efe5af1315f2cace5c36702919c79f4"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"849753047fa4673d5c6ba16b1e84e63b3fd0e0ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"1fa4df85_2be4b4e0","updated":"2020-03-03 17:07:36.000000000","message":"this document needs to be reflowed, the spacing is using 1 sometimes two.","commit_id":"33af577ad801df1c8c36db943de443bdb1c2bddc"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"eac2746f448e1f2250a8012ad80f4e434bf00bec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"1fa4df85_ab8744b5","in_reply_to":"1fa4df85_2be4b4e0","updated":"2020-03-03 17:18:05.000000000","message":"Thanks for the review, I\u0027ll fix the spacing in the next PR","commit_id":"33af577ad801df1c8c36db943de443bdb1c2bddc"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"5dbc63f939a3ad32232ee1cb214e13c0c985747c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: reset profiles string to avoid complex string manipulation"},{"line_number":3,"context_line":"  set_fact:"},{"line_number":4,"context_line":"   profiles: \"\""}],"source_content_type":"text/x-yaml","patch_set":31,"id":"1fa4df85_abf8a47a","line":1,"updated":"2020-03-03 17:12:29.000000000","message":"missing boilerplate license header.","commit_id":"33af577ad801df1c8c36db943de443bdb1c2bddc"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"849753047fa4673d5c6ba16b1e84e63b3fd0e0ce","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: build openstack client key"},{"line_number":7,"context_line":"  block:"},{"line_number":8,"context_line":"   - name: build openstack client profiles per pool"},{"line_number":9,"context_line":"     set_fact:"},{"line_number":10,"context_line":"      profiles: \"{{ \u0027profile rbd pool\u003d\u0027.join((profiles|default(\u0027\u0027), (current+\u0027, \u0027))) }}\""},{"line_number":11,"context_line":"     vars:"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"1fa4df85_abcae44a","line":8,"range":{"start_line":8,"start_character":2,"end_line":8,"end_character":3},"updated":"2020-03-03 17:07:36.000000000","message":"two spaces","commit_id":"33af577ad801df1c8c36db943de443bdb1c2bddc"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"849753047fa4673d5c6ba16b1e84e63b3fd0e0ce","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  block:"},{"line_number":8,"context_line":"   - name: build openstack client profiles per pool"},{"line_number":9,"context_line":"     set_fact:"},{"line_number":10,"context_line":"      profiles: \"{{ \u0027profile rbd pool\u003d\u0027.join((profiles|default(\u0027\u0027), (current+\u0027, \u0027))) }}\""},{"line_number":11,"context_line":"     vars:"},{"line_number":12,"context_line":"      current: \"{{ item.name }}\""},{"line_number":13,"context_line":"     with_items: \"{{ openstack_pools.openstack_pools }}\""}],"source_content_type":"text/x-yaml","patch_set":31,"id":"1fa4df85_8bcda867","line":10,"range":{"start_line":10,"start_character":5,"end_line":10,"end_character":6},"updated":"2020-03-03 17:07:36.000000000","message":"two spaces","commit_id":"33af577ad801df1c8c36db943de443bdb1c2bddc"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"849753047fa4673d5c6ba16b1e84e63b3fd0e0ce","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"   - name: set openstack client caps"},{"line_number":16,"context_line":"     set_fact:"},{"line_number":17,"context_line":"      osp_client_caps: {\u0027mgr\u0027: \u0027allow *\u0027, \u0027mon\u0027: \u0027profile rbd\u0027, \u0027osd\u0027: \"{{ profiles | regex_replace(\u0027\\\\, $\u0027, \u0027\u0027) }}\"}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"   - name: set openstack client key"},{"line_number":20,"context_line":"     set_fact:"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"1fa4df85_4bc33039","line":17,"range":{"start_line":17,"start_character":5,"end_line":17,"end_character":6},"updated":"2020-03-03 17:07:36.000000000","message":"two spaces.","commit_id":"33af577ad801df1c8c36db943de443bdb1c2bddc"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"849753047fa4673d5c6ba16b1e84e63b3fd0e0ce","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"   - name: set openstack client key"},{"line_number":20,"context_line":"     set_fact:"},{"line_number":21,"context_line":"      client_key: [{\u0027name\u0027: \u0027{{ \".\".join((\"client\", ceph_keys.openstack_client.name)) }}\u0027,"},{"line_number":22,"context_line":"                    \u0027key\u0027: \u0027{{ ceph_keys.openstack_client.key }}\u0027, \u0027mode\u0027:\u00270600\u0027, \u0027caps\u0027: \u0027{{ osp_client_caps }}\u0027}]"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: build manila key for openstack"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"1fa4df85_ebb45cd3","line":21,"range":{"start_line":21,"start_character":5,"end_line":21,"end_character":6},"updated":"2020-03-03 17:07:36.000000000","message":"two spaces.","commit_id":"33af577ad801df1c8c36db943de443bdb1c2bddc"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"849753047fa4673d5c6ba16b1e84e63b3fd0e0ce","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  block:"},{"line_number":26,"context_line":"   - name: compute manila caps"},{"line_number":27,"context_line":"     set_fact:"},{"line_number":28,"context_line":"      manila_caps: {\"mgr\": \"allow *\", \"mon\": \"allow r, allow command \u0027auth del\u0027, allow command \u0027auth caps\u0027,"},{"line_number":29,"context_line":"                   allow command \u0027auth get\u0027, allow command \u0027auth get-or-create\u0027\", \"mds\": \"allow *\", \"osd\": \"allow rw\"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"   - name: create manila key"},{"line_number":32,"context_line":"     set_fact:"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"1fa4df85_ebe9bcb6","line":29,"range":{"start_line":28,"start_character":6,"end_line":29,"end_character":118},"updated":"2020-03-03 17:07:36.000000000","message":"this all looks static, maybe this would be better as a var or default.","commit_id":"33af577ad801df1c8c36db943de443bdb1c2bddc"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"eac2746f448e1f2250a8012ad80f4e434bf00bec","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  block:"},{"line_number":26,"context_line":"   - name: compute manila caps"},{"line_number":27,"context_line":"     set_fact:"},{"line_number":28,"context_line":"      manila_caps: {\"mgr\": \"allow *\", \"mon\": \"allow r, allow command \u0027auth del\u0027, allow command \u0027auth caps\u0027,"},{"line_number":29,"context_line":"                   allow command \u0027auth get\u0027, allow command \u0027auth get-or-create\u0027\", \"mds\": \"allow *\", \"osd\": \"allow rw\"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"   - name: create manila key"},{"line_number":32,"context_line":"     set_fact:"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"1fa4df85_cbb5e07f","line":29,"range":{"start_line":28,"start_character":6,"end_line":29,"end_character":118},"in_reply_to":"1fa4df85_ebe9bcb6","updated":"2020-03-03 17:18:05.000000000","message":"yeah, I put it here to improve readability, I think this should go in tripleo_ceph_common/defaults/main.yml, which contains all our static defaults.","commit_id":"33af577ad801df1c8c36db943de443bdb1c2bddc"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"849753047fa4673d5c6ba16b1e84e63b3fd0e0ce","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  block:"},{"line_number":39,"context_line":"   - name: compute radosgw caps"},{"line_number":40,"context_line":"     set_fact:"},{"line_number":41,"context_line":"      rgw_caps: {\"mgr\": \"allow *\", \"mon\": \"allow rw\", \"osd\": \"allow rwx\"}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"   - name: create rgw key"},{"line_number":44,"context_line":"     set_fact:"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"1fa4df85_8bd288ff","line":41,"range":{"start_line":41,"start_character":16,"end_line":41,"end_character":73},"updated":"2020-03-03 17:07:36.000000000","message":"same as above.","commit_id":"33af577ad801df1c8c36db943de443bdb1c2bddc"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"eac2746f448e1f2250a8012ad80f4e434bf00bec","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  block:"},{"line_number":39,"context_line":"   - name: compute radosgw caps"},{"line_number":40,"context_line":"     set_fact:"},{"line_number":41,"context_line":"      rgw_caps: {\"mgr\": \"allow *\", \"mon\": \"allow rw\", \"osd\": \"allow rwx\"}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"   - name: create rgw key"},{"line_number":44,"context_line":"     set_fact:"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"1fa4df85_2bc594f1","line":41,"range":{"start_line":41,"start_character":16,"end_line":41,"end_character":73},"in_reply_to":"1fa4df85_8bd288ff","updated":"2020-03-03 17:18:05.000000000","message":"++","commit_id":"33af577ad801df1c8c36db943de443bdb1c2bddc"}],"tripleo_ansible/roles/tripleo_ceph_work_dir/tasks/build_pools.yml":[{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"5512efec46bdece8c206544bf7d933b973ae7daa","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"   - name: add gnocchi pool"},{"line_number":23,"context_line":"     set_fact:"},{"line_number":24,"context_line":"       metrics: [{\u0027name\u0027: \u0027metrics\u0027, \u0027pg_num\u0027: \u0027{{ pg_num }}\u0027, \u0027rule_name\u0027: \u0027replicated_rule\u0027, \u0027application\u0027: \u0027openstack_gnocchi\u0027 }]"},{"line_number":25,"context_line":"     when:"},{"line_number":26,"context_line":"       - tripleo_pool_metrics|bool|default(false)"},{"line_number":27,"context_line":"       - \"\u0027gnocchi_api\u0027 in {{ enabled_services.stdout }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_f2cfa6b3","line":24,"range":{"start_line":24,"start_character":27,"end_line":24,"end_character":34},"updated":"2020-02-21 10:05:05.000000000","message":"next PS: the pool names should be parameters generated by tht","commit_id":"f10cf5de736da2eb4934992e83fc8ad7e7a5786e"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"e67266ee5cf8792591c7b20c92f834950528305c","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"   - name: build resulting pool list"},{"line_number":38,"context_line":"     set_fact:"},{"line_number":39,"context_line":"      openstack_pools: \"{\u0027openstack_pools\u0027: {{ vms|default([]) + volumes|default([]) + images|default([]) + metrics|default([]) + backup|default([]) }} }\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1fa4df85_4c4c3376","line":39,"updated":"2020-02-23 16:20:04.000000000","message":"Please merge CinderRbdExtraPools into this list. It is a list of extra pools the user can specify so that cinder will have extra pools (usually used for storage tiers).","commit_id":"0862833ce42c8e3e8cb54737ab17723907e13e5e"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"fc28904cdb3fed6b77692704c12dbdca3a52936f","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"   - name: build resulting pool list"},{"line_number":38,"context_line":"     set_fact:"},{"line_number":39,"context_line":"      openstack_pools: \"{\u0027openstack_pools\u0027: {{ vms|default([]) + volumes|default([]) + images|default([]) + metrics|default([]) + backup|default([]) }} }\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1fa4df85_8c90eb97","line":39,"in_reply_to":"1fa4df85_4c4c3376","updated":"2020-02-23 16:35:03.000000000","message":"+1, in the current PS I passed here the extra_pools var, in the next one (since I\u0027m sure this flow is working), I\u0027ll review the missing pools.\nThanks for the review!","commit_id":"0862833ce42c8e3e8cb54737ab17723907e13e5e"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"55af64694f2f379a7cdc0c8ead8bded4e4e0b617","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"   - name: add cinder extra pools"},{"line_number":39,"context_line":"     set_fact:"},{"line_number":40,"context_line":"      cinder_extra: \"{{ cinder_extra|default([])|unique + [ pool ] }}\""},{"line_number":41,"context_line":"     vars:"},{"line_number":42,"context_line":"      pool: \"{\u0027name\u0027: \u0027{{ item }}\u0027, \u0027pg_num\u0027: \u0027{{ pg_num }}\u0027, \u0027rule_name\u0027: \u0027replicated_rule\u0027, \u0027application\u0027: \u0027rbd\u0027 }\""},{"line_number":43,"context_line":"     with_items: \"{{ ceph_pools.cinder_extra_pools_name }}\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1fa4df85_b8e2bd2e","line":40,"range":{"start_line":40,"start_character":49,"end_line":40,"end_character":55},"updated":"2020-02-24 07:57:59.000000000","message":"We need to apply this filter to the whole resulting array","commit_id":"de65832a9a206f95ac4bed47165e36a95b371a57"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"24a1ee6a768dee5b21cf3cac505b87c63bb7c4b6","unresolved":false,"context_lines":[{"line_number":33,"context_line":"     set_fact:"},{"line_number":34,"context_line":"      backup: [{\u0027name\u0027: \u0027{{ ceph_pools.backup_pool }}\u0027, \u0027pg_num\u0027: \u0027{{ ceph_pools.pg_num }}\u0027, \u0027rule_name\u0027: \u0027replicated_rule\u0027, \u0027application\u0027: \u0027rbd\u0027}]"},{"line_number":35,"context_line":"     when:"},{"line_number":36,"context_line":"      - tripleo_pool_volumes"},{"line_number":37,"context_line":"      - \"\u0027cinder_backup\u0027 in {{ enabled_services.stdout }}\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"   - name: add cinder extra pools"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"1fa4df85_bc405109","line":36,"range":{"start_line":36,"start_character":8,"end_line":36,"end_character":28},"updated":"2020-02-25 17:31:05.000000000","message":"this means cinder is enabled and we should check the \u0027cinder_backup\u0027 service is present","commit_id":"c448740c0866aee23c501eaf45d0a9ad4ccbe855"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"ccf9dd13482ee5990a5ceb6f905a474c6305fe99","unresolved":false,"context_lines":[{"line_number":62,"context_line":"      cephfs_metadata_pool: {\u0027name\u0027: \u0027{{ manila_pools.metadata }}\u0027, \u0027pg_num\u0027: \u0027{{ manila_pools.metadata_pg_num }}\u0027, \u0027rule_name\u0027: \u0027replicated_rule\u0027,"},{"line_number":63,"context_line":"                             \u0027application\u0027: \u0027cephfs\u0027}"},{"line_number":64,"context_line":"  when:"},{"line_number":65,"context_line":"   - \"\u0027manila_api\u0027 in {{ enabled_services.stdout }}\""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"1fa4df85_fc0489c8","line":65,"range":{"start_line":65,"start_character":7,"end_line":65,"end_character":17},"updated":"2020-02-25 17:33:31.000000000","message":"should we check other services or this is enough?","commit_id":"c448740c0866aee23c501eaf45d0a9ad4ccbe855"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"3a82edcc45182595fa827d7439e8e3ff31f539f2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: gather enabled services"},{"line_number":3,"context_line":"  shell: hiera -c /etc/puppet/hiera.yaml enabled_services"},{"line_number":4,"context_line":"  register: enabled_services"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: build pool list"},{"line_number":7,"context_line":"  block:"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"1fa4df85_401d940d","line":4,"range":{"start_line":2,"start_character":1,"end_line":4,"end_character":28},"updated":"2020-02-27 11:34:05.000000000","message":"This is a common task for both pools and keys, so we can move it to prepare.yaml","commit_id":"bb27b9a23efe5af1315f2cace5c36702919c79f4"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"3a82edcc45182595fa827d7439e8e3ff31f539f2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"     set_fact:"},{"line_number":33,"context_line":"      backup: [{\u0027name\u0027: \u0027{{ ceph_pools.backup_pool }}\u0027, \u0027pg_num\u0027: \u0027{{ ceph_pools.pg_num }}\u0027, \u0027rule_name\u0027: \u0027replicated_rule\u0027, \u0027application\u0027: \u0027rbd\u0027}]"},{"line_number":34,"context_line":"     when:"},{"line_number":35,"context_line":"      - tripleo_pool_volumes"},{"line_number":36,"context_line":"      - \"\u0027cinder_backup\u0027 in {{ enabled_services.stdout }}\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"   - name: add cinder extra pools"},{"line_number":39,"context_line":"     set_fact:"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"1fa4df85_60dd3041","line":36,"range":{"start_line":35,"start_character":7,"end_line":36,"end_character":58},"updated":"2020-02-27 11:34:05.000000000","message":"Cinder rbd must be enabled and cinder_backup service must be present.\nI need to review this condition since it can be turned into \n(tripleo_pool_volumes) AND (\u0027cinder_backup\u0027 in {{ enabled_services.stdout }}\")","commit_id":"bb27b9a23efe5af1315f2cace5c36702919c79f4"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"3a82edcc45182595fa827d7439e8e3ff31f539f2","unresolved":false,"context_lines":[{"line_number":42,"context_line":"      pool: \"{\u0027name\u0027: \u0027{{ item }}\u0027, \u0027pg_num\u0027: \u0027{{ ceph_pools.pg_num }}\u0027, \u0027rule_name\u0027: \u0027replicated_rule\u0027, \u0027application\u0027: \u0027rbd\u0027 }\""},{"line_number":43,"context_line":"     with_items: \"{{ ceph_pools.cinder_pool.extra_pools }}\""},{"line_number":44,"context_line":"     when:"},{"line_number":45,"context_line":"      - tripleo_pool_volumes"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"   - name: build resulting pool list"},{"line_number":48,"context_line":"     set_fact:"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"1fa4df85_e01b6018","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":28},"updated":"2020-02-27 11:34:05.000000000","message":"This depends on cinder service","commit_id":"bb27b9a23efe5af1315f2cace5c36702919c79f4"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"6935c6141e3162e7f0734f7f14b1e8a08a3d738b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"   - name: build resulting pool list"},{"line_number":44,"context_line":"     set_fact:"},{"line_number":45,"context_line":"      openstack_pools: \"{\u0027openstack_pools\u0027: {{ vms|default([]) + volumes|default([]) + images|default([]) + metrics|default([])"},{"line_number":46,"context_line":"      + backup|default([]) + cinder_extra|default([]) + ceph_pools.extra_pools|default([]) }} }\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"- name: build manila pool list"},{"line_number":49,"context_line":"  block:"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"1fa4df85_ca7095a8","line":46,"updated":"2020-03-02 12:26:53.000000000","message":"I am not sure if + ceph_pools.extra_pools is actually overwriting existing list items or of it is just appending multiple times data for same pool?","commit_id":"2b9464fc6d33ecd8faed065341ab42e541a7c2ac"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"44a751277a154511d0637e9e3d860268b0ee47f1","unresolved":false,"context_lines":[{"line_number":43,"context_line":"   - name: build resulting pool list"},{"line_number":44,"context_line":"     set_fact:"},{"line_number":45,"context_line":"      openstack_pools: \"{\u0027openstack_pools\u0027: {{ vms|default([]) + volumes|default([]) + images|default([]) + metrics|default([])"},{"line_number":46,"context_line":"      + backup|default([]) + cinder_extra|default([]) + ceph_pools.extra_pools|default([]) }} }\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"- name: build manila pool list"},{"line_number":49,"context_line":"  block:"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"1fa4df85_e27a48ef","line":46,"in_reply_to":"1fa4df85_ca7095a8","updated":"2020-03-03 09:42:58.000000000","message":"You\u0027re right.\nThis will produce duplicates and the main pool list is not filtered. \nSince this is a list of dicts, I\u0027m not sure the combine filter can be used here (I think it doesn\u0027t work w/ tweaking w/ data structures), so I\u0027m going to rework these set of tasks adding a condition to properly filter the main pool list according to the extra pool data structure.\nThanks Giulio, good catch here!","commit_id":"2b9464fc6d33ecd8faed065341ab42e541a7c2ac"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"5dbc63f939a3ad32232ee1cb214e13c0c985747c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"1fa4df85_2b0d94a0","updated":"2020-03-03 17:12:29.000000000","message":"this document needs to be reflowed.","commit_id":"33af577ad801df1c8c36db943de443bdb1c2bddc"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"5dbc63f939a3ad32232ee1cb214e13c0c985747c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: build pool list"},{"line_number":3,"context_line":"  block:"},{"line_number":4,"context_line":"   - name: build filter list"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"1fa4df85_8bfb6877","line":1,"updated":"2020-03-03 17:12:29.000000000","message":"missing boilerplate license header.","commit_id":"33af577ad801df1c8c36db943de443bdb1c2bddc"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"e2ccfbb8ae7bb827dde3c4ecc08498df1a551cf3","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        images: [{\u0027name\u0027: \u0027{{ ceph_pools.glance_pool.name }}\u0027, \u0027pg_num\u0027: \u0027{{ ceph_pools.pg_num }}\u0027, \u0027rule_name\u0027: \u0027replicated_rule\u0027, \u0027application\u0027: \u0027rbd\u0027}]"},{"line_number":27,"context_line":"      when:"},{"line_number":28,"context_line":"        - tripleo_pool_images"},{"line_number":29,"context_line":"        - \"\u0027{{ ceph_pools.glance_pool.name }}\u0027 not in overrides|default([])\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    - name: add volumes pool"},{"line_number":32,"context_line":"      set_fact:"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"1fa4df85_dd702f0b","line":29,"range":{"start_line":29,"start_character":8,"end_line":29,"end_character":76},"updated":"2020-03-04 16:35:19.000000000","message":"@cloudnull, do you think this line should be turned into:\n\n```\n- ceph_pools.glance_pool.name not in overrides|default([])\n\n```\n(and same for all the other similar conditions?)","commit_id":"121de1954fdc9ac1babd120fbf2142d909f1ab24"}],"tripleo_ansible/roles/tripleo_ceph_work_dir/tasks/prepare.yml":[{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"5512efec46bdece8c206544bf7d933b973ae7daa","unresolved":false,"context_lines":[{"line_number":42,"context_line":"- name: build the openstack pool list"},{"line_number":43,"context_line":"  import_tasks: build_pools.yml"},{"line_number":44,"context_line":"  vars:"},{"line_number":45,"context_line":"    - pg_num: 64"},{"line_number":46,"context_line":"    - tripleo_pool_metrics: true"},{"line_number":47,"context_line":"    - tripleo_pool_vms: true"},{"line_number":48,"context_line":"    - tripleo_pool_volumes: true"},{"line_number":49,"context_line":"    - tripleo_pool_images: true"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- name: generate ceph-ansible group vars all"},{"line_number":52,"context_line":"  copy:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_12eb6211","line":49,"range":{"start_line":45,"start_character":4,"end_line":49,"end_character":31},"updated":"2020-02-21 10:05:05.000000000","message":"for testing purposes, these params will be generated by tht","commit_id":"f10cf5de736da2eb4934992e83fc8ad7e7a5786e"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"e67266ee5cf8792591c7b20c92f834950528305c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"- name: build the openstack pool list"},{"line_number":43,"context_line":"  import_tasks: build_pools.yml"},{"line_number":44,"context_line":"  vars:"},{"line_number":45,"context_line":"    - pg_num: 64"},{"line_number":46,"context_line":"    - tripleo_pool_metrics: true"},{"line_number":47,"context_line":"    - tripleo_pool_vms: true"},{"line_number":48,"context_line":"    - tripleo_pool_volumes: true"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1fa4df85_2c5bf72e","line":45,"range":{"start_line":45,"start_character":6,"end_line":45,"end_character":12},"updated":"2020-02-23 16:20:04.000000000","message":"Will this come from CephPoolDefaultPgNum?","commit_id":"0862833ce42c8e3e8cb54737ab17723907e13e5e"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"fc28904cdb3fed6b77692704c12dbdca3a52936f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"- name: build the openstack pool list"},{"line_number":43,"context_line":"  import_tasks: build_pools.yml"},{"line_number":44,"context_line":"  vars:"},{"line_number":45,"context_line":"    - pg_num: 64"},{"line_number":46,"context_line":"    - tripleo_pool_metrics: true"},{"line_number":47,"context_line":"    - tripleo_pool_vms: true"},{"line_number":48,"context_line":"    - tripleo_pool_volumes: true"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1fa4df85_6ced6f24","line":45,"range":{"start_line":45,"start_character":6,"end_line":45,"end_character":12},"in_reply_to":"1fa4df85_2c5bf72e","updated":"2020-02-23 16:35:03.000000000","message":"Yes, all the variables you see here are my first attempt to create the logic in this role, I\u0027m going to remove them soon from this task.\nNext step is to pass them from tht of course, and pg_num will be the CephPoolDefaultPgNum param you mentioned","commit_id":"0862833ce42c8e3e8cb54737ab17723907e13e5e"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"71ccc4ee5c55eaef98ee1e33b69b64c9e5c651ec","unresolved":false,"context_lines":[{"line_number":52,"context_line":"- name: generate ceph-ansible group vars all"},{"line_number":53,"context_line":"  copy:"},{"line_number":54,"context_line":"    dest: \"{{ playbook_dir }}/ceph-ansible/group_vars/all.yml\""},{"line_number":55,"context_line":"    content: \"{{ ceph_ansible_group_vars_all | combine(openstack_pools|default({})) | to_nice_yaml }}\""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- name: generate ceph-ansible extra vars"},{"line_number":58,"context_line":"  copy:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"1fa4df85_11472720","line":55,"range":{"start_line":55,"start_character":71,"end_line":55,"end_character":82},"updated":"2020-02-24 15:34:16.000000000","message":"This should be: default({\u0027openstack_pools\u0027: []})  because we need the empty array called `openstack_pools` anyway in ceph-ansible","commit_id":"d41adff278723176ab0d4549f2f62d3f2b9c07f1"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"9d3ddc65b08cc2f0094a6693b862b75d74ec42a2","unresolved":false,"context_lines":[{"line_number":46,"context_line":"- name: build the openstack pool list"},{"line_number":47,"context_line":"  import_tasks: build_pools.yml"},{"line_number":48,"context_line":"  vars:"},{"line_number":49,"context_line":"    - tripleo_pool_metrics: \"{{ ceph_pools.gnocchi_pool.enabled }}\""},{"line_number":50,"context_line":"    - tripleo_pool_images: \"{{ ceph_pools.glance_pool.enabled }}\""},{"line_number":51,"context_line":"    - tripleo_pool_vms: \"{{ ceph_pools.nova_pool.enabled }}\""},{"line_number":52,"context_line":"    - tripleo_pool_volumes: \"{{ ceph_pools.cinder_pool.enabled }}\""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"- name: build openstack keys"},{"line_number":55,"context_line":"  include_tasks: build_keys.yml"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"1fa4df85_352201a6","line":52,"range":{"start_line":49,"start_character":4,"end_line":52,"end_character":66},"updated":"2020-02-28 16:00:00.000000000","message":"https://github.com/openstack/tripleo-heat-templates/blob/master/environments/ceph-ansible/ceph-ansible.yaml#L13-L17","commit_id":"d67313d91cf0379d5a395648911bc45a27b96f96"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"6935c6141e3162e7f0734f7f14b1e8a08a3d738b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"- name: build the openstack pool list"},{"line_number":47,"context_line":"  import_tasks: build_pools.yml"},{"line_number":48,"context_line":"  vars:"},{"line_number":49,"context_line":"    - tripleo_pool_metrics: \"{{ ceph_pools.gnocchi_pool.enabled }}\""},{"line_number":50,"context_line":"    - tripleo_pool_images: \"{{ ceph_pools.glance_pool.enabled }}\""},{"line_number":51,"context_line":"    - tripleo_pool_vms: \"{{ ceph_pools.nova_pool.enabled }}\""},{"line_number":52,"context_line":"    - tripleo_pool_volumes: \"{{ ceph_pools.cinder_pool.enabled }}\""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"1fa4df85_672afc90","line":49,"updated":"2020-03-02 12:26:53.000000000","message":"should be removed if we do the cinder-backup way","commit_id":"2b9464fc6d33ecd8faed065341ab42e541a7c2ac"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"44a751277a154511d0637e9e3d860268b0ee47f1","unresolved":false,"context_lines":[{"line_number":46,"context_line":"- name: build the openstack pool list"},{"line_number":47,"context_line":"  import_tasks: build_pools.yml"},{"line_number":48,"context_line":"  vars:"},{"line_number":49,"context_line":"    - tripleo_pool_metrics: \"{{ ceph_pools.gnocchi_pool.enabled }}\""},{"line_number":50,"context_line":"    - tripleo_pool_images: \"{{ ceph_pools.glance_pool.enabled }}\""},{"line_number":51,"context_line":"    - tripleo_pool_vms: \"{{ ceph_pools.nova_pool.enabled }}\""},{"line_number":52,"context_line":"    - tripleo_pool_volumes: \"{{ ceph_pools.cinder_pool.enabled }}\""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"1fa4df85_82d914f4","line":49,"in_reply_to":"1fa4df85_672afc90","updated":"2020-03-03 09:42:58.000000000","message":"ok, as discussed in the tht review we can avoid this condition here","commit_id":"2b9464fc6d33ecd8faed065341ab42e541a7c2ac"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"5dbc63f939a3ad32232ee1cb214e13c0c985747c","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    - run_ceph_ansible"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- name: gather hiera metadata"},{"line_number":43,"context_line":"  shell: hiera -c /etc/puppet/hiera.yaml enabled_services"},{"line_number":44,"context_line":"  register: enabled_services"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- name: build the openstack pool list"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"1fa4df85_6b714c0c","line":43,"range":{"start_line":43,"start_character":2,"end_line":43,"end_character":7},"updated":"2020-03-03 17:12:29.000000000","message":"unless shell is required, lets use command here.","commit_id":"33af577ad801df1c8c36db943de443bdb1c2bddc"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"5dbc63f939a3ad32232ee1cb214e13c0c985747c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"- name: build the openstack pool list"},{"line_number":47,"context_line":"  import_tasks: build_pools.yml"},{"line_number":48,"context_line":"  vars:"},{"line_number":49,"context_line":"    - tripleo_pool_images: \"{{ ceph_pools.glance_pool.enabled }}\""},{"line_number":50,"context_line":"    - tripleo_pool_vms: \"{{ ceph_pools.nova_pool.enabled }}\""},{"line_number":51,"context_line":"    - tripleo_pool_volumes: \"{{ ceph_pools.cinder_pool.enabled }}\""},{"line_number":52,"context_line":"    - tripleo_pool_backup: \"{{ ceph_pools.cinder_backup_pool.enabled }}\""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"- name: build openstack keys"},{"line_number":55,"context_line":"  include_tasks: build_keys.yml"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"1fa4df85_cb59608e","line":52,"range":{"start_line":49,"start_character":0,"end_line":52,"end_character":72},"updated":"2020-03-03 17:12:29.000000000","message":"I think this needs to be rewritten as a dictionary.\n\n  vars:\n    tripleo_pool_images: \"{{ ceph_pools.glance_pool.enabled }}\"\n    tripleo_pool_vms: \"{{ ceph_pools.nova_pool.enabled }}\"\n    tripleo_pool_volumes: \"{{ ceph_pools.cinder_pool.enabled }}\"\n    tripleo_pool_backup: \"{{ ceph_pools.cinder_backup_pool.enabled }}\"","commit_id":"33af577ad801df1c8c36db943de443bdb1c2bddc"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"831a839f608a35f5a668749705044b2147343038","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    - run_uuid_ansible"},{"line_number":40,"context_line":"    - run_ceph_ansible"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- name: gather hiera metadata"},{"line_number":43,"context_line":"  command: /bin/hiera -c /etc/puppet/hiera.yaml enabled_services"},{"line_number":44,"context_line":"  register: enabled_services"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- name: build the openstack pool list"},{"line_number":47,"context_line":"  import_tasks: build_pools.yml"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"1fa4df85_ce083793","line":44,"range":{"start_line":42,"start_character":0,"end_line":44,"end_character":28},"updated":"2020-03-09 19:18:15.000000000","message":"I think we needed a become here.\n\nhttps://bugs.launchpad.net/tripleo/+bug/1866694","commit_id":"144f5aa690eb2c6ea6071dc2732c721e6bde4c77"}]}