)]}'
{"tripleo_ansible/playbooks/undercloud-ipa-install.yaml":[{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"862489fc6e011d7d59d6cf3caf8bab67431ee831","unresolved":false,"context_lines":[{"line_number":107,"context_line":"  become: true\r"},{"line_number":108,"context_line":"  tasks:\r"},{"line_number":109,"context_line":"    - include_role:\r"},{"line_number":110,"context_line":"        name: tripleo-create-admin\r"},{"line_number":111,"context_line":"\r"},{"line_number":112,"context_line":"- hosts: \"{{ tripleo_ipa_undercloud_host | default(\u0027localhost\u0027) }}\"\r"},{"line_number":113,"context_line":"  become: true\r"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1fa4df85_0d7e19e4","line":110,"updated":"2020-02-25 13:59:58.000000000","message":"this should be changed to tripleo_create_admin (with underscores)","commit_id":"304d7c6df7e40b45153cb3a505368e8b174dcdec"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"45fc04afd2e0939738c47a6809374abe6d3b1b41","unresolved":false,"context_lines":[{"line_number":107,"context_line":"  become: true\r"},{"line_number":108,"context_line":"  tasks:\r"},{"line_number":109,"context_line":"    - include_role:\r"},{"line_number":110,"context_line":"        name: tripleo-create-admin\r"},{"line_number":111,"context_line":"\r"},{"line_number":112,"context_line":"- hosts: \"{{ tripleo_ipa_undercloud_host | default(\u0027localhost\u0027) }}\"\r"},{"line_number":113,"context_line":"  become: true\r"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1fa4df85_f0e83217","line":110,"in_reply_to":"1fa4df85_0d7e19e4","updated":"2020-02-25 14:31:34.000000000","message":"+1","commit_id":"304d7c6df7e40b45153cb3a505368e8b174dcdec"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"862489fc6e011d7d59d6cf3caf8bab67431ee831","unresolved":false,"context_lines":[{"line_number":132,"context_line":"\r"},{"line_number":133,"context_line":"    - name: create users, perms, get keytab\r"},{"line_number":134,"context_line":"      include_role:\r"},{"line_number":135,"context_line":"        name: tripleo-ipa\r"},{"line_number":136,"context_line":"        tasks_from: setup\r"},{"line_number":137,"context_line":"        apply:\r"},{"line_number":138,"context_line":"          environment:\r"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1fa4df85_6d6c6d36","line":135,"updated":"2020-02-25 13:59:58.000000000","message":"same here - replace with and underscore - tripleo_ipa","commit_id":"304d7c6df7e40b45153cb3a505368e8b174dcdec"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"45fc04afd2e0939738c47a6809374abe6d3b1b41","unresolved":false,"context_lines":[{"line_number":132,"context_line":"\r"},{"line_number":133,"context_line":"    - name: create users, perms, get keytab\r"},{"line_number":134,"context_line":"      include_role:\r"},{"line_number":135,"context_line":"        name: tripleo-ipa\r"},{"line_number":136,"context_line":"        tasks_from: setup\r"},{"line_number":137,"context_line":"        apply:\r"},{"line_number":138,"context_line":"          environment:\r"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1fa4df85_10ee2e22","line":135,"in_reply_to":"1fa4df85_6d6c6d36","updated":"2020-02-25 14:31:34.000000000","message":"+1","commit_id":"304d7c6df7e40b45153cb3a505368e8b174dcdec"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"eeb156e469cbc18069c659bc5a40d82a7068d919","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        ipaclient_realm: \"{{ ipa_realm }}\"\r"},{"line_number":76,"context_line":"        ipaclient_force: true\r"},{"line_number":77,"context_line":"        ipaadmin_principal: \"{{ ipa_server_user }}\"\r"},{"line_number":78,"context_line":"        ipaadmin_password: \"{{ ipa_server_password }}\"\r"},{"line_number":79,"context_line":"        ansible_user: \"{{ undercloud_ansible_user }}\"\r"},{"line_number":80,"context_line":"        ansible_ssh_extra_args: \"-o StrictHostKeyChecking\u003dno -o UserKnownHostsFile\u003d/dev/null\"\r"},{"line_number":81,"context_line":"\r"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_f51a127b","line":78,"updated":"2020-03-02 13:57:41.000000000","message":"leaking passwords here, you probably want a no_log.","commit_id":"8c6d5047e44a1ed86a18a938116c965b36e4f45b"},{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"aae5a82ea0b6c23becbf0a48eb61039045f491a2","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        ipaclient_realm: \"{{ ipa_realm }}\"\r"},{"line_number":76,"context_line":"        ipaclient_force: true\r"},{"line_number":77,"context_line":"        ipaadmin_principal: \"{{ ipa_server_user }}\"\r"},{"line_number":78,"context_line":"        ipaadmin_password: \"{{ ipa_server_password }}\"\r"},{"line_number":79,"context_line":"        ansible_user: \"{{ undercloud_ansible_user }}\"\r"},{"line_number":80,"context_line":"        ansible_ssh_extra_args: \"-o StrictHostKeyChecking\u003dno -o UserKnownHostsFile\u003d/dev/null\"\r"},{"line_number":81,"context_line":"\r"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_03677327","line":78,"in_reply_to":"1fa4df85_f51a127b","updated":"2020-03-02 18:53:29.000000000","message":"Done","commit_id":"8c6d5047e44a1ed86a18a938116c965b36e4f45b"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"eeb156e469cbc18069c659bc5a40d82a7068d919","unresolved":false,"context_lines":[{"line_number":88,"context_line":"  become: true\r"},{"line_number":89,"context_line":"  tasks:\r"},{"line_number":90,"context_line":"    - name: Install distro packages required for IPA enrollment\r"},{"line_number":91,"context_line":"      yum:\r"},{"line_number":92,"context_line":"        name: \"{{ ipa_distro_packages }}\"\r"},{"line_number":93,"context_line":"        state: present\r"},{"line_number":94,"context_line":"\r"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_557c46b4","line":91,"range":{"start_line":91,"start_character":6,"end_line":91,"end_character":9},"updated":"2020-03-02 13:57:41.000000000","message":"please use package module instead; more generic than yum/dnf modules.","commit_id":"8c6d5047e44a1ed86a18a938116c965b36e4f45b"},{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"aae5a82ea0b6c23becbf0a48eb61039045f491a2","unresolved":false,"context_lines":[{"line_number":88,"context_line":"  become: true\r"},{"line_number":89,"context_line":"  tasks:\r"},{"line_number":90,"context_line":"    - name: Install distro packages required for IPA enrollment\r"},{"line_number":91,"context_line":"      yum:\r"},{"line_number":92,"context_line":"        name: \"{{ ipa_distro_packages }}\"\r"},{"line_number":93,"context_line":"        state: present\r"},{"line_number":94,"context_line":"\r"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_a36d3f05","line":91,"range":{"start_line":91,"start_character":6,"end_line":91,"end_character":9},"in_reply_to":"1fa4df85_557c46b4","updated":"2020-03-02 18:53:29.000000000","message":"Done","commit_id":"8c6d5047e44a1ed86a18a938116c965b36e4f45b"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"eeb156e469cbc18069c659bc5a40d82a7068d919","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        state: present\r"},{"line_number":94,"context_line":"\r"},{"line_number":95,"context_line":"    - name: Install pip packages required for IPA enrollment\r"},{"line_number":96,"context_line":"      pip:\r"},{"line_number":97,"context_line":"        name: \"{{ ipa_pip_packages }}\"\r"},{"line_number":98,"context_line":"        state: present\r"},{"line_number":99,"context_line":"\r"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_355aea4e","line":96,"updated":"2020-03-02 13:57:41.000000000","message":"mixing rpms \u0026 pip isn\u0027t something we want to do in production. Aren\u0027t IPA dependencies available in RPM? I\u0027m not in favor of doing that.","commit_id":"8c6d5047e44a1ed86a18a938116c965b36e4f45b"},{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"aae5a82ea0b6c23becbf0a48eb61039045f491a2","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        state: present\r"},{"line_number":94,"context_line":"\r"},{"line_number":95,"context_line":"    - name: Install pip packages required for IPA enrollment\r"},{"line_number":96,"context_line":"      pip:\r"},{"line_number":97,"context_line":"        name: \"{{ ipa_pip_packages }}\"\r"},{"line_number":98,"context_line":"        state: present\r"},{"line_number":99,"context_line":"\r"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_c3707bdf","line":96,"in_reply_to":"1fa4df85_2d361ee8","updated":"2020-03-02 18:53:29.000000000","message":"I\u0027ve added a TODO in my latest revision to remove this and the definition once CI moves to centos 8.","commit_id":"8c6d5047e44a1ed86a18a938116c965b36e4f45b"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"98e4e9fdc67dc616164bc1e7d56703745e514c26","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        state: present\r"},{"line_number":94,"context_line":"\r"},{"line_number":95,"context_line":"    - name: Install pip packages required for IPA enrollment\r"},{"line_number":96,"context_line":"      pip:\r"},{"line_number":97,"context_line":"        name: \"{{ ipa_pip_packages }}\"\r"},{"line_number":98,"context_line":"        state: present\r"},{"line_number":99,"context_line":"\r"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_2d361ee8","line":96,"in_reply_to":"1fa4df85_355aea4e","updated":"2020-03-02 16:31:15.000000000","message":"This package is available on centos 8, but this is being tested on centos 7 and it\u0027s not available there...","commit_id":"8c6d5047e44a1ed86a18a938116c965b36e4f45b"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"eeb156e469cbc18069c659bc5a40d82a7068d919","unresolved":false,"context_lines":[{"line_number":113,"context_line":"  become: true\r"},{"line_number":114,"context_line":"  tasks:\r"},{"line_number":115,"context_line":"    - name: kinit to get admin credentials\r"},{"line_number":116,"context_line":"      command: kinit -c KEYRING:persistent:1 \"{{ ipa_server_user }}@{{ ipa_realm }}\"\r"},{"line_number":117,"context_line":"      args:\r"},{"line_number":118,"context_line":"        stdin: \"{{ ipa_server_password }}\"\r"},{"line_number":119,"context_line":"      register: kinit\r"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_552a0690","line":116,"updated":"2020-03-02 13:57:41.000000000","message":"you\u0027re leaking credentials in the logs. You probably want a no_log here.","commit_id":"8c6d5047e44a1ed86a18a938116c965b36e4f45b"},{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"aae5a82ea0b6c23becbf0a48eb61039045f491a2","unresolved":false,"context_lines":[{"line_number":113,"context_line":"  become: true\r"},{"line_number":114,"context_line":"  tasks:\r"},{"line_number":115,"context_line":"    - name: kinit to get admin credentials\r"},{"line_number":116,"context_line":"      command: kinit -c KEYRING:persistent:1 \"{{ ipa_server_user }}@{{ ipa_realm }}\"\r"},{"line_number":117,"context_line":"      args:\r"},{"line_number":118,"context_line":"        stdin: \"{{ ipa_server_password }}\"\r"},{"line_number":119,"context_line":"      register: kinit\r"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_637747d6","line":116,"in_reply_to":"1fa4df85_552a0690","updated":"2020-03-02 18:53:29.000000000","message":"Done","commit_id":"8c6d5047e44a1ed86a18a938116c965b36e4f45b"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"eeb156e469cbc18069c659bc5a40d82a7068d919","unresolved":false,"context_lines":[{"line_number":123,"context_line":"      command: ktutil\r"},{"line_number":124,"context_line":"      args:\r"},{"line_number":125,"context_line":"        stdin: |\r"},{"line_number":126,"context_line":"          addent -password -p {{ ipa_server_user }}@{{ ipa_realm }} -k 1 -e aes128-cts-hmac-sha1-96\r"},{"line_number":127,"context_line":"          {{ ipa_server_password }}\r"},{"line_number":128,"context_line":"          wkt {{ admin_keytab }}\r"},{"line_number":129,"context_line":"          quit\r"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_d517d650","line":126,"updated":"2020-03-02 13:57:41.000000000","message":"ditto on no_log","commit_id":"8c6d5047e44a1ed86a18a938116c965b36e4f45b"},{"author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"change_message_id":"aae5a82ea0b6c23becbf0a48eb61039045f491a2","unresolved":false,"context_lines":[{"line_number":123,"context_line":"      command: ktutil\r"},{"line_number":124,"context_line":"      args:\r"},{"line_number":125,"context_line":"        stdin: |\r"},{"line_number":126,"context_line":"          addent -password -p {{ ipa_server_user }}@{{ ipa_realm }} -k 1 -e aes128-cts-hmac-sha1-96\r"},{"line_number":127,"context_line":"          {{ ipa_server_password }}\r"},{"line_number":128,"context_line":"          wkt {{ admin_keytab }}\r"},{"line_number":129,"context_line":"          quit\r"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_837283e2","line":126,"in_reply_to":"1fa4df85_d517d650","updated":"2020-03-02 18:53:29.000000000","message":"Done","commit_id":"8c6d5047e44a1ed86a18a938116c965b36e4f45b"}]}