)]}'
{"tripleo_ansible/playbooks/rotate-fernet-keys.yaml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"19be7423ed8db4404810b8864b585ca3445922d5","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  any_errors_fatal: true"},{"line_number":23,"context_line":"  vars:"},{"line_number":24,"context_line":"    container: overcloud"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  tasks:"},{"line_number":27,"context_line":"    - name: Rotate keys and update plan"},{"line_number":28,"context_line":"      rotate_fernet_keys:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1fa4df85_50be42b4","line":25,"updated":"2020-03-06 14:43:59.000000000","message":"should we add a pre_task here to check `hostvars[\u0027Undercloud\u0027][\u0027fernet_keys\u0027]` is defined before attempting to pass it through?","commit_id":"d621eda34666dc982fdc70626ffc08b286052a35"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"5c11c7a5935bf1292599e582c7e5098d76431e01","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  any_errors_fatal: true"},{"line_number":23,"context_line":"  vars:"},{"line_number":24,"context_line":"    container: overcloud"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  tasks:"},{"line_number":27,"context_line":"    - name: Rotate keys and update plan"},{"line_number":28,"context_line":"      rotate_fernet_keys:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1fa4df85_7cf78b8c","line":25,"in_reply_to":"1fa4df85_50be42b4","updated":"2020-03-08 05:02:34.000000000","message":"It does not exist before, we add it in L30","commit_id":"d621eda34666dc982fdc70626ffc08b286052a35"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"6d327d38213f1c6ed5b35c9a8180d8a3579169c6","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  any_errors_fatal: true"},{"line_number":23,"context_line":"  vars:"},{"line_number":24,"context_line":"    container: overcloud"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  tasks:"},{"line_number":27,"context_line":"    - name: Rotate keys and update plan"},{"line_number":28,"context_line":"      rotate_fernet_keys:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1fa4df85_3b5350e4","line":25,"in_reply_to":"1fa4df85_7cf78b8c","updated":"2020-03-09 13:30:28.000000000","message":"++ thanks for clarifying that.","commit_id":"d621eda34666dc982fdc70626ffc08b286052a35"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"19be7423ed8db4404810b8864b585ca3445922d5","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      register: fernet_keys"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: Rotate Fernet Keys on Controlleri nodes"},{"line_number":33,"context_line":"  include: rotate-keys.yaml variable\u003dhostvars[\u0027Undercloud\u0027][\u0027fernet_keys\u0027]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  tags:"},{"line_number":36,"context_line":"    - rotate-ferent-keys"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1fa4df85_10020a70","line":33,"range":{"start_line":33,"start_character":28,"end_line":33,"end_character":74},"updated":"2020-03-06 14:43:59.000000000","message":"I don\u0027t see where this variable is used?","commit_id":"d621eda34666dc982fdc70626ffc08b286052a35"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"5c11c7a5935bf1292599e582c7e5098d76431e01","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      register: fernet_keys"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: Rotate Fernet Keys on Controlleri nodes"},{"line_number":33,"context_line":"  include: rotate-keys.yaml variable\u003dhostvars[\u0027Undercloud\u0027][\u0027fernet_keys\u0027]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  tags:"},{"line_number":36,"context_line":"    - rotate-ferent-keys"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1fa4df85_1cf2179b","line":33,"range":{"start_line":33,"start_character":28,"end_line":33,"end_character":74},"in_reply_to":"1fa4df85_10020a70","updated":"2020-03-08 05:02:34.000000000","message":"Sorry, it should be fernet_keys. corrected in next patchset","commit_id":"d621eda34666dc982fdc70626ffc08b286052a35"}]}
