)]}'
{"tripleo_ansible/roles/tripleo_ceph_work_dir/tasks/build_keys.yml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"1aea42be17a3418d6cb80f164a08f0c013b2f5cf","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    manila_key: [{\u0027name\u0027: \u0027{{ \".\".join((\"client\", ceph_keys.manila.name)) }}\u0027, \u0027key\u0027: \u0027{{ ceph_keys.manila.key }}\u0027,"},{"line_number":45,"context_line":"                  \u0027mode\u0027: \u00270600\u0027, \u0027caps\u0027: \u0027{{ manila_caps }}\u0027}]"},{"line_number":46,"context_line":"  when:"},{"line_number":47,"context_line":"    - \"\u0027manila_api\u0027 in {{ enabled_services.stdout }}\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- name: build radosgw key for openstack"},{"line_number":50,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1fa4df85_4997333c","side":"PARENT","line":47,"range":{"start_line":47,"start_character":6,"end_line":47,"end_character":53},"updated":"2020-03-12 00:28:02.000000000","message":"This syntax was producing:\n\n[WARNING]: conditional statements should not include jinja2 templating delimiters such as {{ }} or {% %}.\n\nWhen I had a real list and didn\u0027t need standard out it didn\u0027t work with the error below. Easier to just use intersect.\n\nfatal: [undercloud]: FAILED! \u003d\u003e {\"msg\": \"The conditional check \u0027\u0027gnocchi_api\u0027 in {{ enabled_services }}\u0027 failed. The error was: template error while templating string: expected token \u0027,\u0027, got \u0027string\u0027. String: {% if \u0027gnocchi_api\u0027 in [u\u0027keystone_admin_api\u0027, u\u0027keystone_public_api\u0027, u\u0027boot_params_service\u0027, u\u0027ca_certs\u0027, u\u0027ceph_mgr\u0027, u\u0027ceph_mon\u0027, u\u0027certmonger_user\u0027, u\u0027cinder_api\u0027, u\u0027cinder_scheduler\u0027, u\u0027cinder_volume\u0027, u\u0027container_image_prepare\u0027, u\u0027glance_api\u0027, u\u0027haproxy\u0027, u\u0027heat_api\u0027, u\u0027heat_api_cloudwatch_disabled\u0027, u\u0027heat_api_cfn\u0027, u\u0027heat_engine\u0027, u\u0027horizon\u0027, u\u0027iscsid\u0027, u\u0027keepalived\u0027, u\u0027kernel\u0027, u\u0027keystone\u0027, u\u0027memcached\u0027, u\u0027mysql\u0027, u\u0027mysql_client\u0027, u\u0027neutron_api\u0027, u\u0027neutron_plugin_ml2_ovn\u0027, u\u0027nova_api\u0027, u\u0027nova_conductor\u0027, u\u0027nova_metadata\u0027, u\u0027nova_scheduler\u0027, u\u0027nova_vnc_proxy\u0027, u\u0027logrotate_crond\u0027, u\u0027ovn_dbs\u0027, u\u0027ovn_controller\u0027, u\u0027placement\u0027, u\u0027oslo_messaging_rpc\u0027, u\u0027oslo_messaging_notify\u0027, u\u0027podman\u0027, u\u0027snmp\u0027, u\u0027sshd\u0027, u\u0027swift_proxy\u0027, u\u0027swift_ringbuilder\u0027, u\u0027swift_storage\u0027, u\u0027chrony\u0027, u\u0027timezone\u0027, u\u0027tripleo_firewall\u0027, u\u0027tripleo_packages\u0027, u\u0027tuned\u0027, u\u0027boot_params_service\u0027, u\u0027ca_certs\u0027, u\u0027ceph_client\u0027, u\u0027ceph_osd\u0027, u\u0027certmonger_user\u0027, u\u0027iscsid\u0027, u\u0027kernel\u0027, u\u0027mysql_client\u0027, u\u0027nova_compute\u0027, u\u0027nova_libvirt\u0027, u\u0027nova_libvirt_guests\u0027, u\u0027nova_migration_target\u0027, u\u0027logrotate_crond\u0027, u\u0027podman\u0027, u\u0027snmp\u0027, u\u0027sshd\u0027, u\u0027chrony\u0027, u\u0027timezone\u0027, u\u0027tripleo_firewall\u0027, u\u0027tripleo_packages\u0027, u\u0027tuned\u0027, u\u0027ovn_controller\u0027, u\u0027ovn_metadata\u0027] %} True {% else %} False {% endif %}\\n\\nThe error appears to be in \u0027/home/stack/tripleo-ansible/tripleo_ansible/roles/tripleo_ceph_work_dir/tasks/build_pools.yml\u0027: line 45, column 7, but may\\nbe elsewhere in the file depending on the exact syntax problem.\\n\\nThe offending line appears to be:\\n\\n\\n    - name: add gnocchi pool\\n      ^ here\\n\"}","commit_id":"f128b92622b6a357cc66fcc0068ff602a66c7a34"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"d15394138d96ced51fb2a8e1bcd7e137a32b126f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    manila_key: [{\u0027name\u0027: \u0027{{ \".\".join((\"client\", ceph_keys.manila.name)) }}\u0027, \u0027key\u0027: \u0027{{ ceph_keys.manila.key }}\u0027,"},{"line_number":45,"context_line":"                  \u0027mode\u0027: \u00270600\u0027, \u0027caps\u0027: \u0027{{ manila_caps }}\u0027}]"},{"line_number":46,"context_line":"  when:"},{"line_number":47,"context_line":"    - enabled_services | intersect([\u0027manila_api\u0027])"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- name: build radosgw key for openstack"},{"line_number":50,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1fa4df85_29c19781","line":47,"range":{"start_line":47,"start_character":6,"end_line":47,"end_character":50},"updated":"2020-03-12 00:19:27.000000000","message":"This works because an empty list is falsy and a non-empty list is truthy","commit_id":"03ff94ab368c2b43a03d76a9bff1e0e042a7c650"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"4a371576273f5c96a2c3e72ce9233256df01de14","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    manila_key: [{\u0027name\u0027: \u0027{{ \".\".join((\"client\", ceph_keys.manila.name)) }}\u0027, \u0027key\u0027: \u0027{{ ceph_keys.manila.key }}\u0027,"},{"line_number":45,"context_line":"                  \u0027mode\u0027: \u00270600\u0027, \u0027caps\u0027: \u0027{{ manila_caps }}\u0027}]"},{"line_number":46,"context_line":"  when:"},{"line_number":47,"context_line":"    - enabled_services | intersect([\u0027manila_api\u0027])"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- name: build radosgw key for openstack"},{"line_number":50,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1fa4df85_de2bd27f","line":47,"range":{"start_line":47,"start_character":6,"end_line":47,"end_character":50},"in_reply_to":"1fa4df85_29c19781","updated":"2020-03-12 09:09:56.000000000","message":"interesting solution but according to [1] no keys are created :/\n\n[1] https://fc7da22d605cc199ea32-a05951a0ad29f0907f5578ce9b824040.ssl.cf1.rackcdn.com/712589/2/check/tripleo-ci-centos-8-scenario004-standalone/ba30f27/logs/undercloud/home/zuul/standalone-ansible-6v_ui053/ceph-ansible/group_vars/all.yml","commit_id":"03ff94ab368c2b43a03d76a9bff1e0e042a7c650"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"4a371576273f5c96a2c3e72ce9233256df01de14","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    rgw_key: [{\u0027name\u0027: \u0027{{ \".\".join((\"client\", ceph_keys.radosgw.name)) }}\u0027, \u0027key\u0027: \u0027{{ ceph_keys.radosgw.key }}\u0027,"},{"line_number":54,"context_line":"               \u0027mode\u0027: \u00270600\u0027, \u0027caps\u0027: \u0027{{ rgw_caps }}\u0027}]"},{"line_number":55,"context_line":"  when:"},{"line_number":56,"context_line":"    - enabled_services | intersect([\u0027ceph_rgw\u0027])"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"- name: build the resulting keys"},{"line_number":59,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1fa4df85_7e209e9c","line":56,"range":{"start_line":56,"start_character":6,"end_line":56,"end_character":48},"updated":"2020-03-12 09:09:56.000000000","message":"same as manila key","commit_id":"03ff94ab368c2b43a03d76a9bff1e0e042a7c650"}],"tripleo_ansible/roles/tripleo_ceph_work_dir/tasks/build_pools.yml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"d15394138d96ced51fb2a8e1bcd7e137a32b126f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        metrics: [{\u0027name\u0027: \u0027{{ ceph_pools.gnocchi_pool.name }}\u0027, \u0027pg_num\u0027: \u0027{{ ceph_pools.pg_num }}\u0027, \u0027rule_name\u0027: \u0027replicated_rule\u0027,"},{"line_number":48,"context_line":"                   \u0027application\u0027: \u0027openstack_gnocchi\u0027}]"},{"line_number":49,"context_line":"      when:"},{"line_number":50,"context_line":"        - tripleo_pool_metrics"},{"line_number":51,"context_line":"        - enabled_services | intersect([\u0027gnocchi_api\u0027])"},{"line_number":52,"context_line":"        - ceph_pools.gnocchi_pool.name not in overrides|default([])"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    - name: add cinder backup pool"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1fa4df85_29e2f702","line":51,"range":{"start_line":50,"start_character":0,"end_line":51,"end_character":55},"updated":"2020-03-12 00:19:27.000000000","message":"Do we need to see if the service is in the enabled list according to hiera if we already have tripleo_pool_metrics as defined above it?\n\nhttps://opendev.org/openstack/tripleo-ansible/src/branch/master/tripleo_ansible/roles/tripleo_ceph_work_dir/tasks/prepare.yml#L50-L54","commit_id":"03ff94ab368c2b43a03d76a9bff1e0e042a7c650"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"4a371576273f5c96a2c3e72ce9233256df01de14","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        metrics: [{\u0027name\u0027: \u0027{{ ceph_pools.gnocchi_pool.name }}\u0027, \u0027pg_num\u0027: \u0027{{ ceph_pools.pg_num }}\u0027, \u0027rule_name\u0027: \u0027replicated_rule\u0027,"},{"line_number":48,"context_line":"                   \u0027application\u0027: \u0027openstack_gnocchi\u0027}]"},{"line_number":49,"context_line":"      when:"},{"line_number":50,"context_line":"        - tripleo_pool_metrics"},{"line_number":51,"context_line":"        - enabled_services | intersect([\u0027gnocchi_api\u0027])"},{"line_number":52,"context_line":"        - ceph_pools.gnocchi_pool.name not in overrides|default([])"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    - name: add cinder backup pool"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1fa4df85_7e073e1a","line":51,"range":{"start_line":50,"start_character":0,"end_line":51,"end_character":55},"in_reply_to":"1fa4df85_29e2f702","updated":"2020-03-12 09:09:56.000000000","message":"In theory, we should remove this check here, because we already have the \"enabled\" flag produced by tht (same way of the other services).\nThis check here can just reinforce the fact we need to enable the pool and the service should be active.\nTo make things easier for us, I suggest to remove this condition.\nwdyt?","commit_id":"03ff94ab368c2b43a03d76a9bff1e0e042a7c650"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"4a371576273f5c96a2c3e72ce9233256df01de14","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        cephfs_metadata: {\u0027cephfs_metadata_pool\u0027: {\u0027name\u0027: \u0027{{ manila_pools.metadata }}\u0027, \u0027pg_num\u0027: \u0027{{ manila_pools.metadata_pg_num }}\u0027,"},{"line_number":89,"context_line":"                                                   \u0027rule_name\u0027: \u0027replicated_rule\u0027, \u0027application\u0027: \u0027cephfs\u0027}}"},{"line_number":90,"context_line":"  when:"},{"line_number":91,"context_line":"    - enabled_services | intersect([\u0027manila_api\u0027])"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1fa4df85_2a098530","line":91,"range":{"start_line":91,"start_character":6,"end_line":91,"end_character":50},"updated":"2020-03-12 09:09:56.000000000","message":"that\u0027s interesting but according to scenario004 (it should have manila_api), no cephfs and cephfs_metadata are created.\nFor some reasons it doesn\u0027t work.\nLet\u0027s dig more into a safe solution to process the list of enabled_services.","commit_id":"03ff94ab368c2b43a03d76a9bff1e0e042a7c650"}],"tripleo_ansible/roles/tripleo_ceph_work_dir/tasks/prepare.yml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"d15394138d96ced51fb2a8e1bcd7e137a32b126f","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- name: gather enabled_services list from hiera metadata"},{"line_number":43,"context_line":"  set_fact:"},{"line_number":44,"context_line":"    enabled_services: (lookup(\u0027file\u0027, \u0027/etc/puppet/hieradata/all_nodes.json\u0027)|from_json).get(\u0027enabled_services\u0027)|list"},{"line_number":45,"context_line":"  become: true"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: build the openstack pool list"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1fa4df85_c95243df","line":44,"range":{"start_line":44,"start_character":51,"end_line":44,"end_character":60},"updated":"2020-03-12 00:19:27.000000000","message":"This role is only run against the undercloud.\n\nDo we want to be looking at the hiera data on the undercloud?","commit_id":"03ff94ab368c2b43a03d76a9bff1e0e042a7c650"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"841fbc0748378f614d10f4ba2855bf7b6a671452","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- name: gather enabled_services list from hiera metadata"},{"line_number":43,"context_line":"  set_fact:"},{"line_number":44,"context_line":"    enabled_services: (lookup(\u0027file\u0027, \u0027/etc/puppet/hieradata/all_nodes.json\u0027)|from_json).get(\u0027enabled_services\u0027)|list"},{"line_number":45,"context_line":"  become: true"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: build the openstack pool list"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1fa4df85_1e9aca6d","line":44,"range":{"start_line":44,"start_character":51,"end_line":44,"end_character":60},"in_reply_to":"1fa4df85_7e55fef9","updated":"2020-03-12 09:33:26.000000000","message":"P.S. I think this should be:\n\n\"{{ enabled_services: (lookup(\u0027file\u0027, \u0027/etc/puppet/hieradata/all_nodes.json\u0027)|from_json).get(\u0027enabled_services\u0027)|list }}\"","commit_id":"03ff94ab368c2b43a03d76a9bff1e0e042a7c650"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"72107d0bde7fb87769e254733bb906b13dcdaaea","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- name: gather enabled_services list from hiera metadata"},{"line_number":43,"context_line":"  set_fact:"},{"line_number":44,"context_line":"    enabled_services: (lookup(\u0027file\u0027, \u0027/etc/puppet/hieradata/all_nodes.json\u0027)|from_json).get(\u0027enabled_services\u0027)|list"},{"line_number":45,"context_line":"  become: true"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: build the openstack pool list"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1fa4df85_d41df373","line":44,"range":{"start_line":44,"start_character":51,"end_line":44,"end_character":60},"in_reply_to":"1fa4df85_7e55fef9","updated":"2020-03-12 11:55:41.000000000","message":"Yes, we need a new approach. Let\u0027s revert the original patches and start over. I\u0027ll abandon this fix too.","commit_id":"03ff94ab368c2b43a03d76a9bff1e0e042a7c650"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"4a371576273f5c96a2c3e72ce9233256df01de14","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- name: gather enabled_services list from hiera metadata"},{"line_number":43,"context_line":"  set_fact:"},{"line_number":44,"context_line":"    enabled_services: (lookup(\u0027file\u0027, \u0027/etc/puppet/hieradata/all_nodes.json\u0027)|from_json).get(\u0027enabled_services\u0027)|list"},{"line_number":45,"context_line":"  become: true"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: build the openstack pool list"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1fa4df85_7e55fef9","line":44,"range":{"start_line":44,"start_character":51,"end_line":44,"end_character":60},"in_reply_to":"1fa4df85_c95243df","updated":"2020-03-12 09:09:56.000000000","message":"We can easily solve the array issue we had for this bug, but imho the main issue is here! You\u0027re right, we need to query all_nodes.json on the overcloud, and here it works because it\u0027s a standalone deployment!!!\nMy question is: how can we do that according to the tripleo logic?","commit_id":"03ff94ab368c2b43a03d76a9bff1e0e042a7c650"}]}