)]}'
{"tripleo_ansible/ansible_plugins/modules/tripleo_swift_tempurl.py":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"1578799e281f7e6e6ea9ffa0c3742b869be376c6","unresolved":false,"context_lines":[{"line_number":31,"context_line":"#       tripleo-common expects the legacy clients. Once"},{"line_number":32,"context_line":"#       we\u0027ve updated tripleo-common to use the SDK we"},{"line_number":33,"context_line":"#       should revise this."},{"line_number":34,"context_line":"import swiftclient"},{"line_number":35,"context_line":"from tripleo_common.utils import swift as swift_utils"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"ANSIBLE_METADATA \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"1fa4df85_b42a89e4","line":34,"updated":"2020-03-16 13:36:46.000000000","message":"this seems ok given its used in tripleo-common which expects the legacy clients: https://review.opendev.org/#/c/712899/5/tripleo_ansible/ansible_plugins/modules/tripleo_swift_tempurl.py@126","commit_id":"9982cb90ad9afa247860247c14a2ec810fd4aaa2"},{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"778f1dd7d5fa589c6d0ed5d6f8c7909c5a90b585","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/python"},{"line_number":2,"context_line":"# -*- coding: utf-8 -*-"},{"line_number":3,"context_line":"# Copyright (c) 2018 OpenStack Foundation"},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":9,"id":"1fa4df85_01e9b818","line":1,"updated":"2020-03-18 13:54:11.000000000","message":"This module is generic enough that it could be part of our ansible-collections-openstack. Where possible, I\u0027d love for us to have content in a more shared location used by the broader community. https://opendev.org/openstack/ansible-collections-openstack","commit_id":"b096945a28637113bb7ad04218c093c6293a91df"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"544c609ddfc84245f10134b59aaa55b2b7b2769b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/python"},{"line_number":2,"context_line":"# -*- coding: utf-8 -*-"},{"line_number":3,"context_line":"# Copyright (c) 2018 OpenStack Foundation"},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":9,"id":"1fa4df85_273ac497","line":1,"in_reply_to":"1fa4df85_01e9b818","updated":"2020-03-18 15:20:44.000000000","message":"This still uses code tripleo-common which can\u0027t be a dependency when made available to a broader community. Also, it uses custom logic of keeping the \u0027key\u0027 used to create tempurl in container header, which is very specific to tripleo.","commit_id":"b096945a28637113bb7ad04218c093c6293a91df"},{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"778f1dd7d5fa589c6d0ed5d6f8c7909c5a90b585","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"EXAMPLES \u003d \u0027\u0027\u0027"},{"line_number":76,"context_line":"- name: Get tempurl for swit backup"},{"line_number":77,"context_line":"  tripleo_fernet_keys_rotate:"},{"line_number":78,"context_line":"      container: overcloud-swift-rings"},{"line_number":79,"context_line":"      object: swift-rings.tar.gz"},{"line_number":80,"context_line":"      method: GET"}],"source_content_type":"text/x-python","patch_set":9,"id":"1fa4df85_219e34b8","line":77,"updated":"2020-03-18 13:54:11.000000000","message":"Is this example supposed to mention tripleo_fernet_keys_rotate?","commit_id":"b096945a28637113bb7ad04218c093c6293a91df"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"544c609ddfc84245f10134b59aaa55b2b7b2769b","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"EXAMPLES \u003d \u0027\u0027\u0027"},{"line_number":76,"context_line":"- name: Get tempurl for swit backup"},{"line_number":77,"context_line":"  tripleo_fernet_keys_rotate:"},{"line_number":78,"context_line":"      container: overcloud-swift-rings"},{"line_number":79,"context_line":"      object: swift-rings.tar.gz"},{"line_number":80,"context_line":"      method: GET"}],"source_content_type":"text/x-python","patch_set":9,"id":"1fa4df85_874a9824","line":77,"in_reply_to":"1fa4df85_219e34b8","updated":"2020-03-18 15:20:44.000000000","message":"Thanks for noticing that. copypasta:/","commit_id":"b096945a28637113bb7ad04218c093c6293a91df"}],"tripleo_ansible/playbooks/cli-update-deployment-plan.yaml":[{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"907a5517d4c20bc171633db5fd30838b7f5d6b82","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    validate_stack: true"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  handlers:"},{"line_number":30,"context_line":"    - name: Cleanup temp directory"},{"line_number":31,"context_line":"      file:"},{"line_number":32,"context_line":"        path: \"{{ temp_dir.path }}\""},{"line_number":33,"context_line":"        state: absent"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1fa4df85_0078f228","line":30,"updated":"2020-03-16 22:02:02.000000000","message":"Do we want to add a default temp_dir.path and/or ignore_errors here?","commit_id":"9982cb90ad9afa247860247c14a2ec810fd4aaa2"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"8891c325a0feac044af25621afe0314f35acdd95","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    validate_stack: true"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  handlers:"},{"line_number":30,"context_line":"    - name: Cleanup temp directory"},{"line_number":31,"context_line":"      file:"},{"line_number":32,"context_line":"        path: \"{{ temp_dir.path }}\""},{"line_number":33,"context_line":"        state: absent"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1fa4df85_9120b2f9","line":30,"in_reply_to":"1fa4df85_0078f228","updated":"2020-03-17 04:23:06.000000000","message":"Not sure why that would be required, it\u0027s only called when temp_dir is defined (i.e L43) right?","commit_id":"9982cb90ad9afa247860247c14a2ec810fd4aaa2"}]}