)]}'
{"tripleo_ansible/ansible_plugins/action/podman_containers.py":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"d81fa80222cfab86ee1f94d43bc3ab874d78fb15","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        if skipped:"},{"line_number":65,"context_line":"            return {\u0027results\u0027: results, \u0027changed\u0027: False, \u0027skipped\u0027: skipped}"},{"line_number":66,"context_line":"        if failed:"},{"line_number":67,"context_line":"            msg \u003d \"\\n\".join([i.get(\u0027msg\u0027, \u0027\u0027) for i in results])"},{"line_number":68,"context_line":"            return {\u0027results\u0027: results,"},{"line_number":69,"context_line":"                    \u0027changed\u0027: changed,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_81ffe232","line":66,"range":{"start_line":66,"start_character":8,"end_line":66,"end_character":10},"updated":"2020-07-30 20:59:04.000000000","message":"elif","commit_id":"f97d727c3d4ec504a841db8f8a8263632d777e5a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c7ea14aa72a5a6d5bec8298fec21e67e6f43729b","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        if skipped:"},{"line_number":65,"context_line":"            return {\u0027results\u0027: results, \u0027changed\u0027: False, \u0027skipped\u0027: skipped}"},{"line_number":66,"context_line":"        if failed:"},{"line_number":67,"context_line":"            msg \u003d \"\\n\".join([i.get(\u0027msg\u0027, \u0027\u0027) for i in results])"},{"line_number":68,"context_line":"            return {\u0027results\u0027: results,"},{"line_number":69,"context_line":"                    \u0027changed\u0027: changed,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_90555c20","line":66,"range":{"start_line":66,"start_character":8,"end_line":66,"end_character":10},"in_reply_to":"9f560f44_81ffe232","updated":"2020-07-31 12:17:44.000000000","message":"the elif doesn\u0027t matter much, since there is a return right before. if or elif, we\u0027ll never reach it if previously we returned.","commit_id":"f97d727c3d4ec504a841db8f8a8263632d777e5a"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"d81fa80222cfab86ee1f94d43bc3ab874d78fb15","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                    \u0027changed\u0027: changed,"},{"line_number":70,"context_line":"                    \u0027failed\u0027: failed,"},{"line_number":71,"context_line":"                    \u0027msg\u0027: msg}"},{"line_number":72,"context_line":"        if not wrap_async:"},{"line_number":73,"context_line":"            # remove a temporary path we created"},{"line_number":74,"context_line":"            self._remove_tmp_path(self._connection._shell.tmpdir)"},{"line_number":75,"context_line":"        return {\u0027results\u0027: results,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_e1fe9e35","line":72,"range":{"start_line":72,"start_character":8,"end_line":72,"end_character":10},"updated":"2020-07-30 20:59:04.000000000","message":"elif","commit_id":"f97d727c3d4ec504a841db8f8a8263632d777e5a"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"d81fa80222cfab86ee1f94d43bc3ab874d78fb15","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                    \u0027msg\u0027: msg}"},{"line_number":72,"context_line":"        if not wrap_async:"},{"line_number":73,"context_line":"            # remove a temporary path we created"},{"line_number":74,"context_line":"            self._remove_tmp_path(self._connection._shell.tmpdir)"},{"line_number":75,"context_line":"        return {\u0027results\u0027: results,"},{"line_number":76,"context_line":"                \u0027changed\u0027: changed,"},{"line_number":77,"context_line":"                \u0027failed\u0027: False,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_c18eface","line":74,"range":{"start_line":74,"start_character":12,"end_line":74,"end_character":16},"updated":"2020-07-30 20:59:04.000000000","message":"Could we do try/finally: around this if block.","commit_id":"f97d727c3d4ec504a841db8f8a8263632d777e5a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c7ea14aa72a5a6d5bec8298fec21e67e6f43729b","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                    \u0027msg\u0027: msg}"},{"line_number":72,"context_line":"        if not wrap_async:"},{"line_number":73,"context_line":"            # remove a temporary path we created"},{"line_number":74,"context_line":"            self._remove_tmp_path(self._connection._shell.tmpdir)"},{"line_number":75,"context_line":"        return {\u0027results\u0027: results,"},{"line_number":76,"context_line":"                \u0027changed\u0027: changed,"},{"line_number":77,"context_line":"                \u0027failed\u0027: False,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_d034f4fd","line":74,"range":{"start_line":74,"start_character":12,"end_line":74,"end_character":16},"in_reply_to":"9f560f44_c18eface","updated":"2020-07-31 12:17:44.000000000","message":"yes I agree","commit_id":"f97d727c3d4ec504a841db8f8a8263632d777e5a"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"d81fa80222cfab86ee1f94d43bc3ab874d78fb15","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        if not wrap_async:"},{"line_number":73,"context_line":"            # remove a temporary path we created"},{"line_number":74,"context_line":"            self._remove_tmp_path(self._connection._shell.tmpdir)"},{"line_number":75,"context_line":"        return {\u0027results\u0027: results,"},{"line_number":76,"context_line":"                \u0027changed\u0027: changed,"},{"line_number":77,"context_line":"                \u0027failed\u0027: False,"},{"line_number":78,"context_line":"                \u0027msg\u0027: \u0027All items completed\u0027}"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_c1f9da4d","line":75,"range":{"start_line":75,"start_character":8,"end_line":75,"end_character":14},"updated":"2020-07-30 20:59:04.000000000","message":"I think this can be under an else:","commit_id":"f97d727c3d4ec504a841db8f8a8263632d777e5a"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c7ea14aa72a5a6d5bec8298fec21e67e6f43729b","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        if not wrap_async:"},{"line_number":73,"context_line":"            # remove a temporary path we created"},{"line_number":74,"context_line":"            self._remove_tmp_path(self._connection._shell.tmpdir)"},{"line_number":75,"context_line":"        return {\u0027results\u0027: results,"},{"line_number":76,"context_line":"                \u0027changed\u0027: changed,"},{"line_number":77,"context_line":"                \u0027failed\u0027: False,"},{"line_number":78,"context_line":"                \u0027msg\u0027: \u0027All items completed\u0027}"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_103f8cd6","line":75,"range":{"start_line":75,"start_character":8,"end_line":75,"end_character":14},"in_reply_to":"9f560f44_c1f9da4d","updated":"2020-07-31 12:17:44.000000000","message":"no need else, since we have return.","commit_id":"f97d727c3d4ec504a841db8f8a8263632d777e5a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"fc4b62d6f91bf80ee78571d2731d8841f1dcf027","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        DISPLAY.vvvv(\u0027Running for containers: %s\u0027 % str(containers))"},{"line_number":52,"context_line":"        wrap_async \u003d self._task.async_val and ("},{"line_number":53,"context_line":"            not self._connection.has_native_async)"},{"line_number":54,"context_line":"        results \u003d [self._execute_module("},{"line_number":55,"context_line":"            module_name\u003d\u0027podman_container\u0027,"},{"line_number":56,"context_line":"            module_args\u003dcontainer,"},{"line_number":57,"context_line":"            task_vars\u003dtask_vars, wrap_async\u003dwrap_async"},{"line_number":58,"context_line":"        ) for container in containers]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        changed \u003d any([i.get(\u0027changed\u0027) for i in results])"},{"line_number":61,"context_line":"        skipped \u003d all([i.get(\u0027skipped\u0027, False) for i in results])"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_3020b948","line":58,"range":{"start_line":54,"start_character":0,"end_line":58,"end_character":38},"updated":"2020-08-03 08:08:36.000000000","message":"Does such a simple thing as calling a module in a loop *really* require an action plugin? Is that the traditional way of calling it via standard yaml format is unacceptible for TripleO? What is the ultimate goal of that approach? Is it leave only action plugins in the roles and playbooks? Wrap all things with custom python? I\u0027m sorry, I can\u0027t get the point here.","commit_id":"da1c62b4591753f32aaaf19cf673296cb0673343"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"58d334005be7f3caa67a54a96e8be765ab0628ec","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            task_vars\u003dtask_vars, wrap_async\u003dwrap_async"},{"line_number":58,"context_line":"        ) for container in containers]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        changed \u003d any([i.get(\u0027changed\u0027) for i in results])"},{"line_number":61,"context_line":"        skipped \u003d all([i.get(\u0027skipped\u0027, False) for i in results])"},{"line_number":62,"context_line":"        failed \u003d any([i.get(\u0027failed\u0027, False) for i in results])"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_b34b4a57","line":60,"updated":"2020-07-31 12:23:31.000000000","message":"if nothing changed, please default to False, just like the case when nothing failed","commit_id":"da1c62b4591753f32aaaf19cf673296cb0673343"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"dde9ca1fad3a1f7cc5e6558e6b3d99c7bed370ac","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            task_vars\u003dtask_vars, wrap_async\u003dwrap_async"},{"line_number":58,"context_line":"        ) for container in containers]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        changed \u003d any([i.get(\u0027changed\u0027) for i in results])"},{"line_number":61,"context_line":"        skipped \u003d all([i.get(\u0027skipped\u0027, False) for i in results])"},{"line_number":62,"context_line":"        failed \u003d any([i.get(\u0027failed\u0027, False) for i in results])"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_935f260d","line":60,"in_reply_to":"9f560f44_b34b4a57","updated":"2020-07-31 12:25:29.000000000","message":"changed will be reported for every container, so it\u0027s calculated from all containers statuses\nwhy should we have default?","commit_id":"da1c62b4591753f32aaaf19cf673296cb0673343"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"21960ec31f8a2d7e3423c34cfb6fd9edaeb52b04","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        skipped \u003d all([i.get(\u0027skipped\u0027, False) for i in results])"},{"line_number":62,"context_line":"        failed \u003d any([i.get(\u0027failed\u0027, False) for i in results])"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        try:"},{"line_number":65,"context_line":"            # remove a temporary path we created"},{"line_number":66,"context_line":"            self._remove_tmp_path(self._connection._shell.tmpdir)"},{"line_number":67,"context_line":"        except Exception:"},{"line_number":68,"context_line":"            pass"},{"line_number":69,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_7341b239","line":66,"range":{"start_line":64,"start_character":8,"end_line":66,"end_character":65},"updated":"2020-07-31 12:23:07.000000000","message":"I think we still might need \u0027if not wrap_async\u0027","commit_id":"da1c62b4591753f32aaaf19cf673296cb0673343"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"9bf0d201dde741b47715a6784defd93d5bdcf928","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            return {\u0027results\u0027: results,"},{"line_number":81,"context_line":"                    \u0027changed\u0027: changed,"},{"line_number":82,"context_line":"                    \u0027failed\u0027: False,"},{"line_number":83,"context_line":"                    \u0027msg\u0027: \u0027All items completed\u0027}"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f560f44_530e2e32","line":83,"updated":"2020-07-31 12:19:52.000000000","message":"note, we don\u0027t need elif/else here because we return in the conditions, so it\u0027s pointless to use it.","commit_id":"da1c62b4591753f32aaaf19cf673296cb0673343"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"3a069ff0a75be75bc22731dccb7ecdc37fe83beb","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            task_vars\u003dtask_vars, wrap_async\u003dwrap_async"},{"line_number":58,"context_line":"        ) for container in containers]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        changed \u003d any([i.get(\u0027changed\u0027, False) for i in results])"},{"line_number":61,"context_line":"        skipped \u003d all([i.get(\u0027skipped\u0027, False) for i in results])"},{"line_number":62,"context_line":"        failed \u003d any([i.get(\u0027failed\u0027, False) for i in results])"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_b3222aff","line":60,"range":{"start_line":60,"start_character":40,"end_line":60,"end_character":45},"updated":"2020-07-31 12:57:08.000000000","message":"by default it\u0027s None, which is also \u0027False\u0027, but ok..","commit_id":"86f1746120ba35a9506177bfa6f3fff5dd9e007b"}]}