)]}'
{"tripleo_ansible/roles/tripleo-container-rm/tasks/tripleo_podman_container_rm.yml":[{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"1b01db26bf90283655a2ef5e8fbf829e26477b6c","unresolved":false,"context_lines":[{"line_number":85,"context_line":"  register: stat_container"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"- name: Stop and remove container"},{"line_number":88,"context_line":"  command: \"podman container rm --force {{ container }}\""},{"line_number":89,"context_line":"  changed_when: true"},{"line_number":90,"context_line":"  retries: \"{{ tripleo_container_rm_podman_retries }}\""},{"line_number":91,"context_line":"  delay: 5"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f493fa4_bf1a1414","line":88,"updated":"2020-05-06 06:17:25.000000000","message":"Bogdan is right. We worked on similar bug in paunch. There is a race during delete operation. \"force\" removes container while device is still present.\n\nThe pattern that worked is \n\npodman container stop \u0026\u0026 podman container rm  || podman container rm --force","commit_id":"14e1a82ec0116d7874f697e76d9efd6f578d546c"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"1464ad6a0795716ee1525323e9a101820507f512","unresolved":false,"context_lines":[{"line_number":85,"context_line":"  register: stat_container"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"- name: Stop and remove container"},{"line_number":88,"context_line":"  command: \"podman container rm --force {{ container }}\""},{"line_number":89,"context_line":"  changed_when: true"},{"line_number":90,"context_line":"  retries: \"{{ tripleo_container_rm_podman_retries }}\""},{"line_number":91,"context_line":"  delay: 5"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f493fa4_bf76943d","line":88,"in_reply_to":"1f493fa4_bf1a1414","updated":"2020-05-06 06:36:23.000000000","message":"the \"stop\" is supposed to be managed by systemd... or shall we re-add a stop here? but with the \u0026\u0026, it will probably fail and won\u0027t hit the \"podman rm\" and directly go to the \"rm --force\"\nWe can\u0027t 100% mimic what was in paunch :/. \"retries\" can\u0027t be applied to a block, which would allow to mimic the whole thing","commit_id":"14e1a82ec0116d7874f697e76d9efd6f578d546c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"106cbfc90a2242e10b1242dfbae124088e0cd655","unresolved":false,"context_lines":[{"line_number":87,"context_line":"- name: Stop and remove container"},{"line_number":88,"context_line":"  command: \"podman container rm --force {{ container }}\""},{"line_number":89,"context_line":"  changed_when: true"},{"line_number":90,"context_line":"  retries: \"{{ tripleo_container_rm_podman_retries }}\""},{"line_number":91,"context_line":"  delay: 5"},{"line_number":92,"context_line":"  when:"},{"line_number":93,"context_line":"    - stat_container.rc is defined"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f493fa4_d229e9f2","line":90,"updated":"2020-05-05 12:47:02.000000000","message":"to follow the paunch\u0027s pattern, it should retry a three-step action: podman container stop \u0026\u0026 rm || rm -f","commit_id":"14e1a82ec0116d7874f697e76d9efd6f578d546c"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"e6cd082a68014000ed2a3c70701c39a87795495f","unresolved":false,"context_lines":[{"line_number":88,"context_line":"  when:"},{"line_number":89,"context_line":"    - stat_container.rc is defined"},{"line_number":90,"context_line":"    - stat_container.rc \u003d\u003d 0"},{"line_number":91,"context_line":"  block:"},{"line_number":92,"context_line":"    - name: No forcing"},{"line_number":93,"context_line":"      block:"},{"line_number":94,"context_line":"        - name: Nice way to stop and remove container"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f493fa4_5fc79046","line":91,"updated":"2020-05-06 06:41:09.000000000","message":"that\u0027s the closer we can get to what paunch did - at least with my current knowledge. Feel free to propose a modification.\n\nA patch using this change is here:\nhttps://review.opendev.org/725545","commit_id":"bca0867c9b2c0a050640aeb8d6499eecaeafa93d"}]}
