)]}'
{"tripleo_ansible/roles/backup_and_restore/molecule/default/prepare.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"4d13b1e6d980b03df1de498ec548b5366b951698","unresolved":false,"context_lines":[{"line_number":36,"context_line":"      selinux:"},{"line_number":37,"context_line":"        state: disabled"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    - name: clone tripleo-repos"},{"line_number":40,"context_line":"      git:"},{"line_number":41,"context_line":"        repo: https://github.com/openstack/tripleo-repos.git"},{"line_number":42,"context_line":"        dest: tripleo-repos/"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_0a6ef92d","line":39,"range":{"start_line":39,"start_character":12,"end_line":39,"end_character":17},"updated":"2020-06-24 06:43:19.000000000","message":"should you be using the test_deps_setup_tripleo here too * for that - seems to be what it does (setup tripleo-repos) see \nhttps://opendev.org/openstack/tripleo-ansible/src/commit/b36a5dd65109db3f81a2b781bafb3ff909e5632d/tripleo_ansible/roles/test_deps/tasks/main.yml#L66-L69\n\n* like you have at https://review.opendev.org/#/c/735628/3/tripleo_ansible/roles/backup_and_restore/molecule/default/prepare.yml","commit_id":"999f5198807387d84ac03ec273fe46b839e0df50"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"835b4905b3444d36e32808eabd130550789838a6","unresolved":false,"context_lines":[{"line_number":36,"context_line":"      selinux:"},{"line_number":37,"context_line":"        state: disabled"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    - name: clone tripleo-repos"},{"line_number":40,"context_line":"      git:"},{"line_number":41,"context_line":"        repo: https://github.com/openstack/tripleo-repos.git"},{"line_number":42,"context_line":"        dest: tripleo-repos/"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_8ac84922","line":39,"range":{"start_line":39,"start_character":12,"end_line":39,"end_character":17},"in_reply_to":"bf51134e_0a6ef92d","updated":"2020-06-24 06:48:14.000000000","message":"yeah, that\u0027s a previous attempt. \nThe worst is that it didn\u0027t work. :(","commit_id":"999f5198807387d84ac03ec273fe46b839e0df50"}],"tripleo_ansible/roles/backup_and_restore/tasks/ceph_authentication.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"8ad545d21ecaafeac740de073959947319517898","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  tags:"},{"line_number":33,"context_line":"    - always"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: Export ceph authentication"},{"line_number":36,"context_line":"  shell: |"},{"line_number":37,"context_line":"    set -o pipefail"},{"line_number":38,"context_line":"    {{ tripleo_container_cli }} exec ceph-mon-{{ ansible_hostname }} bash -c \"ceph auth export\" \u003e {{ tripleo_backup_and_restore_ceph_auth_file }}"},{"line_number":39,"context_line":"  become: true"},{"line_number":40,"context_line":"  tags:"},{"line_number":41,"context_line":"    - bar_create_recover_image"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_98469521","line":41,"range":{"start_line":35,"start_character":0,"end_line":41,"end_character":30},"updated":"2020-06-12 23:30:35.000000000","message":"I wonder if we can do this in a more ansible centric way, something like running this command, capturing the stdout in a register, and then using the copy module with content to generate the file?\n\nIn that way we might be able to make this process idempotent.","commit_id":"ad3af91b4892ff3eba7cc59e44f4e1f69ebccfb4"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"bbf52c13630914915a362df7d3854f7f7d6c8609","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  tags:"},{"line_number":33,"context_line":"    - always"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: Export ceph authentication"},{"line_number":36,"context_line":"  shell: |"},{"line_number":37,"context_line":"    set -o pipefail"},{"line_number":38,"context_line":"    {{ tripleo_container_cli }} exec ceph-mon-{{ ansible_hostname }} bash -c \"ceph auth export\" \u003e {{ tripleo_backup_and_restore_ceph_auth_file }}"},{"line_number":39,"context_line":"  become: true"},{"line_number":40,"context_line":"  tags:"},{"line_number":41,"context_line":"    - bar_create_recover_image"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf51134e_df262c17","line":41,"range":{"start_line":35,"start_character":0,"end_line":41,"end_character":30},"in_reply_to":"bf51134e_98469521","updated":"2020-06-15 07:25:20.000000000","message":"ok but bear in mind this is a cherrypick. That sounds like an improvement that can/should also be on master so I think you should merge this first then improve on master as a new review and cherrypick that too.","commit_id":"ad3af91b4892ff3eba7cc59e44f4e1f69ebccfb4"}]}