)]}'
{"tripleo_ansible/ansible_plugins/modules/metalsmith_instances.py":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"c3ac57c97942dbf8f93c76310a82e99d47b3cb54","unresolved":false,"context_lines":[{"line_number":189,"context_line":"      - If set to true, the \u0027logging\u0027 result will have the logging"},{"line_number":190,"context_line":"        level will be set to DEBUG instead of the default INFO level."},{"line_number":191,"context_line":"    type: bool"},{"line_number":192,"context_line":"    default: no"},{"line_number":193,"context_line":"\u0027\u0027\u0027"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_4bf0f391","line":192,"updated":"2020-07-13 09:57:08.000000000","message":"I think we shouldn\u0027t use \"yes\" or \"no\" here and use the real bool, \"true\" or, in this case, \"false\".","commit_id":"9770190e62e4432d193467ed4fa267b484d8e04c"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"a680bc9f13eff9dde11c93a9c0d20649bad8e1c4","unresolved":false,"context_lines":[{"line_number":189,"context_line":"      - If set to true, the \u0027logging\u0027 result will have the logging"},{"line_number":190,"context_line":"        level will be set to DEBUG instead of the default INFO level."},{"line_number":191,"context_line":"    type: bool"},{"line_number":192,"context_line":"    default: no"},{"line_number":193,"context_line":"\u0027\u0027\u0027"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_16b9f477","line":192,"in_reply_to":"bf51134e_4bf0f391","updated":"2020-07-13 20:34:13.000000000","message":"Agreed, but I kept the convention of the rest of the boolean defaults.","commit_id":"9770190e62e4432d193467ed4fa267b484d8e04c"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"817f77f1cde326ed8e3d417a8104a536df66c411","unresolved":false,"context_lines":[{"line_number":184,"context_line":"      - Maximum number of instances to provision at once. Set to 0 to have no"},{"line_number":185,"context_line":"        concurrency limit"},{"line_number":186,"context_line":"    type: int"},{"line_number":187,"context_line":"  log_debug:"},{"line_number":188,"context_line":"    description:"},{"line_number":189,"context_line":"      - If set to true, the \u0027logging\u0027 result will have the logging"},{"line_number":190,"context_line":"        level will be set to DEBUG instead of the default INFO level."},{"line_number":191,"context_line":"    type: bool"},{"line_number":192,"context_line":"    default: no"},{"line_number":193,"context_line":"\u0027\u0027\u0027"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_24b96278","line":192,"range":{"start_line":187,"start_character":0,"end_line":192,"end_character":15},"updated":"2020-07-13 23:04:28.000000000","message":"if we use logging module here, much better would be configuration of desired log level:\n\nlog_level:\n ...\n default: info\n choices:\n  - debug\n  - info\n  - warning\n  - error","commit_id":"0e8862064e23bf74bd06c75fa70230ab519b545c"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f783650ba6857036974a589f293d0ba7e83b1672","unresolved":false,"context_lines":[{"line_number":184,"context_line":"      - Maximum number of instances to provision at once. Set to 0 to have no"},{"line_number":185,"context_line":"        concurrency limit"},{"line_number":186,"context_line":"    type: int"},{"line_number":187,"context_line":"  log_debug:"},{"line_number":188,"context_line":"    description:"},{"line_number":189,"context_line":"      - If set to true, the \u0027logging\u0027 result will have the logging"},{"line_number":190,"context_line":"        level will be set to DEBUG instead of the default INFO level."},{"line_number":191,"context_line":"    type: bool"},{"line_number":192,"context_line":"    default: no"},{"line_number":193,"context_line":"\u0027\u0027\u0027"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_1c8583ad","line":192,"range":{"start_line":187,"start_character":0,"end_line":192,"end_character":15},"in_reply_to":"bf51134e_24b96278","updated":"2020-07-14 21:38:33.000000000","message":"This was a partial attempt at CLI style logging (--debug, --verbose, -vv, -vvv) but I think log_level will be better.","commit_id":"0e8862064e23bf74bd06c75fa70230ab519b545c"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"817f77f1cde326ed8e3d417a8104a536df66c411","unresolved":false,"context_lines":[{"line_number":324,"context_line":"    metalsmith_level \u003d base_level"},{"line_number":325,"context_line":"    urllib_level \u003d logging.CRITICAL"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    if debug:"},{"line_number":328,"context_line":"        base_level \u003d logging.INFO"},{"line_number":329,"context_line":"        metalsmith_level \u003d logging.DEBUG"},{"line_number":330,"context_line":"    else:"},{"line_number":331,"context_line":"        base_level \u003d logging.WARNING"},{"line_number":332,"context_line":"        metalsmith_level \u003d logging.INFO"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    logging.basicConfig(level\u003dbase_level, format\u003dlog_fmt)"},{"line_number":335,"context_line":"    logging.getLogger(\u0027urllib3.connectionpool\u0027).setLevel(urllib_level)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_c4a98624","line":332,"range":{"start_line":327,"start_character":0,"end_line":332,"end_character":39},"updated":"2020-07-13 23:04:28.000000000","message":"log_level","commit_id":"0e8862064e23bf74bd06c75fa70230ab519b545c"}],"tripleo_ansible/playbooks/cli-overcloud-node-provision.yaml":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"c3ac57c97942dbf8f93c76310a82e99d47b3cb54","unresolved":false,"context_lines":[{"line_number":99,"context_line":"      metalsmith_instances:"},{"line_number":100,"context_line":"        instances: \"{{ baremetal_existing.not_found }}\""},{"line_number":101,"context_line":"        state: reserved"},{"line_number":102,"context_line":"        clean_up: true"},{"line_number":103,"context_line":"      register: baremetal_reserved"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    - name: Metalsmith log for reserve instances"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_2bd49fe8","line":102,"updated":"2020-07-13 09:57:08.000000000","message":"hmmm shouldn\u0027t a new param be put there? \"log_debug: true\" or something?","commit_id":"9770190e62e4432d193467ed4fa267b484d8e04c"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"a680bc9f13eff9dde11c93a9c0d20649bad8e1c4","unresolved":false,"context_lines":[{"line_number":99,"context_line":"      metalsmith_instances:"},{"line_number":100,"context_line":"        instances: \"{{ baremetal_existing.not_found }}\""},{"line_number":101,"context_line":"        state: reserved"},{"line_number":102,"context_line":"        clean_up: true"},{"line_number":103,"context_line":"      register: baremetal_reserved"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    - name: Metalsmith log for reserve instances"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_56736ce7","line":102,"in_reply_to":"bf51134e_2bd49fe8","updated":"2020-07-13 20:34:13.000000000","message":"The default false will log at INFO level which is probably fine, log_debug:true would be useful for developing the module.","commit_id":"9770190e62e4432d193467ed4fa267b484d8e04c"}]}