)]}'
{"tripleo_ansible/ansible_plugins/modules/tripleo_ovs_upgrade.py":[{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"448e4f0637cd4b2b9c00a22c4d75fbe88ec39b46","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"def set_openflow_version_on_bridges(module, bridges\u003d[\u0027br-int\u0027]):"},{"line_number":158,"context_line":"    for brige in bridges:"},{"line_number":159,"context_line":"        cmd \u003d [\u0027ovs-vsctl\u0027, \u0027set\u0027, \u0027bridge\u0027, bridge,"},{"line_number":160,"context_line":"               \u0027protocols\u003dOpenFlow13,OpenFlow15\u0027]"},{"line_number":161,"context_line":"        _, output, _ \u003d module.run_command(cmd, check_rc\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_298cab7d","line":158,"updated":"2020-08-05 14:31:17.000000000","message":"The brige must replace by bridge.","commit_id":"7eefa3d54427eff97bdfd7e4f6782123ba65d07c"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"8e69ea1cfc3709fdf10abe6245561e9dff497f34","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"def set_openflow_version_on_bridges(module, bridges\u003d[\u0027br-int\u0027]):"},{"line_number":158,"context_line":"    for brige in bridges:"},{"line_number":159,"context_line":"        cmd \u003d [\u0027ovs-vsctl\u0027, \u0027set\u0027, \u0027bridge\u0027, bridge,"},{"line_number":160,"context_line":"               \u0027protocols\u003dOpenFlow13,OpenFlow15\u0027]"},{"line_number":161,"context_line":"        _, output, _ \u003d module.run_command(cmd, check_rc\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_7e377700","line":158,"range":{"start_line":158,"start_character":8,"end_line":158,"end_character":13},"updated":"2020-08-05 14:30:34.000000000","message":"bridge","commit_id":"7eefa3d54427eff97bdfd7e4f6782123ba65d07c"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"c5c9a247cc59877d0c82dc993eeef2d13c0ea9b4","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    for bridge in bridges:"},{"line_number":159,"context_line":"        cmd \u003d [\u0027ovs-vsctl\u0027, \u0027set\u0027, \u0027bridge\u0027, bridge,"},{"line_number":160,"context_line":"               \u0027protocols\u003dOpenFlow13,OpenFlow15\u0027]"},{"line_number":161,"context_line":"        _, output, _ \u003d module.run_command(cmd, check_rc\u003dTrue)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"def layer_product_upgrade(module, result, ovs_pkg, lp_ovs_current_version):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_89f1776e","line":161,"range":{"start_line":161,"start_character":47,"end_line":161,"end_character":60},"updated":"2020-08-05 14:50:57.000000000","message":"Check the exception, if the bridge is not there, try the ERROR message but do not fail.","commit_id":"bc07921de380b8ea9f837174e58a0a6bb5f8e8ac"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"3565f80a4a4b0688ebbe7ea6bf1d0b04d7ef94b6","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    for bridge in bridges:"},{"line_number":159,"context_line":"        cmd \u003d [\u0027ovs-vsctl\u0027, \u0027set\u0027, \u0027bridge\u0027, bridge,"},{"line_number":160,"context_line":"               \u0027protocols\u003dOpenFlow13,OpenFlow15\u0027]"},{"line_number":161,"context_line":"        _, output, _ \u003d module.run_command(cmd, check_rc\u003dTrue)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"def layer_product_upgrade(module, result, ovs_pkg, lp_ovs_current_version):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_e98633b9","line":161,"range":{"start_line":161,"start_character":47,"end_line":161,"end_character":60},"in_reply_to":"9f560f44_89f1776e","updated":"2020-08-05 14:52:11.000000000","message":"Exception is:\n\novs-vsctl: no row \"br-inte\" in table Bridge","commit_id":"bc07921de380b8ea9f837174e58a0a6bb5f8e8ac"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"ca959d19b6a303742d4fd267fc299bb816ca66cd","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    if flatten_version(lp_ovs_coming_versions) \\"},{"line_number":175,"context_line":"       !\u003d flatten_version(ovs_current_version):"},{"line_number":176,"context_line":"        # NOTE(mjozefcz): Workaround for bz1863024."},{"line_number":177,"context_line":"        if \"2.11\" in ovs_current_version:"},{"line_number":178,"context_line":"            set_openflow_version_on_bridges(module)"},{"line_number":179,"context_line":"        ovs_pkgs \u003d get_current_ovs_pkg_names(module, pkg_base_name)"},{"line_number":180,"context_line":"        remove_package_noaction(module, ovs_pkgs,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_0a96f54c","line":177,"updated":"2020-08-05 16:51:57.000000000","message":"I\u0027d double check this comparison. IIRC get_version() returns versions in the form [2, 11]","commit_id":"bc07921de380b8ea9f837174e58a0a6bb5f8e8ac"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"5a397ca04a07dae84568f604085b69cf8dc81908","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    if flatten_version(lp_ovs_coming_versions) \\"},{"line_number":175,"context_line":"       !\u003d flatten_version(ovs_current_version):"},{"line_number":176,"context_line":"        # NOTE(mjozefcz): Workaround for bz1863024."},{"line_number":177,"context_line":"        if \"2.11\" in ovs_current_version:"},{"line_number":178,"context_line":"            set_openflow_version_on_bridges(module)"},{"line_number":179,"context_line":"        ovs_pkgs \u003d get_current_ovs_pkg_names(module, pkg_base_name)"},{"line_number":180,"context_line":"        remove_package_noaction(module, ovs_pkgs,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_f233ae12","line":177,"in_reply_to":"9f560f44_0a96f54c","updated":"2020-08-06 08:09:03.000000000","message":"Yeah, I\u0027ll use flatten_version() and compare strings there.","commit_id":"bc07921de380b8ea9f837174e58a0a6bb5f8e8ac"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4f5fe4016d4d22cb65fdf70b4ea3839ee0c262cf","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    return output"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"def set_openflow_version_on_bridges(module, bridges\u003d[\u0027br-int\u0027]):"},{"line_number":159,"context_line":"    for bridge in bridges:"},{"line_number":160,"context_line":"        cmd \u003d [\u0027ovs-vsctl\u0027, \u0027set\u0027, \u0027bridge\u0027, bridge,"},{"line_number":161,"context_line":"               \u0027protocols\u003dOpenFlow13,OpenFlow15\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_83b1464a","line":158,"range":{"start_line":158,"start_character":44,"end_line":158,"end_character":62},"updated":"2020-08-06 10:02:58.000000000","message":"nit: Using mutables as default is an anti-pattern in Python. Better to do:\n\n def set_openflow_version_on_bridges(module, bridges\u003dNone):\n     if bridges is None:\n         bridges \u003d [\u0027br-int\u0027]","commit_id":"96f6db414c3d022629794d6fd6c4f4c546f1d0b7"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"1bfbc551a3f3b2d52c03369c22c034f7ae2f8d51","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    return output"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"def set_openflow_version_on_bridges(module, bridges\u003d[\u0027br-int\u0027]):"},{"line_number":159,"context_line":"    for bridge in bridges:"},{"line_number":160,"context_line":"        cmd \u003d [\u0027ovs-vsctl\u0027, \u0027set\u0027, \u0027bridge\u0027, bridge,"},{"line_number":161,"context_line":"               \u0027protocols\u003dOpenFlow13,OpenFlow15\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_a3ed6ab8","line":158,"range":{"start_line":158,"start_character":44,"end_line":158,"end_character":62},"in_reply_to":"9f560f44_83b1464a","updated":"2020-08-06 10:33:01.000000000","message":"Done","commit_id":"96f6db414c3d022629794d6fd6c4f4c546f1d0b7"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"41c63ecc310808935a41d4b82380cebaf234e2e3","unresolved":false,"context_lines":[{"line_number":179,"context_line":"    if flatten_version(lp_ovs_coming_versions) \\"},{"line_number":180,"context_line":"       !\u003d flatten_version(ovs_current_version):"},{"line_number":181,"context_line":"        # NOTE(mjozefcz): Workaround for bz1863024."},{"line_number":182,"context_line":"        if \u00272.11\u0027 \u003d\u003d flatten_version(ovs_current_version):"},{"line_number":183,"context_line":"            set_openflow_version_on_bridges(module)"},{"line_number":184,"context_line":"        ovs_pkgs \u003d get_current_ovs_pkg_names(module, pkg_base_name)"},{"line_number":185,"context_line":"        remove_package_noaction(module, ovs_pkgs,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_a32f2a86","line":182,"range":{"start_line":182,"start_character":12,"end_line":182,"end_character":16},"updated":"2020-08-06 10:00:25.000000000","message":"This should be \"211\" or use join_str\u003d\".\" when calling flatten:\n\nIn [1]: from tripleo_ansible.ansible_plugins.modules import tripleo_ovs_upgrade\n\nIn [2]: found \u003d [\u00272\u0027, \u002713\u0027]\n\nIn [3]: tripleo_ovs_upgrade.flatten_version(found)\nOut[3]: \u0027213\u0027\n\nIn [4]: tripleo_ovs_upgrade.flatten_version(found, join_str\u003d\".\")\nOut[4]: \u00272.13\u0027","commit_id":"96f6db414c3d022629794d6fd6c4f4c546f1d0b7"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"1bfbc551a3f3b2d52c03369c22c034f7ae2f8d51","unresolved":false,"context_lines":[{"line_number":179,"context_line":"    if flatten_version(lp_ovs_coming_versions) \\"},{"line_number":180,"context_line":"       !\u003d flatten_version(ovs_current_version):"},{"line_number":181,"context_line":"        # NOTE(mjozefcz): Workaround for bz1863024."},{"line_number":182,"context_line":"        if \u00272.11\u0027 \u003d\u003d flatten_version(ovs_current_version):"},{"line_number":183,"context_line":"            set_openflow_version_on_bridges(module)"},{"line_number":184,"context_line":"        ovs_pkgs \u003d get_current_ovs_pkg_names(module, pkg_base_name)"},{"line_number":185,"context_line":"        remove_package_noaction(module, ovs_pkgs,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_43ff2e66","line":182,"range":{"start_line":182,"start_character":12,"end_line":182,"end_character":16},"in_reply_to":"9f560f44_a32f2a86","updated":"2020-08-06 10:33:01.000000000","message":"Done","commit_id":"96f6db414c3d022629794d6fd6c4f4c546f1d0b7"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"c4b6265f5c17985ac6dae8528ac6fdd48d957c09","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"def set_openflow_version_on_bridges(module, bridges\u003dNone):"},{"line_number":159,"context_line":"    if not bridges:"},{"line_number":160,"context_line":"        bridges \u003d [\u0027br-int\u0027]"},{"line_number":161,"context_line":"    for bridge in bridges:"},{"line_number":162,"context_line":"        cmd \u003d [\u0027ovs-vsctl\u0027, \u0027set\u0027, \u0027bridge\u0027, bridge,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_a3a56a49","line":159,"range":{"start_line":159,"start_character":4,"end_line":159,"end_character":18},"updated":"2020-08-06 10:47:38.000000000","message":"if bridges is None\n\nThis will set the [\u0027br-int\u0027] also when passing empty list (which makes no sense to pass empty list but if you do you get unexpected results).","commit_id":"5b2061607eb3d69540eb29ff138fce2d25318fa9"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"4f7d348c0eab93abe1b9a53e29f8a5c73e276162","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"def set_openflow_version_on_bridges(module, bridges\u003dNone):"},{"line_number":159,"context_line":"    if not bridges:"},{"line_number":160,"context_line":"        bridges \u003d [\u0027br-int\u0027]"},{"line_number":161,"context_line":"    for bridge in bridges:"},{"line_number":162,"context_line":"        cmd \u003d [\u0027ovs-vsctl\u0027, \u0027set\u0027, \u0027bridge\u0027, bridge,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_23483a85","line":159,"range":{"start_line":159,"start_character":4,"end_line":159,"end_character":18},"in_reply_to":"9f560f44_a3a56a49","updated":"2020-08-06 10:50:11.000000000","message":"Ok, changed.","commit_id":"5b2061607eb3d69540eb29ff138fce2d25318fa9"}]}