)]}'
{"tripleo_ansible/ansible_plugins/modules/tripleo_container_config_scripts.py":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"0a09587115d179255f581b5bbf4afa7792dd0331","unresolved":false,"context_lines":[{"line_number":57,"context_line":"\"\"\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class TripleOContainerConfigScriptsManager:"},{"line_number":61,"context_line":"    \"\"\"Class for tripleo_container_config_scripts module.\"\"\""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def __init__(self, module, results):"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_0692d2f6","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":43},"updated":"2020-08-18 10:36:33.000000000","message":"Any reason of adding a class with just a private method that\u0027s called in __init__()?\n\nIt does not seem to add any value. I think the code in __init__() can just go in main() or a function in the module?","commit_id":"25024b0fe48d820437741a58fce1c3a01a375d27"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"fa4a7d7ced6d30e8ffabd786389feb36b6a1d69c","unresolved":false,"context_lines":[{"line_number":57,"context_line":"\"\"\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class TripleOContainerConfigScriptsManager:"},{"line_number":61,"context_line":"    \"\"\"Class for tripleo_container_config_scripts module.\"\"\""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def __init__(self, module, results):"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_dde0a4fb","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":43},"in_reply_to":"9f560f44_0692d2f6","updated":"2020-08-18 12:20:40.000000000","message":"yes we could move it, I just followed other modules pattern.","commit_id":"25024b0fe48d820437741a58fce1c3a01a375d27"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"7073a1c8b511976494ae852229722ab110519862","unresolved":false,"context_lines":[{"line_number":57,"context_line":"\"\"\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class TripleOContainerConfigScriptsManager:"},{"line_number":61,"context_line":"    \"\"\"Class for tripleo_container_config_scripts module.\"\"\""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def __init__(self, module, results):"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_fdf8087d","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":43},"in_reply_to":"9f560f44_dde0a4fb","updated":"2020-08-18 12:32:57.000000000","message":"Done","commit_id":"25024b0fe48d820437741a58fce1c3a01a375d27"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"2363f39c02392cbec2c8dee84dd53a2a047a669e","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            mode \u003d config.get(\u0027mode\u0027, \u00270600\u0027)"},{"line_number":79,"context_line":"            self._create_script(path, config[\u0027content\u0027], mode)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        self.module.exit_json(**self.results)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def _create_script(self, path, content, mode):"},{"line_number":84,"context_line":"        \"\"\"Create a script."}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_4604cac6","line":81,"updated":"2020-08-18 09:54:32.000000000","message":"Suggestion: Would it be a good idea to return the list of files written as a result, for logging?","commit_id":"25024b0fe48d820437741a58fce1c3a01a375d27"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"fa4a7d7ced6d30e8ffabd786389feb36b6a1d69c","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            mode \u003d config.get(\u0027mode\u0027, \u00270600\u0027)"},{"line_number":79,"context_line":"            self._create_script(path, config[\u0027content\u0027], mode)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        self.module.exit_json(**self.results)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def _create_script(self, path, content, mode):"},{"line_number":84,"context_line":"        \"\"\"Create a script."}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_bdb5f0f0","line":81,"in_reply_to":"9f560f44_4604cac6","updated":"2020-08-18 12:20:40.000000000","message":"It would be a good idea if we were using this data somewhere, however we don\u0027t (yet?) so for now I suggest we don\u0027t return this list in result, to save resources.","commit_id":"25024b0fe48d820437741a58fce1c3a01a375d27"}]}