)]}'
{"tripleo_ansible/roles/tripleo_kernel/molecule/firstboot_upgrade/Dockerfile":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"780ec5d13b7852c51b334f7681e5e11ed5472c41","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"673ed3d3_1893ccbf","updated":"2021-05-03 13:36:50.000000000","message":"this file is not needed when using the delegated driver.","commit_id":"fb9ca76ec448d6ba7761dde59b8a90c08f6e907e"}],"tripleo_ansible/roles/tripleo_kernel/molecule/firstboot_upgrade/prepare.yml":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0354621525080d9f9df121ef7a336bbbd1796359","unresolved":false,"context_lines":[{"line_number":29,"context_line":"          GRUB_DEFAULT\u003dsaved"},{"line_number":30,"context_line":"          GRUB_DISABLE_SUBMENU\u003dtrue"},{"line_number":31,"context_line":"          GRUB_TERMINAL_OUTPUT\u003d\"console\""},{"line_number":32,"context_line":"          GRUB_CMDLINE_LINUX\u003d\"console\u003dttyS0 console\u003dttyS0,115200n81 no_timer_check  crashkernel\u003dauto rhgb quiet default_hugepagesz\u003d1G test3\u003d3 test2 hugepagesz\u003d1G hugepages\u003d1 hugepagesz\u003d2M hugepages\u003d2 isolcpus\u003d1-2,3 intel_iommu\u003don iommu\u003dpt\""},{"line_number":33,"context_line":"          GRUB_DISABLE_RECOVERY\u003d\"true\""},{"line_number":34,"context_line":"          GRUB_CMDLINE_LINUX_DEFAULT\u003d\"${GRUB_CMDLINE_LINUX_DEFAULT:+$GRUB_CMDLINE_LINUX_DEFAULT }\\$tuned_params\""},{"line_number":35,"context_line":"          GRUB_INITRD_OVERLAY\u003d\"${GRUB_INITRD_OVERLAY:+$GRUB_INITRD_OVERLAY }\\$tuned_initrd\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_06cf9b29","line":32,"updated":"2020-08-31 20:21:49.000000000","message":"linters: [error] line too long (239 \u003e 160 characters) (line-length)","commit_id":"d79a97c30c7523335e9448e18ed6a3dbe637c2c0"}],"tripleo_ansible/roles/tripleo_kernel/tasks/kernelargs.yml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"981b67099e0bf6c3c8c357c768fa3b77876f2549","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    - name: Init GRUB_CMDLINE_LINUX cleanup facts"},{"line_number":24,"context_line":"      set_fact:"},{"line_number":25,"context_line":"        grub_cmdline_linux: []"},{"line_number":26,"context_line":"        # Strip the typical hugepage \u0026 cpu isolation args plus anything that is set in tripleo_kernel_args"},{"line_number":27,"context_line":"        grub_cmdline_remove_args: \u003e-"},{"line_number":28,"context_line":"          default_hugepagesz"},{"line_number":29,"context_line":"          hugepagesz"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_f7c2ee52","line":26,"range":{"start_line":26,"start_character":58,"end_line":26,"end_character":106},"updated":"2020-09-02 16:25:52.000000000","message":"not sure about this, could be dangerous","commit_id":"fb9ca76ec448d6ba7761dde59b8a90c08f6e907e"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"355ed54642e12813364a83c3adec41cbb2ee84b5","unresolved":false,"context_lines":[{"line_number":36,"context_line":"      set_fact:"},{"line_number":37,"context_line":"        grub_cmdline_remove: \"{{ grub_cmdline_remove_args.split(\u0027 \u0027)|unique }}\""},{"line_number":38,"context_line":"    - name: Get existing GRUB_CMDLINE_LINUX"},{"line_number":39,"context_line":"      shell: \"sed -n \u0027s!^GRUB_CMDLINE_LINUX\u003d\\\"\\\\(.*\\\\)\\\"!\\\\1!p\u0027 /etc/default/grub | grep -v TRIPLEO_HEAT_TEMPLATE_KERNEL_ARGS\""},{"line_number":40,"context_line":"      register: existing_grub_entry"},{"line_number":41,"context_line":"    - name: Build clean GRUB_CMDLINE_LINUX"},{"line_number":42,"context_line":"      set_fact:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_0293f45d","line":39,"range":{"start_line":39,"start_character":46,"end_line":39,"end_character":63},"updated":"2020-09-01 19:15:18.000000000","message":"this seems fragile, can we use the regex search modules to create conditions within the task, stead of trying to react to shell conditions?","commit_id":"fb9ca76ec448d6ba7761dde59b8a90c08f6e907e"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"2a953f9577fa7449ed2723d4e6c82f83316e320e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"      set_fact:"},{"line_number":37,"context_line":"        grub_cmdline_remove: \"{{ grub_cmdline_remove_args.split(\u0027 \u0027)|unique }}\""},{"line_number":38,"context_line":"    - name: Get existing GRUB_CMDLINE_LINUX"},{"line_number":39,"context_line":"      shell: \"sed -n \u0027s!^GRUB_CMDLINE_LINUX\u003d\\\"\\\\(.*\\\\)\\\"!\\\\1!p\u0027 /etc/default/grub | grep -v TRIPLEO_HEAT_TEMPLATE_KERNEL_ARGS\""},{"line_number":40,"context_line":"      register: existing_grub_entry"},{"line_number":41,"context_line":"    - name: Build clean GRUB_CMDLINE_LINUX"},{"line_number":42,"context_line":"      set_fact:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_37eaa60d","line":39,"range":{"start_line":39,"start_character":46,"end_line":39,"end_character":63},"in_reply_to":"9f560f44_0293f45d","updated":"2020-09-02 16:10:24.000000000","message":"yes, can probably replace with some jijna-fu","commit_id":"fb9ca76ec448d6ba7761dde59b8a90c08f6e907e"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"431292ee6890be0f2c9ec819f180e8a108cb6d05","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    - tripleo_kernel_args|string"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"# Kernel Args Configuration"},{"line_number":60,"context_line":"- block:"},{"line_number":61,"context_line":"    - name: Ensure the kernel args ( {{ tripleo_kernel_args }} ) is present as TRIPLEO_HEAT_TEMPLATE_KERNEL_ARGS"},{"line_number":62,"context_line":"      lineinfile:"},{"line_number":63,"context_line":"        dest: /etc/default/grub"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_30062722","line":60,"updated":"2020-09-03 04:19:16.000000000","message":"This change will result in a reboot during updates/upgrades if the older environment has newton based config. Are we OK with this additional reboot?\n\nI would recommend to move this part inside this block, in which case, we know that the args have changed by the user and a reboot will be required.","commit_id":"fb9ca76ec448d6ba7761dde59b8a90c08f6e907e"}]}