)]}'
{"tripleo_ansible/roles/tripleo_kernel/tasks/kernelargs.yml":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d561f96cc3a50bbe0bc340c853122851c3fd9941","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    regex: TRIPLEO_HEAT_TEMPLATE_KERNEL_ARGS"},{"line_number":24,"context_line":"    dest: /etc/default/grub"},{"line_number":25,"context_line":"    line: \u0027\u0027"},{"line_number":26,"context_line":"  check_mode: yes"},{"line_number":27,"context_line":"  register: grub_file_entry_check"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Kernel Args Configuration"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_649eb854","line":26,"updated":"2020-09-10 05:41:59.000000000","message":"linters: [warning] truthy value should be one of [false, true] (truthy)","commit_id":"f5586048adc3404d2d935727f31df3ca2bdec25c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"88dff0d5eac4610be1394567cc479ebdfc04f127","unresolved":false,"context_lines":[{"line_number":82,"context_line":"  when:"},{"line_number":83,"context_line":"    - reboot_required is defined and reboot_required"},{"line_number":84,"context_line":"    - not tripleo_kernel_defer_reboot|bool"},{"line_number":85,"context_line":"    - grub_file_entry_check is not changed"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_1b4e366e","line":85,"range":{"start_line":85,"start_character":6,"end_line":85,"end_character":27},"updated":"2020-09-10 07:36:16.000000000","message":"maybe a warning message should be logged about \"Reboot of\nthe node should be planned by the user with migration and\ndowntime window.\"","commit_id":"4cd4cccd5730e23c8b097e7c949c32e4dee2bbaf"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"ce73c4f071d4f5a4793a8bf6f14ec13778fd122b","unresolved":false,"context_lines":[{"line_number":82,"context_line":"  when:"},{"line_number":83,"context_line":"    - reboot_required is defined and reboot_required"},{"line_number":84,"context_line":"    - not tripleo_kernel_defer_reboot|bool"},{"line_number":85,"context_line":"    - grub_file_entry_check is not changed"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f560f44_8a6ae97d","line":85,"range":{"start_line":85,"start_character":6,"end_line":85,"end_character":27},"in_reply_to":"9f560f44_1b4e366e","updated":"2020-09-10 15:24:31.000000000","message":"Done","commit_id":"4cd4cccd5730e23c8b097e7c949c32e4dee2bbaf"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2340c8d5ef01f4cac12e5e1e1bb9c5d65f10178b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  replace:"},{"line_number":23,"context_line":"    regexp: TRIPLEO_HEAT_TEMPLATE_KERNEL_ARGS"},{"line_number":24,"context_line":"    dest: /etc/default/grub"},{"line_number":25,"context_line":"    replace: \u0027\u0027"},{"line_number":26,"context_line":"  check_mode: true"},{"line_number":27,"context_line":"  register: grub_file_entry_check"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_0e7edf17","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":11},"updated":"2020-09-11 06:54:20.000000000","message":"so are you intending to replace with \u0027\u0027 or to just check if it is there?\n\n\"If not set, matches are removed entirely.\" @ https://docs.ansible.com/ansible/latest/modules/replace_module.html#parameter-replace\n\nwhy not use lineinfile as is already done with https://opendev.org/openstack/tripleo-ansible/src/commit/325d0805832c9f7f735409597f951a0533bbf404/tripleo_ansible/roles/tripleo_kernel/molecule/kernelargs/verify.yml#L24","commit_id":"a89cc63f79640a9b71a98d849532c3284e725821"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"8e96296133c63a9fe65710506226b554fd16593a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  replace:"},{"line_number":23,"context_line":"    regexp: TRIPLEO_HEAT_TEMPLATE_KERNEL_ARGS"},{"line_number":24,"context_line":"    dest: /etc/default/grub"},{"line_number":25,"context_line":"    replace: \u0027\u0027"},{"line_number":26,"context_line":"  check_mode: true"},{"line_number":27,"context_line":"  register: grub_file_entry_check"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_ce9b4714","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":11},"in_reply_to":"9f560f44_0e7edf17","updated":"2020-09-11 07:21:32.000000000","message":"It is with \"check_mode: true\" - so no operations performed, only checks.","commit_id":"a89cc63f79640a9b71a98d849532c3284e725821"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ee9c9db4a1e3be3f2345ea318ff4d3a03a890c59","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  replace:"},{"line_number":23,"context_line":"    regexp: TRIPLEO_HEAT_TEMPLATE_KERNEL_ARGS"},{"line_number":24,"context_line":"    dest: /etc/default/grub"},{"line_number":25,"context_line":"    replace: \u0027\u0027"},{"line_number":26,"context_line":"  check_mode: true"},{"line_number":27,"context_line":"  register: grub_file_entry_check"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_b7f448d2","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":11},"in_reply_to":"9f560f44_ce9b4714","updated":"2020-09-14 07:08:17.000000000","message":"ok thanks I missed that.\n\ni was also a bit surprised to read that lineinfile in fact behaves in much the same way https://docs.ansible.com/ansible/latest/modules/lineinfile_module.html - so you\u0027d need check_mode if you used that as well :/","commit_id":"a89cc63f79640a9b71a98d849532c3284e725821"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"9f447abecb04b25bdb34ce147775a1a6bf66858e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  when:"},{"line_number":60,"context_line":"    - cmdline.stdout_lines is defined"},{"line_number":61,"context_line":"    - tripleo_kernel_args|string"},{"line_number":62,"context_line":"    - tripleo_kernel_args not in cmdline.stdout_lines[0]"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"# Apply DPDK workarounds before reboot"},{"line_number":65,"context_line":"- name: Apply DPDK workarounds"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_2b89156e","line":62,"updated":"2020-09-11 04:17:17.000000000","message":"This condition works fine for adding new params and modifying existing params during an update. But it will ignore if the kernel args has been removed from the already activated ones. This case need to be handled. I will do a follow-up for that.","commit_id":"a89cc63f79640a9b71a98d849532c3284e725821"}]}