)]}'
{"tripleo_ansible/ansible_plugins/modules/tripleo_composable_network.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"468fa3adbd9cf93e5a916aacf60706b756a0f604","unresolved":false,"context_lines":[{"line_number":395,"context_line":"        **openstack_module_kwargs()"},{"line_number":396,"context_line":"    )"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"    net_data \u003d module.params[\u0027net_data\u0027]"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    try:"},{"line_number":401,"context_line":"        _, conn \u003d openstack_cloud_from_module(module)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_a59ea452","line":398,"updated":"2020-09-30 23:58:31.000000000","message":"Doing a jsonschema validation before proceeding would be desirable I think","commit_id":"bbd4727ca4ed3a33cb97e16b6ee78c859e97bf8a"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"b4c648d16a8644c25ec2311ab6c5e9149eacfb6c","unresolved":false,"context_lines":[{"line_number":395,"context_line":"        **openstack_module_kwargs()"},{"line_number":396,"context_line":"    )"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"    net_data \u003d module.params[\u0027net_data\u0027]"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    try:"},{"line_number":401,"context_line":"        _, conn \u003d openstack_cloud_from_module(module)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_d0b4e2f3","line":398,"in_reply_to":"9f560f44_a59ea452","updated":"2020-10-07 10:10:28.000000000","message":"Done, (I still need to test it beyond the unit testing.) feedback welcome!","commit_id":"bbd4727ca4ed3a33cb97e16b6ee78c859e97bf8a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"77e3d3d561f7f6b8ab25449b222fee01fe666019","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import yaml"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"try:"},{"line_number":21,"context_line":"    from ansible.module_utils import tripleo_common_utils as tc"},{"line_number":22,"context_line":"except ImportError:"},{"line_number":23,"context_line":"    from tripleo_ansible.ansible_plugins.module_utils import tripleo_common_utils as tc"},{"line_number":24,"context_line":"try:"},{"line_number":25,"context_line":"    from ansible.module_utils import network_data_v2"},{"line_number":26,"context_line":"except ImportError:"},{"line_number":27,"context_line":"    from tripleo_ansible.ansible_plugins.module_utils import network_data_v2"},{"line_number":28,"context_line":"from ansible.module_utils.basic import AnsibleModule"}],"source_content_type":"text/x-python","patch_set":20,"id":"1f621f24_476903f7","line":25,"range":{"start_line":20,"start_character":1,"end_line":25,"end_character":1},"updated":"2020-11-12 08:12:10.000000000","message":"sorry don\u0027t follow why we need to do that is it a version issue?","commit_id":"d40015e967211c90460f9b470fbdcffcd7e95ffd"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"d3c5c061f942a8003a50730aba7cdd6573960d9c","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import yaml"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"try:"},{"line_number":21,"context_line":"    from ansible.module_utils import tripleo_common_utils as tc"},{"line_number":22,"context_line":"except ImportError:"},{"line_number":23,"context_line":"    from tripleo_ansible.ansible_plugins.module_utils import tripleo_common_utils as tc"},{"line_number":24,"context_line":"try:"},{"line_number":25,"context_line":"    from ansible.module_utils import network_data_v2"},{"line_number":26,"context_line":"except ImportError:"},{"line_number":27,"context_line":"    from tripleo_ansible.ansible_plugins.module_utils import network_data_v2"},{"line_number":28,"context_line":"from ansible.module_utils.basic import AnsibleModule"}],"source_content_type":"text/x-python","patch_set":20,"id":"1f621f24_4b390dd5","line":25,"range":{"start_line":20,"start_character":1,"end_line":25,"end_character":1},"in_reply_to":"1f621f24_476903f7","updated":"2020-11-12 08:40:00.000000000","message":"I\u0027m not sure exactly, but ansible runs does some magic that makes tripleo_common_utils and network_data_v2 importable from ansible.module_utils which is\u0027nt happening when executing tests.\n\nSo we need the special import handling for the unit tests.","commit_id":"d40015e967211c90460f9b470fbdcffcd7e95ffd"}],"tripleo_ansible/ansible_plugins/modules/tripleo_network_populate_environment.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"77e3d3d561f7f6b8ab25449b222fee01fe666019","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        # ipv6: true in network_data if services on the network should use ipv6"},{"line_number":84,"context_line":"        return 6 if net_data.get(\u0027ipv6\u0027) is True else 4"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    return ip_versions.pop()"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"def get_net_cidrs(subnets, ip_version):"}],"source_content_type":"text/x-python","patch_set":20,"id":"1f621f24_67bfdf60","line":86,"updated":"2020-11-12 08:12:10.000000000","message":"what if something went horribly wrong here and we are returning something other than \u00274\u0027 ?","commit_id":"d40015e967211c90460f9b470fbdcffcd7e95ffd"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"d3c5c061f942a8003a50730aba7cdd6573960d9c","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        # ipv6: true in network_data if services on the network should use ipv6"},{"line_number":84,"context_line":"        return 6 if net_data.get(\u0027ipv6\u0027) is True else 4"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    return ip_versions.pop()"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"def get_net_cidrs(subnets, ip_version):"}],"source_content_type":"text/x-python","patch_set":20,"id":"1f621f24_ab90a196","line":86,"in_reply_to":"1f621f24_67bfdf60","updated":"2020-11-12 08:40:00.000000000","message":"Unless we sent in a fake list of subnet objects I don\u0027t see how that can happen. The subnet.ip_version is type enforced in neutron so it should never be anything but 4 or 6.\nhttps://opendev.org/openstack/neutron-lib/src/branch/master/neutron_lib/objects/common_types.py#L141-L145","commit_id":"d40015e967211c90460f9b470fbdcffcd7e95ffd"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"546c16335b63d6ed623cfa13db2d306295dd3a70","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        # ipv6: true in network_data if services on the network should use ipv6"},{"line_number":84,"context_line":"        return 6 if net_data.get(\u0027ipv6\u0027) is True else 4"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    return ip_versions.pop()"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"def get_net_cidrs(subnets, ip_version):"}],"source_content_type":"text/x-python","patch_set":20,"id":"1f621f24_dd367151","line":86,"in_reply_to":"1f621f24_ab90a196","updated":"2020-11-13 07:34:13.000000000","message":"ack thanks for checking","commit_id":"d40015e967211c90460f9b470fbdcffcd7e95ffd"}],"tripleo_ansible/playbooks/cli-overcloud-network-provision.yaml":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"468fa3adbd9cf93e5a916aacf60706b756a0f604","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    - name: Load config from file"},{"line_number":47,"context_line":"      set_fact:"},{"line_number":48,"context_line":"        network_data: \"{{ lookup(\u0027file\u0027, network_data_path) | from_yaml}}\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    - name: Create composable networks"},{"line_number":51,"context_line":"      tripleo_composable_network:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9f560f44_e5c1bc31","line":48,"updated":"2020-09-30 23:58:31.000000000","message":"Maybe this could be conditional on network_data not being defined already, allowing it to be passed in by value or file path","commit_id":"bbd4727ca4ed3a33cb97e16b6ee78c859e97bf8a"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"b4c648d16a8644c25ec2311ab6c5e9149eacfb6c","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    - name: Load config from file"},{"line_number":47,"context_line":"      set_fact:"},{"line_number":48,"context_line":"        network_data: \"{{ lookup(\u0027file\u0027, network_data_path) | from_yaml}}\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    - name: Create composable networks"},{"line_number":51,"context_line":"      tripleo_composable_network:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9f560f44_d0db424b","line":48,"in_reply_to":"9f560f44_e5c1bc31","updated":"2020-10-07 10:10:28.000000000","message":"Done","commit_id":"bbd4727ca4ed3a33cb97e16b6ee78c859e97bf8a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"057de7e591855aa4e49612a68f9cd1fceae814e7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2019 Red Hat, Inc."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"1f621f24_37ba2b6d","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":16},"updated":"2020-11-12 19:16:23.000000000","message":"2020","commit_id":"91ce991f3e05130f2ac4ca363fdf517a1f95649a"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"585b498d6fd47df6340225661ca191ef1ce732d3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2019 Red Hat, Inc."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"1f621f24_e78c4a81","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":16},"in_reply_to":"1f621f24_37ba2b6d","updated":"2020-11-18 02:59:45.000000000","message":"Aren\u0027t we pretending 2020 didn\u0027t happen?","commit_id":"91ce991f3e05130f2ac4ca363fdf517a1f95649a"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"63c6360f8757e8ca7971efc0182e1309207aeb2f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2019 Red Hat, Inc."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"1f621f24_61bc9d6c","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":16},"in_reply_to":"1f621f24_75f61bfc","updated":"2020-11-18 18:18:57.000000000","message":"A follow up changeing it to 2020, which is happening ... - https://review.opendev.org/763244","commit_id":"91ce991f3e05130f2ac4ca363fdf517a1f95649a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6fbafeb47477baf6e333ce8ff445c40ca250f7d7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2019 Red Hat, Inc."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"1f621f24_75f61bfc","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":16},"in_reply_to":"1f621f24_e78c4a81","updated":"2020-11-18 14:19:22.000000000","message":"If only we could","commit_id":"91ce991f3e05130f2ac4ca363fdf517a1f95649a"}]}