)]}'
{"tripleo_ansible/roles/tripleo_network_config/templates/multiple_nics/multiple_nics.j2":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"1b05b9c2d173a760739c773b7d1d07032651b2c0","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    use_dhcp: false"},{"line_number":53,"context_line":"    primary: true"},{"line_number":54,"context_line":"{% endif %}"},{"line_number":55,"context_line":"{% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_76a4524c","line":55,"updated":"2020-09-30 07:54:50.000000000","message":"thanks just spent some time staring at https://opendev.org/openstack/tripleo-heat-templates/src/commit/e2010c80644a48242613bc88c2d070d031977941/network/config/multiple-nics/role.role.j2.yaml and https://opendev.org/openstack/tripleo-heat-templates/src/commit/e2010c80644a48242613bc88c2d070d031977941/network/config/multiple-nics-vlans/role.role.j2.yaml\n\n\nhave you thought about how you will handle the extra dpdk stuff or it is done already somewhere else","commit_id":"10d0adbef7c02c71c2b452049907dc0c93609609"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"b249cb43a30c29794e7b3471730c96b9d3af436f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    use_dhcp: false"},{"line_number":53,"context_line":"    primary: true"},{"line_number":54,"context_line":"{% endif %}"},{"line_number":55,"context_line":"{% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_82b8c011","line":55,"in_reply_to":"9f560f44_39d5ab48","updated":"2020-09-30 12:01:01.000000000","message":"+1 on not using \u0027if role logic\u0027.\n\nIf we want to do something like the dpdk stuff we should have use a tag in the role instead of relying on names.","commit_id":"10d0adbef7c02c71c2b452049907dc0c93609609"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"2704fc1bc03060a610cf181808dda6b946115e80","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    use_dhcp: false"},{"line_number":53,"context_line":"    primary: true"},{"line_number":54,"context_line":"{% endif %}"},{"line_number":55,"context_line":"{% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_39d5ab48","line":55,"in_reply_to":"9f560f44_76a4524c","updated":"2020-09-30 08:16:57.000000000","message":"There would be another template for that role. No \u0027if role logic\u0027 as this is not generated per role. If a role requires some additional config it would have a separate template.","commit_id":"10d0adbef7c02c71c2b452049907dc0c93609609"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"e1a13fc0edf8bddd5b46092bde118f464229483b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  use_dhcp: false"},{"line_number":22,"context_line":"  addresses:"},{"line_number":23,"context_line":"  - ip_netmask:"},{"line_number":24,"context_line":"    {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_ip\u0027) }}/{{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_cidr\u0027) }}"},{"line_number":25,"context_line":"{% if default_route_networks and \u0027ControlPlane\u0027 in default_route_networks %}"},{"line_number":26,"context_line":"  routes:"},{"line_number":27,"context_line":"    {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_host_routes\u0027) }} + [{\u0027default\u0027: true, \u0027next_hop\u0027: {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_gateway_ip\u0027) }}}]"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9f560f44_82a4404d","line":24,"updated":"2020-09-30 12:42:14.000000000","message":"Will need indent here as well?","commit_id":"1d72874c002d460566477f2512f7ed6a84d2e247"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"e1a13fc0edf8bddd5b46092bde118f464229483b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  use_dhcp: false"},{"line_number":41,"context_line":"  addresses:"},{"line_number":42,"context_line":"  - ip_netmask:"},{"line_number":43,"context_line":"    {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_ip\u0027) }}/{{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_cidr\u0027) }}"},{"line_number":44,"context_line":"{% if default_route_networks and network in default_route_networks %}"},{"line_number":45,"context_line":"  routes:"},{"line_number":46,"context_line":"    {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_host_routes\u0027) }} + [{\u0027default\u0027: true, \u0027next_hop\u0027: {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_gateway_ip\u0027) }}}]"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9f560f44_e25edc4f","line":43,"updated":"2020-09-30 12:42:14.000000000","message":"ditto?","commit_id":"1d72874c002d460566477f2512f7ed6a84d2e247"}],"tripleo_ansible/roles/tripleo_network_config/templates/single_nic_vlans/single_nic_vlans.j2":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"b249cb43a30c29794e7b3471730c96b9d3af436f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"network_config:"},{"line_number":8,"context_line":"- type: ovs_bridge"},{"line_number":9,"context_line":"  name: {{ neutron_physical_bridge_name }}"},{"line_number":10,"context_line":" mtu: {{ min_viable_mtu }}"},{"line_number":11,"context_line":"  use_dhcp: false"},{"line_number":12,"context_line":"  dns_servers: {{ ctlplane_dns_nameservers }}"},{"line_number":13,"context_line":"  domain: {{ dns_search_domains }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_221e145f","line":10,"range":{"start_line":10,"start_character":1,"end_line":10,"end_character":4},"updated":"2020-09-30 12:01:01.000000000","message":"intendtation error?","commit_id":"10d0adbef7c02c71c2b452049907dc0c93609609"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"e7790dc7313266b54a444f3cab23da7cb7d8322a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"network_config:"},{"line_number":8,"context_line":"- type: ovs_bridge"},{"line_number":9,"context_line":"  name: {{ neutron_physical_bridge_name }}"},{"line_number":10,"context_line":" mtu: {{ min_viable_mtu }}"},{"line_number":11,"context_line":"  use_dhcp: false"},{"line_number":12,"context_line":"  dns_servers: {{ ctlplane_dns_nameservers }}"},{"line_number":13,"context_line":"  domain: {{ dns_search_domains }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_821440eb","line":10,"range":{"start_line":10,"start_character":1,"end_line":10,"end_character":4},"in_reply_to":"9f560f44_221e145f","updated":"2020-09-30 12:11:59.000000000","message":"Done","commit_id":"10d0adbef7c02c71c2b452049907dc0c93609609"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"08fae5cdf91af7143768d020b02836ea91c9b104","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    addresses:"},{"line_number":32,"context_line":"    - ip_netmask:"},{"line_number":33,"context_line":"      {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_ip\u0027) }}/{{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_cidr\u0027) }}"},{"line_number":34,"context_line":"{% if default_route_networks and \u0027ControlPlane\u0027 in default_route_networks %}"},{"line_number":35,"context_line":"    routes:"},{"line_number":36,"context_line":"    {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_host_routes\u0027) }} + [{\u0027default\u0027: true, \u0027next_hop\u0027: {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_gateway_ip\u0027) }}}]"},{"line_number":37,"context_line":"{% else %}"},{"line_number":38,"context_line":"    routes: {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_host_routes\u0027) }}"},{"line_number":39,"context_line":"{% endif %}"},{"line_number":40,"context_line":"{% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_471d1a76","line":37,"range":{"start_line":34,"start_character":0,"end_line":37,"end_character":10},"updated":"2020-09-30 11:45:31.000000000","message":"We only need to add this above. No need to set the same default route another time for each vlan interface?","commit_id":"10d0adbef7c02c71c2b452049907dc0c93609609"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"b249cb43a30c29794e7b3471730c96b9d3af436f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    addresses:"},{"line_number":32,"context_line":"    - ip_netmask:"},{"line_number":33,"context_line":"      {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_ip\u0027) }}/{{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_cidr\u0027) }}"},{"line_number":34,"context_line":"{% if default_route_networks and \u0027ControlPlane\u0027 in default_route_networks %}"},{"line_number":35,"context_line":"    routes:"},{"line_number":36,"context_line":"    {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_host_routes\u0027) }} + [{\u0027default\u0027: true, \u0027next_hop\u0027: {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_gateway_ip\u0027) }}}]"},{"line_number":37,"context_line":"{% else %}"},{"line_number":38,"context_line":"    routes: {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_host_routes\u0027) }}"},{"line_number":39,"context_line":"{% endif %}"},{"line_number":40,"context_line":"{% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_c260f8a7","line":37,"range":{"start_line":34,"start_character":0,"end_line":37,"end_character":10},"in_reply_to":"9f560f44_426228db","updated":"2020-09-30 12:01:01.000000000","message":"{%-     if network.name in role.default_route_networks %}\n\nis not the same as:\n\n{% if default_route_networks and \u0027ControlPlane\u0027 in default_route_networks %}\n\n\nIn heat tampltes it\u0027s for example \"if \u0027External\u0027 in default_route_networks\", not if \u0027ControlPlane\u0027","commit_id":"10d0adbef7c02c71c2b452049907dc0c93609609"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"e9a4f7d80d148cb82e803378538f6ddf99d6c8a3","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    addresses:"},{"line_number":32,"context_line":"    - ip_netmask:"},{"line_number":33,"context_line":"      {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_ip\u0027) }}/{{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_cidr\u0027) }}"},{"line_number":34,"context_line":"{% if default_route_networks and \u0027ControlPlane\u0027 in default_route_networks %}"},{"line_number":35,"context_line":"    routes:"},{"line_number":36,"context_line":"    {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_host_routes\u0027) }} + [{\u0027default\u0027: true, \u0027next_hop\u0027: {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_gateway_ip\u0027) }}}]"},{"line_number":37,"context_line":"{% else %}"},{"line_number":38,"context_line":"    routes: {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_host_routes\u0027) }}"},{"line_number":39,"context_line":"{% endif %}"},{"line_number":40,"context_line":"{% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_426228db","line":37,"range":{"start_line":34,"start_character":0,"end_line":37,"end_character":10},"in_reply_to":"9f560f44_471d1a76","updated":"2020-09-30 11:54:28.000000000","message":"Strangely that\u0027s the case with heat templates.\n\nhttps://github.com/openstack/tripleo-heat-templates/blob/master/network/config/single-nic-vlans/role.role.j2.yaml#L158-L166","commit_id":"10d0adbef7c02c71c2b452049907dc0c93609609"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"e7790dc7313266b54a444f3cab23da7cb7d8322a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    addresses:"},{"line_number":32,"context_line":"    - ip_netmask:"},{"line_number":33,"context_line":"      {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_ip\u0027) }}/{{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_cidr\u0027) }}"},{"line_number":34,"context_line":"{% if default_route_networks and \u0027ControlPlane\u0027 in default_route_networks %}"},{"line_number":35,"context_line":"    routes:"},{"line_number":36,"context_line":"    {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_host_routes\u0027) }} + [{\u0027default\u0027: true, \u0027next_hop\u0027: {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_gateway_ip\u0027) }}}]"},{"line_number":37,"context_line":"{% else %}"},{"line_number":38,"context_line":"    routes: {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_host_routes\u0027) }}"},{"line_number":39,"context_line":"{% endif %}"},{"line_number":40,"context_line":"{% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_421a2818","line":37,"range":{"start_line":34,"start_character":0,"end_line":37,"end_character":10},"in_reply_to":"9f560f44_c260f8a7","updated":"2020-09-30 12:11:59.000000000","message":"sorry copy paste error.","commit_id":"10d0adbef7c02c71c2b452049907dc0c93609609"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"e1a13fc0edf8bddd5b46092bde118f464229483b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"{% set mtu_list \u003d [] %}"},{"line_number":3,"context_line":"{% for network in role_networks %}"},{"line_number":4,"context_line":"  {{ mtu_list.append(lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_mtu\u0027)) }}"},{"line_number":5,"context_line":"{% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9f560f44_62092c31","line":2,"updated":"2020-09-30 12:42:14.000000000","message":"nit: should add \u0027-\u0027 here to not add n number of whitespace at top of file?","commit_id":"1d72874c002d460566477f2512f7ed6a84d2e247"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"e1a13fc0edf8bddd5b46092bde118f464229483b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"{% set mtu_list \u003d [] %}"},{"line_number":3,"context_line":"{% for network in role_networks %}"},{"line_number":4,"context_line":"  {{ mtu_list.append(lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_mtu\u0027)) }}"},{"line_number":5,"context_line":"{% endfor %}"},{"line_number":6,"context_line":"{% set min_viable_mtu \u003d mtu_list | max %}"},{"line_number":7,"context_line":"network_config:"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9f560f44_edfa4d0f","line":4,"range":{"start_line":4,"start_character":2,"end_line":4,"end_character":78},"updated":"2020-09-30 12:42:14.000000000","message":"Should be {%- %} as well?","commit_id":"1d72874c002d460566477f2512f7ed6a84d2e247"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"a8fa14c76b98874751fbff0c57395b5a7e6e307c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"{% set mtu_list \u003d [] %}"},{"line_number":3,"context_line":"{% for network in role_networks %}"},{"line_number":4,"context_line":"  {{ mtu_list.append(lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_mtu\u0027)) }}"},{"line_number":5,"context_line":"{% endfor %}"},{"line_number":6,"context_line":"{% set min_viable_mtu \u003d mtu_list | max %}"},{"line_number":7,"context_line":"network_config:"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9f560f44_f92e8140","line":4,"range":{"start_line":4,"start_character":2,"end_line":4,"end_character":78},"in_reply_to":"9f560f44_edfa4d0f","updated":"2020-10-01 09:21:00.000000000","message":"Not sure if this can be changed to {%- %} inside a for loop. I\u0027ve updated(tested) to remove blank lines in the latest patchset.","commit_id":"1d72874c002d460566477f2512f7ed6a84d2e247"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"e1a13fc0edf8bddd5b46092bde118f464229483b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  domain: {{ dns_search_domains }}"},{"line_number":14,"context_line":"  addresses:"},{"line_number":15,"context_line":"  - ip_netmask: {{ ctlplane_ip }}/{{ ctlplane_subnet_cidr }}"},{"line_number":16,"context_line":"{% if default_route_networks and \u0027ControlPlane\u0027 in default_route_networks %}"},{"line_number":17,"context_line":"  routes: {{ ctlplane_host_routes }} + [{\u0027default\u0027: true, \u0027next_hop\u0027: {{ ctlplane_gateway_ip }}]"},{"line_number":18,"context_line":"{% else %}"},{"line_number":19,"context_line":"  routes: {{ ctlplane_host_routes }}"},{"line_number":20,"context_line":"{% endif %}"},{"line_number":21,"context_line":"  members:"},{"line_number":22,"context_line":"  - type: interface"},{"line_number":23,"context_line":"    name: nic1"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9f560f44_ed488d63","line":20,"range":{"start_line":16,"start_character":0,"end_line":20,"end_character":11},"updated":"2020-09-30 12:42:14.000000000","message":"nit: I think we could do this logic in THT, i.e have the ctlplane_host_routes and _host_routes pre-populated with the default route entry in group_vars if appropriate. (I can try getting a patch up adding that.) It would make both these and heat templates less complex.","commit_id":"1d72874c002d460566477f2512f7ed6a84d2e247"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"e1a13fc0edf8bddd5b46092bde118f464229483b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    vlan_id: {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_vlan_id\u0027) }}"},{"line_number":31,"context_line":"    addresses:"},{"line_number":32,"context_line":"    - ip_netmask:"},{"line_number":33,"context_line":"      {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_ip\u0027) }}/{{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_cidr\u0027) }}"},{"line_number":34,"context_line":"{% if default_route_networks and network in default_route_networks %}"},{"line_number":35,"context_line":"    routes:"},{"line_number":36,"context_line":"    {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_host_routes\u0027) }} + [{\u0027default\u0027: true, \u0027next_hop\u0027: {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_gateway_ip\u0027) }}}]"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9f560f44_82528034","line":33,"updated":"2020-09-30 12:42:14.000000000","message":"ditto, indentation?","commit_id":"1d72874c002d460566477f2512f7ed6a84d2e247"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"e1a13fc0edf8bddd5b46092bde118f464229483b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_ip\u0027) }}/{{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_cidr\u0027) }}"},{"line_number":34,"context_line":"{% if default_route_networks and network in default_route_networks %}"},{"line_number":35,"context_line":"    routes:"},{"line_number":36,"context_line":"    {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_host_routes\u0027) }} + [{\u0027default\u0027: true, \u0027next_hop\u0027: {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_gateway_ip\u0027) }}}]"},{"line_number":37,"context_line":"{% else %}"},{"line_number":38,"context_line":"    routes: {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_host_routes\u0027) }}"},{"line_number":39,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9f560f44_e22c1cb4","line":36,"updated":"2020-09-30 12:42:14.000000000","message":"ditto, indentation?","commit_id":"1d72874c002d460566477f2512f7ed6a84d2e247"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"cb555f82d72ad60bceb9f6818980b728066ca5d1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  domain: {{ dns_search_domains }}"},{"line_number":14,"context_line":"  addresses:"},{"line_number":15,"context_line":"  - ip_netmask: {{ ctlplane_ip }}/{{ ctlplane_subnet_cidr }}"},{"line_number":16,"context_line":"{% if default_route_networks and \u0027ControlPlane\u0027 in default_route_networks %}"},{"line_number":17,"context_line":"  routes: {{ ctlplane_host_routes + [{\u0027default\u0027: true, \u0027next_hop\u0027: ctlplane_gateway_ip}] }}"},{"line_number":18,"context_line":"{% else %}"},{"line_number":19,"context_line":"  routes: {{ ctlplane_host_routes }}"},{"line_number":20,"context_line":"{% endif %}"},{"line_number":21,"context_line":"  members:"},{"line_number":22,"context_line":"  - type: interface"},{"line_number":23,"context_line":"    name: nic1"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9f560f44_cec803aa","line":20,"range":{"start_line":16,"start_character":0,"end_line":20,"end_character":11},"updated":"2020-10-02 07:29:01.000000000","message":"I proposed a patch: https://review.opendev.org/755715\n\nWith that patch we should be able to remove this logic and simply pull the ctlplane_host_routes group var here.\n\n  routes: {{ ctlplane_host_routes }}","commit_id":"f69b41cd57521af1092ffc02ee35290025164465"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"30520967b14a6b740b13595b69032484820652d1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  domain: {{ dns_search_domains }}"},{"line_number":14,"context_line":"  addresses:"},{"line_number":15,"context_line":"  - ip_netmask: {{ ctlplane_ip }}/{{ ctlplane_subnet_cidr }}"},{"line_number":16,"context_line":"{% if default_route_networks and \u0027ControlPlane\u0027 in default_route_networks %}"},{"line_number":17,"context_line":"  routes: {{ ctlplane_host_routes + [{\u0027default\u0027: true, \u0027next_hop\u0027: ctlplane_gateway_ip}] }}"},{"line_number":18,"context_line":"{% else %}"},{"line_number":19,"context_line":"  routes: {{ ctlplane_host_routes }}"},{"line_number":20,"context_line":"{% endif %}"},{"line_number":21,"context_line":"  members:"},{"line_number":22,"context_line":"  - type: interface"},{"line_number":23,"context_line":"    name: nic1"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9f560f44_d9e60bb1","line":20,"range":{"start_line":16,"start_character":0,"end_line":20,"end_character":11},"in_reply_to":"9f560f44_19d9a383","updated":"2020-10-02 09:15:24.000000000","message":"In that case whatever replaces heat should put things together the same way that patch does it in heat? I.e ansible set a fact or dynamically add to group_vars?","commit_id":"f69b41cd57521af1092ffc02ee35290025164465"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"226fdbbcdec16e9024ac4fa0da28f17661e25fc6","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  domain: {{ dns_search_domains }}"},{"line_number":14,"context_line":"  addresses:"},{"line_number":15,"context_line":"  - ip_netmask: {{ ctlplane_ip }}/{{ ctlplane_subnet_cidr }}"},{"line_number":16,"context_line":"{% if default_route_networks and \u0027ControlPlane\u0027 in default_route_networks %}"},{"line_number":17,"context_line":"  routes: {{ ctlplane_host_routes + [{\u0027default\u0027: true, \u0027next_hop\u0027: ctlplane_gateway_ip}] }}"},{"line_number":18,"context_line":"{% else %}"},{"line_number":19,"context_line":"  routes: {{ ctlplane_host_routes }}"},{"line_number":20,"context_line":"{% endif %}"},{"line_number":21,"context_line":"  members:"},{"line_number":22,"context_line":"  - type: interface"},{"line_number":23,"context_line":"    name: nic1"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9f560f44_a9ef721b","line":20,"range":{"start_line":16,"start_character":0,"end_line":20,"end_character":11},"in_reply_to":"9f560f44_2e6088cf","updated":"2020-10-05 09:39:40.000000000","message":"I guess the problem is we don\u0027t know. Removing heat, does that mean removing tripleo-heat-templates, or does it mean processing them with something else? AFAIK there is no spec or design discussion openly available, so who knows ... Removing THT means switching the entire user interface. IMO that would be not good, 3rd party integrations would suffer etc.\n\nMy change also simplifies the heat based nic configs, if you insist on keeping this in ansible I can update the patch to not concatenate the groupvars value. But we should do the work setting the ansible fact so that the user facing ansible templates are kept as simple as possible.","commit_id":"f69b41cd57521af1092ffc02ee35290025164465"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"6df67d13c85be070b87f6105d066b641b7276d43","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  domain: {{ dns_search_domains }}"},{"line_number":14,"context_line":"  addresses:"},{"line_number":15,"context_line":"  - ip_netmask: {{ ctlplane_ip }}/{{ ctlplane_subnet_cidr }}"},{"line_number":16,"context_line":"{% if default_route_networks and \u0027ControlPlane\u0027 in default_route_networks %}"},{"line_number":17,"context_line":"  routes: {{ ctlplane_host_routes + [{\u0027default\u0027: true, \u0027next_hop\u0027: ctlplane_gateway_ip}] }}"},{"line_number":18,"context_line":"{% else %}"},{"line_number":19,"context_line":"  routes: {{ ctlplane_host_routes }}"},{"line_number":20,"context_line":"{% endif %}"},{"line_number":21,"context_line":"  members:"},{"line_number":22,"context_line":"  - type: interface"},{"line_number":23,"context_line":"    name: nic1"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9f560f44_c918e620","line":20,"range":{"start_line":16,"start_character":0,"end_line":20,"end_character":11},"in_reply_to":"9f560f44_a9ef721b","updated":"2020-10-05 09:49:39.000000000","message":"I\u0027m not blocking your patch, just saying that it does not align with the long term strategy of everything ansible. Unless we go the heat as a library way, THT won\u0027t have any significance. Network resource management had been the least problem area for heat, but we want to get rid of it, isn\u0027t it ? And hence all what we\u0027re doing atm.\n\nMy only point is if we want everything in ansible then let\u0027s not add all these manipulations that use yaql and heat intrinsic functions.","commit_id":"f69b41cd57521af1092ffc02ee35290025164465"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"a7702a47cafcc19d410b4ec1844c196900b39357","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  domain: {{ dns_search_domains }}"},{"line_number":14,"context_line":"  addresses:"},{"line_number":15,"context_line":"  - ip_netmask: {{ ctlplane_ip }}/{{ ctlplane_subnet_cidr }}"},{"line_number":16,"context_line":"{% if default_route_networks and \u0027ControlPlane\u0027 in default_route_networks %}"},{"line_number":17,"context_line":"  routes: {{ ctlplane_host_routes + [{\u0027default\u0027: true, \u0027next_hop\u0027: ctlplane_gateway_ip}] }}"},{"line_number":18,"context_line":"{% else %}"},{"line_number":19,"context_line":"  routes: {{ ctlplane_host_routes }}"},{"line_number":20,"context_line":"{% endif %}"},{"line_number":21,"context_line":"  members:"},{"line_number":22,"context_line":"  - type: interface"},{"line_number":23,"context_line":"    name: nic1"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9f560f44_19d9a383","line":20,"range":{"start_line":16,"start_character":0,"end_line":20,"end_character":11},"in_reply_to":"9f560f44_cec803aa","updated":"2020-10-02 08:34:00.000000000","message":"I\u0027m not sure about it. AFAIU long term goal is to move all(most) data manipulation logic away from heat to ansible (and then you push this vars external to heat) and this probably does not fit with that.\n\nThough I completely agree that it would make the jinja templates simpler.","commit_id":"f69b41cd57521af1092ffc02ee35290025164465"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"1a731d6083bc797c760b9124107ec71fa9d49f43","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  domain: {{ dns_search_domains }}"},{"line_number":14,"context_line":"  addresses:"},{"line_number":15,"context_line":"  - ip_netmask: {{ ctlplane_ip }}/{{ ctlplane_subnet_cidr }}"},{"line_number":16,"context_line":"{% if default_route_networks and \u0027ControlPlane\u0027 in default_route_networks %}"},{"line_number":17,"context_line":"  routes: {{ ctlplane_host_routes + [{\u0027default\u0027: true, \u0027next_hop\u0027: ctlplane_gateway_ip}] }}"},{"line_number":18,"context_line":"{% else %}"},{"line_number":19,"context_line":"  routes: {{ ctlplane_host_routes }}"},{"line_number":20,"context_line":"{% endif %}"},{"line_number":21,"context_line":"  members:"},{"line_number":22,"context_line":"  - type: interface"},{"line_number":23,"context_line":"    name: nic1"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9f560f44_2e6088cf","line":20,"range":{"start_line":16,"start_character":0,"end_line":20,"end_character":11},"in_reply_to":"9f560f44_d9e60bb1","updated":"2020-10-05 08:28:21.000000000","message":"AFAIU the assumption is there would be no replacement for heat as everything would be ansibilized;) So all these data manipulations would be in ansible unless it\u0027s done by the cli tool you\u0027re proposing. So yeah we can move these to some additional set_fact tasks in the role if we want.","commit_id":"f69b41cd57521af1092ffc02ee35290025164465"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"cb555f82d72ad60bceb9f6818980b728066ca5d1","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    addresses:"},{"line_number":32,"context_line":"    - ip_netmask:"},{"line_number":33,"context_line":"        {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_ip\u0027) }}/{{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_cidr\u0027) }}"},{"line_number":34,"context_line":"{% if default_route_networks and network in default_route_networks %}"},{"line_number":35,"context_line":"    routes:"},{"line_number":36,"context_line":"      {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_host_routes\u0027) + [{\u0027default\u0027: true, \u0027next_hop\u0027: lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_gateway_ip\u0027)}] }}"},{"line_number":37,"context_line":"{% else %}"},{"line_number":38,"context_line":"    routes: {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_host_routes\u0027) }}"},{"line_number":39,"context_line":"{% endif %}"},{"line_number":40,"context_line":"{% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9f560f44_4ee35335","line":39,"range":{"start_line":34,"start_character":0,"end_line":39,"end_character":11},"updated":"2020-10-02 07:29:01.000000000","message":"I proposed a patch: https://review.opendev.org/755715\n\nWith that patch we should be able to remove this logic and simply pull the _host_routes group var here.\n\n  routes: {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_host_routes\u0027) }}","commit_id":"f69b41cd57521af1092ffc02ee35290025164465"}],"tripleo_ansible/roles/tripleo_network_config/templates/single_nic_vlans/storage_single_nic_vlans.j2":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"b249cb43a30c29794e7b3471730c96b9d3af436f","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% set min_viable_mtu \u003d mtu_list | max %}"},{"line_number":7,"context_line":"network_config:"},{"line_number":8,"context_line":"- type: ovs_bridge"},{"line_number":9,"context_line":"  name: br_storage"},{"line_number":10,"context_line":"  name: {{ neutron_physical_bridge_name }}"},{"line_number":11,"context_line":" mtu: {{ min_viable_mtu }}"},{"line_number":12,"context_line":"  use_dhcp: false"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_c29bd8c5","line":9,"range":{"start_line":9,"start_character":8,"end_line":9,"end_character":18},"updated":"2020-09-30 12:01:01.000000000","message":"\u0027-\u0027 dash, not underscore.","commit_id":"10d0adbef7c02c71c2b452049907dc0c93609609"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"e7790dc7313266b54a444f3cab23da7cb7d8322a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% set min_viable_mtu \u003d mtu_list | max %}"},{"line_number":7,"context_line":"network_config:"},{"line_number":8,"context_line":"- type: ovs_bridge"},{"line_number":9,"context_line":"  name: br_storage"},{"line_number":10,"context_line":"  name: {{ neutron_physical_bridge_name }}"},{"line_number":11,"context_line":" mtu: {{ min_viable_mtu }}"},{"line_number":12,"context_line":"  use_dhcp: false"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_e2853c0c","line":9,"range":{"start_line":9,"start_character":8,"end_line":9,"end_character":18},"in_reply_to":"9f560f44_c29bd8c5","updated":"2020-09-30 12:11:59.000000000","message":"Done","commit_id":"10d0adbef7c02c71c2b452049907dc0c93609609"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"b249cb43a30c29794e7b3471730c96b9d3af436f","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% set min_viable_mtu \u003d mtu_list | max %}"},{"line_number":7,"context_line":"network_config:"},{"line_number":8,"context_line":"- type: ovs_bridge"},{"line_number":9,"context_line":"  name: br_storage"},{"line_number":10,"context_line":"  name: {{ neutron_physical_bridge_name }}"},{"line_number":11,"context_line":" mtu: {{ min_viable_mtu }}"},{"line_number":12,"context_line":"  use_dhcp: false"},{"line_number":13,"context_line":"  dns_servers: {{ ctlplane_dns_nameservers }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_226c54cf","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":42},"updated":"2020-09-30 12:01:01.000000000","message":"name: twice?","commit_id":"10d0adbef7c02c71c2b452049907dc0c93609609"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"e7790dc7313266b54a444f3cab23da7cb7d8322a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% set min_viable_mtu \u003d mtu_list | max %}"},{"line_number":7,"context_line":"network_config:"},{"line_number":8,"context_line":"- type: ovs_bridge"},{"line_number":9,"context_line":"  name: br_storage"},{"line_number":10,"context_line":"  name: {{ neutron_physical_bridge_name }}"},{"line_number":11,"context_line":" mtu: {{ min_viable_mtu }}"},{"line_number":12,"context_line":"  use_dhcp: false"},{"line_number":13,"context_line":"  dns_servers: {{ ctlplane_dns_nameservers }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_2280d4f7","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":42},"in_reply_to":"9f560f44_226c54cf","updated":"2020-09-30 12:11:59.000000000","message":"Done","commit_id":"10d0adbef7c02c71c2b452049907dc0c93609609"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"b249cb43a30c29794e7b3471730c96b9d3af436f","unresolved":false,"context_lines":[{"line_number":8,"context_line":"- type: ovs_bridge"},{"line_number":9,"context_line":"  name: br_storage"},{"line_number":10,"context_line":"  name: {{ neutron_physical_bridge_name }}"},{"line_number":11,"context_line":" mtu: {{ min_viable_mtu }}"},{"line_number":12,"context_line":"  use_dhcp: false"},{"line_number":13,"context_line":"  dns_servers: {{ ctlplane_dns_nameservers }}"},{"line_number":14,"context_line":"  domain: {{ dns_search_domains }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_62aaccd3","line":11,"range":{"start_line":11,"start_character":1,"end_line":11,"end_character":4},"updated":"2020-09-30 12:01:01.000000000","message":"intentation?","commit_id":"10d0adbef7c02c71c2b452049907dc0c93609609"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"e7790dc7313266b54a444f3cab23da7cb7d8322a","unresolved":false,"context_lines":[{"line_number":8,"context_line":"- type: ovs_bridge"},{"line_number":9,"context_line":"  name: br_storage"},{"line_number":10,"context_line":"  name: {{ neutron_physical_bridge_name }}"},{"line_number":11,"context_line":" mtu: {{ min_viable_mtu }}"},{"line_number":12,"context_line":"  use_dhcp: false"},{"line_number":13,"context_line":"  dns_servers: {{ ctlplane_dns_nameservers }}"},{"line_number":14,"context_line":"  domain: {{ dns_search_domains }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_0285d007","line":11,"range":{"start_line":11,"start_character":1,"end_line":11,"end_character":4},"in_reply_to":"9f560f44_62aaccd3","updated":"2020-09-30 12:11:59.000000000","message":"Done","commit_id":"10d0adbef7c02c71c2b452049907dc0c93609609"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"b249cb43a30c29794e7b3471730c96b9d3af436f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  dns_servers: {{ ctlplane_dns_nameservers }}"},{"line_number":14,"context_line":"  domain: {{ dns_search_domains }}"},{"line_number":15,"context_line":"  addresses:"},{"line_number":16,"context_line":"  - ip_netmask: {{ ctlplane_ip }}/{{ ctlplane_subnet_cidr }}"},{"line_number":17,"context_line":"{% if default_route_networks and \u0027ControlPlane\u0027 in default_route_networks %}"},{"line_number":18,"context_line":"  routes: {{ ctlplane_host_routes }} + [{\u0027default\u0027: true, \u0027next_hop\u0027: {{ ctlplane_gateway_ip }}]"},{"line_number":19,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_a2e2242f","line":16,"range":{"start_line":16,"start_character":16,"end_line":16,"end_character":60},"updated":"2020-09-30 12:01:01.000000000","message":"wonder if we should just store a \u0027_ip_netmask\u0027 in host_vars instead of joining it here.","commit_id":"10d0adbef7c02c71c2b452049907dc0c93609609"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"b249cb43a30c29794e7b3471730c96b9d3af436f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    vlan_id: {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_vlan_id\u0027) }}"},{"line_number":32,"context_line":"    addresses:"},{"line_number":33,"context_line":"    - ip_netmask:"},{"line_number":34,"context_line":"      {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_ip\u0027) }}/{{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_cidr\u0027) }}"},{"line_number":35,"context_line":"{% if default_route_networks and \u0027ControlPlane\u0027 in default_route_networks %}"},{"line_number":36,"context_line":"    routes:"},{"line_number":37,"context_line":"    {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_host_routes\u0027) }} + [{\u0027default\u0027: true, \u0027next_hop\u0027: {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_gateway_ip\u0027) }}}]"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_22ef341e","line":34,"range":{"start_line":34,"start_character":6,"end_line":34,"end_character":125},"updated":"2020-09-30 12:01:01.000000000","message":"wonder if we should just store a \u0027_ip_netmask\u0027 in host_vars instead of joining it here. Keep it simpler here since this is user facing.","commit_id":"10d0adbef7c02c71c2b452049907dc0c93609609"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"b249cb43a30c29794e7b3471730c96b9d3af436f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    addresses:"},{"line_number":33,"context_line":"    - ip_netmask:"},{"line_number":34,"context_line":"      {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_ip\u0027) }}/{{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_cidr\u0027) }}"},{"line_number":35,"context_line":"{% if default_route_networks and \u0027ControlPlane\u0027 in default_route_networks %}"},{"line_number":36,"context_line":"    routes:"},{"line_number":37,"context_line":"    {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_host_routes\u0027) }} + [{\u0027default\u0027: true, \u0027next_hop\u0027: {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_gateway_ip\u0027) }}}]"},{"line_number":38,"context_line":"{% else %}"},{"line_number":39,"context_line":"    routes: {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_host_routes\u0027) }}"},{"line_number":40,"context_line":"{% endif %}"},{"line_number":41,"context_line":"{% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9f560f44_82b1e047","line":38,"range":{"start_line":35,"start_character":0,"end_line":38,"end_character":10},"updated":"2020-09-30 12:01:01.000000000","message":"only set default route on one interface. i.e it\u0027s done above.","commit_id":"10d0adbef7c02c71c2b452049907dc0c93609609"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"e1a13fc0edf8bddd5b46092bde118f464229483b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"{% set mtu_list \u003d [] %}"},{"line_number":3,"context_line":"{% for network in role_networks %}"},{"line_number":4,"context_line":"  {{ mtu_list.append(lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_mtu\u0027)) }}"},{"line_number":5,"context_line":"{% endfor %}"},{"line_number":6,"context_line":"{% set min_viable_mtu \u003d mtu_list | max %}"},{"line_number":7,"context_line":"network_config:"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9f560f44_cd4dc972","line":4,"range":{"start_line":4,"start_character":2,"end_line":4,"end_character":78},"updated":"2020-09-30 12:42:14.000000000","message":"Should be {%- %}, not {{ }} ?","commit_id":"1d72874c002d460566477f2512f7ed6a84d2e247"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"e1a13fc0edf8bddd5b46092bde118f464229483b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    vlan_id: {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_vlan_id\u0027) }}"},{"line_number":31,"context_line":"    addresses:"},{"line_number":32,"context_line":"    - ip_netmask:"},{"line_number":33,"context_line":"      {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_ip\u0027) }}/{{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_cidr\u0027) }}"},{"line_number":34,"context_line":"{% if default_route_networks and network in default_route_networks %}"},{"line_number":35,"context_line":"    routes:"},{"line_number":36,"context_line":"    {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_host_routes\u0027) }} + [{\u0027default\u0027: true, \u0027next_hop\u0027: {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_gateway_ip\u0027) }}}]"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9f560f44_2d53a518","line":33,"updated":"2020-09-30 12:42:14.000000000","message":"need intentation?","commit_id":"1d72874c002d460566477f2512f7ed6a84d2e247"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"e1a13fc0edf8bddd5b46092bde118f464229483b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_ip\u0027) }}/{{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_cidr\u0027) }}"},{"line_number":34,"context_line":"{% if default_route_networks and network in default_route_networks %}"},{"line_number":35,"context_line":"    routes:"},{"line_number":36,"context_line":"    {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_host_routes\u0027) }} + [{\u0027default\u0027: true, \u0027next_hop\u0027: {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_gateway_ip\u0027) }}}]"},{"line_number":37,"context_line":"{% else %}"},{"line_number":38,"context_line":"    routes: {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_host_routes\u0027) }}"},{"line_number":39,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9f560f44_0d58612f","line":36,"updated":"2020-09-30 12:42:14.000000000","message":"need intentation?","commit_id":"1d72874c002d460566477f2512f7ed6a84d2e247"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"785b9032b12de2d21d96eb61dd7bd19a892aefca","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% set min_viable_mtu \u003d mtu_list | max %}"},{"line_number":7,"context_line":"network_config:"},{"line_number":8,"context_line":"- type: ovs_bridge"},{"line_number":9,"context_line":"  name: br-storage"},{"line_number":10,"context_line":"  mtu: {{ min_viable_mtu }}"},{"line_number":11,"context_line":"  use_dhcp: false"},{"line_number":12,"context_line":"  dns_servers: {{ ctlplane_dns_nameservers }}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9f560f44_626f55fa","line":9,"range":{"start_line":9,"start_character":8,"end_line":9,"end_character":18},"updated":"2020-10-01 16:32:07.000000000","message":"is there a reason the name isn\u0027t dynamic on this one?","commit_id":"f69b41cd57521af1092ffc02ee35290025164465"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"20443c1c6f25f57a5cd3b0908b86a6dd734d0234","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% set min_viable_mtu \u003d mtu_list | max %}"},{"line_number":7,"context_line":"network_config:"},{"line_number":8,"context_line":"- type: ovs_bridge"},{"line_number":9,"context_line":"  name: br-storage"},{"line_number":10,"context_line":"  mtu: {{ min_viable_mtu }}"},{"line_number":11,"context_line":"  use_dhcp: false"},{"line_number":12,"context_line":"  dns_servers: {{ ctlplane_dns_nameservers }}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9f560f44_1d299836","line":9,"range":{"start_line":9,"start_character":8,"end_line":9,"end_character":18},"in_reply_to":"9f560f44_626f55fa","updated":"2020-10-01 16:49:39.000000000","message":"dynamic in what way? This template is to be used for certain roles and bridge name is common(static)[1].\n\nhttps://github.com/openstack/tripleo-heat-templates/blob/master/network/config/single-nic-vlans/role.role.j2.yaml#L116-L117","commit_id":"f69b41cd57521af1092ffc02ee35290025164465"}]}