)]}'
{"tripleo_ansible/ansible_plugins/modules/tripleo_ovs_upgrade.py":[{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"e28fa8b2b86d368a196d1d36739e47e34a246f96","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    It\u0027s rhosp-package on redhat, and rdo-openvswitch on centos."},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    \"\"\""},{"line_number":264,"context_line":"    if os.path.exists(\u0027/etc/redhat-release\u0027):"},{"line_number":265,"context_line":"        return \u0027rhosp-openvswitch\u0027"},{"line_number":266,"context_line":"    else:"},{"line_number":267,"context_line":"        return \u0027rdo-openvswitch\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_2ecf118c","line":264,"range":{"start_line":264,"start_character":4,"end_line":264,"end_character":45},"updated":"2020-10-01 07:35:51.000000000","message":"Actually /etc/redhat-release exist in CentOS, it\u0027s a link to centos-release:\n\n# ls -l /etc/redhat-release \nlrwxrwxrwx. 1 root root 14 Sep 15 20:10 /etc/redhat-release -\u003e centos-release\n\nIt may work to do it the other way around, check for /etc/centos-release existence.\n\nAlso, this assumes that Tripleo with RDO will always run on CentOS. In the past there were CI jobs running with RDO on RHEL which will not work with this. It may be better to test which package is actually installed rhosp-openvswitch or rdo-openvswitch if any instead of asume RDO \u003d\u003d CentOS and OSP \u003d\u003d RHEL.","commit_id":"58a6afca4c3979350047aadec114582753448057"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"ef26d380900e67eb4c09d77fe924b7645bd4c2d6","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    It\u0027s rhosp-package on redhat, and rdo-openvswitch on centos."},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    \"\"\""},{"line_number":264,"context_line":"    if os.path.exists(\u0027/etc/redhat-release\u0027):"},{"line_number":265,"context_line":"        return \u0027rhosp-openvswitch\u0027"},{"line_number":266,"context_line":"    else:"},{"line_number":267,"context_line":"        return \u0027rdo-openvswitch\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_fd0024b4","line":264,"range":{"start_line":264,"start_character":4,"end_line":264,"end_character":45},"in_reply_to":"9f560f44_2ecf118c","updated":"2020-10-01 16:47:53.000000000","message":"maybe we can fall back to os-release, which should exist no matter the distro?","commit_id":"58a6afca4c3979350047aadec114582753448057"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"18d29ea8fcdb68f93a7e49c7ece07db1c9d32e38","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    It\u0027s rhosp-package on redhat, and rdo-openvswitch on centos."},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    \"\"\""},{"line_number":264,"context_line":"    if os.path.exists(\u0027/etc/redhat-release\u0027):"},{"line_number":265,"context_line":"        return \u0027rhosp-openvswitch\u0027"},{"line_number":266,"context_line":"    else:"},{"line_number":267,"context_line":"        return \u0027rdo-openvswitch\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_b37b33f2","line":264,"range":{"start_line":264,"start_character":4,"end_line":264,"end_character":45},"in_reply_to":"9f560f44_8136c24e","updated":"2020-10-07 16:16:03.000000000","message":"crap... there used to be \n\n    platform.linux_distribution()\n\nin python stdlib, but it\u0027s been removed in python3.8.  Now you need the \"distro\" package, which isn\u0027t installed by default.  I\u0027ll end up parsing this file then.\n\nThanks.\n\nhttps://docs.python.org/2.7/library/platform.html#platform.linux_distribution","commit_id":"58a6afca4c3979350047aadec114582753448057"},{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"ee843690db4cda71a69d8fc31d6f8054f3461387","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    It\u0027s rhosp-package on redhat, and rdo-openvswitch on centos."},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    \"\"\""},{"line_number":264,"context_line":"    if os.path.exists(\u0027/etc/redhat-release\u0027):"},{"line_number":265,"context_line":"        return \u0027rhosp-openvswitch\u0027"},{"line_number":266,"context_line":"    else:"},{"line_number":267,"context_line":"        return \u0027rdo-openvswitch\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_8136c24e","line":264,"range":{"start_line":264,"start_character":4,"end_line":264,"end_character":45},"in_reply_to":"9f560f44_fd0024b4","updated":"2020-10-05 14:37:40.000000000","message":"my 2 cents... \n\nsource /etc/os-release\necho $NAME; echo $VERSION works well across the distros we use","commit_id":"58a6afca4c3979350047aadec114582753448057"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"abdfd9569c3812a3f2d6625a0e12dce04d4d6d14","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    \"\"\""},{"line_number":282,"context_line":"    distro \u003d get_distro()"},{"line_number":283,"context_line":"    if distro is not None:"},{"line_number":284,"context_line":"        if distro \u003d\u003d \u0027centos\u0027:"},{"line_number":285,"context_line":"            return \u0027rdo-openvswitch\u0027"},{"line_number":286,"context_line":"    return \u0027rhosp-openvswitch\u0027"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_2f4b79b0","line":284,"range":{"start_line":284,"start_character":21,"end_line":284,"end_character":29},"updated":"2020-11-02 16:34:23.000000000","message":"\u0027\"centos\"\u0027:","commit_id":"c28c9ab0700c7d9325478023818ee4a4e43f0a4b"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"a1644d4bdace3c4260fa1a1a6ff41f466c13c28c","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    \"\"\""},{"line_number":282,"context_line":"    distro \u003d get_distro()"},{"line_number":283,"context_line":"    if distro is not None:"},{"line_number":284,"context_line":"        if distro \u003d\u003d \u0027centos\u0027:"},{"line_number":285,"context_line":"            return \u0027rdo-openvswitch\u0027"},{"line_number":286,"context_line":"    return \u0027rhosp-openvswitch\u0027"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_8fbe0d63","line":284,"range":{"start_line":284,"start_character":21,"end_line":284,"end_character":29},"in_reply_to":"1f621f24_2f4b79b0","updated":"2020-11-02 16:38:01.000000000","message":"without this it always return rhosp-openvswitch","commit_id":"c28c9ab0700c7d9325478023818ee4a4e43f0a4b"}]}