)]}'
{"tripleo_ansible/roles/tripleo_network_config/templates/2_linux_bonds_vlans/2-linux-bonds-vlans.j2":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"40cd988ea08f7af2bd937222c18cc05ee85f6493","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  routes: {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_host_routes\u0027) }}"},{"line_number":60,"context_line":"{% endif %}"},{"line_number":61,"context_line":"{% endfor %}"},{"line_number":62,"context_line":"{%- if not tripleo_role_name.startswith(\u0027ComputeOvsDpdk\u0027) %}"},{"line_number":63,"context_line":"- type: ovs_bridge"},{"line_number":64,"context_line":"  name: {{ neutron_physical_bridge_name }}"},{"line_number":65,"context_line":"  dns_servers: {{ ctlplane_dns_nameservers }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9f560f44_3ffef003","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":60},"updated":"2020-10-05 11:39:34.000000000","message":"I think we have decided to not have role_name specific checks in these templates, rather have separate templates if there is role specific configuration[1] as these would be specified per role.\n\n[1] https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo_network_config/templates/single_nic_vlans/storage_single_nic_vlans.j2","commit_id":"1a75e233a5d3cb63f3b2947a4e08f52cd13a43f2"}],"tripleo_ansible/roles/tripleo_network_config/templates/2_linux_bonds_vlans/2_linux_bonds_vlans.j2":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"588b75749fe266d8fa3e01f94184b5e5a2690e3f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  addresses:"},{"line_number":27,"context_line":"  - ip_netmask: {{ ctlplane_ip }}/{{ ctlplane_subnet_cidr }}"},{"line_number":28,"context_line":"{# TODO(emilien) remove this block after https://review.opendev.org/755715 #}"},{"line_number":29,"context_line":"{% if default_route_networks and \u0027ControlPlane\u0027 in default_route_networks %}"},{"line_number":30,"context_line":"  routes: {{ ctlplane_host_routes + [{\u0027default\u0027: true, \u0027next_hop\u0027: ctlplane_gateway_ip}] }}"},{"line_number":31,"context_line":"{% else %}"},{"line_number":32,"context_line":"  routes: {{ ctlplane_host_routes }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9f560f44_933d6bbe","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":76},"updated":"2020-10-06 05:25:08.000000000","message":"I think this condition would be, thanks to Harald for pointing it out.\n\n{% if default_route_networks is not defined or \u0027ControlPlane\u0027 in default networks%}","commit_id":"45adc88e951005bb36699b6a06f9f6d859437fa7"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0c4d4ab15e478aa1e8d787532ac0fc089474d108","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  addresses:"},{"line_number":27,"context_line":"  - ip_netmask: {{ ctlplane_ip }}/{{ ctlplane_subnet_cidr }}"},{"line_number":28,"context_line":"{# TODO(emilien) remove this block after https://review.opendev.org/755715 #}"},{"line_number":29,"context_line":"{% if default_route_networks and \u0027ControlPlane\u0027 in default_route_networks %}"},{"line_number":30,"context_line":"  routes: {{ ctlplane_host_routes + [{\u0027default\u0027: true, \u0027next_hop\u0027: ctlplane_gateway_ip}] }}"},{"line_number":31,"context_line":"{% else %}"},{"line_number":32,"context_line":"  routes: {{ ctlplane_host_routes }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9f560f44_b0b50035","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":76},"in_reply_to":"9f560f44_933d6bbe","updated":"2020-10-06 10:46:54.000000000","message":"ack, done","commit_id":"45adc88e951005bb36699b6a06f9f6d859437fa7"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"588b75749fe266d8fa3e01f94184b5e5a2690e3f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  bonding_options: {{ bound_interface_ovs_options }}"},{"line_number":39,"context_line":"  dns_servers: {{ ctlplane_dns_nameservers }}"},{"line_number":40,"context_line":"  domain: {{ dns_search_domains }}"},{"line_number":41,"context_line":"  members: {{ min_viable_mtu }}"},{"line_number":42,"context_line":"  - type: interface"},{"line_number":43,"context_line":"    name: nic2"},{"line_number":44,"context_line":"    mtu: {{ min_viable_mtu }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9f560f44_535473fe","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":31},"updated":"2020-10-06 05:25:08.000000000","message":"This looks incorrect","commit_id":"45adc88e951005bb36699b6a06f9f6d859437fa7"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0c4d4ab15e478aa1e8d787532ac0fc089474d108","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  bonding_options: {{ bound_interface_ovs_options }}"},{"line_number":39,"context_line":"  dns_servers: {{ ctlplane_dns_nameservers }}"},{"line_number":40,"context_line":"  domain: {{ dns_search_domains }}"},{"line_number":41,"context_line":"  members: {{ min_viable_mtu }}"},{"line_number":42,"context_line":"  - type: interface"},{"line_number":43,"context_line":"    name: nic2"},{"line_number":44,"context_line":"    mtu: {{ min_viable_mtu }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9f560f44_b08ea076","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":31},"in_reply_to":"9f560f44_535473fe","updated":"2020-10-06 10:46:54.000000000","message":"Done","commit_id":"45adc88e951005bb36699b6a06f9f6d859437fa7"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"bf459217a36c83591ee6e5d154eec102395ed1ba","unresolved":false,"context_lines":[{"line_number":14,"context_line":"{# The bridge, bond or interface must have an MTU to allow the VLAN with the #}"},{"line_number":15,"context_line":"{# largest MTU. #}"},{"line_number":16,"context_line":"{% set mtu_dataplane_list \u003d [] %}"},{"line_number":17,"context_line":"{% for network in role_networks if network.startswith(\u0027Tenant\u0027) %}"},{"line_number":18,"context_line":"{{ mtu_dataplane_list.append(lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_mtu\u0027)) }}"},{"line_number":19,"context_line":"{%- endfor %}"},{"line_number":20,"context_line":"{% set min_viable_mtu_dataplane \u003d mtu_dataplane_list | max %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9f560f44_bbb834e8","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":66},"updated":"2020-10-07 03:14:23.000000000","message":"Probably could have used the same for loop for both these.","commit_id":"b66bca3b2aef5d545b71da1bf5dd9625d75acac3"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"20cac10cdf896533acc722bc63ecb9035223008c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"{# The bridge, bond or interface must have an MTU to allow the VLAN with the #}"},{"line_number":15,"context_line":"{# largest MTU. #}"},{"line_number":16,"context_line":"{% set mtu_dataplane_list \u003d [] %}"},{"line_number":17,"context_line":"{% for network in role_networks if network.startswith(\u0027Tenant\u0027) %}"},{"line_number":18,"context_line":"{{ mtu_dataplane_list.append(lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_mtu\u0027)) }}"},{"line_number":19,"context_line":"{%- endfor %}"},{"line_number":20,"context_line":"{% set min_viable_mtu_dataplane \u003d mtu_dataplane_list | max %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9f560f44_166e5295","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":66},"in_reply_to":"9f560f44_bbb834e8","updated":"2020-10-07 12:25:48.000000000","message":"yes indeed, let me fix that","commit_id":"b66bca3b2aef5d545b71da1bf5dd9625d75acac3"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"2d3ad55591989a399289f23c79d1898eca38345f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"{% set mtu_ctlplane_list \u003d [] %}"},{"line_number":3,"context_line":"{% set mtu_dataplane_list \u003d [] %}"},{"line_number":4,"context_line":"{{ mtu_ctlplane_list.append(lookup(\u0027vars\u0027, ctlplane_mtu)) }}"},{"line_number":5,"context_line":"{% for network in role_networks %}"},{"line_number":6,"context_line":"{# This block resolves the minimum viable MTU for interfaces connected to #}"},{"line_number":7,"context_line":"{# the dataplane network(s), which start by \"Tenant\", and also bonds #}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9f560f44_ff3445ae","line":4,"range":{"start_line":4,"start_character":28,"end_line":4,"end_character":57},"updated":"2020-10-08 04:02:16.000000000","message":"We probably don\u0027t need to dynamic lookup here. Below would have been sufficient.\n\n{% set mtu_ctlplane_list \u003d [ctlplane_mtu] %}","commit_id":"7aca7246280422bd323ab11517f5f64040e5af96"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"f3c448ad88e6a6f09a9be501c4b4699e0808ca63","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  - type: interface"},{"line_number":43,"context_line":"    name: nic3"},{"line_number":44,"context_line":"    mtu: {{ min_viable_mtu_ctlplane }}"},{"line_number":45,"context_line":"{% for network in role_networks if network.startswith(\u0027Tenant\u0027) %}"},{"line_number":46,"context_line":"- type: vlan"},{"line_number":47,"context_line":"  device: bond_api"},{"line_number":48,"context_line":"  mtu: {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_mtu\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"9f560f44_5dfc470b","line":45,"updated":"2020-10-09 03:23:58.000000000","message":"not?","commit_id":"6a51e427e8cb41c8a20414843cbc24fac5cb8364"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"0464183da49f53b0f9487d404dc8e9dab6660d7e","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  - type: interface"},{"line_number":43,"context_line":"    name: nic3"},{"line_number":44,"context_line":"    mtu: {{ min_viable_mtu_ctlplane }}"},{"line_number":45,"context_line":"{% for network in role_networks if network.startswith(\u0027Tenant\u0027) %}"},{"line_number":46,"context_line":"- type: vlan"},{"line_number":47,"context_line":"  device: bond_api"},{"line_number":48,"context_line":"  mtu: {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_mtu\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"9f560f44_9d537fde","line":45,"in_reply_to":"9f560f44_5dfc470b","updated":"2020-10-09 03:43:23.000000000","message":"Done","commit_id":"6a51e427e8cb41c8a20414843cbc24fac5cb8364"}],"tripleo_ansible/roles/tripleo_network_config/templates/2_linux_bonds_vlans/2_linux_bonds_vlans_dpdk.j2":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"588b75749fe266d8fa3e01f94184b5e5a2690e3f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  addresses:"},{"line_number":17,"context_line":"  - ip_netmask: {{ ctlplane_ip }}/{{ ctlplane_subnet_cidr }}"},{"line_number":18,"context_line":"{# TODO(emilien) remove this block after https://review.opendev.org/755715 #}"},{"line_number":19,"context_line":"{% if default_route_networks and \u0027ControlPlane\u0027 in default_route_networks %}"},{"line_number":20,"context_line":"  routes: {{ ctlplane_host_routes + [{\u0027default\u0027: true, \u0027next_hop\u0027: ctlplane_gateway_ip}] }}"},{"line_number":21,"context_line":"{% else %}"},{"line_number":22,"context_line":"  routes: {{ ctlplane_host_routes }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9f560f44_d347e34b","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":76},"updated":"2020-10-06 05:25:08.000000000","message":"As mentioned in the other template this condition needs to be changed.","commit_id":"45adc88e951005bb36699b6a06f9f6d859437fa7"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0c4d4ab15e478aa1e8d787532ac0fc089474d108","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  addresses:"},{"line_number":17,"context_line":"  - ip_netmask: {{ ctlplane_ip }}/{{ ctlplane_subnet_cidr }}"},{"line_number":18,"context_line":"{# TODO(emilien) remove this block after https://review.opendev.org/755715 #}"},{"line_number":19,"context_line":"{% if default_route_networks and \u0027ControlPlane\u0027 in default_route_networks %}"},{"line_number":20,"context_line":"  routes: {{ ctlplane_host_routes + [{\u0027default\u0027: true, \u0027next_hop\u0027: ctlplane_gateway_ip}] }}"},{"line_number":21,"context_line":"{% else %}"},{"line_number":22,"context_line":"  routes: {{ ctlplane_host_routes }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9f560f44_70c24888","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":76},"in_reply_to":"9f560f44_d347e34b","updated":"2020-10-06 10:46:54.000000000","message":"Done","commit_id":"45adc88e951005bb36699b6a06f9f6d859437fa7"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"588b75749fe266d8fa3e01f94184b5e5a2690e3f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  bonding_options: {{ bound_interface_ovs_options }}"},{"line_number":29,"context_line":"  dns_servers: {{ ctlplane_dns_nameservers }}"},{"line_number":30,"context_line":"  domain: {{ dns_search_domains }}"},{"line_number":31,"context_line":"  members: {{ min_viable_mtu }}"},{"line_number":32,"context_line":"  - type: interface"},{"line_number":33,"context_line":"    name: nic2"},{"line_number":34,"context_line":"    mtu: {{ min_viable_mtu }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9f560f44_b3422f3a","line":31,"range":{"start_line":31,"start_character":2,"end_line":31,"end_character":31},"updated":"2020-10-06 05:25:08.000000000","message":"same here.","commit_id":"45adc88e951005bb36699b6a06f9f6d859437fa7"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0c4d4ab15e478aa1e8d787532ac0fc089474d108","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  bonding_options: {{ bound_interface_ovs_options }}"},{"line_number":29,"context_line":"  dns_servers: {{ ctlplane_dns_nameservers }}"},{"line_number":30,"context_line":"  domain: {{ dns_search_domains }}"},{"line_number":31,"context_line":"  members: {{ min_viable_mtu }}"},{"line_number":32,"context_line":"  - type: interface"},{"line_number":33,"context_line":"    name: nic2"},{"line_number":34,"context_line":"    mtu: {{ min_viable_mtu }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9f560f44_50bd8401","line":31,"range":{"start_line":31,"start_character":2,"end_line":31,"end_character":31},"in_reply_to":"9f560f44_b3422f3a","updated":"2020-10-06 10:46:54.000000000","message":"Done","commit_id":"45adc88e951005bb36699b6a06f9f6d859437fa7"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"f3c448ad88e6a6f09a9be501c4b4699e0808ca63","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  use_dhcp: false"},{"line_number":17,"context_line":"  addresses:"},{"line_number":18,"context_line":"  - ip_netmask: {{ ctlplane_ip }}/{{ ctlplane_subnet_cidr }}"},{"line_number":19,"context_line":"{# TODO(emilien) remove this block after https://review.opendev.org/755715 #}"},{"line_number":20,"context_line":"  routes: {{ ctlplane_host_routes }}"},{"line_number":21,"context_line":"- type: linux_bond"},{"line_number":22,"context_line":"  name: bond_api"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"9f560f44_5d2567ad","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":77},"updated":"2020-10-09 03:23:58.000000000","message":"nit: Drop this comment.","commit_id":"6a51e427e8cb41c8a20414843cbc24fac5cb8364"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"0464183da49f53b0f9487d404dc8e9dab6660d7e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  use_dhcp: false"},{"line_number":17,"context_line":"  addresses:"},{"line_number":18,"context_line":"  - ip_netmask: {{ ctlplane_ip }}/{{ ctlplane_subnet_cidr }}"},{"line_number":19,"context_line":"{# TODO(emilien) remove this block after https://review.opendev.org/755715 #}"},{"line_number":20,"context_line":"  routes: {{ ctlplane_host_routes }}"},{"line_number":21,"context_line":"- type: linux_bond"},{"line_number":22,"context_line":"  name: bond_api"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"9f560f44_7d582bf8","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":77},"in_reply_to":"9f560f44_5d2567ad","updated":"2020-10-09 03:43:23.000000000","message":"Done","commit_id":"6a51e427e8cb41c8a20414843cbc24fac5cb8364"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"f3c448ad88e6a6f09a9be501c4b4699e0808ca63","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  - type: interface"},{"line_number":34,"context_line":"    name: nic3"},{"line_number":35,"context_line":"    mtu: {{ min_viable_mtu }}"},{"line_number":36,"context_line":"{% for network in role_networks if network.startswith(\u0027Tenant\u0027) %}"},{"line_number":37,"context_line":"- type: vlan"},{"line_number":38,"context_line":"  device: bond_api"},{"line_number":39,"context_line":"  mtu: {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_mtu\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"9f560f44_dd0fb72c","line":36,"updated":"2020-10-09 03:23:58.000000000","message":"not?","commit_id":"6a51e427e8cb41c8a20414843cbc24fac5cb8364"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"0464183da49f53b0f9487d404dc8e9dab6660d7e","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  - type: interface"},{"line_number":34,"context_line":"    name: nic3"},{"line_number":35,"context_line":"    mtu: {{ min_viable_mtu }}"},{"line_number":36,"context_line":"{% for network in role_networks if network.startswith(\u0027Tenant\u0027) %}"},{"line_number":37,"context_line":"- type: vlan"},{"line_number":38,"context_line":"  device: bond_api"},{"line_number":39,"context_line":"  mtu: {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_mtu\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"9f560f44_dd705776","line":36,"in_reply_to":"9f560f44_dd0fb72c","updated":"2020-10-09 03:43:23.000000000","message":"Done","commit_id":"6a51e427e8cb41c8a20414843cbc24fac5cb8364"}]}