)]}'
{"tripleo_ansible/roles/tripleo_network_config/templates/multiple_nics/multiple_nics_dpdk.j2":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"de424e390250c2c23bd7ed1f807ed773fcf808e2","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  mtu: {{ ctlplane_mtu }}"},{"line_number":6,"context_line":"  dns_servers: {{ ctlplane_dns_nameservers }}"},{"line_number":7,"context_line":"  domain: {{ dns_search_domains }}"},{"line_number":8,"context_line":"{% if default_route_networks and \u0027ControlPlane\u0027 in default_route_networks %}"},{"line_number":9,"context_line":"  routes: {{ ctlplane_host_routes + [{\u0027default\u0027: true, \u0027next_hop\u0027: ctlplane_gateway_ip}] }}"},{"line_number":10,"context_line":"{% else %}"},{"line_number":11,"context_line":"  routes: {{ ctlplane_host_routes }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9f560f44_27570104","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":76},"updated":"2020-10-05 20:44:53.000000000","message":"I just realized this logic is different from the logic in THT[1]. In THT we set the default gateway on the ctlplane interface if \u0027default_route_network\u0027 is not defined.\n\nThese templates will not set a default route on roles without \n\u0027default_route_networks\u0027 defined.\n\nI missed this when reviewing previous patches, we may want to just merge this and then push one patch to fix all templates that already merged.\n\n[1] https://opendev.org/openstack/tripleo-heat-templates/src/branch/master/network/config/multiple-nics/role.role.j2.yaml#L131","commit_id":"11c9fd493ac65e77a9bcb76ccd3351288982cc20"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"7fea802e8ea4dcce1d499a3292998251bf900fb2","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  mtu: {{ ctlplane_mtu }}"},{"line_number":6,"context_line":"  dns_servers: {{ ctlplane_dns_nameservers }}"},{"line_number":7,"context_line":"  domain: {{ dns_search_domains }}"},{"line_number":8,"context_line":"{% if default_route_networks and \u0027ControlPlane\u0027 in default_route_networks %}"},{"line_number":9,"context_line":"  routes: {{ ctlplane_host_routes + [{\u0027default\u0027: true, \u0027next_hop\u0027: ctlplane_gateway_ip}] }}"},{"line_number":10,"context_line":"{% else %}"},{"line_number":11,"context_line":"  routes: {{ ctlplane_host_routes }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9f560f44_7daea62f","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":76},"in_reply_to":"9f560f44_27570104","updated":"2020-10-06 02:04:01.000000000","message":"Thanks for spotting that. I missed it somehow.","commit_id":"11c9fd493ac65e77a9bcb76ccd3351288982cc20"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"de424e390250c2c23bd7ed1f807ed773fcf808e2","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  addresses:"},{"line_number":24,"context_line":"  - ip_netmask:"},{"line_number":25,"context_line":"      {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_ip\u0027) }}/{{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_cidr\u0027) }}"},{"line_number":26,"context_line":"{% if default_route_networks and \u0027ControlPlane\u0027 in default_route_networks %}"},{"line_number":27,"context_line":"  routes:"},{"line_number":28,"context_line":"    {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_host_routes\u0027) + [{\u0027default\u0027: true, \u0027next_hop\u0027: lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_gateway_ip\u0027)}] }}"},{"line_number":29,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9f560f44_476dd5ca","line":26,"range":{"start_line":26,"start_character":33,"end_line":26,"end_character":48},"updated":"2020-10-05 20:44:53.000000000","message":"s/\u0027ControlPlane\u0027/network/ ?","commit_id":"11c9fd493ac65e77a9bcb76ccd3351288982cc20"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"7fea802e8ea4dcce1d499a3292998251bf900fb2","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  addresses:"},{"line_number":24,"context_line":"  - ip_netmask:"},{"line_number":25,"context_line":"      {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_ip\u0027) }}/{{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_cidr\u0027) }}"},{"line_number":26,"context_line":"{% if default_route_networks and \u0027ControlPlane\u0027 in default_route_networks %}"},{"line_number":27,"context_line":"  routes:"},{"line_number":28,"context_line":"    {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_host_routes\u0027) + [{\u0027default\u0027: true, \u0027next_hop\u0027: lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_gateway_ip\u0027)}] }}"},{"line_number":29,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9f560f44_5da92223","line":26,"range":{"start_line":26,"start_character":33,"end_line":26,"end_character":48},"in_reply_to":"9f560f44_476dd5ca","updated":"2020-10-06 02:04:01.000000000","message":"Done","commit_id":"11c9fd493ac65e77a9bcb76ccd3351288982cc20"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"de424e390250c2c23bd7ed1f807ed773fcf808e2","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  name: {{ \u0027br-\u0027 ~ role_networks_lower[network] }}"},{"line_number":38,"context_line":"{% endif %}"},{"line_number":39,"context_line":"  mtu: {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_mtu\u0027) }}"},{"line_number":40,"context_line":"  dns_servers: {{ ctlplane_dns_nameservers }}"},{"line_number":41,"context_line":"  use_dhcp: false"},{"line_number":42,"context_line":"  addresses:"},{"line_number":43,"context_line":"  - ip_netmask:"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9f560f44_0798fdc9","line":40,"range":{"start_line":40,"start_character":2,"end_line":40,"end_character":45},"updated":"2020-10-05 20:44:53.000000000","message":"nit: This is redundant since we set DNS servers on the ctlplane interface at L6. (I guess we did this in THT as well ...)","commit_id":"11c9fd493ac65e77a9bcb76ccd3351288982cc20"}],"tripleo_ansible/roles/tripleo_network_config/templates/multiple_nics/multiple_nics_dvr.j2":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"de424e390250c2c23bd7ed1f807ed773fcf808e2","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  addresses:"},{"line_number":24,"context_line":"  - ip_netmask:"},{"line_number":25,"context_line":"      {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_ip\u0027) }}/{{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_cidr\u0027) }}"},{"line_number":26,"context_line":"{% if default_route_networks and \u0027ControlPlane\u0027 in default_route_networks %}"},{"line_number":27,"context_line":"  routes:"},{"line_number":28,"context_line":"    {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_host_routes\u0027) + [{\u0027default\u0027: true, \u0027next_hop\u0027: lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_gateway_ip\u0027)}] }}"},{"line_number":29,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9f560f44_07347dab","line":26,"range":{"start_line":26,"start_character":33,"end_line":26,"end_character":47},"updated":"2020-10-05 20:44:53.000000000","message":"ditto? s/\u0027ControlPlane\u0027/network/","commit_id":"11c9fd493ac65e77a9bcb76ccd3351288982cc20"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"7fea802e8ea4dcce1d499a3292998251bf900fb2","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  addresses:"},{"line_number":24,"context_line":"  - ip_netmask:"},{"line_number":25,"context_line":"      {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_ip\u0027) }}/{{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_cidr\u0027) }}"},{"line_number":26,"context_line":"{% if default_route_networks and \u0027ControlPlane\u0027 in default_route_networks %}"},{"line_number":27,"context_line":"  routes:"},{"line_number":28,"context_line":"    {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_host_routes\u0027) + [{\u0027default\u0027: true, \u0027next_hop\u0027: lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_gateway_ip\u0027)}] }}"},{"line_number":29,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9f560f44_bda83e20","line":26,"range":{"start_line":26,"start_character":33,"end_line":26,"end_character":47},"in_reply_to":"9f560f44_07347dab","updated":"2020-10-06 02:04:01.000000000","message":"Done","commit_id":"11c9fd493ac65e77a9bcb76ccd3351288982cc20"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"de424e390250c2c23bd7ed1f807ed773fcf808e2","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  name: {{ \u0027br-\u0027 ~ role_networks_lower[network] }}"},{"line_number":35,"context_line":"  name: {{ neutron_physical_bridge_name }}"},{"line_number":36,"context_line":"  mtu: {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_mtu\u0027) }}"},{"line_number":37,"context_line":"  dns_servers: {{ ctlplane_dns_nameservers }}"},{"line_number":38,"context_line":"  use_dhcp: false"},{"line_number":39,"context_line":"  addresses:"},{"line_number":40,"context_line":"  - ip_netmask:"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9f560f44_e736a9b3","line":37,"range":{"start_line":37,"start_character":2,"end_line":37,"end_character":45},"updated":"2020-10-05 20:44:53.000000000","message":"ditto, redundant?","commit_id":"11c9fd493ac65e77a9bcb76ccd3351288982cc20"}],"tripleo_ansible/roles/tripleo_network_config/templates/multiple_nics_vlans/multiple_nics_vlans_dpdk.j2":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"de424e390250c2c23bd7ed1f807ed773fcf808e2","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  addresses:"},{"line_number":28,"context_line":"  - ip_netmask:"},{"line_number":29,"context_line":"      {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_ip\u0027) }}/{{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_cidr\u0027) }}"},{"line_number":30,"context_line":"{% if default_route_networks and \u0027ControlPlane\u0027 in default_route_networks %}"},{"line_number":31,"context_line":"  routes:"},{"line_number":32,"context_line":"    {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_host_routes\u0027) + [{\u0027default\u0027: true, \u0027next_hop\u0027: lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_gateway_ip\u0027)}] }}"},{"line_number":33,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9f560f44_2741c10b","line":30,"range":{"start_line":30,"start_character":33,"end_line":30,"end_character":47},"updated":"2020-10-05 20:44:53.000000000","message":"ditto?","commit_id":"11c9fd493ac65e77a9bcb76ccd3351288982cc20"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"7fea802e8ea4dcce1d499a3292998251bf900fb2","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  addresses:"},{"line_number":28,"context_line":"  - ip_netmask:"},{"line_number":29,"context_line":"      {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_ip\u0027) }}/{{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_cidr\u0027) }}"},{"line_number":30,"context_line":"{% if default_route_networks and \u0027ControlPlane\u0027 in default_route_networks %}"},{"line_number":31,"context_line":"  routes:"},{"line_number":32,"context_line":"    {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_host_routes\u0027) + [{\u0027default\u0027: true, \u0027next_hop\u0027: lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_gateway_ip\u0027)}] }}"},{"line_number":33,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9f560f44_fd5f564a","line":30,"range":{"start_line":30,"start_character":33,"end_line":30,"end_character":47},"in_reply_to":"9f560f44_2741c10b","updated":"2020-10-06 02:04:01.000000000","message":"Done","commit_id":"11c9fd493ac65e77a9bcb76ccd3351288982cc20"}],"tripleo_ansible/roles/tripleo_network_config/templates/multiple_nics_vlans/multiple_nics_vlans_dvr.j2":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"de424e390250c2c23bd7ed1f807ed773fcf808e2","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  addresses:"},{"line_number":28,"context_line":"  - ip_netmask:"},{"line_number":29,"context_line":"      {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_ip\u0027) }}/{{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_cidr\u0027) }}"},{"line_number":30,"context_line":"{% if default_route_networks and \u0027ControlPlane\u0027 in default_route_networks %}"},{"line_number":31,"context_line":"  routes:"},{"line_number":32,"context_line":"    {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_host_routes\u0027) + [{\u0027default\u0027: true, \u0027next_hop\u0027: lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_gateway_ip\u0027)}] }}"},{"line_number":33,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9f560f44_8747ed1e","line":30,"range":{"start_line":30,"start_character":33,"end_line":30,"end_character":47},"updated":"2020-10-05 20:44:53.000000000","message":"ditto?","commit_id":"11c9fd493ac65e77a9bcb76ccd3351288982cc20"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"7fea802e8ea4dcce1d499a3292998251bf900fb2","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  addresses:"},{"line_number":28,"context_line":"  - ip_netmask:"},{"line_number":29,"context_line":"      {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_ip\u0027) }}/{{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_cidr\u0027) }}"},{"line_number":30,"context_line":"{% if default_route_networks and \u0027ControlPlane\u0027 in default_route_networks %}"},{"line_number":31,"context_line":"  routes:"},{"line_number":32,"context_line":"    {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_host_routes\u0027) + [{\u0027default\u0027: true, \u0027next_hop\u0027: lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_gateway_ip\u0027)}] }}"},{"line_number":33,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9f560f44_3d6a6eec","line":30,"range":{"start_line":30,"start_character":33,"end_line":30,"end_character":47},"in_reply_to":"9f560f44_8747ed1e","updated":"2020-10-06 02:04:01.000000000","message":"Done","commit_id":"11c9fd493ac65e77a9bcb76ccd3351288982cc20"}],"tripleo_ansible/roles/tripleo_network_config/templates/single_nic_vlans/controller_no_external.j2":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"de424e390250c2c23bd7ed1f807ed773fcf808e2","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    vlan_id: {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_vlan_id\u0027) }}"},{"line_number":31,"context_line":"    addresses:"},{"line_number":32,"context_line":"    - ip_netmask:"},{"line_number":33,"context_line":"        {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_ip\u0027) }}/{{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_cidr\u0027) }}"},{"line_number":34,"context_line":"{% if default_route_networks and network in default_route_networks %}"},{"line_number":35,"context_line":"    routes:"},{"line_number":36,"context_line":"      {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_host_routes\u0027) + [{\u0027default\u0027: true, \u0027next_hop\u0027: lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_gateway_ip\u0027)}] }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9f560f44_87f52dcf","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":127},"updated":"2020-10-05 20:44:53.000000000","message":"nit: Just a general comment for imo better user experiance.\nLet\u0027s store a new group var named _ip_netmask and the just do one var lookup here?\n\n  {{ lookup(\u0027vars\u0027, role_networks_lower[network] ~ \u0027_ip_netmask\u0027) }}","commit_id":"11c9fd493ac65e77a9bcb76ccd3351288982cc20"}]}