)]}'
{"tripleo_ansible/roles/tripleo_frr/defaults/main.yml":[{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"c01d4c36d89829247329302b25815348fdc8edbd","unresolved":true,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# All variables within this role should have a prefix of \"tripleo_frr\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"tripleo_frr_bfd: false"},{"line_number":23,"context_line":"tripleo_frr_bgp: false"},{"line_number":24,"context_line":"tripleo_frr_bgp_ipv4: true"},{"line_number":25,"context_line":"tripleo_frr_bgp_ipv4_allowas_in: false"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"12036171_718501f7","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":22},"updated":"2020-11-25 18:34:49.000000000","message":"This translates to: bfdd\u003dFalse, bgpd\u003dTrue\nShould we set these to \u0027yes\u0027 or \u0027no\u0027 to remain consistent with the rest of the file? (I am assuming frr will be fine with False and True)\nWe could add a pre tasks that validates these if we fear folks might get it wrong","commit_id":"39b05d2ce536b410203f2433c3d0d14ecc02f17a"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"e5595d363d3f4d9e97b931c60d8c9d006f5cfb78","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# All variables within this role should have a prefix of \"tripleo_frr\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"tripleo_frr_bfd: false"},{"line_number":23,"context_line":"tripleo_frr_bgp: false"},{"line_number":24,"context_line":"tripleo_frr_bgp_ipv4: true"},{"line_number":25,"context_line":"tripleo_frr_bgp_ipv4_allowas_in: false"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"34e88928_dd5c3e13","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":22},"in_reply_to":"12036171_718501f7","updated":"2020-11-26 07:58:53.000000000","message":"Good catch!","commit_id":"39b05d2ce536b410203f2433c3d0d14ecc02f17a"}],"tripleo_ansible/roles/tripleo_frr/tasks/main.yml":[{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"577835258205b79b34c9c5d3b3ffd38d5374cadb","unresolved":true,"context_lines":[{"line_number":19,"context_line":"  ansible.builtin.file:"},{"line_number":20,"context_line":"    path: \"{{ tripleo_frr_config_basedir }}\""},{"line_number":21,"context_line":"    state: directory"},{"line_number":22,"context_line":"    owner: frr"},{"line_number":23,"context_line":"    group: frr"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: configure FRR"},{"line_number":26,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0a07c0b1_be63681a","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":14},"updated":"2020-11-25 14:05:25.000000000","message":"can you remove these? (and the other two instances below) We will force the frr user later on via kolla/container","commit_id":"64aeefc8f80034fc769b796f2ca9fb6f78fbc5af"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"86a61da67ea8e7dbf4e2e6611fc577470cbeb57e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  ansible.builtin.file:"},{"line_number":20,"context_line":"    path: \"{{ tripleo_frr_config_basedir }}\""},{"line_number":21,"context_line":"    state: directory"},{"line_number":22,"context_line":"    owner: frr"},{"line_number":23,"context_line":"    group: frr"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: configure FRR"},{"line_number":26,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8aae76f8_a8c4d91b","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":14},"in_reply_to":"0a07c0b1_be63681a","updated":"2020-11-25 14:24:54.000000000","message":"Done","commit_id":"64aeefc8f80034fc769b796f2ca9fb6f78fbc5af"}],"tripleo_ansible/roles/tripleo_frr/templates/frr.conf.j2":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"a548f5683d321534d444127f2237c9e18d23ce01","unresolved":true,"context_lines":[{"line_number":26,"context_line":"  exit-address-family"},{"line_number":27,"context_line":"{% endif %}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{% if tripleo_frr_bgp_ipv4 %}"},{"line_number":30,"context_line":"  address-family ipv6 unicast"},{"line_number":31,"context_line":"    redistribute connected"},{"line_number":32,"context_line":"    neighbor uplink activate"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"6f719f44_a493990e","line":29,"range":{"start_line":29,"start_character":25,"end_line":29,"end_character":26},"updated":"2020-11-22 17:30:45.000000000","message":"s/4/6/","commit_id":"e513119228fd4b765ce428ac15c7c192903606f0"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"560fac4cce6328cf7e5794899c8a97f3f17242e2","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  exit-address-family"},{"line_number":27,"context_line":"{% endif %}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{% if tripleo_frr_bgp_ipv4 %}"},{"line_number":30,"context_line":"  address-family ipv6 unicast"},{"line_number":31,"context_line":"    redistribute connected"},{"line_number":32,"context_line":"    neighbor uplink activate"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"a5ec462d_9da23a1a","line":29,"range":{"start_line":29,"start_character":25,"end_line":29,"end_character":26},"in_reply_to":"6f719f44_a493990e","updated":"2020-11-23 17:08:50.000000000","message":"Done","commit_id":"e513119228fd4b765ce428ac15c7c192903606f0"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"a548f5683d321534d444127f2237c9e18d23ce01","unresolved":true,"context_lines":[{"line_number":48,"context_line":"ip protocol bgp route-map rm-only-default"},{"line_number":49,"context_line":"{% endif %}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"{% if tripleo_frr_bgp_ipv4 %}"},{"line_number":52,"context_line":"ipv6 prefix-list only-default permit ::/0"},{"line_number":53,"context_line":"ipv6 prefix-list only-host-prefixes permit ::/0 ge 128"},{"line_number":54,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"059ec044_1a645432","line":51,"range":{"start_line":51,"start_character":25,"end_line":51,"end_character":26},"updated":"2020-11-22 17:30:45.000000000","message":"s/4/6/","commit_id":"e513119228fd4b765ce428ac15c7c192903606f0"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"560fac4cce6328cf7e5794899c8a97f3f17242e2","unresolved":false,"context_lines":[{"line_number":48,"context_line":"ip protocol bgp route-map rm-only-default"},{"line_number":49,"context_line":"{% endif %}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"{% if tripleo_frr_bgp_ipv4 %}"},{"line_number":52,"context_line":"ipv6 prefix-list only-default permit ::/0"},{"line_number":53,"context_line":"ipv6 prefix-list only-host-prefixes permit ::/0 ge 128"},{"line_number":54,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"87acc3ac_b67d7f01","line":51,"range":{"start_line":51,"start_character":25,"end_line":51,"end_character":26},"in_reply_to":"059ec044_1a645432","updated":"2020-11-23 17:08:50.000000000","message":"Done","commit_id":"e513119228fd4b765ce428ac15c7c192903606f0"}]}