)]}'
{"tripleo_ansible/roles/tripleo_redhat_enforce/tasks/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"736377b0c4f232499f244da27726854899c76abf","unresolved":true,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- include_tasks: enforce_release.yml"},{"line_number":35,"context_line":"  name: Enforce RHEL/OSP version pair"},{"line_number":36,"context_line":"  when: tripleo_redhat_enforce|default(true)|bool"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6b2b162d_01988ea3","line":36,"range":{"start_line":36,"start_character":8,"end_line":36,"end_character":49},"updated":"2021-01-22 14:06:51.000000000","message":"I would recommend doing this to ensure precedence:\n\n(tripleo_redhat_enforce | default(true)) | bool","commit_id":"0ba1cdc2ebc26b3acf8661cc2d224d13af086ec8"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"d59703c5c491ba406d6f8d82658a65c204ccc585","unresolved":true,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- include_tasks: enforce_release.yml"},{"line_number":35,"context_line":"  name: Enforce RHEL/OSP version pair"},{"line_number":36,"context_line":"  when: tripleo_redhat_enforce|default(true)|bool"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7b4ac717_1d335b7e","line":36,"range":{"start_line":36,"start_character":8,"end_line":36,"end_character":49},"in_reply_to":"6b2b162d_01988ea3","updated":"2021-01-22 21:02:16.000000000","message":"can we really have another precedence here than left to right, given that those are jinja filter ?","commit_id":"0ba1cdc2ebc26b3acf8661cc2d224d13af086ec8"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"7de7db260fc2ed0fbdbf5be8f66f7c47bfb762ef","unresolved":true,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- include_tasks: enforce_release.yml"},{"line_number":35,"context_line":"  name: Enforce RHEL/OSP version pair"},{"line_number":36,"context_line":"  when: tripleo_redhat_enforce|default(true)|bool"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"afb0f520_377a3580","line":36,"range":{"start_line":36,"start_character":8,"end_line":36,"end_character":49},"in_reply_to":"7b4ac717_1d335b7e","updated":"2021-01-25 11:30:40.000000000","message":"I guess it is a matter of safety...but if you have already defined tripleo_redhat_enforce in defaults/main.yaml with a value. Should\u0027t that be already the default? this seems a little bit redundant..however I won\u0027t block it.","commit_id":"0ba1cdc2ebc26b3acf8661cc2d224d13af086ec8"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"3e4293794f816ab65314906a4799687fea4850d6","unresolved":true,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- include_tasks: enforce_release.yml"},{"line_number":35,"context_line":"  name: Enforce RHEL/OSP version pair"},{"line_number":36,"context_line":"  when: tripleo_redhat_enforce|default(true)|bool"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"40ed5d56_bb4cede7","line":36,"range":{"start_line":36,"start_character":8,"end_line":36,"end_character":49},"in_reply_to":"afb0f520_377a3580","updated":"2021-01-25 13:46:56.000000000","message":"Looking further into precedence issue in jinja filter, this seems to be a problem when you mix it up with math operator:\n\n  foo * 3 | int\n\nshould be\n\n  ( foo * 3 ) | int\n\nto have the int filter applied to the result of the foo * 3.\n\nHere, the non precedence version is safe and adding parenthesis would clutter the code with no real gain on safety.\n\nThat being said, the comment by @Jose is very pertinent. The variable is set in defaults/main.yml in any case so it will never be empty. In the sake of clarity I\u0027ll remove the default altogether as it\u0027s not needed.\n\nI add the \"default\" initially because I remove it from the redhat.yml file, but even downstream the \"default true\" will not be taken into account because \"defaults/main.yml\" set it to false.\n\nI have thus an issue if that variable is not set downstream, which is likely if people miss the note about adding it to their plan.\n\nBack to drawing board then ?","commit_id":"0ba1cdc2ebc26b3acf8661cc2d224d13af086ec8"}]}