)]}'
{"tripleo_ansible/roles/tripleo_metrics_qdr/.ansible-lint":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99670fb83178f13927d3026cb2b92e81169e4fe6","unresolved":true,"context_lines":[{"line_number":1,"context_line":"skip_list:  # or \u0027skip_list\u0027 to silence them completely"},{"line_number":2,"context_line":"  - \u0027106\u0027  # \"Role name {} does not match ``^[a-z][a-z0-9_]+$`` pattern\" - True"},{"line_number":3,"context_line":"  - \u0027502\u0027  # \"All tasks should be named\" - I don\u0027t want to name asserts, it\u0027s too verbose"},{"line_number":4,"context_line":"warn_list:"},{"line_number":5,"context_line":"  - \u0027204\u0027 # \"Lines should be no longer than 120 chars\"  - except log lines"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"791d801c_2e2cbf77","line":2,"range":{"start_line":2,"start_character":5,"end_line":2,"end_character":79},"updated":"2021-01-28 19:34:10.000000000","message":"because we\u0027re moving toward collections, this rule must be followed.","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"89457e7c24cc152e77a838a92664513fd97325d3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"skip_list:  # or \u0027skip_list\u0027 to silence them completely"},{"line_number":2,"context_line":"  - \u0027106\u0027  # \"Role name {} does not match ``^[a-z][a-z0-9_]+$`` pattern\" - True"},{"line_number":3,"context_line":"  - \u0027502\u0027  # \"All tasks should be named\" - I don\u0027t want to name asserts, it\u0027s too verbose"},{"line_number":4,"context_line":"warn_list:"},{"line_number":5,"context_line":"  - \u0027204\u0027 # \"Lines should be no longer than 120 chars\"  - except log lines"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3705156d_b95059bd","line":2,"range":{"start_line":2,"start_character":5,"end_line":2,"end_character":79},"in_reply_to":"791d801c_2e2cbf77","updated":"2021-02-03 02:54:59.000000000","message":"This exception was no longer needed. I\u0027m just removing this file entirely.","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99670fb83178f13927d3026cb2b92e81169e4fe6","unresolved":true,"context_lines":[{"line_number":1,"context_line":"skip_list:  # or \u0027skip_list\u0027 to silence them completely"},{"line_number":2,"context_line":"  - \u0027106\u0027  # \"Role name {} does not match ``^[a-z][a-z0-9_]+$`` pattern\" - True"},{"line_number":3,"context_line":"  - \u0027502\u0027  # \"All tasks should be named\" - I don\u0027t want to name asserts, it\u0027s too verbose"},{"line_number":4,"context_line":"warn_list:"},{"line_number":5,"context_line":"  - \u0027204\u0027 # \"Lines should be no longer than 120 chars\"  - except log lines"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7a785a55_5375ff0b","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":89},"updated":"2021-01-28 19:34:10.000000000","message":"this is a style change, I know its verbose but there\u0027s really no good reason to not do it. Its something we\u0027ve enforced across the board and it should be enforced here too.","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"89457e7c24cc152e77a838a92664513fd97325d3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"skip_list:  # or \u0027skip_list\u0027 to silence them completely"},{"line_number":2,"context_line":"  - \u0027106\u0027  # \"Role name {} does not match ``^[a-z][a-z0-9_]+$`` pattern\" - True"},{"line_number":3,"context_line":"  - \u0027502\u0027  # \"All tasks should be named\" - I don\u0027t want to name asserts, it\u0027s too verbose"},{"line_number":4,"context_line":"warn_list:"},{"line_number":5,"context_line":"  - \u0027204\u0027 # \"Lines should be no longer than 120 chars\"  - except log lines"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"51744680_7ae88f7f","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":89},"in_reply_to":"7a785a55_5375ff0b","updated":"2021-02-03 02:54:59.000000000","message":"Ack","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"}],"tripleo_ansible/roles/tripleo_metrics_qdr/README.md":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99670fb83178f13927d3026cb2b92e81169e4fe6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"01a0f626_1852df1e","updated":"2021-01-28 19:34:10.000000000","message":"delete this file, documentation for the repo is generated.","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"89457e7c24cc152e77a838a92664513fd97325d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a965cffb_9173a745","in_reply_to":"01a0f626_1852df1e","updated":"2021-02-03 02:54:59.000000000","message":"Ack","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"}],"tripleo_ansible/roles/tripleo_metrics_qdr/filter_plugins/.gitignore":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99670fb83178f13927d3026cb2b92e81169e4fe6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9bc448e5_6f785edd","updated":"2021-01-28 19:34:10.000000000","message":"this isn\u0027t a submodule, we\u0027ll need to move this to the project .gitignore.","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"89457e7c24cc152e77a838a92664513fd97325d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"aff57b37_1f475954","in_reply_to":"9bc448e5_6f785edd","updated":"2021-02-03 02:54:59.000000000","message":"Sorry, it was just copied in from the repo we used for early development. It\u0027s already in the top-level .gitignore. Removing this file.","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"}],"tripleo_ansible/roles/tripleo_metrics_qdr/filter_plugins/filter_snake_case.py":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99670fb83178f13927d3026cb2b92e81169e4fe6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d5ff9101_924ffb33","updated":"2021-01-28 19:34:10.000000000","message":"all of this will need to be addressed. Additionally the role filters should go into the filters directory. While embedded filters work within a role, its not something we promote or want to deal with when it comes to the complexity of packaging or building into a collect.","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"89457e7c24cc152e77a838a92664513fd97325d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e0ade228_24ce9389","in_reply_to":"d5ff9101_924ffb33","updated":"2021-02-03 02:54:59.000000000","message":"Alright, moved it. LMK if you think it should be integrated into helpers.py","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"}],"tripleo_ansible/roles/tripleo_metrics_qdr/meta/main.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99670fb83178f13927d3026cb2b92e81169e4fe6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c94f0667_32c9e972","updated":"2021-01-28 19:34:10.000000000","message":"all of this will need to be addressed. when generating a role following the developer documentation this file is generated for you. If you manually create it, it will need to adhere to the given spec.","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"89457e7c24cc152e77a838a92664513fd97325d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"198370c7_48354c36","in_reply_to":"c94f0667_32c9e972","updated":"2021-02-03 02:54:59.000000000","message":"Ack","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99670fb83178f13927d3026cb2b92e81169e4fe6","unresolved":true,"context_lines":[{"line_number":1,"context_line":"galaxy_info:"},{"line_number":2,"context_line":"  author: Chris Sibbitt"},{"line_number":3,"context_line":"  description: TripleO qdr ansible interface"},{"line_number":4,"context_line":"  company: Red Hat"},{"line_number":5,"context_line":"  license: Apache-2.0"},{"line_number":6,"context_line":"  min_ansible_version: 2.9"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"41a5b912_87942c8a","line":3,"range":{"start_line":2,"start_character":0,"end_line":3,"end_character":44},"updated":"2021-01-28 19:34:10.000000000","message":"as with all of our roles, \n\n  author: OpenStack\n  description: TripleO OpenStack Role -- tripleo_metrics_qdr","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"89457e7c24cc152e77a838a92664513fd97325d3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"galaxy_info:"},{"line_number":2,"context_line":"  author: Chris Sibbitt"},{"line_number":3,"context_line":"  description: TripleO qdr ansible interface"},{"line_number":4,"context_line":"  company: Red Hat"},{"line_number":5,"context_line":"  license: Apache-2.0"},{"line_number":6,"context_line":"  min_ansible_version: 2.9"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ad02ec4c_9b8a47f3","line":3,"range":{"start_line":2,"start_character":0,"end_line":3,"end_character":44},"in_reply_to":"41a5b912_87942c8a","updated":"2021-02-03 02:54:59.000000000","message":"Done","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"}],"tripleo_ansible/roles/tripleo_metrics_qdr/molecule/common/Dockerfile.j2":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99670fb83178f13927d3026cb2b92e81169e4fe6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"73f6c9b4_a211bb99","updated":"2021-01-28 19:34:10.000000000","message":"There is a docker file from template that should be used here. Example - https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo_ceph_uuid/molecule/default/Dockerfile\n\nUnless there\u0027s a good reason to not use that template, we should update this file accordingly.","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"89457e7c24cc152e77a838a92664513fd97325d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7288f23d_569aed73","in_reply_to":"73f6c9b4_a211bb99","updated":"2021-02-03 02:54:59.000000000","message":"Swapped for the template, works fine. Thanks!","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"9a6ec4b86f5a731bdc3e59fc36165e4dbd902f50","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":26,"id":"d20da823_75956d38","updated":"2021-03-26 18:23:29.000000000","message":"file needs to be renamed to Dockerfile","commit_id":"6da84c1a6ae664ba8a2489bba778c4f68c0696dd"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"9a6ec4b86f5a731bdc3e59fc36165e4dbd902f50","unresolved":true,"context_lines":[{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% raw %}"},{"line_number":18,"context_line":"{% if item.registry is defined %}"},{"line_number":19,"context_line":"FROM {{ item.registry.url }}/{{ item.image }}"},{"line_number":20,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"cb8bcd4d_0675381d","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":9},"updated":"2021-03-26 18:23:29.000000000","message":"templating is done by molecule, no need for the raw blocks.","commit_id":"6da84c1a6ae664ba8a2489bba778c4f68c0696dd"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"9a6ec4b86f5a731bdc3e59fc36165e4dbd902f50","unresolved":true,"context_lines":[{"line_number":32,"context_line":"# install pip for centos where there is no python-pip rpm in default repos"},{"line_number":33,"context_line":"RUN easy_install {{ pkg }}"},{"line_number":34,"context_line":"{% endfor %}"},{"line_number":35,"context_line":"{% endraw %}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"CMD [\"sh\", \"-c\", \"while true; do sleep 10000; done\"]"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"2b86983e_21a42f16","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":12},"updated":"2021-03-26 18:23:29.000000000","message":"templating is done by molecule, no need for the raw blocks.","commit_id":"6da84c1a6ae664ba8a2489bba778c4f68c0696dd"}],"tripleo_ansible/roles/tripleo_metrics_qdr/molecule/common/prepare.yml":[{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"4f15543278b8de34df16e5cede5ea30ca870b32c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# HACK - This doesn\u0027t seem like it should be necesarry, as I think"},{"line_number":3,"context_line":"#        test_deps_setup_tripleo below should be able to bring in the repos I"},{"line_number":4,"context_line":"#        need, however that is giving me problems on my local system due to what"},{"line_number":5,"context_line":"#        I think is conflicts with subscription-manager repos from my host"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fe4d78f_cb2f0583","line":2,"updated":"2021-02-03 03:11:45.000000000","message":"I could use some help here. I need to install qpid-dispatch-router in the ubi image, but it\u0027s not available by default. I previously tested with the kolla container, which appears to pull the package from the RDO repos[1]. \n\nMy guess is that if I enabled test_deps_setup_tripleo on L24 below I might get this package, but doing so causes problems in my test environment. I think these problems may be due to running the ubi image on a host that has subscription-manager running, but I haven\u0027t had a chance to test another host yet.\n\nWhat you see here is a temporary hack-around until I can get to the bottom of this.\n\n[1] https://github.com/openstack/kolla/blob/master/docker/qdrouterd/Dockerfile.j2#L24","commit_id":"a78d6d0afe6f6c6a978afecfa5ff2f17d46fb732"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"fdfd09a9de7c42a2bba01026c0c06cb7fd4c1bba","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# HACK - This doesn\u0027t seem like it should be necesarry, as I think"},{"line_number":3,"context_line":"#        test_deps_setup_tripleo below should be able to bring in the repos I"},{"line_number":4,"context_line":"#        need, however that is giving me problems on my local system due to what"},{"line_number":5,"context_line":"#        I think is conflicts with subscription-manager repos from my host"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"52126418_c2962456","line":2,"in_reply_to":"9fe4d78f_cb2f0583","updated":"2021-02-03 13:24:52.000000000","message":"This repo hack didn\u0027t work in CI. Error is `nothing provides libev.so.4()(64bit) needed by libwebsockets-3.2.2-1.el8.x86_64`. I\u0027m going to send in a patch with this Victoria repo removed and test_deps_setup_tripleo enabled below to see if it works in CI or not.","commit_id":"a78d6d0afe6f6c6a978afecfa5ff2f17d46fb732"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"4f15543278b8de34df16e5cede5ea30ca870b32c","unresolved":true,"context_lines":[{"line_number":20,"context_line":"      test_deps_extra_packages:"},{"line_number":21,"context_line":"        - qpid-dispatch-router-1.9.0"},{"line_number":22,"context_line":"        - qpid-dispatch-tools-1.9.0"},{"line_number":23,"context_line":"        # I think this should be enabled but it doesn\u0027t work on my local machine"},{"line_number":24,"context_line":"        # test_deps_setup_tripleo: true"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"- name: \"Create dirs that are usually volume mounted from the host\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f467a294_5fdf592d","line":23,"updated":"2021-02-03 03:11:45.000000000","message":"file /var/lib/puppet conflicts between attempted installs of puppet-headless-6.14.0-2.el8.noarch and puppet-6.19.0-1.el8.noarch","commit_id":"a78d6d0afe6f6c6a978afecfa5ff2f17d46fb732"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"2583857788dc6840ce8dd1d51c707eeaebf655ab","unresolved":true,"context_lines":[{"line_number":8,"context_line":"          - qpid-dispatch-router"},{"line_number":9,"context_line":"          - qpid-dispatch-tools"},{"line_number":10,"context_line":"        test_deps_setup_tripleo: true"},{"line_number":11,"context_line":"  post_tasks:"},{"line_number":12,"context_line":"    - name: \"Make sure that /var/log/qdrouterd exists\""},{"line_number":13,"context_line":"      file:"},{"line_number":14,"context_line":"        path: \"/var/log/qdrouterd\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5d6f8470_4c3c6fb8","line":11,"updated":"2021-03-25 16:44:27.000000000","message":"Does this somehow solve a race condition?","commit_id":"7454068ac9f48a50b05838cba8a4677c02150fcc"}],"tripleo_ansible/roles/tripleo_metrics_qdr/molecule/common/requirements.yml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"ebc9e816a1019eb625afb1e7ab321df95315d126","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"roles:"},{"line_number":3,"context_line":"  - src: git+https://github.com/infrawatch/functional-tests"},{"line_number":4,"context_line":"    name: functional_tests"},{"line_number":5,"context_line":"  - src: git+https://github.com/infrawatch/qdr-config-ansible-role"},{"line_number":6,"context_line":"    name: qdr_config"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"475c5cd9_e335d5ad","line":3,"range":{"start_line":3,"start_character":7,"end_line":3,"end_character":34},"updated":"2021-02-20 13:55:18.000000000","message":"using github in our jobs is not so reliable because of connection failures to it, can it be replaces with something cacheable? opendev.org, pypi, etc","commit_id":"68f014afc665ca47216e74e5a43740d68c6f393a"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"d694c78141513fed3e76f2d4258bee84568d7e05","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"roles:"},{"line_number":3,"context_line":"  - src: git+https://github.com/infrawatch/functional-tests"},{"line_number":4,"context_line":"    name: functional_tests"},{"line_number":5,"context_line":"  - src: git+https://github.com/infrawatch/qdr-config-ansible-role"},{"line_number":6,"context_line":"    name: qdr_config"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d1488b7a_1fbe9e19","line":3,"range":{"start_line":3,"start_character":7,"end_line":3,"end_character":34},"in_reply_to":"16ece6f4_1ac090a2","updated":"2021-02-24 18:03:08.000000000","message":"Emma, definitely a good idea. I think it requires adding the project into zuul gates projects, like it\u0027s done with ansible for example: \nhttps://opendev.org/openstack/project-config/src/branch/master/zuul/main.yaml#L39\nhttps://opendev.org/openstack/project-config/src/branch/master/zuul.d/projects.yaml#L28\nWorth to ask on #opendev though for details.","commit_id":"68f014afc665ca47216e74e5a43740d68c6f393a"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"c154177dcbddae6771d88762cd225cf12d466927","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"roles:"},{"line_number":3,"context_line":"  - src: git+https://github.com/infrawatch/functional-tests"},{"line_number":4,"context_line":"    name: functional_tests"},{"line_number":5,"context_line":"  - src: git+https://github.com/infrawatch/qdr-config-ansible-role"},{"line_number":6,"context_line":"    name: qdr_config"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a97413f7_ff6e97b0","line":3,"range":{"start_line":3,"start_character":7,"end_line":3,"end_character":34},"in_reply_to":"475c5cd9_e335d5ad","updated":"2021-02-24 15:31:30.000000000","message":"Thanks for the review, Shnaidman. Moving that code will require some co-ordination with other QE automation that depends on these tests. I will bring it up with the team and see what we can do, but it will have to stay here for the moment I think.","commit_id":"68f014afc665ca47216e74e5a43740d68c6f393a"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"b8356942bf8b2ec27db7e306786c0973504ca1e7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"roles:"},{"line_number":3,"context_line":"  - src: git+https://github.com/infrawatch/functional-tests"},{"line_number":4,"context_line":"    name: functional_tests"},{"line_number":5,"context_line":"  - src: git+https://github.com/infrawatch/qdr-config-ansible-role"},{"line_number":6,"context_line":"    name: qdr_config"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4eee56f7_cdd52361","line":3,"range":{"start_line":3,"start_character":7,"end_line":3,"end_character":34},"in_reply_to":"6d8a27e2_af1791ff","updated":"2021-02-24 16:43:28.000000000","message":"Does adding this as a required-project in the zuul config work? I can add the repo to project-config [1], I think that should make infrawatch/functional-tests available in the test environment.\n\nCan we mark this as TODO here for now? And I\u0027ll compose some follow-up patches to get molecule using the locally available copy of functional tests (once available)\n\n[1] https://github.com/openstack/project-config/blob/master/zuul/main.yaml#L1474","commit_id":"68f014afc665ca47216e74e5a43740d68c6f393a"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"e0c02096c00daad0de91f9db8619ec4ddb1f3a50","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"roles:"},{"line_number":3,"context_line":"  - src: git+https://github.com/infrawatch/functional-tests"},{"line_number":4,"context_line":"    name: functional_tests"},{"line_number":5,"context_line":"  - src: git+https://github.com/infrawatch/qdr-config-ansible-role"},{"line_number":6,"context_line":"    name: qdr_config"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"16ece6f4_1ac090a2","line":3,"range":{"start_line":3,"start_character":7,"end_line":3,"end_character":34},"in_reply_to":"6d8a27e2_af1791ff","updated":"2021-02-24 16:44:26.000000000","message":"Done","commit_id":"68f014afc665ca47216e74e5a43740d68c6f393a"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"ebc6a95af9411c14c0755f1430393012b9ae9a2e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"roles:"},{"line_number":3,"context_line":"  - src: git+https://github.com/infrawatch/functional-tests"},{"line_number":4,"context_line":"    name: functional_tests"},{"line_number":5,"context_line":"  - src: git+https://github.com/infrawatch/qdr-config-ansible-role"},{"line_number":6,"context_line":"    name: qdr_config"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"6d8a27e2_af1791ff","line":3,"range":{"start_line":3,"start_character":7,"end_line":3,"end_character":34},"in_reply_to":"a97413f7_ff6e97b0","updated":"2021-02-24 15:37:55.000000000","message":"Ack, maybe worth to add here TODO comment to change it - so we don\u0027t forget. Since using github in upstream CI is strictly not recommended.","commit_id":"68f014afc665ca47216e74e5a43740d68c6f393a"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"b1583005554f5b6e5c792697ea46fdfa02ffedc8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"roles:"},{"line_number":3,"context_line":"  - src: git+https://github.com/infrawatch/functional-tests"},{"line_number":4,"context_line":"    name: functional_tests"},{"line_number":5,"context_line":"  - src: git+https://github.com/infrawatch/qdr-config-ansible-role"},{"line_number":6,"context_line":"    name: qdr_config"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7e16b723_b5345b51","line":3,"range":{"start_line":3,"start_character":7,"end_line":3,"end_character":34},"in_reply_to":"d1488b7a_1fbe9e19","updated":"2021-02-24 18:34:07.000000000","message":"I think it requires a change to project-config, so that the instance of zuul that gates these jobs will include the required repos.\n\nI started with [1] in project-config, and have started \nAnd have started drafting a follow up in [2] for tripleo_ansible (both tripleo_collectd and tripleo_metrics_qdr require infrawatch/functional-tests).\n\nOnce [1] is merged, I think we\u0027ll have to mount the functional-tests repo  into the molecule container, and install from there somehow.\n\n[1] https://review.opendev.org/c/openstack/project-config/+/777428\n[2] https://review.opendev.org/c/openstack/tripleo-ansible/+/777435","commit_id":"68f014afc665ca47216e74e5a43740d68c6f393a"}],"tripleo_ansible/roles/tripleo_metrics_qdr/molecule/common/verify.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99670fb83178f13927d3026cb2b92e81169e4fe6","unresolved":true,"context_lines":[{"line_number":76,"context_line":"- name: Check log for correct config of common QDR functionality"},{"line_number":77,"context_line":"  hosts: qdrtest"},{"line_number":78,"context_line":"  tasks:"},{"line_number":79,"context_line":"    - assert:"},{"line_number":80,"context_line":"        that:"},{"line_number":81,"context_line":"          - \"{{ qdrlog_content is search (\u0027Configured Listener: \u0027 + ansible_default_ipv4.address + \u0027:5666 proto\u003dany, role\u003dnormal\u0027) }}\""},{"line_number":82,"context_line":"        success_msg: Local listener configured"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    - assert:"},{"line_number":85,"context_line":"        that:"},{"line_number":86,"context_line":"          - qdrlog_content is search(\u0027Created SSL Profile with name sslProfile\u0027)"},{"line_number":87,"context_line":"        success_msg: default sslProfile for external connector configured"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a5a60da1_81d6c6f3","line":84,"range":{"start_line":79,"start_character":0,"end_line":84,"end_character":13},"updated":"2021-01-28 19:34:10.000000000","message":"tasks need names.","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"89457e7c24cc152e77a838a92664513fd97325d3","unresolved":false,"context_lines":[{"line_number":76,"context_line":"- name: Check log for correct config of common QDR functionality"},{"line_number":77,"context_line":"  hosts: qdrtest"},{"line_number":78,"context_line":"  tasks:"},{"line_number":79,"context_line":"    - assert:"},{"line_number":80,"context_line":"        that:"},{"line_number":81,"context_line":"          - \"{{ qdrlog_content is search (\u0027Configured Listener: \u0027 + ansible_default_ipv4.address + \u0027:5666 proto\u003dany, role\u003dnormal\u0027) }}\""},{"line_number":82,"context_line":"        success_msg: Local listener configured"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    - assert:"},{"line_number":85,"context_line":"        that:"},{"line_number":86,"context_line":"          - qdrlog_content is search(\u0027Created SSL Profile with name sslProfile\u0027)"},{"line_number":87,"context_line":"        success_msg: default sslProfile for external connector configured"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b0660320_5e0e6de1","line":84,"range":{"start_line":79,"start_character":0,"end_line":84,"end_character":13},"in_reply_to":"a5a60da1_81d6c6f3","updated":"2021-02-03 02:54:59.000000000","message":"Ack","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"2583857788dc6840ce8dd1d51c707eeaebf655ab","unresolved":true,"context_lines":[{"line_number":37,"context_line":"            name: functional_tests"},{"line_number":38,"context_line":"            tasks_from: test_qdr"},{"line_number":39,"context_line":"          vars:"},{"line_number":40,"context_line":"            qdr_container_name: \u0027all\u0027"},{"line_number":41,"context_line":"            container_bin: podman"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"      rescue:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"f3861658_b7da1f4f","line":40,"updated":"2021-03-25 16:44:27.000000000","message":"This is a bit weird looking. functional_tests is going to do `{{ container_bin }} ps | grep {{ qdr_container_name }}` [1]. Will the container literally be named \"all\" in podman? I\u0027m setting up to test this now.\n\n[1]https://github.com/infrawatch/functional-tests/blob/master/tasks/test_qdr.yml#L4","commit_id":"7454068ac9f48a50b05838cba8a4677c02150fcc"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"944106c93a0a64df3d4a1df40d571519a0693c34","unresolved":true,"context_lines":[{"line_number":37,"context_line":"            name: functional_tests"},{"line_number":38,"context_line":"            tasks_from: test_qdr"},{"line_number":39,"context_line":"          vars:"},{"line_number":40,"context_line":"            qdr_container_name: \u0027all\u0027"},{"line_number":41,"context_line":"            container_bin: podman"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"      rescue:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3900eb2f_4fce3410","line":40,"in_reply_to":"f3861658_b7da1f4f","updated":"2021-03-25 17:07:22.000000000","message":"it seemed to work, at least locally. We can tweak this setting as the container name would be ubi8 but I want to see where the runs end up.","commit_id":"7454068ac9f48a50b05838cba8a4677c02150fcc"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"3bd9344f9d82d3a5a84415a1fb0bd31aa2121493","unresolved":true,"context_lines":[{"line_number":32,"context_line":"        - name: Clear the failure flag"},{"line_number":33,"context_line":"          set_fact: functest_failed_flag\u003d\"unknown\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        - name: \"[Test] Check that qdr container is running.\""},{"line_number":36,"context_line":"          command: pkill -0 qdrouterd"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        - name: \"[Setup] Get Qdr bus address\""}],"source_content_type":"text/x-yaml","patch_set":25,"id":"7cf566a9_9eafd70a","line":35,"updated":"2021-03-26 01:30:13.000000000","message":"Ah, so if we\u0027re running outside the container we also lose our ability to re-use our functional tests. :-( Hmmmm....","commit_id":"fafe831e5e53c2404b6fc9409985d01d43f52760"}],"tripleo_ansible/roles/tripleo_metrics_qdr/molecule/controller-mesh-edge-node/converge.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99670fb83178f13927d3026cb2b92e81169e4fe6","unresolved":true,"context_lines":[{"line_number":4,"context_line":"- name: Converge controller-mesh edge node config"},{"line_number":5,"context_line":"  hosts: qdrtest"},{"line_number":6,"context_line":"  tasks:"},{"line_number":7,"context_line":"    - include_role:"},{"line_number":8,"context_line":"        name: \"{{ playbook_dir }}/../../../tripleo_metrics_qdr\""},{"line_number":9,"context_line":"        tasks_from: create_config"},{"line_number":10,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0809005b_33755cd8","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":19},"updated":"2021-01-28 19:34:10.000000000","message":"needs a name.","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"89457e7c24cc152e77a838a92664513fd97325d3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"- name: Converge controller-mesh edge node config"},{"line_number":5,"context_line":"  hosts: qdrtest"},{"line_number":6,"context_line":"  tasks:"},{"line_number":7,"context_line":"    - include_role:"},{"line_number":8,"context_line":"        name: \"{{ playbook_dir }}/../../../tripleo_metrics_qdr\""},{"line_number":9,"context_line":"        tasks_from: create_config"},{"line_number":10,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1aeee595_dffed90d","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":19},"in_reply_to":"0809005b_33755cd8","updated":"2021-02-03 02:54:59.000000000","message":"Ack","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"}],"tripleo_ansible/roles/tripleo_metrics_qdr/molecule/controller-mesh-edge-node/molecule.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99670fb83178f13927d3026cb2b92e81169e4fe6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"54260b37_de74bd3c","updated":"2021-01-28 19:34:10.000000000","message":"please see comments in other molecule files, we need this file to adhere to our spec.","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"89457e7c24cc152e77a838a92664513fd97325d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"aec8e1eb_6629dda2","in_reply_to":"54260b37_de74bd3c","updated":"2021-02-03 02:54:59.000000000","message":"Ack","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"2583857788dc6840ce8dd1d51c707eeaebf655ab","unresolved":true,"context_lines":[{"line_number":5,"context_line":"log: true"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"platforms:"},{"line_number":8,"context_line":"  - name: ubi8"},{"line_number":9,"context_line":"    hostname: ubi8"},{"line_number":10,"context_line":"    image: ubi8/ubi-init"},{"line_number":11,"context_line":"    registry:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"ca7fcf74_5860360b","line":8,"updated":"2021-03-25 16:44:27.000000000","message":"Does something else (outside this code base) depend on matching this platform name?","commit_id":"7454068ac9f48a50b05838cba8a4677c02150fcc"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"944106c93a0a64df3d4a1df40d571519a0693c34","unresolved":true,"context_lines":[{"line_number":5,"context_line":"log: true"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"platforms:"},{"line_number":8,"context_line":"  - name: ubi8"},{"line_number":9,"context_line":"    hostname: ubi8"},{"line_number":10,"context_line":"    image: ubi8/ubi-init"},{"line_number":11,"context_line":"    registry:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"b2fa9268_65befd06","line":8,"in_reply_to":"ca7fcf74_5860360b","updated":"2021-03-25 17:07:22.000000000","message":"I\u0027m not sure. I was making the molecule config similar to what we have elsewhere. After changing all of the names, and setting the convergence playbooks to \"all\" I wasn\u0027t able to reproduce the failure locally.","commit_id":"7454068ac9f48a50b05838cba8a4677c02150fcc"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"2583857788dc6840ce8dd1d51c707eeaebf655ab","unresolved":true,"context_lines":[{"line_number":33,"context_line":"          ubi8:"},{"line_number":34,"context_line":"            ansible_python_interpreter: /usr/bin/python3"},{"line_number":35,"context_line":"        vars:"},{"line_number":36,"context_line":"          ansible_user: root"},{"line_number":37,"context_line":"          tripleo_metrics_qdr_conf_output_dir: /etc/qpid-dispatch/"},{"line_number":38,"context_line":"  name: ansible"},{"line_number":39,"context_line":"  log: true"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"15bbc66f_8dec9c4b","line":36,"updated":"2021-03-25 16:44:27.000000000","message":"Does this have anything to do with our failure to install things via test_deps?","commit_id":"7454068ac9f48a50b05838cba8a4677c02150fcc"}],"tripleo_ansible/roles/tripleo_metrics_qdr/molecule/controller-mesh-edge-node/verify.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99670fb83178f13927d3026cb2b92e81169e4fe6","unresolved":true,"context_lines":[{"line_number":4,"context_line":"- name: Check log for correct config of controller-mesh edge nodes"},{"line_number":5,"context_line":"  hosts: qdrtest"},{"line_number":6,"context_line":"  tasks:"},{"line_number":7,"context_line":"  - assert:"},{"line_number":8,"context_line":"      that:"},{"line_number":9,"context_line":"        - qdrlog_content.find(\u0027Router started in Edge mode\u0027) !\u003d -1"},{"line_number":10,"context_line":"      success_msg: Router started in Edge mode"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  - assert:"},{"line_number":13,"context_line":"      that:"},{"line_number":14,"context_line":"        - qdrlog_content is search(\u0027Configured Connector: 10.0.0.20:5668 proto\u003dany, role\u003dedge\u0027)"},{"line_number":15,"context_line":"        - qdrlog_content is search(\u0027Configured Connector: 10.0.0.30:5668 proto\u003dany, role\u003dedge\u0027)"},{"line_number":16,"context_line":"      success_msg: Connectors to internal mesh configured"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  - assert:"},{"line_number":19,"context_line":"      that:"},{"line_number":20,"context_line":"        - qdrlog_content is not search(\u0027stf-default-interconnect-5671-service-telemetry.example.com\u0027)"},{"line_number":21,"context_line":"      success_msg: External connector correctly supressed for edge nodes in mesh mode"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"70b0d5fd_2df518e5","line":21,"range":{"start_line":7,"start_character":0,"end_line":21,"end_character":85},"updated":"2021-01-28 19:34:10.000000000","message":"these tasks all need names.","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"89457e7c24cc152e77a838a92664513fd97325d3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"- name: Check log for correct config of controller-mesh edge nodes"},{"line_number":5,"context_line":"  hosts: qdrtest"},{"line_number":6,"context_line":"  tasks:"},{"line_number":7,"context_line":"  - assert:"},{"line_number":8,"context_line":"      that:"},{"line_number":9,"context_line":"        - qdrlog_content.find(\u0027Router started in Edge mode\u0027) !\u003d -1"},{"line_number":10,"context_line":"      success_msg: Router started in Edge mode"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  - assert:"},{"line_number":13,"context_line":"      that:"},{"line_number":14,"context_line":"        - qdrlog_content is search(\u0027Configured Connector: 10.0.0.20:5668 proto\u003dany, role\u003dedge\u0027)"},{"line_number":15,"context_line":"        - qdrlog_content is search(\u0027Configured Connector: 10.0.0.30:5668 proto\u003dany, role\u003dedge\u0027)"},{"line_number":16,"context_line":"      success_msg: Connectors to internal mesh configured"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  - assert:"},{"line_number":19,"context_line":"      that:"},{"line_number":20,"context_line":"        - qdrlog_content is not search(\u0027stf-default-interconnect-5671-service-telemetry.example.com\u0027)"},{"line_number":21,"context_line":"      success_msg: External connector correctly supressed for edge nodes in mesh mode"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a85c0462_851cb824","line":21,"range":{"start_line":7,"start_character":0,"end_line":21,"end_character":85},"in_reply_to":"70b0d5fd_2df518e5","updated":"2021-02-03 02:54:59.000000000","message":"Ack","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"}],"tripleo_ansible/roles/tripleo_metrics_qdr/molecule/controller-mesh-interior-node/converge.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99670fb83178f13927d3026cb2b92e81169e4fe6","unresolved":true,"context_lines":[{"line_number":4,"context_line":"- name: Converge controller-mesh interior node config"},{"line_number":5,"context_line":"  hosts: qdrtest"},{"line_number":6,"context_line":"  tasks:"},{"line_number":7,"context_line":"    - include_role:"},{"line_number":8,"context_line":"        name: \"{{ playbook_dir }}/../../../tripleo_metrics_qdr\""},{"line_number":9,"context_line":"        tasks_from: create_config"},{"line_number":10,"context_line":"      vars:"},{"line_number":11,"context_line":"        qdr_connectors:"},{"line_number":12,"context_line":"          - host: stf-default-interconnect-5671-service-telemetry.example.com"},{"line_number":13,"context_line":"            port: 443"},{"line_number":14,"context_line":"            role: edge"},{"line_number":15,"context_line":"            sslProfile: sslProfile"},{"line_number":16,"context_line":"            verifyHostname: false"},{"line_number":17,"context_line":"        qdr_deployment_mode: controller-mesh"},{"line_number":18,"context_line":"        controller_node_ips: \"10.0.0.20,10.0.0.30,10.0.0.40,{{ ansible_default_ipv4.address }}\""},{"line_number":19,"context_line":"        ctlplane_ip: \"{{ ansible_default_ipv4.address }}\""},{"line_number":20,"context_line":"        internal_api_ip: \"{{ ansible_default_ipv4.address }}\""},{"line_number":21,"context_line":"        service_net_map:"},{"line_number":22,"context_line":"          controller_metrics_qdr_network: internal_api"},{"line_number":23,"context_line":"        tripleo_role_name: Controller"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"190b5b9e_28fd83d0","line":23,"range":{"start_line":7,"start_character":0,"end_line":23,"end_character":37},"updated":"2021-01-28 19:34:10.000000000","message":"task needs a name.","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"89457e7c24cc152e77a838a92664513fd97325d3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"- name: Converge controller-mesh interior node config"},{"line_number":5,"context_line":"  hosts: qdrtest"},{"line_number":6,"context_line":"  tasks:"},{"line_number":7,"context_line":"    - include_role:"},{"line_number":8,"context_line":"        name: \"{{ playbook_dir }}/../../../tripleo_metrics_qdr\""},{"line_number":9,"context_line":"        tasks_from: create_config"},{"line_number":10,"context_line":"      vars:"},{"line_number":11,"context_line":"        qdr_connectors:"},{"line_number":12,"context_line":"          - host: stf-default-interconnect-5671-service-telemetry.example.com"},{"line_number":13,"context_line":"            port: 443"},{"line_number":14,"context_line":"            role: edge"},{"line_number":15,"context_line":"            sslProfile: sslProfile"},{"line_number":16,"context_line":"            verifyHostname: false"},{"line_number":17,"context_line":"        qdr_deployment_mode: controller-mesh"},{"line_number":18,"context_line":"        controller_node_ips: \"10.0.0.20,10.0.0.30,10.0.0.40,{{ ansible_default_ipv4.address }}\""},{"line_number":19,"context_line":"        ctlplane_ip: \"{{ ansible_default_ipv4.address }}\""},{"line_number":20,"context_line":"        internal_api_ip: \"{{ ansible_default_ipv4.address }}\""},{"line_number":21,"context_line":"        service_net_map:"},{"line_number":22,"context_line":"          controller_metrics_qdr_network: internal_api"},{"line_number":23,"context_line":"        tripleo_role_name: Controller"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7dc12761_61c1b11a","line":23,"range":{"start_line":7,"start_character":0,"end_line":23,"end_character":37},"in_reply_to":"190b5b9e_28fd83d0","updated":"2021-02-03 02:54:59.000000000","message":"Ack","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"}],"tripleo_ansible/roles/tripleo_metrics_qdr/molecule/controller-mesh-interior-node/molecule.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99670fb83178f13927d3026cb2b92e81169e4fe6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1a26a88e_f2497c16","updated":"2021-01-28 19:34:10.000000000","message":"we have a template for this file. please adhere to the template spec. Example - https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo_ceph_uuid/molecule/default/molecule.yml","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"89457e7c24cc152e77a838a92664513fd97325d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5e2a40bb_2c6f3e71","in_reply_to":"1a26a88e_f2497c16","updated":"2021-02-03 02:54:59.000000000","message":"Ack","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99670fb83178f13927d3026cb2b92e81169e4fe6","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"driver:"},{"line_number":3,"context_line":"  name: ${CONTAINER_BIN:-docker}"},{"line_number":4,"context_line":"platforms:"},{"line_number":5,"context_line":"  - name: qdrtest"},{"line_number":6,"context_line":"    image: quay.io/tripleomaster/openstack-qdrouterd:current-tripleo"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a2c2155_76b06cf1","line":3,"range":{"start_line":2,"start_character":0,"end_line":3,"end_character":32},"updated":"2021-01-28 19:34:10.000000000","message":"we only support the podman driver.","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"89457e7c24cc152e77a838a92664513fd97325d3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"driver:"},{"line_number":3,"context_line":"  name: ${CONTAINER_BIN:-docker}"},{"line_number":4,"context_line":"platforms:"},{"line_number":5,"context_line":"  - name: qdrtest"},{"line_number":6,"context_line":"    image: quay.io/tripleomaster/openstack-qdrouterd:current-tripleo"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e65ba12b_8b60f47d","line":3,"range":{"start_line":2,"start_character":0,"end_line":3,"end_character":32},"in_reply_to":"1a2c2155_76b06cf1","updated":"2021-02-03 02:54:59.000000000","message":"Vestiges of the github CI system this code came from. I swapped this for the the templated file and it works fine.","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99670fb83178f13927d3026cb2b92e81169e4fe6","unresolved":true,"context_lines":[{"line_number":2,"context_line":"driver:"},{"line_number":3,"context_line":"  name: ${CONTAINER_BIN:-docker}"},{"line_number":4,"context_line":"platforms:"},{"line_number":5,"context_line":"  - name: qdrtest"},{"line_number":6,"context_line":"    image: quay.io/tripleomaster/openstack-qdrouterd:current-tripleo"},{"line_number":7,"context_line":"    dockerfile: ../common/Dockerfile.j2"},{"line_number":8,"context_line":"provisioner:"},{"line_number":9,"context_line":"  name: ansible"},{"line_number":10,"context_line":"  log: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"37bbb015_545457c0","line":7,"range":{"start_line":5,"start_character":0,"end_line":7,"end_character":39},"updated":"2021-01-28 19:34:10.000000000","message":"platform should be explicitly stated as UBI8.","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"89457e7c24cc152e77a838a92664513fd97325d3","unresolved":false,"context_lines":[{"line_number":2,"context_line":"driver:"},{"line_number":3,"context_line":"  name: ${CONTAINER_BIN:-docker}"},{"line_number":4,"context_line":"platforms:"},{"line_number":5,"context_line":"  - name: qdrtest"},{"line_number":6,"context_line":"    image: quay.io/tripleomaster/openstack-qdrouterd:current-tripleo"},{"line_number":7,"context_line":"    dockerfile: ../common/Dockerfile.j2"},{"line_number":8,"context_line":"provisioner:"},{"line_number":9,"context_line":"  name: ansible"},{"line_number":10,"context_line":"  log: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3923147d_6e2b6f4a","line":7,"range":{"start_line":5,"start_character":0,"end_line":7,"end_character":39},"in_reply_to":"37bbb015_545457c0","updated":"2021-02-03 02:54:59.000000000","message":"Ack","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"}],"tripleo_ansible/roles/tripleo_metrics_qdr/molecule/controller-mesh-interior-node/verify.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99670fb83178f13927d3026cb2b92e81169e4fe6","unresolved":true,"context_lines":[{"line_number":4,"context_line":"- name: Check log for correct config of controller-mesh interior nodes"},{"line_number":5,"context_line":"  hosts: qdrtest"},{"line_number":6,"context_line":"  tasks:"},{"line_number":7,"context_line":"  - assert:"},{"line_number":8,"context_line":"      that:"},{"line_number":9,"context_line":"        - qdrlog_content.find(\u0027Router started in Interior mode\u0027) !\u003d -1"},{"line_number":10,"context_line":"      success_msg: Router started in Interior mode"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  - assert:"},{"line_number":13,"context_line":"      that:"},{"line_number":14,"context_line":"        - qdrlog_content is search(\u0027Configured Listener:.*:5667 proto\u003dany, role\u003dinter-router\u0027)"},{"line_number":15,"context_line":"      success_msg: Mesh-to-mesh listener configured"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  - assert:"},{"line_number":18,"context_line":"      that:"},{"line_number":19,"context_line":"        - qdrlog_content is search(\u0027Configured Listener:.*:5668 proto\u003dany, role\u003dedge\u0027)"},{"line_number":20,"context_line":"      success_msg: Edge-to-mesh listener configured"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  - assert:"},{"line_number":23,"context_line":"      that:"},{"line_number":24,"context_line":"        - qdrlog_content is search(\u0027Configured Connector: 10.0.0.20:5667 proto\u003dany, role\u003dedge\u0027)"},{"line_number":25,"context_line":"        - qdrlog_content is search(\u0027Configured Connector: 10.0.0.30:5667 proto\u003dany, role\u003dedge\u0027)"},{"line_number":26,"context_line":"        - qdrlog_content is search(\u0027Configured Connector: 10.0.0.40:5667 proto\u003dany, role\u003dedge\u0027)"},{"line_number":27,"context_line":"      success_msg: Connectors to other mesh nodes configured"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  - assert:"},{"line_number":30,"context_line":"      that:"},{"line_number":31,"context_line":"        - qdrlog_content is search(\u0027Configured Connector: stf-default-interconnect-5671-service-telemetry.example.com:443 .* role\u003dedge\u0027)"},{"line_number":32,"context_line":"      success_msg: Connector to STF configured"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c49df1be_4a91558d","line":32,"range":{"start_line":7,"start_character":0,"end_line":32,"end_character":46},"updated":"2021-01-28 19:34:10.000000000","message":"tasks need names.","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"89457e7c24cc152e77a838a92664513fd97325d3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"- name: Check log for correct config of controller-mesh interior nodes"},{"line_number":5,"context_line":"  hosts: qdrtest"},{"line_number":6,"context_line":"  tasks:"},{"line_number":7,"context_line":"  - assert:"},{"line_number":8,"context_line":"      that:"},{"line_number":9,"context_line":"        - qdrlog_content.find(\u0027Router started in Interior mode\u0027) !\u003d -1"},{"line_number":10,"context_line":"      success_msg: Router started in Interior mode"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  - assert:"},{"line_number":13,"context_line":"      that:"},{"line_number":14,"context_line":"        - qdrlog_content is search(\u0027Configured Listener:.*:5667 proto\u003dany, role\u003dinter-router\u0027)"},{"line_number":15,"context_line":"      success_msg: Mesh-to-mesh listener configured"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  - assert:"},{"line_number":18,"context_line":"      that:"},{"line_number":19,"context_line":"        - qdrlog_content is search(\u0027Configured Listener:.*:5668 proto\u003dany, role\u003dedge\u0027)"},{"line_number":20,"context_line":"      success_msg: Edge-to-mesh listener configured"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  - assert:"},{"line_number":23,"context_line":"      that:"},{"line_number":24,"context_line":"        - qdrlog_content is search(\u0027Configured Connector: 10.0.0.20:5667 proto\u003dany, role\u003dedge\u0027)"},{"line_number":25,"context_line":"        - qdrlog_content is search(\u0027Configured Connector: 10.0.0.30:5667 proto\u003dany, role\u003dedge\u0027)"},{"line_number":26,"context_line":"        - qdrlog_content is search(\u0027Configured Connector: 10.0.0.40:5667 proto\u003dany, role\u003dedge\u0027)"},{"line_number":27,"context_line":"      success_msg: Connectors to other mesh nodes configured"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  - assert:"},{"line_number":30,"context_line":"      that:"},{"line_number":31,"context_line":"        - qdrlog_content is search(\u0027Configured Connector: stf-default-interconnect-5671-service-telemetry.example.com:443 .* role\u003dedge\u0027)"},{"line_number":32,"context_line":"      success_msg: Connector to STF configured"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"efe28f42_4b81ae1c","line":32,"range":{"start_line":7,"start_character":0,"end_line":32,"end_character":46},"in_reply_to":"c49df1be_4a91558d","updated":"2021-02-03 02:54:59.000000000","message":"Ack","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"}],"tripleo_ansible/roles/tripleo_metrics_qdr/molecule/default/converge.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99670fb83178f13927d3026cb2b92e81169e4fe6","unresolved":true,"context_lines":[{"line_number":4,"context_line":"- name: Converge edge-only config"},{"line_number":5,"context_line":"  hosts: qdrtest"},{"line_number":6,"context_line":"  tasks:"},{"line_number":7,"context_line":"    - include_role:"},{"line_number":8,"context_line":"        name: \"{{ playbook_dir }}/../../../tripleo_metrics_qdr\""},{"line_number":9,"context_line":"        tasks_from: create_config"},{"line_number":10,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a0094ae3_8b67f195","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":19},"updated":"2021-01-28 19:34:10.000000000","message":"tasks need names.","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"89457e7c24cc152e77a838a92664513fd97325d3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"- name: Converge edge-only config"},{"line_number":5,"context_line":"  hosts: qdrtest"},{"line_number":6,"context_line":"  tasks:"},{"line_number":7,"context_line":"    - include_role:"},{"line_number":8,"context_line":"        name: \"{{ playbook_dir }}/../../../tripleo_metrics_qdr\""},{"line_number":9,"context_line":"        tasks_from: create_config"},{"line_number":10,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"06de2858_ea2ab082","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":19},"in_reply_to":"a0094ae3_8b67f195","updated":"2021-02-03 02:54:59.000000000","message":"Ack","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"}],"tripleo_ansible/roles/tripleo_metrics_qdr/molecule/default/molecule.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99670fb83178f13927d3026cb2b92e81169e4fe6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e663cc5e_950b778b","updated":"2021-01-28 19:34:10.000000000","message":"we have a template for this file. please adhere to the template spec. Example - https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo_ceph_uuid/molecule/default/molecule.yml","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"89457e7c24cc152e77a838a92664513fd97325d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d49cbd0d_c9540132","in_reply_to":"e663cc5e_950b778b","updated":"2021-02-03 02:54:59.000000000","message":"I\u0027ve matched it as closely as possible, let me know if any of the differences are a problem.","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"4f15543278b8de34df16e5cede5ea30ca870b32c","unresolved":true,"context_lines":[{"line_number":16,"context_line":"      - /etc/ci/mirror_info.sh:/etc/ci/mirror_info.sh:ro"},{"line_number":17,"context_line":"      # Had to comment this out to fix a problem installing rdo-release-victoria"},{"line_number":18,"context_line":"      # see common/prepare.yml"},{"line_number":19,"context_line":"      # - /etc/pki/rpm-gpg:/etc/pki/rpm-gpg"},{"line_number":20,"context_line":"    privileged: true"},{"line_number":21,"context_line":"    environment: \u0026env"},{"line_number":22,"context_line":"      http_proxy: \"{{ lookup(\u0027env\u0027, \u0027http_proxy\u0027) }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"98a14b9b_c5e5661c","line":19,"updated":"2021-02-03 03:11:45.000000000","message":"If I leave this mount in place, I\u0027m unable to install the victoria repos package because it tries to write into this directory and fails to unpack. Hopefully this can unwind along with the installation of that package.","commit_id":"a78d6d0afe6f6c6a978afecfa5ff2f17d46fb732"}],"tripleo_ansible/roles/tripleo_metrics_qdr/molecule/default/verify.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99670fb83178f13927d3026cb2b92e81169e4fe6","unresolved":true,"context_lines":[{"line_number":5,"context_line":"- name: Check log for correct config"},{"line_number":6,"context_line":"  hosts: qdrtest"},{"line_number":7,"context_line":"  tasks:"},{"line_number":8,"context_line":"  - assert:"},{"line_number":9,"context_line":"      that:"},{"line_number":10,"context_line":"        - qdrlog_content.find(\u0027Router started in Edge mode\u0027) !\u003d -1"},{"line_number":11,"context_line":"      success_msg: Router started in Edge mode"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  - assert:"},{"line_number":14,"context_line":"      that:"},{"line_number":15,"context_line":"        - qdrlog_content is search(\u0027Configured Connector: stf-default-interconnect-5671-service-telemetry.example.com:443 proto\u003dany, role\u003dedge, sslProfile\u003dsslProfile\u0027)  #noqa 204"},{"line_number":16,"context_line":"      success_msg: Connector to STF configured"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ef7c82e6_d4de7036","line":14,"range":{"start_line":8,"start_character":0,"end_line":14,"end_character":11},"updated":"2021-01-28 19:34:10.000000000","message":"tasks need names.","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"89457e7c24cc152e77a838a92664513fd97325d3","unresolved":false,"context_lines":[{"line_number":5,"context_line":"- name: Check log for correct config"},{"line_number":6,"context_line":"  hosts: qdrtest"},{"line_number":7,"context_line":"  tasks:"},{"line_number":8,"context_line":"  - assert:"},{"line_number":9,"context_line":"      that:"},{"line_number":10,"context_line":"        - qdrlog_content.find(\u0027Router started in Edge mode\u0027) !\u003d -1"},{"line_number":11,"context_line":"      success_msg: Router started in Edge mode"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  - assert:"},{"line_number":14,"context_line":"      that:"},{"line_number":15,"context_line":"        - qdrlog_content is search(\u0027Configured Connector: stf-default-interconnect-5671-service-telemetry.example.com:443 proto\u003dany, role\u003dedge, sslProfile\u003dsslProfile\u0027)  #noqa 204"},{"line_number":16,"context_line":"      success_msg: Connector to STF configured"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"81b81c8b_8ba1566e","line":14,"range":{"start_line":8,"start_character":0,"end_line":14,"end_character":11},"in_reply_to":"ef7c82e6_d4de7036","updated":"2021-02-03 02:54:59.000000000","message":"Ack","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"}],"tripleo_ansible/roles/tripleo_metrics_qdr/molecule/internal-tls/converge.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99670fb83178f13927d3026cb2b92e81169e4fe6","unresolved":true,"context_lines":[{"line_number":4,"context_line":"- name: Converge edge-only config"},{"line_number":5,"context_line":"  hosts: qdrtest"},{"line_number":6,"context_line":"  tasks:"},{"line_number":7,"context_line":"    - include_role:"},{"line_number":8,"context_line":"        name: \"{{ playbook_dir }}/../../../tripleo_metrics_qdr\""},{"line_number":9,"context_line":"        tasks_from: create_config"},{"line_number":10,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f483168e_dd7e1a8a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":19},"updated":"2021-01-28 19:34:10.000000000","message":"tasks need names.","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"89457e7c24cc152e77a838a92664513fd97325d3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"- name: Converge edge-only config"},{"line_number":5,"context_line":"  hosts: qdrtest"},{"line_number":6,"context_line":"  tasks:"},{"line_number":7,"context_line":"    - include_role:"},{"line_number":8,"context_line":"        name: \"{{ playbook_dir }}/../../../tripleo_metrics_qdr\""},{"line_number":9,"context_line":"        tasks_from: create_config"},{"line_number":10,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7b85b5f5_86893496","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":19},"in_reply_to":"f483168e_dd7e1a8a","updated":"2021-02-03 02:54:59.000000000","message":"Ack","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"}],"tripleo_ansible/roles/tripleo_metrics_qdr/molecule/internal-tls/molecule.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99670fb83178f13927d3026cb2b92e81169e4fe6","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"driver:"},{"line_number":3,"context_line":"  name: ${CONTAINER_BIN:-docker}"},{"line_number":4,"context_line":"platforms:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"24001a7e_96a191da","line":1,"updated":"2021-01-28 19:34:10.000000000","message":"we have a template for this file. please adhere to the template spec. Example - https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo_ceph_uuid/molecule/default/molecule.yml","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"89457e7c24cc152e77a838a92664513fd97325d3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"driver:"},{"line_number":3,"context_line":"  name: ${CONTAINER_BIN:-docker}"},{"line_number":4,"context_line":"platforms:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"cbe25680_139bcd56","line":1,"in_reply_to":"24001a7e_96a191da","updated":"2021-02-03 02:54:59.000000000","message":"Ack","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"9a6ec4b86f5a731bdc3e59fc36165e4dbd902f50","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    image: ubi8/ubi-init"},{"line_number":11,"context_line":"    registry:"},{"line_number":12,"context_line":"      url: registry.access.redhat.com"},{"line_number":13,"context_line":"    dockerfile: Dockerfile"},{"line_number":14,"context_line":"    pkg_extras: python*setuptools"},{"line_number":15,"context_line":"    volumes:"},{"line_number":16,"context_line":"      - /etc/ci/mirror_info.sh:/etc/ci/mirror_info.sh:ro"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"1d72b373_d361ee63","line":13,"range":{"start_line":13,"start_character":4,"end_line":13,"end_character":26},"updated":"2021-03-26 18:23:29.000000000","message":"this needs to point to ../common/Dockerfile.j2 otherwise we\u0027re using the built in dockerfile from molecule.","commit_id":"6da84c1a6ae664ba8a2489bba778c4f68c0696dd"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"20c826489c3eb07e69964338e0ab64aa6b53f974","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    image: ubi8/ubi-init"},{"line_number":11,"context_line":"    registry:"},{"line_number":12,"context_line":"      url: registry.access.redhat.com"},{"line_number":13,"context_line":"    dockerfile: Dockerfile"},{"line_number":14,"context_line":"    pkg_extras: python*setuptools"},{"line_number":15,"context_line":"    volumes:"},{"line_number":16,"context_line":"      - /etc/ci/mirror_info.sh:/etc/ci/mirror_info.sh:ro"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"392ac0bc_b84ec6fd","line":13,"range":{"start_line":13,"start_character":4,"end_line":13,"end_character":26},"in_reply_to":"1d72b373_d361ee63","updated":"2021-03-26 18:25:00.000000000","message":"this change has to be made in all of the molecule files.","commit_id":"6da84c1a6ae664ba8a2489bba778c4f68c0696dd"}],"tripleo_ansible/roles/tripleo_metrics_qdr/molecule/internal-tls/verify.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99670fb83178f13927d3026cb2b92e81169e4fe6","unresolved":true,"context_lines":[{"line_number":5,"context_line":"- name: Check log for correct config"},{"line_number":6,"context_line":"  hosts: qdrtest"},{"line_number":7,"context_line":"  tasks:"},{"line_number":8,"context_line":"  - assert:"},{"line_number":9,"context_line":"      that:"},{"line_number":10,"context_line":"        - qdrlog_content is search(\u0027Created SSL Profile with name tlsProfile\u0027)"},{"line_number":11,"context_line":"      success_msg: tlsProfile configured"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"92691c28_a59cc2ce","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":11},"updated":"2021-01-28 19:34:10.000000000","message":"tasks need names.","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"89457e7c24cc152e77a838a92664513fd97325d3","unresolved":false,"context_lines":[{"line_number":5,"context_line":"- name: Check log for correct config"},{"line_number":6,"context_line":"  hosts: qdrtest"},{"line_number":7,"context_line":"  tasks:"},{"line_number":8,"context_line":"  - assert:"},{"line_number":9,"context_line":"      that:"},{"line_number":10,"context_line":"        - qdrlog_content is search(\u0027Created SSL Profile with name tlsProfile\u0027)"},{"line_number":11,"context_line":"      success_msg: tlsProfile configured"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"cc268a3f_aa42a8ca","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":11},"in_reply_to":"92691c28_a59cc2ce","updated":"2021-02-03 02:54:59.000000000","message":"Ack","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"}],"tripleo_ansible/roles/tripleo_metrics_qdr/tasks/create_config.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99670fb83178f13927d3026cb2b92e81169e4fe6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"60bad42f_41d8ab40","updated":"2021-01-28 19:34:10.000000000","message":"many of the individual set_fact calls, that are not dependent on one another should all be consolidated into one task. While the readability of the listed tasks is great, consolidating them into as few tasks as possible is considerably faster, especially when executing at scale. Please review the task layout and consolidate wherever possible.","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"89457e7c24cc152e77a838a92664513fd97325d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"51934b0d_b10d5731","in_reply_to":"60bad42f_41d8ab40","updated":"2021-02-03 02:54:59.000000000","message":"Ack","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99670fb83178f13927d3026cb2b92e81169e4fe6","unresolved":true,"context_lines":[{"line_number":4,"context_line":"# 1) Mesh mode - Controllers form a QDR mesh which connects to the external endpoint, all other nodes connect to the mesh"},{"line_number":5,"context_line":"# 2) TLS Everywhere - Enabling SSL for mesh-to-mesh and edge-to-mesh connections (WIP)"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Get a mutable version of the connectors so we can supress it on edge nodes if controller-mesh is enabled"},{"line_number":8,"context_line":"  set_fact:"},{"line_number":9,"context_line":"    connectors: \"{{ qdr_connectors }}\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# *CS"},{"line_number":12,"context_line":"# Q1. Alex Schultz suggested I consider moving this (computation of listener_addr) back to THT. It\u0027s so much more readable and testable here."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"401a3e11_42011d44","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":38},"updated":"2021-01-28 19:34:10.000000000","message":"another thing we should consider with facts, it to set `run_once: true`. If a fact is to apply to all hosts within the playbook execution the same way, we can set run_once: true which will save on execution time and apply globally.","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"89457e7c24cc152e77a838a92664513fd97325d3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# 1) Mesh mode - Controllers form a QDR mesh which connects to the external endpoint, all other nodes connect to the mesh"},{"line_number":5,"context_line":"# 2) TLS Everywhere - Enabling SSL for mesh-to-mesh and edge-to-mesh connections (WIP)"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Get a mutable version of the connectors so we can supress it on edge nodes if controller-mesh is enabled"},{"line_number":8,"context_line":"  set_fact:"},{"line_number":9,"context_line":"    connectors: \"{{ qdr_connectors }}\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# *CS"},{"line_number":12,"context_line":"# Q1. Alex Schultz suggested I consider moving this (computation of listener_addr) back to THT. It\u0027s so much more readable and testable here."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"89e723ec_d71495b0","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":38},"in_reply_to":"401a3e11_42011d44","updated":"2021-02-03 02:54:59.000000000","message":"Ack","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99670fb83178f13927d3026cb2b92e81169e4fe6","unresolved":true,"context_lines":[{"line_number":20,"context_line":"  set_fact:"},{"line_number":21,"context_line":"    qdr_listener_addr: \"{{ lookup(\u0027vars\u0027, service_net_map[ (tripleo_role_name + \u0027MetricsQdrNetwork\u0027) | snake_case] + \u0027_ip\u0027 ) }}\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Handle EnableInternalTLS"},{"line_number":24,"context_line":"  when: tripleo_enable_internal_tls"},{"line_number":25,"context_line":"  block:"},{"line_number":26,"context_line":"    - name: Augment qdr_extra_ssl_profiles with internal profile"},{"line_number":27,"context_line":"      set_fact:"},{"line_number":28,"context_line":"        qdr_extra_ssl_profiles: \"{{ qdr_extra_ssl_profiles +"},{"line_number":29,"context_line":"                        [{ \u0027name\u0027: \u0027tlsProfile\u0027,"},{"line_number":30,"context_line":"                            \u0027certFile\u0027: qdr_listener_ssl_cert_file,"},{"line_number":31,"context_line":"                            \u0027keyFile\u0027: qdr_listener_ssl_key_file,"},{"line_number":32,"context_line":"                            \u0027caCertFile\u0027: tripleo_internal_tlscafile"},{"line_number":33,"context_line":"                          }] }}\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: Set logging params"},{"line_number":36,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"10d665b8_7419acb2","line":33,"range":{"start_line":23,"start_character":0,"end_line":33,"end_character":32},"updated":"2021-01-28 19:34:10.000000000","message":"when there\u0027s only one task in a block, there\u0027s no need for a block.","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"89457e7c24cc152e77a838a92664513fd97325d3","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  set_fact:"},{"line_number":21,"context_line":"    qdr_listener_addr: \"{{ lookup(\u0027vars\u0027, service_net_map[ (tripleo_role_name + \u0027MetricsQdrNetwork\u0027) | snake_case] + \u0027_ip\u0027 ) }}\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Handle EnableInternalTLS"},{"line_number":24,"context_line":"  when: tripleo_enable_internal_tls"},{"line_number":25,"context_line":"  block:"},{"line_number":26,"context_line":"    - name: Augment qdr_extra_ssl_profiles with internal profile"},{"line_number":27,"context_line":"      set_fact:"},{"line_number":28,"context_line":"        qdr_extra_ssl_profiles: \"{{ qdr_extra_ssl_profiles +"},{"line_number":29,"context_line":"                        [{ \u0027name\u0027: \u0027tlsProfile\u0027,"},{"line_number":30,"context_line":"                            \u0027certFile\u0027: qdr_listener_ssl_cert_file,"},{"line_number":31,"context_line":"                            \u0027keyFile\u0027: qdr_listener_ssl_key_file,"},{"line_number":32,"context_line":"                            \u0027caCertFile\u0027: tripleo_internal_tlscafile"},{"line_number":33,"context_line":"                          }] }}\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: Set logging params"},{"line_number":36,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f64f2a7_6a703292","line":33,"range":{"start_line":23,"start_character":0,"end_line":33,"end_character":32},"in_reply_to":"10d665b8_7419acb2","updated":"2021-02-03 02:54:59.000000000","message":"Side effects of iterative development. Thanks :)","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99670fb83178f13927d3026cb2b92e81169e4fe6","unresolved":true,"context_lines":[{"line_number":38,"context_line":"    log_enable: \u0027info+\u0027"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- name: Configure the mesh mode settings if requested"},{"line_number":41,"context_line":"  when: qdr_deployment_mode \u003d\u003d \u0027controller-mesh\u0027"},{"line_number":42,"context_line":"  block:"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  - name: Set the list of interior mesh nodes"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9015fd36_7fcd5f4c","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":48},"updated":"2021-01-28 19:34:10.000000000","message":"when should be written as a list.","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99670fb83178f13927d3026cb2b92e81169e4fe6","unresolved":true,"context_lines":[{"line_number":106,"context_line":"        loop: \"{{ mesh_connection_nodes_list }}\""},{"line_number":107,"context_line":"        set_fact:"},{"line_number":108,"context_line":"          # *CS TODO: Add the SSL support to mesh mode like node_base from the puppet (internal_tls), see https://github.com/openstack/puppet-tripleo/blob/432b0497f7d0d051f2b4bf34c3e841f2b97bbb44/manifests/profile/base/metrics/qdr.pp#L141"},{"line_number":109,"context_line":"          connectors: \"{{ connectors + [{"},{"line_number":110,"context_line":"                        \u0027host\u0027: item,"},{"line_number":111,"context_line":"                        \u0027port\u0027: \u00275667\u0027,"},{"line_number":112,"context_line":"                        \u0027role\u0027: \u0027inter-router\u0027,"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0509315a_74260e9f","line":109,"range":{"start_line":109,"start_character":37,"end_line":109,"end_character":38},"updated":"2021-01-28 19:34:10.000000000","message":"Assuming the intention is to append a list, we should use the union filter here.\n\nhttps://docs.ansible.com/ansible/latest/user_guide/playbooks_filters.html#selecting-from-sets-or-lists-set-theory","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99670fb83178f13927d3026cb2b92e81169e4fe6","unresolved":true,"context_lines":[{"line_number":115,"context_line":"                      }}\""},{"line_number":116,"context_line":"# End of mesh-mode block"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"- name: \"Include QDR config role\""},{"line_number":119,"context_line":"  block:"},{"line_number":120,"context_line":"    - name: \"Generate the qdr config files\""},{"line_number":121,"context_line":"      include_role:"},{"line_number":122,"context_line":"        name: qdr_config"},{"line_number":123,"context_line":"      vars:"},{"line_number":124,"context_line":"        qdr_connectors: \"{{ connectors }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c9d2fda7_710951e1","line":124,"range":{"start_line":118,"start_character":0,"end_line":124,"end_character":42},"updated":"2021-01-28 19:34:10.000000000","message":"when there\u0027s only one task in a block, there\u0027s no need for a block.","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"89457e7c24cc152e77a838a92664513fd97325d3","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                      }}\""},{"line_number":116,"context_line":"# End of mesh-mode block"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"- name: \"Include QDR config role\""},{"line_number":119,"context_line":"  block:"},{"line_number":120,"context_line":"    - name: \"Generate the qdr config files\""},{"line_number":121,"context_line":"      include_role:"},{"line_number":122,"context_line":"        name: qdr_config"},{"line_number":123,"context_line":"      vars:"},{"line_number":124,"context_line":"        qdr_connectors: \"{{ connectors }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c67a405a_a9c54619","line":124,"range":{"start_line":118,"start_character":0,"end_line":124,"end_character":42},"in_reply_to":"c9d2fda7_710951e1","updated":"2021-02-03 02:54:59.000000000","message":"Ack","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"}],"tripleo_ansible/roles/tripleo_metrics_qdr/vars/main.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99670fb83178f13927d3026cb2b92e81169e4fe6","unresolved":true,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Corresponds to MetricsQdrAddresses in THT"},{"line_number":4,"context_line":"# Addresses configuration (array of hashes)."},{"line_number":5,"context_line":"qdr_addresses: [{\u0027prefix\u0027: \u0027collectd\u0027, \u0027distribution\u0027: \u0027multicast\u0027}, {\u0027prefix\u0027: \u0027ceilometer/metering.sample\u0027, \u0027distribution\u0027: \u0027multicast\u0027}, {\u0027prefix\u0027: \u0027ceilometer/event.sample\u0027, \u0027distribution\u0027: \u0027multicast\u0027}]"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# Corresponds to MetricsQdrAutoLinks in THT"},{"line_number":8,"context_line":"# AutoLinks for the Configured Addresses"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"edc4518f_0c03fd87","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":207},"updated":"2021-01-28 19:34:10.000000000","message":"given this is an array, we can write it vertically to appease the linter.","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"89457e7c24cc152e77a838a92664513fd97325d3","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Corresponds to MetricsQdrAddresses in THT"},{"line_number":4,"context_line":"# Addresses configuration (array of hashes)."},{"line_number":5,"context_line":"qdr_addresses: [{\u0027prefix\u0027: \u0027collectd\u0027, \u0027distribution\u0027: \u0027multicast\u0027}, {\u0027prefix\u0027: \u0027ceilometer/metering.sample\u0027, \u0027distribution\u0027: \u0027multicast\u0027}, {\u0027prefix\u0027: \u0027ceilometer/event.sample\u0027, \u0027distribution\u0027: \u0027multicast\u0027}]"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# Corresponds to MetricsQdrAutoLinks in THT"},{"line_number":8,"context_line":"# AutoLinks for the Configured Addresses"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f9f5cb2_450e1b2c","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":207},"in_reply_to":"edc4518f_0c03fd87","updated":"2021-02-03 02:54:59.000000000","message":"Ack","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99670fb83178f13927d3026cb2b92e81169e4fe6","unresolved":true,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# Corresponds to MetricsQdrAuthenticateClient in THT"},{"line_number":26,"context_line":"# Authenticate the client using SSL/TLS"},{"line_number":27,"context_line":"qdr_listener_auth_peer: no"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Corresponds to MetricsQdrPort in THT"},{"line_number":30,"context_line":"# Service name or port number on which the qdrouterd will accept connections."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8dcebf7a_296e66df","line":27,"range":{"start_line":27,"start_character":24,"end_line":27,"end_character":26},"updated":"2021-01-28 19:34:10.000000000","message":"no !\u003d false, please correct.","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"89457e7c24cc152e77a838a92664513fd97325d3","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# Corresponds to MetricsQdrAuthenticateClient in THT"},{"line_number":26,"context_line":"# Authenticate the client using SSL/TLS"},{"line_number":27,"context_line":"qdr_listener_auth_peer: no"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Corresponds to MetricsQdrPort in THT"},{"line_number":30,"context_line":"# Service name or port number on which the qdrouterd will accept connections."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4ce2d419_0f367e55","line":27,"range":{"start_line":27,"start_character":24,"end_line":27,"end_character":26},"in_reply_to":"8dcebf7a_296e66df","updated":"2021-02-03 02:54:59.000000000","message":"Ack","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99670fb83178f13927d3026cb2b92e81169e4fe6","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Corresponds to MetricsQdrUseSSL in THT"},{"line_number":34,"context_line":"# Set to true if it is required to use SSL or TLS on the connection for listener."},{"line_number":35,"context_line":"qdr_listener_require_ssl: no"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# Corresponds to MetricsQdrSaslMechanisms in THT"},{"line_number":38,"context_line":"# List of accepted SASL auth mechanisms for listener in format of comma separated"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"068dbbf3_c0ce8b21","line":35,"range":{"start_line":35,"start_character":26,"end_line":35,"end_character":28},"updated":"2021-01-28 19:34:10.000000000","message":"no !\u003d false, please correct.","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"89457e7c24cc152e77a838a92664513fd97325d3","unresolved":true,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Corresponds to MetricsQdrUseSSL in THT"},{"line_number":34,"context_line":"# Set to true if it is required to use SSL or TLS on the connection for listener."},{"line_number":35,"context_line":"qdr_listener_require_ssl: no"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# Corresponds to MetricsQdrSaslMechanisms in THT"},{"line_number":38,"context_line":"# List of accepted SASL auth mechanisms for listener in format of comma separated"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dc5c9701_dfa8d280","line":35,"range":{"start_line":35,"start_character":26,"end_line":35,"end_character":28},"in_reply_to":"068dbbf3_c0ce8b21","updated":"2021-02-03 02:54:59.000000000","message":"Summary of our IRC discussion: The underlying service config uses \u0027yes\u0027 and \u0027no\u0027, and all the legacy code I\u0027m replacing represented it that way too. We both agree that it\u0027s preferable to fix it top-to-bottom, and I will do that on an upcoming patch with co-ordinating patches in THT, this repo, and the \"qdr_config\" role here: https://github.com/infrawatch/qdr-config-ansible-role","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99670fb83178f13927d3026cb2b92e81169e4fe6","unresolved":true,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# Corresponds to MetricsQdrUseEncryption in THT"},{"line_number":67,"context_line":"# Set to true if it is required to encrypt connection to the peer for listener."},{"line_number":68,"context_line":"qdr_listener_use_encryption: no"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"qdr_log_output: /var/log/qdrouterd/metrics_qdr.log"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ee900bb4_fb56fff9","line":68,"range":{"start_line":68,"start_character":29,"end_line":68,"end_character":31},"updated":"2021-01-28 19:34:10.000000000","message":"no !\u003d false, please correct.","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"89457e7c24cc152e77a838a92664513fd97325d3","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# Corresponds to MetricsQdrUseEncryption in THT"},{"line_number":67,"context_line":"# Set to true if it is required to encrypt connection to the peer for listener."},{"line_number":68,"context_line":"qdr_listener_use_encryption: no"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"qdr_log_output: /var/log/qdrouterd/metrics_qdr.log"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"69a18646_ead475f9","line":68,"range":{"start_line":68,"start_character":29,"end_line":68,"end_character":31},"in_reply_to":"ee900bb4_fb56fff9","updated":"2021-02-03 02:54:59.000000000","message":"Ack","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99670fb83178f13927d3026cb2b92e81169e4fe6","unresolved":true,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# Corresponds to MetricsQdrSSLProfiles in THT"},{"line_number":79,"context_line":"# SSL Profiles for the connectors (array of hashes)."},{"line_number":80,"context_line":"qdr_ssl_profiles: [{\u0027name\u0027: \u0027sslProfile\u0027}]"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"# Corresponds to MetricsQdrUsername in THT"},{"line_number":83,"context_line":"# Username which should be used to authenticate to the deployed qdrouterd."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"05e9edc0_7503e069","line":80,"updated":"2021-01-28 19:34:10.000000000","message":"for consistency sake, this can be written vertically.","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"89457e7c24cc152e77a838a92664513fd97325d3","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# Corresponds to MetricsQdrSSLProfiles in THT"},{"line_number":79,"context_line":"# SSL Profiles for the connectors (array of hashes)."},{"line_number":80,"context_line":"qdr_ssl_profiles: [{\u0027name\u0027: \u0027sslProfile\u0027}]"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"# Corresponds to MetricsQdrUsername in THT"},{"line_number":83,"context_line":"# Username which should be used to authenticate to the deployed qdrouterd."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2902df59_f9db6f9d","line":80,"in_reply_to":"05e9edc0_7503e069","updated":"2021-02-03 02:54:59.000000000","message":"Ack","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"99670fb83178f13927d3026cb2b92e81169e4fe6","unresolved":true,"context_lines":[{"line_number":86,"context_line":"# Corresponds to MetricsQdrExternalEndpoint in THT"},{"line_number":87,"context_line":"# Whether QDR should listen on external network interface. To enable listening"},{"line_number":88,"context_line":"# on external network one must deploy QDRs in mesh mode."},{"line_number":89,"context_line":"metrics_qdr_external_endpoint: False"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"# Corresponds to EnableInternalTLS in THT"},{"line_number":92,"context_line":"tripleo_enable_internal_tls: false"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5027a407_2c4d2f6f","line":89,"range":{"start_line":89,"start_character":31,"end_line":89,"end_character":36},"updated":"2021-01-28 19:34:10.000000000","message":"False !\u003d false, please correct.","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"89457e7c24cc152e77a838a92664513fd97325d3","unresolved":false,"context_lines":[{"line_number":86,"context_line":"# Corresponds to MetricsQdrExternalEndpoint in THT"},{"line_number":87,"context_line":"# Whether QDR should listen on external network interface. To enable listening"},{"line_number":88,"context_line":"# on external network one must deploy QDRs in mesh mode."},{"line_number":89,"context_line":"metrics_qdr_external_endpoint: False"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"# Corresponds to EnableInternalTLS in THT"},{"line_number":92,"context_line":"tripleo_enable_internal_tls: false"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7e527806_246a1d97","line":89,"range":{"start_line":89,"start_character":31,"end_line":89,"end_character":36},"in_reply_to":"5027a407_2c4d2f6f","updated":"2021-02-03 02:54:59.000000000","message":"Ack","commit_id":"4128dd9a107099e1bcdb5ae05e887d89e6f0447b"}]}