)]}'
{"tripleo_ansible/ansible_plugins/filter/snake_case.py":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"b8e1e657fe26fa0609218ac26be2f881b9230a8b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"48679d1f_1afa82f3","updated":"2021-03-03 19:46:45.000000000","message":"needs boilerplate.","commit_id":"8ecaefc09827cbe12b1055ae193743bfba1c630d"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"c362d30aa6fd9604d3e27b5523e77a1f1521b268","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"69b42d1a_53d27985","in_reply_to":"48679d1f_1afa82f3","updated":"2021-03-04 18:06:48.000000000","message":"Resolved due to this being moved to filter/helpers instead","commit_id":"8ecaefc09827cbe12b1055ae193743bfba1c630d"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"b8e1e657fe26fa0609218ac26be2f881b9230a8b","unresolved":true,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"class FilterModule(object):"},{"line_number":5,"context_line":"    def filters(self):"},{"line_number":6,"context_line":"        return {\u0027snake_case\u0027: self.filter_snake_case}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    def filter_snake_case(self, camel_case_string):"},{"line_number":9,"context_line":"        \"\"\"Convert from THTCamelCase to ansible_snake_case"},{"line_number":10,"context_line":"        This filter will return a snake_case version of the input string."},{"line_number":11,"context_line":"        \u003e\u003e\u003e filter_snake_case(\u0027CephStorage\u0027)"},{"line_number":12,"context_line":"        \u0027ceph_storage\u0027"},{"line_number":13,"context_line":"        \u003e\u003e\u003e filter_snake_case(\u0027HTTPWorker\u0027)"},{"line_number":14,"context_line":"        \u0027http_worker\u0027"},{"line_number":15,"context_line":"        \u003e\u003e\u003e filter_snake_case(\u0027MetricsQDR\u0027)"},{"line_number":16,"context_line":"        \u0027metrics_qdr\u0027"},{"line_number":17,"context_line":"        \"\"\""},{"line_number":18,"context_line":"        camel_case_string \u003d re.sub(r\u0027(.)([A-Z][a-z]+)\u0027, r\u0027\\1_\\2\u0027,"},{"line_number":19,"context_line":"                                   camel_case_string)"},{"line_number":20,"context_line":"        return re.sub(r\u0027([a-z0-9])([A-Z])\u0027, r\u0027\\1_\\2\u0027, camel_case_string).lower()"}],"source_content_type":"text/x-python","patch_set":10,"id":"0d24f093_6108dbb6","line":20,"range":{"start_line":5,"start_character":0,"end_line":20,"end_character":80},"updated":"2021-03-03 19:46:45.000000000","message":"can we add this to the existing filters plugin that we maintain under helpers [0]?\n\n[0] https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/ansible_plugins/filter/helpers.py","commit_id":"8ecaefc09827cbe12b1055ae193743bfba1c630d"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"76f782c603f8ddb4717bf78305971cd7015702da","unresolved":true,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"class FilterModule(object):"},{"line_number":5,"context_line":"    def filters(self):"},{"line_number":6,"context_line":"        return {\u0027snake_case\u0027: self.filter_snake_case}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    def filter_snake_case(self, camel_case_string):"},{"line_number":9,"context_line":"        \"\"\"Convert from THTCamelCase to ansible_snake_case"},{"line_number":10,"context_line":"        This filter will return a snake_case version of the input string."},{"line_number":11,"context_line":"        \u003e\u003e\u003e filter_snake_case(\u0027CephStorage\u0027)"},{"line_number":12,"context_line":"        \u0027ceph_storage\u0027"},{"line_number":13,"context_line":"        \u003e\u003e\u003e filter_snake_case(\u0027HTTPWorker\u0027)"},{"line_number":14,"context_line":"        \u0027http_worker\u0027"},{"line_number":15,"context_line":"        \u003e\u003e\u003e filter_snake_case(\u0027MetricsQDR\u0027)"},{"line_number":16,"context_line":"        \u0027metrics_qdr\u0027"},{"line_number":17,"context_line":"        \"\"\""},{"line_number":18,"context_line":"        camel_case_string \u003d re.sub(r\u0027(.)([A-Z][a-z]+)\u0027, r\u0027\\1_\\2\u0027,"},{"line_number":19,"context_line":"                                   camel_case_string)"},{"line_number":20,"context_line":"        return re.sub(r\u0027([a-z0-9])([A-Z])\u0027, r\u0027\\1_\\2\u0027, camel_case_string).lower()"}],"source_content_type":"text/x-python","patch_set":10,"id":"78acff9c_ecbc0117","line":20,"range":{"start_line":5,"start_character":0,"end_line":20,"end_character":80},"in_reply_to":"0d24f093_6108dbb6","updated":"2021-03-03 20:18:32.000000000","message":"This is from the change that csibbitt proposed: https://review.opendev.org/c/openstack/tripleo-ansible/+/772920/10/tripleo_ansible/ansible_plugins/filter/snake_case.py\n\nWe can probably split this out and have both changes depend on it.","commit_id":"8ecaefc09827cbe12b1055ae193743bfba1c630d"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"c362d30aa6fd9604d3e27b5523e77a1f1521b268","unresolved":true,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"class FilterModule(object):"},{"line_number":5,"context_line":"    def filters(self):"},{"line_number":6,"context_line":"        return {\u0027snake_case\u0027: self.filter_snake_case}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    def filter_snake_case(self, camel_case_string):"},{"line_number":9,"context_line":"        \"\"\"Convert from THTCamelCase to ansible_snake_case"},{"line_number":10,"context_line":"        This filter will return a snake_case version of the input string."},{"line_number":11,"context_line":"        \u003e\u003e\u003e filter_snake_case(\u0027CephStorage\u0027)"},{"line_number":12,"context_line":"        \u0027ceph_storage\u0027"},{"line_number":13,"context_line":"        \u003e\u003e\u003e filter_snake_case(\u0027HTTPWorker\u0027)"},{"line_number":14,"context_line":"        \u0027http_worker\u0027"},{"line_number":15,"context_line":"        \u003e\u003e\u003e filter_snake_case(\u0027MetricsQDR\u0027)"},{"line_number":16,"context_line":"        \u0027metrics_qdr\u0027"},{"line_number":17,"context_line":"        \"\"\""},{"line_number":18,"context_line":"        camel_case_string \u003d re.sub(r\u0027(.)([A-Z][a-z]+)\u0027, r\u0027\\1_\\2\u0027,"},{"line_number":19,"context_line":"                                   camel_case_string)"},{"line_number":20,"context_line":"        return re.sub(r\u0027([a-z0-9])([A-Z])\u0027, r\u0027\\1_\\2\u0027, camel_case_string).lower()"}],"source_content_type":"text/x-python","patch_set":10,"id":"61c366ee_1c6cf294","line":20,"range":{"start_line":5,"start_character":0,"end_line":20,"end_character":80},"in_reply_to":"78acff9c_ecbc0117","updated":"2021-03-04 18:06:48.000000000","message":"I split it out here: https://review.opendev.org/c/openstack/tripleo-ansible/+/778704","commit_id":"8ecaefc09827cbe12b1055ae193743bfba1c630d"}],"tripleo_ansible/roles/tripleo_collectd/defaults/main.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"b8e1e657fe26fa0609218ac26be2f881b9230a8b","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Corresponds to RoleName in THT"},{"line_number":19,"context_line":"# Role name on which the service is applied"},{"line_number":20,"context_line":"tripleo_role_name:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# Corresponds to MetricsQdrPort in THT"},{"line_number":23,"context_line":"# Service name or port number on which the qdrouterd will accept connections."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"66ff87a6_b28c6827","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":18},"updated":"2021-03-03 19:46:45.000000000","message":"what is the default here? if null lets set it accordingly.","commit_id":"8ecaefc09827cbe12b1055ae193743bfba1c630d"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"76f782c603f8ddb4717bf78305971cd7015702da","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Corresponds to RoleName in THT"},{"line_number":19,"context_line":"# Role name on which the service is applied"},{"line_number":20,"context_line":"tripleo_role_name:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# Corresponds to MetricsQdrPort in THT"},{"line_number":23,"context_line":"# Service name or port number on which the qdrouterd will accept connections."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"0a401a34_9b223428","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":18},"in_reply_to":"66ff87a6_b28c6827","updated":"2021-03-03 20:18:32.000000000","message":"There\u0027s no default, as it\u0027s supposed to be passed in from THT.\nIt was originally added here as a placeholder, along with some other vars that I wasn\u0027t sure were needed; AFAIK, it can be removed from here.\n\nIt\u0027s used in https://review.opendev.org/c/openstack/tripleo-ansible/+/776709/10/tripleo_ansible/roles/tripleo_collectd/tasks/configure_collectd.yml#57 and https://review.opendev.org/c/openstack/tripleo-ansible/+/776709/10/tripleo_ansible/roles/tripleo_collectd/tasks/configure_collectd.yml#176","commit_id":"8ecaefc09827cbe12b1055ae193743bfba1c630d"}],"tripleo_ansible/roles/tripleo_collectd/tasks/configure_collectd.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"b8e1e657fe26fa0609218ac26be2f881b9230a8b","unresolved":true,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: \"Enable read plugins for STF\""},{"line_number":24,"context_line":"  when:"},{"line_number":25,"context_line":"    - tripleo_collectd_enable_stf|bool"},{"line_number":26,"context_line":"  set_fact:"},{"line_number":27,"context_line":"    collectd_plugins: \"{{ collectd_plugins | union([\u0027cpu\u0027, \u0027df\u0027, \u0027load\u0027, \u0027connectivity\u0027, \u0027intel_rdt\u0027, \u0027ipmi\u0027, \u0027procevent\u0027]) | unique }}\""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"df80f107_a227398a","line":25,"range":{"start_line":25,"start_character":6,"end_line":25,"end_character":38},"updated":"2021-03-03 19:46:45.000000000","message":"nit: spaces between objects and filters","commit_id":"8ecaefc09827cbe12b1055ae193743bfba1c630d"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"c362d30aa6fd9604d3e27b5523e77a1f1521b268","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: \"Enable read plugins for STF\""},{"line_number":24,"context_line":"  when:"},{"line_number":25,"context_line":"    - tripleo_collectd_enable_stf|bool"},{"line_number":26,"context_line":"  set_fact:"},{"line_number":27,"context_line":"    collectd_plugins: \"{{ collectd_plugins | union([\u0027cpu\u0027, \u0027df\u0027, \u0027load\u0027, \u0027connectivity\u0027, \u0027intel_rdt\u0027, \u0027ipmi\u0027, \u0027procevent\u0027]) | unique }}\""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"f3e671fb_5a369bc7","line":25,"range":{"start_line":25,"start_character":6,"end_line":25,"end_character":38},"in_reply_to":"df80f107_a227398a","updated":"2021-03-04 18:06:48.000000000","message":"Done","commit_id":"8ecaefc09827cbe12b1055ae193743bfba1c630d"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"b8e1e657fe26fa0609218ac26be2f881b9230a8b","unresolved":true,"context_lines":[{"line_number":82,"context_line":"      block:"},{"line_number":83,"context_line":"        - name: \"Populate the initial config for network server.\""},{"line_number":84,"context_line":"          set_fact:"},{"line_number":85,"context_line":"            collectd_plugin_network_server: {"},{"line_number":86,"context_line":"              \u0027name\u0027: \"{{ tripleo_collectd_server }}\","},{"line_number":87,"context_line":"              \u0027port\u0027: \"{{ tripleo_collectd_server_port | default(omit) }}\","},{"line_number":88,"context_line":"              \u0027username\u0027: \"{{ tripleo_collectd_username | default(omit) }}\","},{"line_number":89,"context_line":"              \u0027password\u0027: \"{{ tripleo_collectd_password | default(omit) }}\","},{"line_number":90,"context_line":"              \u0027securitylevel\u0027: \"{{ tripleo_collectd_security_level | default(omit) }}\","},{"line_number":91,"context_line":"            }"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        - name: \"Filter out the empty string values from the network server config\""},{"line_number":94,"context_line":"          set_fact:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"48e62dc2_49012e0b","line":91,"range":{"start_line":85,"start_character":0,"end_line":91,"end_character":13},"updated":"2021-03-03 19:46:45.000000000","message":"while valid, this can be defined without the writing it in specific JSON.\n\n            collectd_plugin_network_server:\n              name: \"{{ tripleo_collectd_server }}\"\n              port: \"{{ tripleo_collectd_server_port | default(omit) }}\"\n              username: \"{{ tripleo_collectd_username | default(omit) }}\"\n              password: \"{{ tripleo_collectd_password | default(omit) }}\"\n              securitylevel: \"{{ tripleo_collectd_security_level | default(omit) }}\"","commit_id":"8ecaefc09827cbe12b1055ae193743bfba1c630d"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"c362d30aa6fd9604d3e27b5523e77a1f1521b268","unresolved":false,"context_lines":[{"line_number":82,"context_line":"      block:"},{"line_number":83,"context_line":"        - name: \"Populate the initial config for network server.\""},{"line_number":84,"context_line":"          set_fact:"},{"line_number":85,"context_line":"            collectd_plugin_network_server: {"},{"line_number":86,"context_line":"              \u0027name\u0027: \"{{ tripleo_collectd_server }}\","},{"line_number":87,"context_line":"              \u0027port\u0027: \"{{ tripleo_collectd_server_port | default(omit) }}\","},{"line_number":88,"context_line":"              \u0027username\u0027: \"{{ tripleo_collectd_username | default(omit) }}\","},{"line_number":89,"context_line":"              \u0027password\u0027: \"{{ tripleo_collectd_password | default(omit) }}\","},{"line_number":90,"context_line":"              \u0027securitylevel\u0027: \"{{ tripleo_collectd_security_level | default(omit) }}\","},{"line_number":91,"context_line":"            }"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        - name: \"Filter out the empty string values from the network server config\""},{"line_number":94,"context_line":"          set_fact:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f0dfc39_d51ab3f2","line":91,"range":{"start_line":85,"start_character":0,"end_line":91,"end_character":13},"in_reply_to":"48e62dc2_49012e0b","updated":"2021-03-04 18:06:48.000000000","message":"Done","commit_id":"8ecaefc09827cbe12b1055ae193743bfba1c630d"}],"tripleo_ansible/roles/tripleo_collectd/tasks/configure_healthcheck.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"b8e1e657fe26fa0609218ac26be2f881b9230a8b","unresolved":true,"context_lines":[{"line_number":26,"context_line":"  block:"},{"line_number":27,"context_line":"    - name: Log healthchecks in dedicated file"},{"line_number":28,"context_line":"      when:"},{"line_number":29,"context_line":"        - tripleo_collectd_enable_sensubility|bool"},{"line_number":30,"context_line":"      register: logconfig_add"},{"line_number":31,"context_line":"      copy:"},{"line_number":32,"context_line":"        dest: /etc/rsyslog.d/"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5ff96fe6_cbcf7a28","line":29,"range":{"start_line":29,"start_character":10,"end_line":29,"end_character":50},"updated":"2021-03-03 19:46:45.000000000","message":"nit: spaces between objects and filters","commit_id":"8ecaefc09827cbe12b1055ae193743bfba1c630d"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"c362d30aa6fd9604d3e27b5523e77a1f1521b268","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  block:"},{"line_number":27,"context_line":"    - name: Log healthchecks in dedicated file"},{"line_number":28,"context_line":"      when:"},{"line_number":29,"context_line":"        - tripleo_collectd_enable_sensubility|bool"},{"line_number":30,"context_line":"      register: logconfig_add"},{"line_number":31,"context_line":"      copy:"},{"line_number":32,"context_line":"        dest: /etc/rsyslog.d/"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"6b817ac3_22b80775","line":29,"range":{"start_line":29,"start_character":10,"end_line":29,"end_character":50},"in_reply_to":"5ff96fe6_cbcf7a28","updated":"2021-03-04 18:06:48.000000000","message":"Done","commit_id":"8ecaefc09827cbe12b1055ae193743bfba1c630d"}],"tripleo_ansible/roles/tripleo_collectd/tasks/configure_host_software.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"b8e1e657fe26fa0609218ac26be2f881b9230a8b","unresolved":true,"context_lines":[{"line_number":19,"context_line":"  import_role:"},{"line_number":20,"context_line":"    name: tripleo_provision_mcelog"},{"line_number":21,"context_line":"  when:"},{"line_number":22,"context_line":"    - tripleo_collectd_enable_mcelog|bool"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"8d37a0e9_738024b3","line":22,"range":{"start_line":22,"start_character":6,"end_line":22,"end_character":41},"updated":"2021-03-03 19:46:45.000000000","message":"nit: spaces between objects and filters","commit_id":"8ecaefc09827cbe12b1055ae193743bfba1c630d"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"c362d30aa6fd9604d3e27b5523e77a1f1521b268","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  import_role:"},{"line_number":20,"context_line":"    name: tripleo_provision_mcelog"},{"line_number":21,"context_line":"  when:"},{"line_number":22,"context_line":"    - tripleo_collectd_enable_mcelog|bool"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7e7c5843_4513dd12","line":22,"range":{"start_line":22,"start_character":6,"end_line":22,"end_character":41},"in_reply_to":"8d37a0e9_738024b3","updated":"2021-03-04 18:06:48.000000000","message":"Done","commit_id":"8ecaefc09827cbe12b1055ae193743bfba1c630d"}],"tripleo_ansible/roles/tripleo_collectd/tasks/main.yml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f27a015bdaf104e8d55cbd698d4cacfa8262feb8","unresolved":true,"context_lines":[{"line_number":23,"context_line":"  with_first_found:"},{"line_number":24,"context_line":"    - skip: true"},{"line_number":25,"context_line":"      files:"},{"line_number":26,"context_line":"        - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml\""},{"line_number":27,"context_line":"        - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml\""},{"line_number":28,"context_line":"        - \"{{ ansible_os_family | lower }}-{{ ansible_distribution_major_version | lower }}.yml\""},{"line_number":29,"context_line":"        - \"{{ ansible_distribution | lower }}.yml\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1fcedb34_d778fedb","line":26,"range":{"start_line":26,"start_character":14,"end_line":26,"end_character":34},"updated":"2021-03-03 19:47:49.000000000","message":"Please use ansible_facts versions. We\u0027ve changed this everywhere else via  https://review.opendev.org/c/openstack/tripleo-ansible/+/776666","commit_id":"8ecaefc09827cbe12b1055ae193743bfba1c630d"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"c362d30aa6fd9604d3e27b5523e77a1f1521b268","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  with_first_found:"},{"line_number":24,"context_line":"    - skip: true"},{"line_number":25,"context_line":"      files:"},{"line_number":26,"context_line":"        - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yml\""},{"line_number":27,"context_line":"        - \"{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yml\""},{"line_number":28,"context_line":"        - \"{{ ansible_os_family | lower }}-{{ ansible_distribution_major_version | lower }}.yml\""},{"line_number":29,"context_line":"        - \"{{ ansible_distribution | lower }}.yml\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"882ed332_1f50b84b","line":26,"range":{"start_line":26,"start_character":14,"end_line":26,"end_character":34},"in_reply_to":"1fcedb34_d778fedb","updated":"2021-03-04 18:06:48.000000000","message":"Done","commit_id":"8ecaefc09827cbe12b1055ae193743bfba1c630d"}],"tripleo_ansible/roles/tripleo_collectd/vars/main.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"b8e1e657fe26fa0609218ac26be2f881b9230a8b","unresolved":true,"context_lines":[{"line_number":31,"context_line":"collectd_plugin_cpu_reportnumcpu: false"},{"line_number":32,"context_line":"collectd_plugin_cpu_valuespercentage: true"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"collectd_plugin_df_fstypes: [\u0027xfs\u0027]"},{"line_number":35,"context_line":"collectd_plugin_df_ignoreselected: true"},{"line_number":36,"context_line":"collectd_plugin_df_reportbydevice: true"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"53806832_84b9e617","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":35},"updated":"2021-03-03 19:46:45.000000000","message":"nit: we can write this vertically.\n\n  collectd_plugin_df_fstypes:\n    - xfs","commit_id":"8ecaefc09827cbe12b1055ae193743bfba1c630d"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"c362d30aa6fd9604d3e27b5523e77a1f1521b268","unresolved":false,"context_lines":[{"line_number":31,"context_line":"collectd_plugin_cpu_reportnumcpu: false"},{"line_number":32,"context_line":"collectd_plugin_cpu_valuespercentage: true"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"collectd_plugin_df_fstypes: [\u0027xfs\u0027]"},{"line_number":35,"context_line":"collectd_plugin_df_ignoreselected: true"},{"line_number":36,"context_line":"collectd_plugin_df_reportbydevice: true"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"bdf5062f_71b85f1a","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":35},"in_reply_to":"53806832_84b9e617","updated":"2021-03-04 18:06:48.000000000","message":"Ack\n\nI also just realised that \"hardcoding\" these values by putting them here is not the best idea. I\u0027ll move them to default/main, so that they can actually be overwritten using the CollectVars parameter in THT, if required. However, they are values for the collectd_config role rather than this tripleo_config role.","commit_id":"8ecaefc09827cbe12b1055ae193743bfba1c630d"}]}