)]}'
{"tripleo_ansible/ansible_plugins/module_utils/network_data_v2.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"0305d49878317f71c4b973af1442a90f637c783e","unresolved":true,"context_lines":[{"line_number":415,"context_line":"    return error_messages"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"def tags_to_dict(resource_tags):"},{"line_number":419,"context_line":"    tag_dict \u003d dict()"},{"line_number":420,"context_line":"    for tag in resource_tags:"},{"line_number":421,"context_line":"        if not tag.startswith(\u0027tripleo_\u0027):"}],"source_content_type":"text/x-python","patch_set":3,"id":"cbd36583_65ac0a56","line":418,"range":{"start_line":418,"start_character":4,"end_line":418,"end_character":16},"updated":"2021-03-25 08:09:42.000000000","message":"as mentioned in the commit message the functions here are straight copy from the original (except the name of this one) lgtm but please see other comment I think forgot to remove one?","commit_id":"3a8eb47edbfa984e7caa91d23dc28d10b899d720"}],"tripleo_ansible/ansible_plugins/modules/tripleo_overcloud_network_ports.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"0305d49878317f71c4b973af1442a90f637c783e","unresolved":true,"context_lines":[{"line_number":181,"context_line":"\u0027\u0027\u0027"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"def create_name_id_maps(conn):"},{"line_number":185,"context_line":"    net_name_map \u003d {}"},{"line_number":186,"context_line":"    net_id_map \u003d {}"},{"line_number":187,"context_line":"    cidr_prefix_map \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"e129f958_48795109","line":184,"updated":"2021-03-25 08:09:42.000000000","message":"did you forget to remove that one? now duplicate there https://review.opendev.org/c/openstack/tripleo-ansible/+/782187/3/tripleo_ansible/ansible_plugins/module_utils/network_data_v2.py#462","commit_id":"3a8eb47edbfa984e7caa91d23dc28d10b899d720"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"2053b1a03001290a1f5f73b73b8043f1dba23a5d","unresolved":true,"context_lines":[{"line_number":181,"context_line":"\u0027\u0027\u0027"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"def create_name_id_maps(conn):"},{"line_number":185,"context_line":"    net_name_map \u003d {}"},{"line_number":186,"context_line":"    net_id_map \u003d {}"},{"line_number":187,"context_line":"    cidr_prefix_map \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"2d074d61_df9b538e","line":184,"in_reply_to":"e129f958_48795109","updated":"2021-03-25 23:39:29.000000000","message":"*facepalm*, I\u0027ll do an update.","commit_id":"3a8eb47edbfa984e7caa91d23dc28d10b899d720"}],"tripleo_ansible/tests/modules/test_network_data_v2.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"52b72f815db6aa44e1a82d8bb808e265a3a9f855","unresolved":true,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from tripleo_ansible.tests import base as tests_base"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from tripleo_ansible.ansible_plugins.module_utils import network_data_v2"},{"line_number":25,"context_line":"from tripleo_ansible.tests import stubs"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"b7a1080d_5ae75161","line":24,"updated":"2021-03-30 06:55:58.000000000","message":"for consistency/easier maintenance for the humans consider using the same alias here as everywhere else i.e. \n\nfrom tripleo_ansible.ansible_plugins.module_utils import network_data_v2 as n_utils","commit_id":"7cd199260ae915c6444fc038ea1b05900f095fc8"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"23b228b3c4474d69f49a6bc41537b519d10c8079","unresolved":true,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from tripleo_ansible.tests import base as tests_base"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from tripleo_ansible.ansible_plugins.module_utils import network_data_v2"},{"line_number":25,"context_line":"from tripleo_ansible.tests import stubs"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ca4d06fb_a944f0bf","line":24,"in_reply_to":"b7a1080d_5ae75161","updated":"2021-04-01 09:35:18.000000000","message":"good idea, I will do a follow up.","commit_id":"7cd199260ae915c6444fc038ea1b05900f095fc8"}]}