)]}'
{"tripleo_ansible/roles/backup_and_restore/tasks/ceph_authentication.yml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"81e7cfffd971fea4edb93598d0fb418774a03024","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: Unpause ceph mon container if paused"},{"line_number":36,"context_line":"  command: \"{{ tripleo_container_cli }} unpause ceph-mon-{{ ansible_facts[\u0027hostname\u0027] }}\""},{"line_number":37,"context_line":"  ignore_errors: true"},{"line_number":38,"context_line":"  tags:"},{"line_number":39,"context_line":"    - bar_create_recover_image"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"165331dd_00f9d0fe","line":37,"updated":"2021-05-17 16:27:08.000000000","message":"use failed_when: false instead of ignore_errors. It\u0027ll keep it from throwing a scary red message","commit_id":"c71794a143a2541f655ea26a60e2784a69db1759"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"1a138d55fbdacd27c90decc61dcda5b1eee37436","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: Unpause ceph mon container if paused"},{"line_number":36,"context_line":"  command: \"{{ tripleo_container_cli }} unpause ceph-mon-{{ ansible_facts[\u0027hostname\u0027] }}\""},{"line_number":37,"context_line":"  ignore_errors: true"},{"line_number":38,"context_line":"  tags:"},{"line_number":39,"context_line":"    - bar_create_recover_image"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8f4e6e11_d6f500d1","line":37,"in_reply_to":"165331dd_00f9d0fe","updated":"2021-05-19 15:47:01.000000000","message":"Very well indeed. This change and the other two that are the same have been fixed on Patchset 4","commit_id":"c71794a143a2541f655ea26a60e2784a69db1759"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"717b88c16ff0472ae7e76af901a88c28e2c1217c","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    - always"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: Unpause ceph mon container if paused"},{"line_number":36,"context_line":"  command: \"{{ tripleo_container_cli }} unpause ceph-mon-{{ ansible_facts[\u0027hostname\u0027] }}\""},{"line_number":37,"context_line":"  failed_when: false"},{"line_number":38,"context_line":"  tags:"},{"line_number":39,"context_line":"    - bar_create_recover_image"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f78f105b_ee3c7f35","line":36,"updated":"2021-05-24 14:52:19.000000000","message":"become: true","commit_id":"6fb8aa4434cd486bd06dd00ebc45a411ea7219da"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e6208703f58da09b860fd7af4a655466c8127495","unresolved":true,"context_lines":[{"line_number":32,"context_line":"  tags:"},{"line_number":33,"context_line":"    - always"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: Unpause ceph mon container if paused"},{"line_number":36,"context_line":"  command: \"{{ tripleo_container_cli }} unpause ceph-mon-{{ ansible_facts[\u0027hostname\u0027] }}\""},{"line_number":37,"context_line":"  failed_when: false"},{"line_number":38,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"65997a98_3def70b3","line":35,"range":{"start_line":35,"start_character":35,"end_line":35,"end_character":38},"updated":"2021-05-28 07:01:15.000000000","message":"actually you are doing it unconditionally","commit_id":"9a865d176987f82ecafe121f21ba8db9641379d2"}],"tripleo_ansible/roles/backup_and_restore/tasks/db_backup.yml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"81e7cfffd971fea4edb93598d0fb418774a03024","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    - tripleo_backup_and_restore_mysql_container \u003d\u003d \"mysql\""},{"line_number":98,"context_line":"    - not enabled_galera"},{"line_number":99,"context_line":"    - tripleo_backup_and_restore_service_manager|bool"},{"line_number":100,"context_line":"  ignore_errors: true"},{"line_number":101,"context_line":"  tags:"},{"line_number":102,"context_line":"    - bar_create_recover_image"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"2184f7fe_a7b21f60","line":100,"updated":"2021-05-17 16:27:08.000000000","message":"same","commit_id":"c71794a143a2541f655ea26a60e2784a69db1759"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"81e7cfffd971fea4edb93598d0fb418774a03024","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    - not enabled_galera"},{"line_number":136,"context_line":"    - tripleo_backup_and_restore_service_manager|bool"},{"line_number":137,"context_line":"    - not tripleo_backup_and_restore_enable_snapshots|bool"},{"line_number":138,"context_line":"  ignore_errors: true"},{"line_number":139,"context_line":"  tags:"},{"line_number":140,"context_line":"    - bar_create_recover_image"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a5dccf15_2fff1be3","line":138,"updated":"2021-05-17 16:27:08.000000000","message":"same","commit_id":"c71794a143a2541f655ea26a60e2784a69db1759"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"717b88c16ff0472ae7e76af901a88c28e2c1217c","unresolved":true,"context_lines":[{"line_number":54,"context_line":"    - enabled_galera"},{"line_number":55,"context_line":"    - tripleo_backup_and_restore_service_manager|bool"},{"line_number":56,"context_line":"    - not tripleo_backup_and_restore_enable_snapshots|bool"},{"line_number":57,"context_line":"  run_once: true"},{"line_number":58,"context_line":"  tags:"},{"line_number":59,"context_line":"    - bar_create_recover_image"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"d942de4d_4333733a","line":57,"updated":"2021-05-24 14:52:19.000000000","message":"become: true","commit_id":"6fb8aa4434cd486bd06dd00ebc45a411ea7219da"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"717b88c16ff0472ae7e76af901a88c28e2c1217c","unresolved":true,"context_lines":[{"line_number":62,"context_line":"  shell: |"},{"line_number":63,"context_line":"    set -o pipefail"},{"line_number":64,"context_line":"    netstat -tunlp | grep \":3306 \" | sed -e \u0027s/.*\\///\u0027"},{"line_number":65,"context_line":"  register: mysql_result"},{"line_number":66,"context_line":"  retries: 300"},{"line_number":67,"context_line":"  until: mysql_result is search(\u0027mysqld\u0027)"},{"line_number":68,"context_line":"  delay: 5"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ce2cc76a_e8b69743","line":65,"updated":"2021-05-24 14:52:19.000000000","message":"become: true, use ss instead of netstat","commit_id":"6fb8aa4434cd486bd06dd00ebc45a411ea7219da"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"166fdb8f46edf97aa186437fdafd1d2665eef218","unresolved":false,"context_lines":[{"line_number":62,"context_line":"  shell: |"},{"line_number":63,"context_line":"    set -o pipefail"},{"line_number":64,"context_line":"    netstat -tunlp | grep \":3306 \" | sed -e \u0027s/.*\\///\u0027"},{"line_number":65,"context_line":"  register: mysql_result"},{"line_number":66,"context_line":"  retries: 300"},{"line_number":67,"context_line":"  until: mysql_result is search(\u0027mysqld\u0027)"},{"line_number":68,"context_line":"  delay: 5"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"e8dde099_0f85af1e","line":65,"in_reply_to":"ce2cc76a_e8b69743","updated":"2021-05-25 13:44:15.000000000","message":"Done","commit_id":"6fb8aa4434cd486bd06dd00ebc45a411ea7219da"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"717b88c16ff0472ae7e76af901a88c28e2c1217c","unresolved":true,"context_lines":[{"line_number":91,"context_line":"    - bar_create_recover_image"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"- name: Unpause mysql for backup if it is paused"},{"line_number":94,"context_line":"  command: \"{{ tripleo_container_cli }} unpause {{ tripleo_backup_and_restore_mysql_container }}\""},{"line_number":95,"context_line":"  when:"},{"line_number":96,"context_line":"    - mysql_password.stderr is defined"},{"line_number":97,"context_line":"    - tripleo_backup_and_restore_mysql_container \u003d\u003d \"mysql\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"18b538d0_d81a17d7","line":94,"updated":"2021-05-24 14:52:19.000000000","message":"become: true","commit_id":"6fb8aa4434cd486bd06dd00ebc45a411ea7219da"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e6208703f58da09b860fd7af4a655466c8127495","unresolved":true,"context_lines":[{"line_number":48,"context_line":"  tags:"},{"line_number":49,"context_line":"    - bar_create_recover_image"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- name: Enable pacemaker if it is stopped"},{"line_number":52,"context_line":"  command: pcs cluster start --all"},{"line_number":53,"context_line":"  when:"},{"line_number":54,"context_line":"    - enabled_galera"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"2e8fafc8_d7b122fe","line":51,"range":{"start_line":51,"start_character":25,"end_line":51,"end_character":27},"updated":"2021-05-28 07:01:15.000000000","message":"again you\u0027re doing it without check if it is stopped more like \"Ensure pacemaker is running\"","commit_id":"9a865d176987f82ecafe121f21ba8db9641379d2"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"e6208703f58da09b860fd7af4a655466c8127495","unresolved":true,"context_lines":[{"line_number":90,"context_line":"  tags:"},{"line_number":91,"context_line":"    - bar_create_recover_image"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"- name: Unpause mysql for backup if it is paused"},{"line_number":94,"context_line":"  command: \"{{ tripleo_container_cli }} unpause {{ tripleo_backup_and_restore_mysql_container }}\""},{"line_number":95,"context_line":"  when:"},{"line_number":96,"context_line":"    - mysql_password.stderr is defined"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"7f806edf_66584939","line":93,"range":{"start_line":93,"start_character":33,"end_line":93,"end_character":35},"updated":"2021-05-28 07:01:15.000000000","message":";) you know what i will say by now... \n\n\"Ensure mysql container is not paused\"","commit_id":"9a865d176987f82ecafe121f21ba8db9641379d2"}],"tripleo_ansible/roles/backup_and_restore/tasks/pacemaker_unstandby.yml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"717b88c16ff0472ae7e76af901a88c28e2c1217c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"- name: Add the node to the pacemaker cluster"},{"line_number":2,"context_line":"  command: pcs node unstandby"},{"line_number":3,"context_line":"  tags:"},{"line_number":4,"context_line":"    - bar_create_recover_image"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"844a15e9_b59cd01a","line":2,"updated":"2021-05-24 14:52:19.000000000","message":"become: true","commit_id":"6fb8aa4434cd486bd06dd00ebc45a411ea7219da"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"717b88c16ff0472ae7e76af901a88c28e2c1217c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    - bar_create_recover_image"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: Wait until pacemaker has Galera up\u0026running"},{"line_number":7,"context_line":"  shell: netstat -tunlp | grep \":3306 \" | sed -e \u0027s/.*\\///\u0027"},{"line_number":8,"context_line":"  register: mysql_result"},{"line_number":9,"context_line":"  retries: 300"},{"line_number":10,"context_line":"  until: mysql_result is search(\u0027mysqld\u0027)"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"6ac0aa0b_1be6d413","line":7,"updated":"2021-05-24 14:52:19.000000000","message":"use ss","commit_id":"6fb8aa4434cd486bd06dd00ebc45a411ea7219da"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"166fdb8f46edf97aa186437fdafd1d2665eef218","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    - bar_create_recover_image"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: Wait until pacemaker has Galera up\u0026running"},{"line_number":7,"context_line":"  shell: netstat -tunlp | grep \":3306 \" | sed -e \u0027s/.*\\///\u0027"},{"line_number":8,"context_line":"  register: mysql_result"},{"line_number":9,"context_line":"  retries: 300"},{"line_number":10,"context_line":"  until: mysql_result is search(\u0027mysqld\u0027)"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"81533e65_2437b909","line":7,"in_reply_to":"6ac0aa0b_1be6d413","updated":"2021-05-25 13:44:15.000000000","message":"Done","commit_id":"6fb8aa4434cd486bd06dd00ebc45a411ea7219da"}],"tripleo_ansible/roles/backup_and_restore/tasks/service_manager_pause.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"d49df161524c21f43dc0e59e1aa87624a9a248e4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"0e08bf1a_35821ab8","line":52,"range":{"start_line":35,"start_character":0,"end_line":52,"end_character":0},"updated":"2021-05-26 17:25:45.000000000","message":"maybe we can put this in a block with a rescue[0] to avoid the use of ignore_errors?\n\n[0] https://docs.ansible.com/ansible/latest/user_guide/playbooks_blocks.html#handling-errors-with-blocks","commit_id":"eb45f8d6ec38bd45e1289a1d2e118997d54b2647"},{"author":{"_account_id":32968,"name":"Juan Larriba","email":"jlarriba@redhat.com","username":"jlarriba"},"change_message_id":"20b047d69f98d2ae098a16b746d171172753bd35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"94df0aa1_f8759f74","line":52,"range":{"start_line":35,"start_character":0,"end_line":52,"end_character":0},"in_reply_to":"0e08bf1a_35821ab8","updated":"2021-05-27 10:00:16.000000000","message":"I have replaced it with failed_when: false, to be consistent with the rest of the playbook. UI dont think that rescue is worth here, as if this task is not able to execute, we do not want to do anything else: we are perfectly fine with it failing.\n\nfailed_when: false will remove the big red failing messages that could scare the user for an action where a fail is not an issue.","commit_id":"eb45f8d6ec38bd45e1289a1d2e118997d54b2647"}]}