)]}'
{"tripleo_ansible/roles/tripleo_kernel/tasks/kernelargs.yml":[{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"3dd1d8b623695149b872345d5cbe970ef5d80c04","unresolved":true,"context_lines":[{"line_number":41,"context_line":"        - name: Setting defer reboot fact"},{"line_number":42,"context_line":"          set_fact:"},{"line_number":43,"context_line":"            tripleo_kernel_defer_reboot: true"},{"line_number":44,"context_line":"            tripleo_kernel_reboot_protection: true"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- name: Check if the kernelargs entry is already present in the file"},{"line_number":47,"context_line":"  replace:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0878eab9_8a5e30bd","line":44,"range":{"start_line":44,"start_character":12,"end_line":44,"end_character":44},"updated":"2021-08-10 04:16:47.000000000","message":"is this internal variable or used from THT?","commit_id":"39a809f9e735f01865b6e134e5cf1f11ba2c34d8"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"62e2d6ed9a6477a47e5a592bbaa820ce8fc1b1a9","unresolved":true,"context_lines":[{"line_number":41,"context_line":"        - name: Setting defer reboot fact"},{"line_number":42,"context_line":"          set_fact:"},{"line_number":43,"context_line":"            tripleo_kernel_defer_reboot: true"},{"line_number":44,"context_line":"            tripleo_kernel_reboot_protection: true"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- name: Check if the kernelargs entry is already present in the file"},{"line_number":47,"context_line":"  replace:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c4b91b03_855716a0","line":44,"range":{"start_line":44,"start_character":12,"end_line":44,"end_character":44},"in_reply_to":"0878eab9_8a5e30bd","updated":"2021-08-10 05:11:01.000000000","message":"This is internal only.","commit_id":"39a809f9e735f01865b6e134e5cf1f11ba2c34d8"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"27ca1a6a1e9966c8c0810f43f786c41ce8ae2f67","unresolved":true,"context_lines":[{"line_number":41,"context_line":"        - name: Setting defer reboot fact"},{"line_number":42,"context_line":"          set_fact:"},{"line_number":43,"context_line":"            tripleo_kernel_defer_reboot: true"},{"line_number":44,"context_line":"            tripleo_kernel_reboot_protection: true"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- name: Check if the kernelargs entry is already present in the file"},{"line_number":47,"context_line":"  replace:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"29a44237_441779cf","line":44,"range":{"start_line":44,"start_character":12,"end_line":44,"end_character":44},"in_reply_to":"c4b91b03_855716a0","updated":"2021-08-10 05:22:18.000000000","message":"I suggest to rename it without \"tripleo_kernel\" to signify that it is internal variable and remove above line (tripleo_kernel_defer_reboot), as by looking at the code, it is not clear why 2 variables set at same place and checked at same place.","commit_id":"39a809f9e735f01865b6e134e5cf1f11ba2c34d8"}]}