)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"effa9f2e3fae9809473b7d50376aa586957da359","unresolved":true,"context_lines":[{"line_number":17,"context_line":"process is not recommended by systemd man pages."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Increase the grace stop timeout defaults 10-\u003e42s to align it with:"},{"line_number":20,"context_line":"https://github.com/containers/podman/pull/8889"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Closes-bug: #1945791"},{"line_number":23,"context_line":"Change-Id: Iefe861f91cefe2a9cf773cae98b2440566ae8b5e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"349f9fed_d90e5243","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":46},"updated":"2021-10-06 04:05:09.000000000","message":"In this PR it\u0027s 60:\n\nconst minTimeoutStopSec \u003d 60","commit_id":"8ea8243971c1eea2a814be2e057e269a8d8fa65e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e069c33b2653b76a5b62ea794599f851d2dfbf43","unresolved":true,"context_lines":[{"line_number":17,"context_line":"process is not recommended by systemd man pages."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Increase the grace stop timeout defaults 10-\u003e42s to align it with:"},{"line_number":20,"context_line":"https://github.com/containers/podman/pull/8889"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Closes-bug: #1945791"},{"line_number":23,"context_line":"Change-Id: Iefe861f91cefe2a9cf773cae98b2440566ae8b5e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"ba3c3001_96f33681","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":46},"in_reply_to":"349f9fed_d90e5243","updated":"2021-10-06 11:39:40.000000000","message":"yes, but 60 looked too much to me... I don\u0027t mind to update that, if you think we should.","commit_id":"8ea8243971c1eea2a814be2e057e269a8d8fa65e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e5afa316c384e04dd84845efb7e75d1ca5644d08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"5886ca17_7878dbae","updated":"2021-10-11 10:07:40.000000000","message":"So I think it is good to go now?","commit_id":"8ea8243971c1eea2a814be2e057e269a8d8fa65e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"929e06a96c42721afdb8e818306d82abb9abb155","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"6421e7cf_ac906d9b","updated":"2021-10-13 08:27:54.000000000","message":"shall we merge please","commit_id":"8ea8243971c1eea2a814be2e057e269a8d8fa65e"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"7c0dde39ff97f93455c0892183a7ecd4a125799c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"eb214dde_287cc866","updated":"2021-10-13 11:41:14.000000000","message":"Continue in https://review.opendev.org/c/openstack/tripleo-ansible/+/813800/","commit_id":"badd5a3c10f0af9e1c69a9b88064e743a36d4f53"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"13e742b966e5f0d69280f99c7767512e99e2fcc9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"ba9ab1a6_4656a0e8","updated":"2021-10-14 08:53:27.000000000","message":"recheck","commit_id":"badd5a3c10f0af9e1c69a9b88064e743a36d4f53"}],"tripleo_ansible/roles/tripleo_container_manage/templates/systemd-service.j2":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7c841f89e26e238fc91b880565c32cb30f511f2d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"ExecStop\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(10) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":19,"context_line":"ExecStopPost\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(10) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":20,"context_line":"SuccessExitStatus\u003d137 142 143"},{"line_number":21,"context_line":"KillMode\u003dcontrol-group"},{"line_number":22,"context_line":"TimeoutStopSec\u003d{{ 1+lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(10) | int }}"},{"line_number":23,"context_line":"Type\u003dforking"},{"line_number":24,"context_line":"PIDFile\u003d/var/run/{{ lookup(\u0027dict\u0027, container_data_unit).key }}.pid"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"24cbe948_324326fa","line":21,"updated":"2021-09-02 16:42:56.000000000","message":"I want to say there were bugs around killmode so i\u0027m a bit concerned about switching this with a specific bug.","commit_id":"5135957c56cafc30534866e2c3498dda25ca079f"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7c841f89e26e238fc91b880565c32cb30f511f2d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"ExecStopPost\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(10) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":20,"context_line":"SuccessExitStatus\u003d137 142 143"},{"line_number":21,"context_line":"KillMode\u003dcontrol-group"},{"line_number":22,"context_line":"TimeoutStopSec\u003d{{ 1+lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(10) | int }}"},{"line_number":23,"context_line":"Type\u003dforking"},{"line_number":24,"context_line":"PIDFile\u003d/var/run/{{ lookup(\u0027dict\u0027, container_data_unit).key }}.pid"},{"line_number":25,"context_line":"{% if lookup(\u0027dict\u0027, container_data_unit).value.systemd_exec_flags is defined %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"08f3a0f0_666e7d4f","line":22,"updated":"2021-09-02 16:42:56.000000000","message":"why the 1+?","commit_id":"5135957c56cafc30534866e2c3498dda25ca079f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"5bfcac3890fcef74b0cea7bb4d3286d73621eaaa","unresolved":false,"context_lines":[{"line_number":19,"context_line":"ExecStopPost\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(10) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":20,"context_line":"SuccessExitStatus\u003d137 142 143"},{"line_number":21,"context_line":"KillMode\u003dcontrol-group"},{"line_number":22,"context_line":"TimeoutStopSec\u003d{{ 1+lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(10) | int }}"},{"line_number":23,"context_line":"Type\u003dforking"},{"line_number":24,"context_line":"PIDFile\u003d/var/run/{{ lookup(\u0027dict\u0027, container_data_unit).key }}.pid"},{"line_number":25,"context_line":"{% if lookup(\u0027dict\u0027, container_data_unit).value.systemd_exec_flags is defined %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"a5f5fdf4_ad354734","line":22,"in_reply_to":"08f3a0f0_666e7d4f","updated":"2021-09-06 14:24:19.000000000","message":"to wait a X+1 second longer after/if podman -t timeouts after X seconds. I don\u0027t think waiting more would make sense, since the hanged podman -t means that some processes in the cgroup hasn\u0027t responded in time, and we could process with the wanted killmode actions","commit_id":"5135957c56cafc30534866e2c3498dda25ca079f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"ae2e3084a3768d3e2e2bd7eea9fdec39b6dcd656","unresolved":false,"context_lines":[{"line_number":19,"context_line":"ExecStopPost\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(10) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":20,"context_line":"SuccessExitStatus\u003d137 142 143"},{"line_number":21,"context_line":"KillMode\u003dcontrol-group"},{"line_number":22,"context_line":"TimeoutStopSec\u003d{{ 1+lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(10) | int }}"},{"line_number":23,"context_line":"Type\u003dforking"},{"line_number":24,"context_line":"PIDFile\u003d/var/run/{{ lookup(\u0027dict\u0027, container_data_unit).key }}.pid"},{"line_number":25,"context_line":"{% if lookup(\u0027dict\u0027, container_data_unit).value.systemd_exec_flags is defined %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"e48633e2_cd69c4bf","line":22,"in_reply_to":"a5f5fdf4_ad354734","updated":"2021-09-06 14:25:36.000000000","message":"...while giving it less time than X would instead interfere the podman -t logic","commit_id":"5135957c56cafc30534866e2c3498dda25ca079f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"b6cc8e950d1fabef4119c0c3e4664881d067ab2f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"ExecStopPost\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(10) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":20,"context_line":"SuccessExitStatus\u003d137 142 143"},{"line_number":21,"context_line":"KillMode\u003dcontrol-group"},{"line_number":22,"context_line":"TimeoutStopSec\u003d{{ 1+lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(10) | int }}"},{"line_number":23,"context_line":"Type\u003dforking"},{"line_number":24,"context_line":"PIDFile\u003d/var/run/{{ lookup(\u0027dict\u0027, container_data_unit).key }}.pid"},{"line_number":25,"context_line":"{% if lookup(\u0027dict\u0027, container_data_unit).value.systemd_exec_flags is defined %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"c1ea810a_0956e265","line":22,"in_reply_to":"e48633e2_cd69c4bf","updated":"2021-09-06 14:37:30.000000000","message":"ofc I can give it more time to hang around in a half-dead state, if you insist :)","commit_id":"5135957c56cafc30534866e2c3498dda25ca079f"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"2ae971c7a4bac3cd49c7d8900baae6b677215d82","unresolved":true,"context_lines":[{"line_number":15,"context_line":"{% if lookup(\u0027dict\u0027, container_data_unit).value.pre_stop_exec is defined %}"},{"line_number":16,"context_line":"ExecStop\u003d-/usr/bin/podman exec {{ lookup(\u0027dict\u0027, container_data_unit).key }} {{ lookup(\u0027dict\u0027, container_data_unit).value.pre_stop_exec }}"},{"line_number":17,"context_line":"{% endif %}"},{"line_number":18,"context_line":"{% if not restart_preferred | default(false) %}"},{"line_number":19,"context_line":"ExecStop\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(10) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":20,"context_line":"ExecStopPost\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(10) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":21,"context_line":"SuccessExitStatus\u003d137 142 143"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"ed5c2238_226d602e","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":47},"updated":"2021-10-03 06:00:13.000000000","message":"Should we just keep the else part of the if?","commit_id":"2bc7a521b3305ed19ad746aeef4cacba298c8621"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"789369fe57540c3f7ab2e75149760a7e604ec8bb","unresolved":true,"context_lines":[{"line_number":15,"context_line":"{% if lookup(\u0027dict\u0027, container_data_unit).value.pre_stop_exec is defined %}"},{"line_number":16,"context_line":"ExecStop\u003d-/usr/bin/podman exec {{ lookup(\u0027dict\u0027, container_data_unit).key }} {{ lookup(\u0027dict\u0027, container_data_unit).value.pre_stop_exec }}"},{"line_number":17,"context_line":"{% endif %}"},{"line_number":18,"context_line":"{% if not restart_preferred | default(false) %}"},{"line_number":19,"context_line":"ExecStop\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(10) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":20,"context_line":"ExecStopPost\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(10) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":21,"context_line":"SuccessExitStatus\u003d137 142 143"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"a334aa1a_98ccde91","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":47},"in_reply_to":"b4ae03be_a087fb6a","updated":"2021-10-05 08:35:14.000000000","message":"How/why/where? The only upgrade issue mentioned is the one we fixed by hardcoding the runtime no? I think the same comment as Alex in https://review.opendev.org/c/openstack/tripleo-heat-templates/+/811892 applies here? I.e. during FFu the mass restart happens anyways and during minor update we shutdown all containers and do a node per node update\n\nJust as an additional test I only pushed the else bit in https://review.opendev.org/c/openstack/tripleo-ansible/+/812288 and it works fine in CI","commit_id":"2bc7a521b3305ed19ad746aeef4cacba298c8621"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f1cb1723ed3e0069f063b49328da58134734ca36","unresolved":true,"context_lines":[{"line_number":15,"context_line":"{% if lookup(\u0027dict\u0027, container_data_unit).value.pre_stop_exec is defined %}"},{"line_number":16,"context_line":"ExecStop\u003d-/usr/bin/podman exec {{ lookup(\u0027dict\u0027, container_data_unit).key }} {{ lookup(\u0027dict\u0027, container_data_unit).value.pre_stop_exec }}"},{"line_number":17,"context_line":"{% endif %}"},{"line_number":18,"context_line":"{% if not restart_preferred | default(false) %}"},{"line_number":19,"context_line":"ExecStop\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(10) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":20,"context_line":"ExecStopPost\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(10) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":21,"context_line":"SuccessExitStatus\u003d137 142 143"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"b4ae03be_a087fb6a","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":47},"in_reply_to":"ed5c2238_226d602e","updated":"2021-10-04 07:59:35.000000000","message":"we cannot as this causes upgrade impact as described in the underlying issue.","commit_id":"2bc7a521b3305ed19ad746aeef4cacba298c8621"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"2ae971c7a4bac3cd49c7d8900baae6b677215d82","unresolved":true,"context_lines":[{"line_number":25,"context_line":"ExecStopPost\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":26,"context_line":"SuccessExitStatus\u003d137 142 143"},{"line_number":27,"context_line":"TimeoutStopSec\u003d{{ 2*lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }}"},{"line_number":28,"context_line":"{% end %}"},{"line_number":29,"context_line":"Type\u003dforking"},{"line_number":30,"context_line":"PIDFile\u003d/var/run/{{ lookup(\u0027dict\u0027, container_data_unit).key }}.pid"},{"line_number":31,"context_line":"{% if lookup(\u0027dict\u0027, container_data_unit).value.systemd_exec_flags is defined %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"20961509_50a8be9b","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":9},"updated":"2021-10-03 06:00:13.000000000","message":"endif","commit_id":"2bc7a521b3305ed19ad746aeef4cacba298c8621"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"9c7c6b46900447c7223f7c3bd21e556afbb25ce5","unresolved":true,"context_lines":[{"line_number":16,"context_line":"ExecStop\u003d-/usr/bin/podman exec {{ lookup(\u0027dict\u0027, container_data_unit).key }} {{ lookup(\u0027dict\u0027, container_data_unit).value.pre_stop_exec }}"},{"line_number":17,"context_line":"{% endif %}"},{"line_number":18,"context_line":"ExecStop\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":19,"context_line":"ExecStopPost\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":20,"context_line":"SuccessExitStatus\u003d137 142 143"},{"line_number":21,"context_line":"TimeoutStopSec\u003d{{ 2*lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }}"},{"line_number":22,"context_line":"Type\u003dforking"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"0afdd09f_9a7c11c5","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":168},"updated":"2021-10-05 15:13:48.000000000","message":"So why do we need now ExecStopPost? If it doesn\u0027t make sense to run \"stop\" twice and TimeoutStopSec will handle the timeout.","commit_id":"8ea8243971c1eea2a814be2e057e269a8d8fa65e"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"a7c9edbd52e042167a400797c33754003dcbbd4c","unresolved":true,"context_lines":[{"line_number":16,"context_line":"ExecStop\u003d-/usr/bin/podman exec {{ lookup(\u0027dict\u0027, container_data_unit).key }} {{ lookup(\u0027dict\u0027, container_data_unit).value.pre_stop_exec }}"},{"line_number":17,"context_line":"{% endif %}"},{"line_number":18,"context_line":"ExecStop\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":19,"context_line":"ExecStopPost\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":20,"context_line":"SuccessExitStatus\u003d137 142 143"},{"line_number":21,"context_line":"TimeoutStopSec\u003d{{ 2*lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }}"},{"line_number":22,"context_line":"Type\u003dforking"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"74265839_6d1c9986","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":168},"in_reply_to":"0afdd09f_9a7c11c5","updated":"2021-10-05 20:39:21.000000000","message":"Why change the default to 42?","commit_id":"8ea8243971c1eea2a814be2e057e269a8d8fa65e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"8ab43ec0cfadbde3230e11bb16d930b936eb5374","unresolved":true,"context_lines":[{"line_number":16,"context_line":"ExecStop\u003d-/usr/bin/podman exec {{ lookup(\u0027dict\u0027, container_data_unit).key }} {{ lookup(\u0027dict\u0027, container_data_unit).value.pre_stop_exec }}"},{"line_number":17,"context_line":"{% endif %}"},{"line_number":18,"context_line":"ExecStop\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":19,"context_line":"ExecStopPost\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":20,"context_line":"SuccessExitStatus\u003d137 142 143"},{"line_number":21,"context_line":"TimeoutStopSec\u003d{{ 2*lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }}"},{"line_number":22,"context_line":"Type\u003dforking"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"2acc8c55_cdd5d545","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":168},"in_reply_to":"0e1b24de_062ed6ea","updated":"2021-10-06 08:05:52.000000000","message":"Alex asked to increase the default timeout, see the earlier comments","commit_id":"8ea8243971c1eea2a814be2e057e269a8d8fa65e"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"43e867f95e1a57b65b9e7c6fe030e4c2b4602a89","unresolved":true,"context_lines":[{"line_number":16,"context_line":"ExecStop\u003d-/usr/bin/podman exec {{ lookup(\u0027dict\u0027, container_data_unit).key }} {{ lookup(\u0027dict\u0027, container_data_unit).value.pre_stop_exec }}"},{"line_number":17,"context_line":"{% endif %}"},{"line_number":18,"context_line":"ExecStop\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":19,"context_line":"ExecStopPost\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":20,"context_line":"SuccessExitStatus\u003d137 142 143"},{"line_number":21,"context_line":"TimeoutStopSec\u003d{{ 2*lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }}"},{"line_number":22,"context_line":"Type\u003dforking"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"f0bb74b1_ebd3852c","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":168},"in_reply_to":"1f67f67f_4f0c4a1d","updated":"2021-10-13 11:28:59.000000000","message":"I\u0027ll create removing exec post in other patch.","commit_id":"8ea8243971c1eea2a814be2e057e269a8d8fa65e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c7e8daca551820f23c6dfe08dcacff825cba9eea","unresolved":true,"context_lines":[{"line_number":16,"context_line":"ExecStop\u003d-/usr/bin/podman exec {{ lookup(\u0027dict\u0027, container_data_unit).key }} {{ lookup(\u0027dict\u0027, container_data_unit).value.pre_stop_exec }}"},{"line_number":17,"context_line":"{% endif %}"},{"line_number":18,"context_line":"ExecStop\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":19,"context_line":"ExecStopPost\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":20,"context_line":"SuccessExitStatus\u003d137 142 143"},{"line_number":21,"context_line":"TimeoutStopSec\u003d{{ 2*lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }}"},{"line_number":22,"context_line":"Type\u003dforking"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"9e552f3f_f480daf5","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":168},"in_reply_to":"2acc8c55_cdd5d545","updated":"2021-10-06 08:07:18.000000000","message":"@Sagi, that\u0027s a reasonable question, but it is unrelated to the patch scope. Please fill another bug if you propose to work into that direction as well","commit_id":"8ea8243971c1eea2a814be2e057e269a8d8fa65e"},{"author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"change_message_id":"627514d640ca12c1a9f9916ebdbe09830a5126f1","unresolved":true,"context_lines":[{"line_number":16,"context_line":"ExecStop\u003d-/usr/bin/podman exec {{ lookup(\u0027dict\u0027, container_data_unit).key }} {{ lookup(\u0027dict\u0027, container_data_unit).value.pre_stop_exec }}"},{"line_number":17,"context_line":"{% endif %}"},{"line_number":18,"context_line":"ExecStop\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":19,"context_line":"ExecStopPost\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":20,"context_line":"SuccessExitStatus\u003d137 142 143"},{"line_number":21,"context_line":"TimeoutStopSec\u003d{{ 2*lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }}"},{"line_number":22,"context_line":"Type\u003dforking"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"7e80f34a_27546b39","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":168},"in_reply_to":"46e2ae21_972b4928","updated":"2021-10-06 10:31:46.000000000","message":"I think the only thing not entirely clear is why 42. The linked podman PR uses 60 for some minTimeoutStopSec (whatever that really means I have not checked), some tests then change a timeout from 10 to 22, some from 42 to 10 and some from 10 to 42. The rest of the patch seems sane","commit_id":"8ea8243971c1eea2a814be2e057e269a8d8fa65e"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"aa164c27506b6fbc2c9fbcb38b5ee3f5a024c788","unresolved":true,"context_lines":[{"line_number":16,"context_line":"ExecStop\u003d-/usr/bin/podman exec {{ lookup(\u0027dict\u0027, container_data_unit).key }} {{ lookup(\u0027dict\u0027, container_data_unit).value.pre_stop_exec }}"},{"line_number":17,"context_line":"{% endif %}"},{"line_number":18,"context_line":"ExecStop\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":19,"context_line":"ExecStopPost\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":20,"context_line":"SuccessExitStatus\u003d137 142 143"},{"line_number":21,"context_line":"TimeoutStopSec\u003d{{ 2*lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }}"},{"line_number":22,"context_line":"Type\u003dforking"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"0e1b24de_062ed6ea","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":168},"in_reply_to":"74265839_6d1c9986","updated":"2021-10-05 20:41:12.000000000","message":"looks like its being changed to 10 and 42 in the linked review. While I too believe 42 is the ultimate answer, I don\u0027t think this needs to be changed.","commit_id":"8ea8243971c1eea2a814be2e057e269a8d8fa65e"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"c1e3f962f84b0eee5dcd673428ae8fa2501633a0","unresolved":true,"context_lines":[{"line_number":16,"context_line":"ExecStop\u003d-/usr/bin/podman exec {{ lookup(\u0027dict\u0027, container_data_unit).key }} {{ lookup(\u0027dict\u0027, container_data_unit).value.pre_stop_exec }}"},{"line_number":17,"context_line":"{% endif %}"},{"line_number":18,"context_line":"ExecStop\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":19,"context_line":"ExecStopPost\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":20,"context_line":"SuccessExitStatus\u003d137 142 143"},{"line_number":21,"context_line":"TimeoutStopSec\u003d{{ 2*lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }}"},{"line_number":22,"context_line":"Type\u003dforking"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"bd41736b_b53e9027","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":168},"in_reply_to":"7e80f34a_27546b39","updated":"2021-10-06 12:11:31.000000000","message":"@Bogdan, yeah, actually my question is more to Podman folks that left this setting in systemd file, nevermind.","commit_id":"8ea8243971c1eea2a814be2e057e269a8d8fa65e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"883231360f7597b342d2087cfccf6b10262e1da4","unresolved":true,"context_lines":[{"line_number":16,"context_line":"ExecStop\u003d-/usr/bin/podman exec {{ lookup(\u0027dict\u0027, container_data_unit).key }} {{ lookup(\u0027dict\u0027, container_data_unit).value.pre_stop_exec }}"},{"line_number":17,"context_line":"{% endif %}"},{"line_number":18,"context_line":"ExecStop\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":19,"context_line":"ExecStopPost\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":20,"context_line":"SuccessExitStatus\u003d137 142 143"},{"line_number":21,"context_line":"TimeoutStopSec\u003d{{ 2*lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }}"},{"line_number":22,"context_line":"Type\u003dforking"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"46e2ae21_972b4928","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":168},"in_reply_to":"9e552f3f_f480daf5","updated":"2021-10-06 08:09:03.000000000","message":"@Sagi, @Kevin, please also see https://github.com/containers/podman/pull/8889/files with which it is being aligned by the Alex\u0027s request","commit_id":"8ea8243971c1eea2a814be2e057e269a8d8fa65e"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"2bb1a1abb19630dcba2e652a531a509b24fdea86","unresolved":true,"context_lines":[{"line_number":16,"context_line":"ExecStop\u003d-/usr/bin/podman exec {{ lookup(\u0027dict\u0027, container_data_unit).key }} {{ lookup(\u0027dict\u0027, container_data_unit).value.pre_stop_exec }}"},{"line_number":17,"context_line":"{% endif %}"},{"line_number":18,"context_line":"ExecStop\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":19,"context_line":"ExecStopPost\u003d/usr/bin/podman stop -t {{ lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }} {{ lookup(\u0027dict\u0027, container_data_unit).key }}"},{"line_number":20,"context_line":"SuccessExitStatus\u003d137 142 143"},{"line_number":21,"context_line":"TimeoutStopSec\u003d{{ 2*lookup(\u0027dict\u0027, container_data_unit).value.stop_grace_period | default(42) | int }}"},{"line_number":22,"context_line":"Type\u003dforking"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"1f67f67f_4f0c4a1d","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":168},"in_reply_to":"bd41736b_b53e9027","updated":"2021-10-13 11:26:09.000000000","message":"Ok, after a talk with podman guys, I think TimeoutStopSec should be larger than ExecStop + ExecStopPost timeouts. And TBH ExecStopPost looks like redundant here if we have TimeoutStopSec.\n\n\u003csshnaidm\u003e vrothberg, sorry, I\u0027m trying to picture the case if container is stuck, if execstop failed to stop it in its timeout. Will execpost conflict with TimeoutStopSec here?\n\u003cvrothberg\u003e sshnaidm: there is a theoretical conflict/race. That is why Podman adds 60 seconds to the specified time out.  That should give the container and Podman largely enough time to clean up before systemd would hypothetically nuke everything.\n\u003cvrothberg\u003e sshnaidm: the custom TimeoutStopSec is intended to prevent a race/conflict.\n\u003cvrothberg\u003e I think by default it\u0027s also 10 seconds, and hence the same as Podman, so we needed to bump it up.\n\u003csshnaidm\u003e vrothberg, ack, so if I got it right - if container is stuck, execstop is trying to stop it, if can\u0027t - exec-post-stop is trying to rm -f it, and then after a timeout systemd is trying to erase everything there. Is it correct?\n\u003cvrothberg\u003e sshnaidm: if `podman stop` hits the timeout, the container will get killed. Then `podman rm -f` will remove it and clean up. Systemd will only nuke if the previous steps take more than $timeout + 60 secs","commit_id":"8ea8243971c1eea2a814be2e057e269a8d8fa65e"}]}