)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"fa56ee706c4b73537f1ebfec3ed40a7048bf6dce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"659e39d3_79f42761","updated":"2021-11-11 11:41:32.000000000","message":"failing in some other jobs:\n\n Check all networks Gateway availability | undercloud | item\u003d192.168.24.1 | error\u003d{\"ansible_loop_var\": \"gateway_ip\", \"changed\": false, \"cmd\": [\"ping\", \"-w\", \"10\", \"-c\", \"1\", \"1\"], \"delta\": \"0:00:00.004016\", \"end\": \"2021-11-11 03:16:01.351969\", \"gateway_ip\": \"192.168.24.1\", \"msg\": \"non-zero return code\", \"rc\": 2, \"start\": \"2021-11-11 03:16:01.347953\", \"stderr\": \"connect: Invalid argument\", \"stderr_lines\": [\"connect: Invalid argument\"], \"stdout\": \"\", \"stdout_lines\": []}\n\nSo sometimes it is a lists of lists, sometimes just a list?","commit_id":"4182c4fea746600c9d37f228cb71e5c9a11e040c"}],"tripleo_ansible/roles/tripleo_nodes_validation/tasks/main.yml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4bc78d2925bb8144400582589533083a1e68b04c","unresolved":true,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Ping test the gateway IPs before nodes, see RHBZ#1875962"},{"line_number":36,"context_line":"- name: Check all networks Gateway availability"},{"line_number":37,"context_line":"  command: \"{{ (\u0027:\u0027 in gateway_ip) | ternary(\u0027ping6\u0027, \u0027ping\u0027) }} -w 10 -c 1 {{ gateway_ip | first }}\""},{"line_number":38,"context_line":"  retries: 10"},{"line_number":39,"context_line":"  delay: 60"},{"line_number":40,"context_line":"  loop_control:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4205db60_f3794116","line":37,"updated":"2021-11-12 11:02:58.000000000","message":"so, please use flatten | first","commit_id":"4182c4fea746600c9d37f228cb71e5c9a11e040c"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"59ebfa01e74de48e350ebc9502a09526e3f7aac2","unresolved":true,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Ping test the gateway IPs before nodes, see RHBZ#1875962"},{"line_number":36,"context_line":"- name: Check all networks Gateway availability"},{"line_number":37,"context_line":"  command: \"{{ (\u0027:\u0027 in gateway_ip) | ternary(\u0027ping6\u0027, \u0027ping\u0027) }} -w 10 -c 1 {{ gateway_ip | first }}\""},{"line_number":38,"context_line":"  retries: 10"},{"line_number":39,"context_line":"  delay: 60"},{"line_number":40,"context_line":"  loop_control:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f18fe57_be168242","line":37,"in_reply_to":"413dacdd_2864ba57","updated":"2021-11-12 14:29:57.000000000","message":"After a 2nd thought on this, I believe we should flatten at this level:\nhttps://opendev.org/openstack/tripleo-heat-templates/src/branch/master/overcloud.j2.yaml#L1200","commit_id":"4182c4fea746600c9d37f228cb71e5c9a11e040c"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"90a82e00348f988c3c197a9c5d2d99a7b9577feb","unresolved":true,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Ping test the gateway IPs before nodes, see RHBZ#1875962"},{"line_number":36,"context_line":"- name: Check all networks Gateway availability"},{"line_number":37,"context_line":"  command: \"{{ (\u0027:\u0027 in gateway_ip) | ternary(\u0027ping6\u0027, \u0027ping\u0027) }} -w 10 -c 1 {{ gateway_ip | first }}\""},{"line_number":38,"context_line":"  retries: 10"},{"line_number":39,"context_line":"  delay: 60"},{"line_number":40,"context_line":"  loop_control:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d96e3415_3a0d70fa","line":37,"in_reply_to":"4205db60_f3794116","updated":"2021-11-12 11:33:02.000000000","message":"we can\u0027t use first here, since geteway_ip should be a string. but the flatten tip is a good one, I\u0027ve tested it here and works, but adding it to the loop in L42.\n\n`loop: \"{{ tripleo_nodes_validation_ping_test_gateway_ips | flatten }}\"`\n\nthanks","commit_id":"4182c4fea746600c9d37f228cb71e5c9a11e040c"},{"author":{"_account_id":27419,"name":"David Vallee Delisle","email":"me@dvd.dev","username":"dvd"},"change_message_id":"6dd8698e7895a62c81b30e4d4dbbbc996d65afd1","unresolved":true,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# Ping test the gateway IPs before nodes, see RHBZ#1875962"},{"line_number":36,"context_line":"- name: Check all networks Gateway availability"},{"line_number":37,"context_line":"  command: \"{{ (\u0027:\u0027 in gateway_ip) | ternary(\u0027ping6\u0027, \u0027ping\u0027) }} -w 10 -c 1 {{ gateway_ip | first }}\""},{"line_number":38,"context_line":"  retries: 10"},{"line_number":39,"context_line":"  delay: 60"},{"line_number":40,"context_line":"  loop_control:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"413dacdd_2864ba57","line":37,"in_reply_to":"d96e3415_3a0d70fa","updated":"2021-11-12 14:10:28.000000000","message":"my concern with having a solution like first and flatten is that I\u0027m still not sure what\u0027s causing the undercloud role to have a list of gateway as opposed to a single one on the overcloud. When I proposed this patch, I thought it would have been the same across all roles. I\u0027d be curious to root cause this before applying any kind of patch here.","commit_id":"4182c4fea746600c9d37f228cb71e5c9a11e040c"}]}
