)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"f1530cacc938b41d03d307040d10f94aa412f5be","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"testproject: https://review.rdoproject.org/r/c/testproject/+/31954"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I9962be176baafe0c3f7c78626d28466cba76b356"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"242c89ba_279e2910","line":15,"updated":"2021-12-06 11:45:15.000000000","message":"testproject https://review.opendev.org/c/openstack/tripleo-quickstart/+/812428 is green:-\nperiodic-tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset064-master https://review.rdoproject.org/zuul/build/66ff74cef5dd460aa05c1cb91c66e12a : SUCCESS in 3h 01m 06s\n\nDeployment command:-\n\nhttps://logserver.rdoproject.org/54/31954/18/check/periodic-tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset064-master/66ff74c/logs/undercloud/home/zuul/overcloud1-deploy.sh.txt.gz\n\n\nrole_data.yaml:-\nhttps://logserver.rdoproject.org/54/31954/18/check/periodic-tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset064-master/66ff74c/logs/undercloud/home/zuul/overcloud-deploy/overcloud1/tripleo-heat-templates/ci/custom_ci_roles_data.yaml.txt.gz\n\n\nnetwork_data.yaml:-\nhttps://logserver.rdoproject.org/54/31954/18/check/periodic-tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset064-master/66ff74c/logs/undercloud/home/zuul/overcloud-deploy/overcloud1/tripleo-heat-templates/ci/custom_names_network_data.yaml.txt.gz\n\nvip_data.yaml:-\nhttps://logserver.rdoproject.org/54/31954/18/check/periodic-tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset064-master/66ff74c/logs/undercloud/home/zuul/overcloud-deploy/overcloud1/tripleo-heat-templates/ci/custom_names_vip_data.yaml.txt.gz\n\n\novercloud-networks-deployed.yaml:-\nhttps://logserver.rdoproject.org/54/31954/18/check/periodic-tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset064-master/66ff74c/logs/undercloud/home/zuul/overcloud-networks-deployed.yaml.txt.gz\n\n\novercloud-vips-deployed.yaml:-\nhttps://logserver.rdoproject.org/54/31954/18/check/periodic-tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset064-master/66ff74c/logs/undercloud/home/zuul/overcloud-vips-deployed.yaml.txt.gz\n\n\n/etc/hosts from one of the controller node:-\nhttps://logserver.rdoproject.org/54/31954/18/check/periodic-tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset064-master/66ff74c/logs/overcloud1-controller-0/etc/hosts.txt.gz\n\n\nos-net-config/config.yaml from one of the controller node:-\nhttps://logserver.rdoproject.org/54/31954/18/check/periodic-tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset064-master/66ff74c/logs/overcloud1-controller-0/etc/os-net-config/config.yaml.txt.gz","commit_id":"6ad9543a2916781270caa2d987c0b1ee1c027072"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"601ad98fb3b2adda54b1221fda7c4af57ac538b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"01108f20_3e71363f","updated":"2021-12-06 11:45:23.000000000","message":"check-rdo","commit_id":"6ad9543a2916781270caa2d987c0b1ee1c027072"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"99f7803398c09aba5fe6e4d25bb39aba4789a46b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e6e97903_47c3720e","updated":"2021-12-02 15:06:12.000000000","message":"recheck","commit_id":"6ad9543a2916781270caa2d987c0b1ee1c027072"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"ac9fcd283f69c0c56ec0e0e52e485ed9bcb18b4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5717f1f1_fd009842","updated":"2021-12-07 05:32:32.000000000","message":"recheck","commit_id":"50c04c2393b39d82de63110c824e882580c0d256"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"7c4d9091db01795a2f9d57437fea2bad0680cdfc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0aca4818_fd38e82f","updated":"2021-12-07 07:26:35.000000000","message":"-W for testing.","commit_id":"f2e7d5aa5bc6c8550975c0ffded388827d440836"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"7655c88bba63c3a9d47e36f2875e73232130ca45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d6e796ff_d32a9157","updated":"2021-12-07 18:01:38.000000000","message":"check-rdo","commit_id":"951a3070200ffd79827e488de7488d10bfd77a12"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"091946c3314af9cebf483c626c2147284b59d3d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8daeec00_f8b492c9","updated":"2021-12-08 11:20:28.000000000","message":"https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_31d/818529/5/gate/openstack-tox-py38/31dba4a/job-output.txt\n Downloading https://galaxy.ansible.com/download/community-crypto-2.0.1.tar.gz to /home/zuul/.ansible/tmp/ansible-local-18433mkv18ki/tmpc8kbfte8/community-crypto-2.0.1-2hznws2x\n2021-12-08 07:01:53.589745 | ubuntu-focal | ERROR! Unexpected Exception, this is probably a bug: The read operation timed out\n2021-12-08 07:01:53.589889 | ubuntu-focal | to see the full traceback, use -vvv\n\nrecheck","commit_id":"951a3070200ffd79827e488de7488d10bfd77a12"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"4b1f2f17329212d040ed3876c37a297a1b0ec27a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f1c2b7a4_c065e65d","updated":"2021-12-08 11:30:11.000000000","message":"recheck","commit_id":"951a3070200ffd79827e488de7488d10bfd77a12"}],"tripleo_ansible/roles/tripleo_network_config/templates/ci/custom_network_multiple_nics.j2":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"2a8981e1803ea304e61a5a21ec85fb5ae4cb6073","unresolved":true,"context_lines":[{"line_number":15,"context_line":"  dns_servers: {{ ctlplane_dns_nameservers }}"},{"line_number":16,"context_line":"  domain: {{ dns_search_domains }}"},{"line_number":17,"context_line":"  use_dhcp: false"},{"line_number":18,"context_line":"  routes:"},{"line_number":19,"context_line":"  - ip_netmask: 0.0.0.0/0"},{"line_number":20,"context_line":"    next_hop: {{ external_cloud_1_gateway_ip | default(\u002710.0.0.1\u0027) }}"},{"line_number":21,"context_line":"  members:"},{"line_number":22,"context_line":"  - type: interface"},{"line_number":23,"context_line":"    name: nic2"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"aaf7b265_f143c20b","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":68},"updated":"2021-12-06 13:37:12.000000000","message":"A route for 0.0.0.0/0 is a default route, the ctlplane_gateway was set as the default route above L9-L11. There should be only one default route.\n\nIf you want to use ExternalCloud1 for default route when it is available, move the route into the condition where the addresss are on L27. Also add a inverted condition around the routes on the ctlplane interface, to ensure we get either not both.","commit_id":"6ad9543a2916781270caa2d987c0b1ee1c027072"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"2430f86c4e1cb353602be1eb5dd91c2cb99013b7","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  dns_servers: {{ ctlplane_dns_nameservers }}"},{"line_number":16,"context_line":"  domain: {{ dns_search_domains }}"},{"line_number":17,"context_line":"  use_dhcp: false"},{"line_number":18,"context_line":"  routes:"},{"line_number":19,"context_line":"  - ip_netmask: 0.0.0.0/0"},{"line_number":20,"context_line":"    next_hop: {{ external_cloud_1_gateway_ip | default(\u002710.0.0.1\u0027) }}"},{"line_number":21,"context_line":"  members:"},{"line_number":22,"context_line":"  - type: interface"},{"line_number":23,"context_line":"    name: nic2"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"8f3eed68_de6acf1e","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":68},"in_reply_to":"3af2bb33_b1e56f75","updated":"2021-12-06 15:01:43.000000000","message":"For CI use case I don\u0027t think we need route on external network(Someone please correct me if this was added on purpose)\n\nRemoving route from external network, will propose a separate patch to fix existing template[1] \n\n[1]\nhttps://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo_network_config/templates/ci/multiple_nics.j2#L9-L20","commit_id":"6ad9543a2916781270caa2d987c0b1ee1c027072"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"20d7e20e10dde2830bcd19e48fa471914be4dc1d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  dns_servers: {{ ctlplane_dns_nameservers }}"},{"line_number":16,"context_line":"  domain: {{ dns_search_domains }}"},{"line_number":17,"context_line":"  use_dhcp: false"},{"line_number":18,"context_line":"  routes:"},{"line_number":19,"context_line":"  - ip_netmask: 0.0.0.0/0"},{"line_number":20,"context_line":"    next_hop: {{ external_cloud_1_gateway_ip | default(\u002710.0.0.1\u0027) }}"},{"line_number":21,"context_line":"  members:"},{"line_number":22,"context_line":"  - type: interface"},{"line_number":23,"context_line":"    name: nic2"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"507718b8_dca8b332","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":68},"in_reply_to":"4daa978c_b915bf57","updated":"2021-12-07 06:08:47.000000000","message":"Some roles[1] had both with the default route on external network overriding the ctlplane one. Don\u0027t know if it\u0027s ok to not have default route in external for some roles or not. We do have parameters for it[2] and I see it being used in fs001 though[3].\n\ndefault via 10.0.0.1 dev br-ex  (controller)\ndefault via 192.168.24.1 dev ens3  (compute)\n\n[1] https://github.com/openstack/tripleo-heat-templates/blob/stable/train/ci/environments/network/multiple-nics/nic-configs/compute-dvr.yaml\n\n[2] https://github.com/openstack/tripleo-heat-templates/blob/master/ci/environments/network/multiple-nics/network-environment.yaml#L10\n\n[3] https://logserver.rdoproject.org/29/818529/3/openstack-check/tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset001/ff2a816/logs/overcloud-controller-0/var/log/extra/network.txt.gz","commit_id":"6ad9543a2916781270caa2d987c0b1ee1c027072"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"af2ef38d25c983213a7998a13848314151ed9864","unresolved":true,"context_lines":[{"line_number":15,"context_line":"  dns_servers: {{ ctlplane_dns_nameservers }}"},{"line_number":16,"context_line":"  domain: {{ dns_search_domains }}"},{"line_number":17,"context_line":"  use_dhcp: false"},{"line_number":18,"context_line":"  routes:"},{"line_number":19,"context_line":"  - ip_netmask: 0.0.0.0/0"},{"line_number":20,"context_line":"    next_hop: {{ external_cloud_1_gateway_ip | default(\u002710.0.0.1\u0027) }}"},{"line_number":21,"context_line":"  members:"},{"line_number":22,"context_line":"  - type: interface"},{"line_number":23,"context_line":"    name: nic2"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"640664f5_4d2008a0","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":68},"in_reply_to":"507718b8_dca8b332","updated":"2021-12-07 07:16:57.000000000","message":"Thank you Rabi/Harald\n\nI have tested fs001 here https://review.opendev.org/c/openstack/tripleo-ansible/+/820538/ it works even without the default route on the external network, but I haven\u0027t tested other featureset(fs002,fs020,fs35,fs039) which use the same template yet.\n\nhttps://logserver.rdoproject.org/38/820538/1/openstack-check/tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset001/151e759/logs/overcloud-controller-0/var/log/extra/network.txt.gz\n~~~\ndefault via 192.168.24.1 dev ens3 \n~~~\n\nI am not sure why ExternalInterfaceDefaultRoute was added in the first place, thinking of a logical explanation because maybe we wanted to keep the ci testing close to real deployment. As generally on real deployments(customer use case) as we keep controller default routes on External (for Public OpenStack APIs, Horizon dashboard). \n\nI think Harald earlier suggestion makes more sense.\n~~~\nIf you want to use ExternalCloud1 for default route when it is available, move the route into the condition where the addresss are on L27. Also add a inverted condition around the routes on the ctlplane interface, to ensure we get either not both.\n~~~\n\nI will test that out. -W to test that.","commit_id":"6ad9543a2916781270caa2d987c0b1ee1c027072"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"a44afc3ef6f8dd3471dc96f51389c697513f9552","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  dns_servers: {{ ctlplane_dns_nameservers }}"},{"line_number":16,"context_line":"  domain: {{ dns_search_domains }}"},{"line_number":17,"context_line":"  use_dhcp: false"},{"line_number":18,"context_line":"  routes:"},{"line_number":19,"context_line":"  - ip_netmask: 0.0.0.0/0"},{"line_number":20,"context_line":"    next_hop: {{ external_cloud_1_gateway_ip | default(\u002710.0.0.1\u0027) }}"},{"line_number":21,"context_line":"  members:"},{"line_number":22,"context_line":"  - type: interface"},{"line_number":23,"context_line":"    name: nic2"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"001e8d4b_70aa3c3f","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":68},"in_reply_to":"640664f5_4d2008a0","updated":"2021-12-07 18:01:27.000000000","message":"Testing results:\nhttps://review.rdoproject.org/r/c/testproject/+/31954\n\nlogs: \nperiodic-tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset064-master https://review.rdoproject.org/zuul/build/30074ad33ffe45db831562eacf055f16 : SUCCESS in 3h 04m 20s\n\n\nController:-\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\nhttps://logserver.rdoproject.org/54/31954/19/check/periodic-tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset064-master/30074ad/logs/overcloud1-controller-1/etc/os-net-config/config.yaml.txt.gz\n~~~\n---\nnetwork_config:\n- type: interface\n  name: nic1\n  mtu: 1350\n  use_dhcp: false\n  addresses:\n  - ip_netmask: 192.168.24.29/24\n- type: ovs_bridge\n  name: br-ex\n  dns_servers: [\u002710.0.0.250\u0027]\n  domain: []\n  use_dhcp: false\n  members:\n  - type: interface\n    name: nic2\n    mtu: 1350\n    primary: true\n  routes:\n  - ip_netmask: 0.0.0.0/0\n    next_hop: 10.0.0.1\n  addresses:\n  - ip_netmask: 10.0.0.45/24\n~~~\n\n\n\nhttps://logserver.rdoproject.org/54/31954/19/check/periodic-tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset064-master/30074ad/logs/overcloud1-controller-1/var/log/extra/network.txt.gz\n~~~\ndefault via 10.0.0.1 dev br-ex \n~~~\n\n\nCompute:-\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\nhttps://logserver.rdoproject.org/54/31954/19/check/periodic-tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset064-master/30074ad/logs/overcloud1-novacompute-0/etc/os-net-config/config.yaml.txt.gz\n\n~~~\nnetwork_config:\n- type: interface\n  name: nic1\n  mtu: 1350\n  use_dhcp: false\n  addresses:\n  - ip_netmask: 192.168.24.11/24\n  routes:\n  - default: true\n    next_hop: 192.168.24.1\n~~~\n\nhttps://logserver.rdoproject.org/54/31954/19/check/periodic-tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset064-master/30074ad/logs/overcloud1-novacompute-0/var/log/extra/network.txt.gz\n\n~~~\ndefault via 192.168.24.1 dev ens3 \n~~~","commit_id":"6ad9543a2916781270caa2d987c0b1ee1c027072"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"56131c7019b25657c0d6ff9bbdf1653ef043c9e2","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  dns_servers: {{ ctlplane_dns_nameservers }}"},{"line_number":16,"context_line":"  domain: {{ dns_search_domains }}"},{"line_number":17,"context_line":"  use_dhcp: false"},{"line_number":18,"context_line":"  routes:"},{"line_number":19,"context_line":"  - ip_netmask: 0.0.0.0/0"},{"line_number":20,"context_line":"    next_hop: {{ external_cloud_1_gateway_ip | default(\u002710.0.0.1\u0027) }}"},{"line_number":21,"context_line":"  members:"},{"line_number":22,"context_line":"  - type: interface"},{"line_number":23,"context_line":"    name: nic2"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"4daa978c_b915bf57","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":68},"in_reply_to":"8f3eed68_de6acf1e","updated":"2021-12-06 19:04:02.000000000","message":"I\u0027m not sure if we need to route on the external network in CI. Most likely not.\n\nPrior to converting to ansible[1] we had default route on ctlplane for compute, and default route on External for Controllers.\n\nhttps://opendev.org/openstack/tripleo-heat-templates/src/branch/stable/train/ci/environments/network/multiple-nics/nic-configs","commit_id":"6ad9543a2916781270caa2d987c0b1ee1c027072"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"03a88d10adebc36ed402151128440cefa8b4e6a2","unresolved":true,"context_lines":[{"line_number":15,"context_line":"  dns_servers: {{ ctlplane_dns_nameservers }}"},{"line_number":16,"context_line":"  domain: {{ dns_search_domains }}"},{"line_number":17,"context_line":"  use_dhcp: false"},{"line_number":18,"context_line":"  routes:"},{"line_number":19,"context_line":"  - ip_netmask: 0.0.0.0/0"},{"line_number":20,"context_line":"    next_hop: {{ external_cloud_1_gateway_ip | default(\u002710.0.0.1\u0027) }}"},{"line_number":21,"context_line":"  members:"},{"line_number":22,"context_line":"  - type: interface"},{"line_number":23,"context_line":"    name: nic2"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3af2bb33_b1e56f75","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":68},"in_reply_to":"aaf7b265_f143c20b","updated":"2021-12-06 14:40:29.000000000","message":"Thank you Harald,\n\nI was using our existing template[1] as an example, it also needs similar correction.\n\n[1]\nhttps://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo_network_config/templates/ci/multiple_nics.j2#L9-L20","commit_id":"6ad9543a2916781270caa2d987c0b1ee1c027072"}]}