)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d71f31722c7902d1fdb285456d1eeea0abf4e9b7","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Create nova flavor for Octavia"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The nova flavor for Octavia was previously created from puppet-octavia"},{"line_number":10,"context_line":"but it didn\u0027t offer a convenient way to select the type of the API"},{"line_number":11,"context_line":"endpoint (it uses public API endpoint by default while some deployments"},{"line_number":12,"context_line":"don\u0027t have access to the external network from their controllers)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"56e3d4e0_672375b4","line":9,"range":{"start_line":9,"start_character":32,"end_line":9,"end_character":62},"updated":"2021-12-13 08:35:48.000000000","message":"is that no longer happening? bonus would be nice to point to something like some bug or commit that shows it no longer created with puppet-octavia\n\nmain concern is if puppet-tripleo is still creating \u0027default\u0027 flavors and will there be a conflict between this patch and what is currently being created there?\n\n[EDIT]: ah... i see you have a guard \"if ! ... \" ok so only create if it doesn\u0027t exist","commit_id":"a9cdfe2980e7ed6ba79b3c23acea461b57d263e1"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"513bb489846947e30e1b10e5e897ee0091fad612","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Create nova flavor for Octavia"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The nova flavor for Octavia was previously created from puppet-octavia"},{"line_number":10,"context_line":"but it didn\u0027t offer a convenient way to select the type of the API"},{"line_number":11,"context_line":"endpoint (it uses public API endpoint by default while some deployments"},{"line_number":12,"context_line":"don\u0027t have access to the external network from their controllers)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9e0d9317_a7181edb","line":9,"range":{"start_line":9,"start_character":32,"end_line":9,"end_character":62},"in_reply_to":"56e3d4e0_672375b4","updated":"2021-12-13 08:54:16.000000000","message":"puppet-octavia still supports creating flavor but we no longer want to use it because it uses the public API endpoint, and we want something which can be configured more easily.\nwe have a downstream BZ about that https://bugzilla.redhat.com/show_bug.cgi?id\u003d2019808\n\nthe THT related patch will disable the creation of the flavor from puppet-* and at the same time will enable its creation from tripleo-ansible","commit_id":"a9cdfe2980e7ed6ba79b3c23acea461b57d263e1"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9e301bddbc3fb01fdd55c81e74ae92e6b3d3d8da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b99c1489_568d5998","updated":"2021-12-21 08:27:38.000000000","message":"inline thought but lgtm \u0026 ci scen10 seems happy with the change","commit_id":"a9cdfe2980e7ed6ba79b3c23acea461b57d263e1"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"5f3475e146d97c9d3c9f45ffad6f4cb294dc3b8e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"989c8592_6cb5e876","updated":"2021-12-13 06:41:11.000000000","message":"lgtm,\n\nTested at https://review.opendev.org/c/openstack/tripleo-heat-templates/+/820993","commit_id":"a9cdfe2980e7ed6ba79b3c23acea461b57d263e1"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"1886aa77d377c593ab5cccfe35d72e5903a99652","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b8ecd249_db1367a3","updated":"2022-01-13 09:59:14.000000000","message":"recheck","commit_id":"a9cdfe2980e7ed6ba79b3c23acea461b57d263e1"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"08508dbed951f53aa3bc6ccccccfb6a3682f8877","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e9ec9d00_ede9b513","updated":"2022-01-12 12:56:55.000000000","message":"recheck","commit_id":"a9cdfe2980e7ed6ba79b3c23acea461b57d263e1"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"6012eeb073641c2f8f12092016cbcea46e76fedd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ab13124c_6bb2a555","updated":"2021-12-10 14:05:18.000000000","message":"recheck\n\nsc010: cannot build server","commit_id":"a9cdfe2980e7ed6ba79b3c23acea461b57d263e1"}],"tripleo_ansible/roles/octavia_overcloud_config/tasks/flavor.yml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"df939777697c73bc3536406c591ec36dfc0a7b99","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"- name: create nova flavor for Octavia"},{"line_number":4,"context_line":"  shell: |"},{"line_number":5,"context_line":"    if ! openstack flavor show octavia_{{ octavia_flavor_id }} \u003e /dev/null; then"},{"line_number":6,"context_line":"      openstack flavor create -vv \\"},{"line_number":7,"context_line":"        --id {{ octavia_flavor_id }} \\"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1432df8a_20403d65","line":4,"updated":"2021-12-08 11:37:26.000000000","message":"perhaps some tunings are required with the check_mode (if we support running that in the check mode)? also consider adding run_once maybe - that would reduce the idempotency API calls that check for existance to at most once :)","commit_id":"75a236d9877deb51d8c8dfdb646a2232d812eb30"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"89625fdc5279f25cdcaf031dc1530b2cfec33d2f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"- name: create nova flavor for Octavia"},{"line_number":4,"context_line":"  shell: |"},{"line_number":5,"context_line":"    if ! openstack flavor show octavia_{{ octavia_flavor_id }} \u003e /dev/null; then"},{"line_number":6,"context_line":"      openstack flavor create -vv \\"},{"line_number":7,"context_line":"        --id {{ octavia_flavor_id }} \\"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6dd18e5a_91d4587e","line":4,"in_reply_to":"1432df8a_20403d65","updated":"2021-12-10 10:30:55.000000000","message":"1. I don\u0027t think we support check_mode in the octavia playbook, we don\u0027t have any tasks that use it.\n2. The role is included by octavia-files.yaml which already limits the execution of the tasks to one node (octavia_nodes[0]), but yeah maybe it\u0027s worth it to add it explicitly","commit_id":"75a236d9877deb51d8c8dfdb646a2232d812eb30"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9e301bddbc3fb01fdd55c81e74ae92e6b3d3d8da","unresolved":true,"context_lines":[{"line_number":12,"context_line":"        octavia_{{ octavia_flavor_id }}"},{"line_number":13,"context_line":"    fi"},{"line_number":14,"context_line":"  run_once: true"},{"line_number":15,"context_line":"  when: octavia_manage_nova_flavor | default(false) | bool"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0afda634_d51b0a7c","line":15,"range":{"start_line":15,"start_character":45,"end_line":15,"end_character":50},"updated":"2021-12-21 08:27:38.000000000","message":"ok i had a look at the THT patch - cant quite decide which way around the depends-on needs to be but I guess the passing scen10 on https://review.opendev.org/c/openstack/tripleo-heat-templates/+/820993 means it doesn\u0027t break anythign this way.\n\njust wondering about the default(false) here for the when: octavia_manage_nova_flavor\n\nthat is defaulted to true in https://review.opendev.org/c/openstack/tripleo-heat-templates/+/820993\n\n  OctaviaManageNovaFlavor:\n    default: true\n    description: Configure the nova flavor for the amphora.\n    type: boolean\n\nalso do you want to add this octavia_manage_nova_flavor as a role variable? I noticed that actually this role doesn\u0027t have a vars file at all though so perhaps that\u0027s why you didn\u0027t add it (wondering if it is worth adding just one var)","commit_id":"a9cdfe2980e7ed6ba79b3c23acea461b57d263e1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d71f31722c7902d1fdb285456d1eeea0abf4e9b7","unresolved":true,"context_lines":[{"line_number":12,"context_line":"        octavia_{{ octavia_flavor_id }}"},{"line_number":13,"context_line":"    fi"},{"line_number":14,"context_line":"  run_once: true"},{"line_number":15,"context_line":"  when: octavia_manage_nova_flavor | default(false) | bool"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7e578571_54e14c4d","line":15,"range":{"start_line":15,"start_character":8,"end_line":15,"end_character":34},"updated":"2021-12-13 08:35:48.000000000","message":"where is that please I can\u0027t find it https://codesearch.opendev.org/?q\u003doctavia_manage_nova_flavor\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d","commit_id":"a9cdfe2980e7ed6ba79b3c23acea461b57d263e1"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"421d0e08e60c5a434354e2777a24c7bdbc63f872","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        octavia_{{ octavia_flavor_id }}"},{"line_number":13,"context_line":"    fi"},{"line_number":14,"context_line":"  run_once: true"},{"line_number":15,"context_line":"  when: octavia_manage_nova_flavor | default(false) | bool"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"03f99a28_2b7219ce","line":15,"updated":"2021-12-14 17:34:57.000000000","message":"where is the OS_CLOUD specified so this works? I noticed that tripleo_ansible/playbooks/octavia*.yaml have it defined but it appears to be hard coded to overcloud. If a deployer had a different named cloud does it still work?","commit_id":"a9cdfe2980e7ed6ba79b3c23acea461b57d263e1"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"a4e1751ac2725469a249db4634c8ce6d06e361ee","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        octavia_{{ octavia_flavor_id }}"},{"line_number":13,"context_line":"    fi"},{"line_number":14,"context_line":"  run_once: true"},{"line_number":15,"context_line":"  when: octavia_manage_nova_flavor | default(false) | bool"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"27261d9e_f3be1978","line":15,"in_reply_to":"03f99a28_2b7219ce","updated":"2021-12-15 08:55:38.000000000","message":"Env vars are defined in the octavia-files.yaml playbook\nhttps://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/playbooks/octavia-files.yaml#L55-L69\n\nPlease note that OS_CLOUDNAME is defined, but it is unused (AFAIK OS_CLOUDNAME is only used in the prompt of the shell)","commit_id":"a9cdfe2980e7ed6ba79b3c23acea461b57d263e1"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"3bb5061ccc6f2daf8398b1ea06665e1fc6e7e756","unresolved":true,"context_lines":[{"line_number":12,"context_line":"        octavia_{{ octavia_flavor_id }}"},{"line_number":13,"context_line":"    fi"},{"line_number":14,"context_line":"  run_once: true"},{"line_number":15,"context_line":"  when: octavia_manage_nova_flavor | default(false) | bool"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"44e80fc8_55304563","line":15,"range":{"start_line":15,"start_character":45,"end_line":15,"end_character":50},"in_reply_to":"0afda634_d51b0a7c","updated":"2021-12-21 13:40:20.000000000","message":"I want to avoid a backport issue that happened in tripleo/octavia in the past. One tripleo-ansible patch was imported to a downstream branch without the related tht patch and it broke Octavia.\n\nSo my idea is: if the tripleo-ansible patch is backported and the tht patch is missing, the flavor creation is not triggered in tripleo-ansible (because octavia_manage_nova_flavor is defaulted to false), but tht triggers it in puppet-octavia, so it doesn\u0027t break our CI jobs.\n\noctavia_manage_nova_flavor is a parameter that is passed by the related commit in tht.","commit_id":"a9cdfe2980e7ed6ba79b3c23acea461b57d263e1"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"a4e1751ac2725469a249db4634c8ce6d06e361ee","unresolved":true,"context_lines":[{"line_number":12,"context_line":"        octavia_{{ octavia_flavor_id }}"},{"line_number":13,"context_line":"    fi"},{"line_number":14,"context_line":"  run_once: true"},{"line_number":15,"context_line":"  when: octavia_manage_nova_flavor | default(false) | bool"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"62ed1080_9df54f01","line":15,"range":{"start_line":15,"start_character":8,"end_line":15,"end_character":34},"in_reply_to":"3f9c9d31_dc5232a9","updated":"2021-12-15 08:55:38.000000000","message":"Good point, but I believe that the tripleo-ansible commit must be merged before the THT commit","commit_id":"a9cdfe2980e7ed6ba79b3c23acea461b57d263e1"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"9722c17228d6a1464164fe7ed907ea6f78c9aec1","unresolved":true,"context_lines":[{"line_number":12,"context_line":"        octavia_{{ octavia_flavor_id }}"},{"line_number":13,"context_line":"    fi"},{"line_number":14,"context_line":"  run_once: true"},{"line_number":15,"context_line":"  when: octavia_manage_nova_flavor | default(false) | bool"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b24d1b0f_c6c5c680","line":15,"range":{"start_line":15,"start_character":8,"end_line":15,"end_character":34},"in_reply_to":"7e578571_54e14c4d","updated":"2021-12-13 08:45:54.000000000","message":"I only saw it on a patch to get merged\nhttps://review.opendev.org/c/openstack/tripleo-heat-templates/+/820993\n on the file https://review.opendev.org/c/openstack/tripleo-heat-templates/+/820993/1/deployment/octavia/octavia-deployment-config.j2.yaml#261\n\nOn that patch it also set the values of the flavor, and tells the puppet-octavia not to create the flavor.","commit_id":"a9cdfe2980e7ed6ba79b3c23acea461b57d263e1"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"513bb489846947e30e1b10e5e897ee0091fad612","unresolved":true,"context_lines":[{"line_number":12,"context_line":"        octavia_{{ octavia_flavor_id }}"},{"line_number":13,"context_line":"    fi"},{"line_number":14,"context_line":"  run_once: true"},{"line_number":15,"context_line":"  when: octavia_manage_nova_flavor | default(false) | bool"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bbe439d2_ef564bd0","line":15,"range":{"start_line":15,"start_character":8,"end_line":15,"end_character":34},"in_reply_to":"b24d1b0f_c6c5c680","updated":"2021-12-13 08:54:16.000000000","message":"Right, it is in a patch that has a depends-on this one. I set default(false) in case the tripleo-ansible patch is merged before the THT patch (so it won\u0027t change the behavior until THT patch is merged)","commit_id":"a9cdfe2980e7ed6ba79b3c23acea461b57d263e1"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"25fce91d38009cbbae38f969cf1ca02b0317389f","unresolved":true,"context_lines":[{"line_number":12,"context_line":"        octavia_{{ octavia_flavor_id }}"},{"line_number":13,"context_line":"    fi"},{"line_number":14,"context_line":"  run_once: true"},{"line_number":15,"context_line":"  when: octavia_manage_nova_flavor | default(false) | bool"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f9c9d31_dc5232a9","line":15,"range":{"start_line":15,"start_character":8,"end_line":15,"end_character":34},"in_reply_to":"bbe439d2_ef564bd0","updated":"2021-12-15 07:32:26.000000000","message":"k thanks but then maybe the depends-on can be the other way around?","commit_id":"a9cdfe2980e7ed6ba79b3c23acea461b57d263e1"}]}