)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"10a2c715c6d983349d43898b61d879f678808a72","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2b0ee8c7_4acf556b","updated":"2022-01-06 22:28:04.000000000","message":"Now I think about it, this playbook should do everything[1] does, so it should run the tuned role also, and expose vars for tuned_profile and isolated_cores\n\n[1] https://opendev.org/openstack/tripleo-heat-templates/src/branch/master/deployment/kernel/kernel-boot-params-baremetal-ansible.yaml#L96-L113","commit_id":"c19d76325fe8e5883d0d7704935c53e4041c01de"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"05f82d336a18b66b5cc70c7b9e28df5df8190ba1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a1a80601_7d5cf2b2","updated":"2022-01-06 23:16:59.000000000","message":"Here is the docs change which uses it https://review.opendev.org/c/openstack/tripleo-docs/+/823735","commit_id":"28c2a15434627b358bd9c3921d8f61f9dac6d98d"},{"author":{"_account_id":34334,"name":"Ella Shulman","email":"eshulman@redhat.com","username":"eshulman"},"change_message_id":"739f036bcdda44575604616bc9412acefc7592bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3e865d33_83d89bb4","updated":"2022-01-09 14:30:09.000000000","message":"Hi I tried running this playbook on my setup but encountered several issues, \n1. some tasks in the roles requires root permissions (I added become manually in my machine just to make sure it works)\n2. the playbook didn\u0027t reboot the host after the roles which meant that the kargs were not aplied","commit_id":"28c2a15434627b358bd9c3921d8f61f9dac6d98d"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"9bc0837980a859e6046dc48d7e1e0a63cb769fad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"abe0b71a_23d20547","in_reply_to":"3e865d33_83d89bb4","updated":"2022-01-09 20:20:39.000000000","message":"\u003e Hi I tried running this playbook on my setup but encountered several issues, \n\u003e 1. some tasks in the roles requires root permissions (I added become manually in my machine just to make sure it works)\n\nDone\n\n\u003e 2. the playbook didn\u0027t reboot the host after the roles which meant that the kargs were not aplied\n\nHopefully the other changes help with this. You may need to run provision with --verbose and paste the ansible log here.","commit_id":"28c2a15434627b358bd9c3921d8f61f9dac6d98d"},{"author":{"_account_id":34334,"name":"Ella Shulman","email":"eshulman@redhat.com","username":"eshulman"},"change_message_id":"6343a36fa838c0357926b3662e8cf80e1dbf3576","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"57438ebe_c8a14e19","in_reply_to":"3e865d33_83d89bb4","updated":"2022-01-12 10:26:55.000000000","message":"after rechecking reboot works only if the servers are not already deployed","commit_id":"28c2a15434627b358bd9c3921d8f61f9dac6d98d"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"788a367b465f2bda317b5a29cb6b3a6046a5831a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b859bb34_57ed649c","updated":"2022-01-11 05:43:02.000000000","message":"Few more rquirements:\n1) DDP package need be change before reboot for the DPDK nodes, if required\n2) After kernel args and the node is rebooted, DPDK should be enabled in OvS before running the os-net-config, or else DPDK ports will be in error state when added by os-net-config\n\nThese handling is done as part of https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/openvswitch/openvswitch-dpdk-baremetal-ansible.yaml#L239-L280 task for DPDK service.","commit_id":"6f4e998be6fc2468deb5f32010963aa054769780"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"e4980b94a84439382ae45a46789c962a0df562cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"860a6174_d0bf3b40","updated":"2022-01-10 17:43:18.000000000","message":"I belive the ansible lint job error is not releated.\n\n```\nTraceback (most recent call last):\n  File \"/home/zuul/.cache/pre-commit/repo7flqvpa2/py_env-python3.6/bin/ansible-lint\", line 8, in \u003cmodule\u003e\n    sys.exit(_run_cli_entrypoint())\n  File \"/home/zuul/.cache/pre-commit/repo7flqvpa2/py_env-python3.6/lib/python3.6/site-packages/ansiblelint/__main__.py\", line 279, in _run_cli_entrypoint\n    sys.exit(main(sys.argv))\n  File \"/home/zuul/.cache/pre-commit/repo7flqvpa2/py_env-python3.6/lib/python3.6/site-packages/ansiblelint/__main__.py\", line 195, in main\n    from ansiblelint.generate_docs import rules_as_rich, rules_as_rst\n  File \"/home/zuul/.cache/pre-commit/repo7flqvpa2/py_env-python3.6/lib/python3.6/site-packages/ansiblelint/generate_docs.py\", line 6, in \u003cmodule\u003e\n    from rich.console import render_group\nImportError: cannot import name \u0027render_group\u0027\n```","commit_id":"6f4e998be6fc2468deb5f32010963aa054769780"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"ca3cc99a1c9956a34c6608ecf0ecd00199ae18ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1c5d07c0_c8611cbb","updated":"2022-01-11 16:05:09.000000000","message":"I think we need to address Saravanan\u0027s concern regarding the missing parameter.","commit_id":"6f4e998be6fc2468deb5f32010963aa054769780"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"1b3471b27ed1dab36dfcf2f2c9c9f4727888a8da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"68885f70_fbbf7dbe","updated":"2022-01-10 17:41:20.000000000","message":"recheck - content provider job failed.","commit_id":"6f4e998be6fc2468deb5f32010963aa054769780"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"721084e3d666e6311cef1eb6fd2b75e6f1264a2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c30d3a7b_5da0c1ee","updated":"2022-01-13 14:00:39.000000000","message":"AFICT this looks good.\n\nI guess we should wait for Ella to test this before merging.","commit_id":"57de5bb26c2d8da7fe7696f34d0e0835cec5afb4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e86c5bd24c9094db9df31a43ebf6bab00458c660","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"00f8b9d4_9d748835","updated":"2022-01-14 19:35:56.000000000","message":"Ok we can follow up","commit_id":"57de5bb26c2d8da7fe7696f34d0e0835cec5afb4"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"c81af4f61aacabdc074868c0cde9332e6561666d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"130f960c_b12a625f","updated":"2022-01-25 16:25:39.000000000","message":"recheck","commit_id":"57de5bb26c2d8da7fe7696f34d0e0835cec5afb4"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"0d8ecf3331b18f93489719bb253f09a3673ae151","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6f134e5b_5317f1aa","updated":"2022-01-20 05:57:55.000000000","message":"recheck","commit_id":"57de5bb26c2d8da7fe7696f34d0e0835cec5afb4"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"8dc7702b99720c8be13077ca2deabeaafc28064b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b783ee3f_0b5756a6","updated":"2022-01-15 23:53:11.000000000","message":"recheck","commit_id":"57de5bb26c2d8da7fe7696f34d0e0835cec5afb4"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"6d2395640897d25a2ce2fccfb9432ec3ac33422c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c9a35a6c_b2119158","updated":"2022-01-16 15:40:41.000000000","message":"recheck","commit_id":"57de5bb26c2d8da7fe7696f34d0e0835cec5afb4"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"05487e7d1ae27f80c1132dbb06996dfed129cb61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"dc3949f0_2c7240ca","updated":"2022-01-13 07:53:04.000000000","message":"recheck","commit_id":"57de5bb26c2d8da7fe7696f34d0e0835cec5afb4"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"d7db71ed9c364ff341e431899f62ebb1b3873a9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5f5f4770_b71e1d48","updated":"2022-01-17 06:33:18.000000000","message":"recheck\n\nOvercloud deploy: \n FATAL | Debug output for task: Run puppet on the host to apply IPtables rules | centos-9-stream-ovh-gra1-0028028100 | error\u003d{\n2022-01-16 17:21:07 |     \"failed_when_result\": true,\n2022-01-16 17:21:07 |     \"puppet_host_outputs.stdout_lines | default([]) | union(puppet_host_outputs.stderr_lines | default([]))\": [\n2022-01-16 17:21:07 |         \"Notice: Compiled catalog for centos-9-stream-ovh-gra1-0028028100.localdomain in environment production in 0.77 seconds\",\n2022-01-16 17:21:07 |         \"Notice: Applied catalog in 0.23 seconds\",\n2022-01-16 17:21:07 |         \"Application:\",\n2022-01-16 17:21:07 |         \"   Initial environment: production\",\n2022-01-16 17:21:07 |         \"   Converged environment: production\",\n2022-01-16 17:21:07 |         \"         Run mode: user\",\n2022-01-16 17:21:07 |         \"Changes:\",\n2022-01-16 17:21:07 |         \"Events:\",\n2022-01-16 17:21:07 |         \"Resources:\",\n2022-01-16 17:21:07 |         \"          Skipped: 44\",\n2022-01-16 17:21:07 |         \"            Total: 44\",\n2022-01-16 17:21:07 |         \"Time:\",\n2022-01-16 17:21:07 |         \"   Transaction evaluation: 0.23\",\n2022-01-16 17:21:07 |         \"   Catalog application: 0.23\",\n2022-01-16 17:21:07 |         \"   Config retrieval: 0.97\",\n2022-01-16 17:21:07 |         \"         Last run: 1642353667\",\n2022-01-16 17:21:07 |         \"            Total: 0.23\",\n2022-01-16 17:21:07 |         \"Version:\",\n2022-01-16 17:21:07 |         \"           Config: 1642353666\",\n2022-01-16 17:21:07 |         \"           Puppet: 7.10.0\",\n2022-01-16 17:21:07 |         \"Error: Facter: error while resolving custom facts in /usr/share/openstack-puppet/modules/kmod/lib/facter/kmod.rb: expected argument to be a String, Symbol, or Hash\",","commit_id":"57de5bb26c2d8da7fe7696f34d0e0835cec5afb4"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"363fef5e62cc62711560032c12c96a78d4183a31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a85dce98_a396c956","updated":"2022-01-18 15:21:54.000000000","message":"recheck\n\nc9 content provider seems to be passing again","commit_id":"57de5bb26c2d8da7fe7696f34d0e0835cec5afb4"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"7c2adbec627124e58431286e2f7b910e200b42ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"41994cc1_1a5cb570","updated":"2022-01-19 05:16:07.000000000","message":"recheck\n\ntempest failure","commit_id":"57de5bb26c2d8da7fe7696f34d0e0835cec5afb4"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"8a6d1b92a065c36bfb69c6c747b0bf72e7e54237","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e2c90b36_8011d7da","updated":"2022-01-18 06:10:07.000000000","message":"will hit https://bugs.launchpad.net/tripleo/+bug/1958202 for c9","commit_id":"57de5bb26c2d8da7fe7696f34d0e0835cec5afb4"}],"tripleo_ansible/playbooks/cli-overcloud-node-kernelargs.yaml":[{"author":{"_account_id":34334,"name":"Ella Shulman","email":"eshulman@redhat.com","username":"eshulman"},"change_message_id":"739f036bcdda44575604616bc9412acefc7592bf","unresolved":true,"context_lines":[{"line_number":17,"context_line":"- name: Overcloud Node Set Kernel Args"},{"line_number":18,"context_line":"  hosts: allovercloud"},{"line_number":19,"context_line":"  any_errors_fatal: true"},{"line_number":20,"context_line":"  gather_facts: false"},{"line_number":21,"context_line":"  vars:"},{"line_number":22,"context_line":"    kernel_args: \u0027\u0027"},{"line_number":23,"context_line":"    reboot_wait_timeout: 900"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c5aa32ce_95604f1a","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":4},"updated":"2022-01-09 14:30:09.000000000","message":"without \"gather facts\" tuned role will fail at the first task (\"Gather variables for each operating system\") because \"ansible_facts[\u0027distribution\u0027]\" is missing for example","commit_id":"28c2a15434627b358bd9c3921d8f61f9dac6d98d"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"9bc0837980a859e6046dc48d7e1e0a63cb769fad","unresolved":false,"context_lines":[{"line_number":17,"context_line":"- name: Overcloud Node Set Kernel Args"},{"line_number":18,"context_line":"  hosts: allovercloud"},{"line_number":19,"context_line":"  any_errors_fatal: true"},{"line_number":20,"context_line":"  gather_facts: false"},{"line_number":21,"context_line":"  vars:"},{"line_number":22,"context_line":"    kernel_args: \u0027\u0027"},{"line_number":23,"context_line":"    reboot_wait_timeout: 900"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"23321b62_fe314c56","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":4},"in_reply_to":"c5aa32ce_95604f1a","updated":"2022-01-09 20:20:39.000000000","message":"Done","commit_id":"28c2a15434627b358bd9c3921d8f61f9dac6d98d"},{"author":{"_account_id":34334,"name":"Ella Shulman","email":"eshulman@redhat.com","username":"eshulman"},"change_message_id":"739f036bcdda44575604616bc9412acefc7592bf","unresolved":true,"context_lines":[{"line_number":42,"context_line":"        tuned_isolated_cores: \u0027{{ tuned_isolated_cores }}\u0027"},{"line_number":43,"context_line":"    - name: Configure kernel args and reboot"},{"line_number":44,"context_line":"      include_role:"},{"line_number":45,"context_line":"        name: tripleo-kernel"},{"line_number":46,"context_line":"        tasks_from: kernelargs.yml"},{"line_number":47,"context_line":"      vars:"},{"line_number":48,"context_line":"        tripleo_kernel_args: \u0027{{ kernel_args }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b353cc7e_00c64edf","line":45,"range":{"start_line":45,"start_character":14,"end_line":45,"end_character":28},"updated":"2022-01-09 14:30:09.000000000","message":"I think this is a typo and should be tripleo_kernel","commit_id":"28c2a15434627b358bd9c3921d8f61f9dac6d98d"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"9bc0837980a859e6046dc48d7e1e0a63cb769fad","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        tuned_isolated_cores: \u0027{{ tuned_isolated_cores }}\u0027"},{"line_number":43,"context_line":"    - name: Configure kernel args and reboot"},{"line_number":44,"context_line":"      include_role:"},{"line_number":45,"context_line":"        name: tripleo-kernel"},{"line_number":46,"context_line":"        tasks_from: kernelargs.yml"},{"line_number":47,"context_line":"      vars:"},{"line_number":48,"context_line":"        tripleo_kernel_args: \u0027{{ kernel_args }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"34f6099c_5f7ada46","line":45,"range":{"start_line":45,"start_character":14,"end_line":45,"end_character":28},"in_reply_to":"b353cc7e_00c64edf","updated":"2022-01-09 20:20:39.000000000","message":"Done","commit_id":"28c2a15434627b358bd9c3921d8f61f9dac6d98d"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"68654f2c654abb00482161de7f734c38e9204efc","unresolved":true,"context_lines":[{"line_number":19,"context_line":"  any_errors_fatal: true"},{"line_number":20,"context_line":"  gather_facts: true"},{"line_number":21,"context_line":"  vars:"},{"line_number":22,"context_line":"    kernel_args: \u0027\u0027"},{"line_number":23,"context_line":"    reboot_wait_timeout: 900"},{"line_number":24,"context_line":"    tuned_profile: \u0027throughput-performance\u0027"},{"line_number":25,"context_line":"    tuned_isolated_cores: \u0027\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"67f264d0_4b01c879","line":22,"updated":"2022-01-11 05:46:30.000000000","message":"How are these parameter handled role specific? Like ComputeSriov and ComputeOvsDpdk roles will have different kernel args, isolated cores and tuned profile.","commit_id":"6f4e998be6fc2468deb5f32010963aa054769780"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"7947403385deaea7708e97df96a3cac6e8db5d0e","unresolved":true,"context_lines":[{"line_number":19,"context_line":"  any_errors_fatal: true"},{"line_number":20,"context_line":"  gather_facts: true"},{"line_number":21,"context_line":"  vars:"},{"line_number":22,"context_line":"    kernel_args: \u0027\u0027"},{"line_number":23,"context_line":"    reboot_wait_timeout: 900"},{"line_number":24,"context_line":"    tuned_profile: \u0027throughput-performance\u0027"},{"line_number":25,"context_line":"    tuned_isolated_cores: \u0027\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"87a23e8e_c0e8e8f3","line":22,"in_reply_to":"01cc7a12_79d66748","updated":"2022-01-12 06:35:47.000000000","message":"Thanks for clarifying. Is it fair to say that we can remove the THT parameter \"KernelArgs\" on this method is merged? \n\nHere the \"hosts\" is \"allovercloud\".  Is it like while running this playbook the hosts file be generated with \"allovercloud\" targetting only those nodes of the assoicated role?","commit_id":"6f4e998be6fc2468deb5f32010963aa054769780"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"ca3cc99a1c9956a34c6608ecf0ecd00199ae18ff","unresolved":true,"context_lines":[{"line_number":19,"context_line":"  any_errors_fatal: true"},{"line_number":20,"context_line":"  gather_facts: true"},{"line_number":21,"context_line":"  vars:"},{"line_number":22,"context_line":"    kernel_args: \u0027\u0027"},{"line_number":23,"context_line":"    reboot_wait_timeout: 900"},{"line_number":24,"context_line":"    tuned_profile: \u0027throughput-performance\u0027"},{"line_number":25,"context_line":"    tuned_isolated_cores: \u0027\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"01cc7a12_79d66748","line":22,"in_reply_to":"67f264d0_4b01c879","updated":"2022-01-11 16:05:09.000000000","message":"Ansible playbooks are per-role in baremetal_deployment.yaml, you would have one entry for ComputeSriov and another for ComputeOvsDpdk roles. You can add a list of playbooks tho be executed for each role, and the vars to use for each playbook.\n\n\n```\n- name: Controller\n  ansible_playbooks:\n    - playbook: bm-deploy-playbook.yaml\n      extra_vars:\n        foo: bar\n\n- name: Compute\n  ansible_playbooks:\n    - playbook: bm-deploy-playbook.yaml\n      extra_vars:\n        foo: bar\n\n```","commit_id":"6f4e998be6fc2468deb5f32010963aa054769780"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"f836a90844f4e5944421dd62f4ffe364eed5da52","unresolved":true,"context_lines":[{"line_number":19,"context_line":"  any_errors_fatal: true"},{"line_number":20,"context_line":"  gather_facts: true"},{"line_number":21,"context_line":"  vars:"},{"line_number":22,"context_line":"    kernel_args: \u0027\u0027"},{"line_number":23,"context_line":"    reboot_wait_timeout: 900"},{"line_number":24,"context_line":"    tuned_profile: \u0027throughput-performance\u0027"},{"line_number":25,"context_line":"    tuned_isolated_cores: \u0027\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9ae5416a_66b7e72f","line":22,"in_reply_to":"6b2194fe_8d8c4158","updated":"2022-01-17 06:27:01.000000000","message":"Thanks for link. Its clear.","commit_id":"6f4e998be6fc2468deb5f32010963aa054769780"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"721084e3d666e6311cef1eb6fd2b75e6f1264a2b","unresolved":true,"context_lines":[{"line_number":19,"context_line":"  any_errors_fatal: true"},{"line_number":20,"context_line":"  gather_facts: true"},{"line_number":21,"context_line":"  vars:"},{"line_number":22,"context_line":"    kernel_args: \u0027\u0027"},{"line_number":23,"context_line":"    reboot_wait_timeout: 900"},{"line_number":24,"context_line":"    tuned_profile: \u0027throughput-performance\u0027"},{"line_number":25,"context_line":"    tuned_isolated_cores: \u0027\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6b2194fe_8d8c4158","line":22,"in_reply_to":"87a23e8e_c0e8e8f3","updated":"2022-01-13 14:00:39.000000000","message":"Right, this playbook has \"allovercloud\" but it is executed with a limit, see[1], to only apply to the role.\n\n[1] https://opendev.org/openstack/python-tripleoclient/src/branch/master/tripleoclient/utils.py#L3014","commit_id":"6f4e998be6fc2468deb5f32010963aa054769780"},{"author":{"_account_id":34334,"name":"Ella Shulman","email":"eshulman@redhat.com","username":"eshulman"},"change_message_id":"6343a36fa838c0357926b3662e8cf80e1dbf3576","unresolved":true,"context_lines":[{"line_number":35,"context_line":"      connection: local"},{"line_number":36,"context_line":"  tasks:"},{"line_number":37,"context_line":"    - name: Configure tuned before reboot"},{"line_number":38,"context_line":"      become: true"},{"line_number":39,"context_line":"      include_role:"},{"line_number":40,"context_line":"        name: tuned"},{"line_number":41,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba785300_ebb02fd4","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":4},"updated":"2022-01-12 10:26:55.000000000","message":"this is an invalid syntax","commit_id":"6f4e998be6fc2468deb5f32010963aa054769780"},{"author":{"_account_id":18575,"name":"Saravanan KR","email":"krsacme@gmail.com","username":"saravanankr"},"change_message_id":"788a367b465f2bda317b5a29cb6b3a6046a5831a","unresolved":true,"context_lines":[{"line_number":48,"context_line":"        tasks_from: kernelargs.yml"},{"line_number":49,"context_line":"      vars:"},{"line_number":50,"context_line":"        tripleo_kernel_args: \u0027{{ kernel_args }}\u0027"},{"line_number":51,"context_line":"        tripleo_kernel_reboot_timeout: \u0027{{ reboot_wait_timeout }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f6ea3e4b_0b7f214b","line":51,"updated":"2022-01-11 05:43:02.000000000","message":"Parameter \"tripleo_kernel_defer_reboot\" is missing","commit_id":"6f4e998be6fc2468deb5f32010963aa054769780"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"504f501ad4a0404c03ea6796216f8d7cffd8ad34","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        search_regex: OpenSSH"},{"line_number":34,"context_line":"        delay: 10"},{"line_number":35,"context_line":"        msg: Timeout waiting for provisioned nodes to become available"},{"line_number":36,"context_line":"      connection: local"},{"line_number":37,"context_line":"  tasks:"},{"line_number":38,"context_line":"    - name: Kernel args block"},{"line_number":39,"context_line":"      become: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"27dafa6b_e408aefe","line":36,"updated":"2022-01-14 17:49:37.000000000","message":"Any reason not to use wait_for_connection instead?\n\n  tasks:                                                                        \n    - name: Wait for hosts                                                      \n      wait_for_connection:","commit_id":"57de5bb26c2d8da7fe7696f34d0e0835cec5afb4"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"71cf7ddc006a927ce702797a98a58fcb02223f34","unresolved":true,"context_lines":[{"line_number":33,"context_line":"        search_regex: OpenSSH"},{"line_number":34,"context_line":"        delay: 10"},{"line_number":35,"context_line":"        msg: Timeout waiting for provisioned nodes to become available"},{"line_number":36,"context_line":"      connection: local"},{"line_number":37,"context_line":"  tasks:"},{"line_number":38,"context_line":"    - name: Kernel args block"},{"line_number":39,"context_line":"      become: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7a8f3080_8bdac6b4","line":36,"in_reply_to":"27dafa6b_e408aefe","updated":"2022-01-14 19:35:00.000000000","message":"I think this was copy-paste from some other playbooks. [1][2]\n\nI choose wait_for in the network-config playbook, and thats since been used in other places.\nNo objection to change it to use wait_for_connection. But we may want to do a follow up patch to change it in all places?\n\n[1] https://opendev.org/openstack/tripleo-ansible/src/branch/master/tripleo_ansible/playbooks/cli-overcloud-node-network-config.yaml#L22\n[2] https://opendev.org/openstack/tripleo-ansible/src/branch/master/tripleo_ansible/playbooks/cli-overcloud-node-growvols.yaml#L30","commit_id":"57de5bb26c2d8da7fe7696f34d0e0835cec5afb4"}]}