)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"3823638d418cad0d36ed5a6c031b54df7f76e07d","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Harald Jensås \u003chjensas@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-02-05 00:35:03 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tripleo-bootstrap - check packeges fact befor install"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When repository files are present, but the ctlplane is not on a"},{"line_number":10,"context_line":"routed network. (I.e the node cannot connect to repositories.)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"c6e125ae_8c914104","line":7,"updated":"2022-02-09 13:53:40.000000000","message":"minor minor nit maybe correct typos in title if another patchset is needed?","commit_id":"37fac649388e0bf39326bdaaefa5a104b6ef264c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"425b979adb768dffc3996e2a8a15908fad355313","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"51a748c7_a7023814","updated":"2022-02-02 02:07:40.000000000","message":"-W because I was not able to reproduce the issue.\nWill ask bug reporter to test patch.","commit_id":"0f683390519d4c43178563f0e8b87b0526feb9ab"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"e6b823403f173f95c361adcd7f1bbe0e162727a3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"94936073_7c78cb62","updated":"2022-02-02 14:54:33.000000000","message":"Removing -W, overall the fix works. But Francois is highlighting a new issue on RHEL/RHOSP due to custom openvswitch package name.","commit_id":"0f683390519d4c43178563f0e8b87b0526feb9ab"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"fc3d08c5c82ef6bb98e92fd7fbbdec22c046b199","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"663f4949_df0a728f","in_reply_to":"94936073_7c78cb62","updated":"2022-02-02 20:47:41.000000000","message":"Done","commit_id":"0f683390519d4c43178563f0e8b87b0526feb9ab"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"4b9140951f09f8290357e53740e0c43c1893444b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"38567d70_972da262","updated":"2022-02-02 20:51:31.000000000","message":"yea this should be better. I thought we had a shim to disable packages by default similar to the old puppet package shim. guess it\u0027s not there anymore","commit_id":"023551d125174ddc516b65f5d9dc0e714d8daef5"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"03e99b417da7587a53381cfc3b85589753dce305","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b3275d46_aaa8a425","in_reply_to":"38567d70_972da262","updated":"2022-02-02 21:32:55.000000000","message":"I see on RHBZ that tuned[1] has similar issue, but I can do a follow up patch specific to tuned.\n\n\nhttps://opendev.org/openstack/tripleo-ansible/src/branch/master/tripleo_ansible/roles/tuned/tasks/tuned_install.yml","commit_id":"023551d125174ddc516b65f5d9dc0e714d8daef5"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4cfe316f1bd61ccda6c46fea77a036a3241a0772","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6cd78aae_756c89cb","updated":"2022-02-03 11:08:52.000000000","message":"recheck","commit_id":"68c6db9c292bb0194ebb6a4956db85d98bd41210"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"83268b0b26ae7f9d69482d0001969c454ac369e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"967fee92_30d538fe","updated":"2022-02-03 02:37:34.000000000","message":"recheck","commit_id":"68c6db9c292bb0194ebb6a4956db85d98bd41210"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"3823638d418cad0d36ed5a6c031b54df7f76e07d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b216a3c1_7f36fc05","updated":"2022-02-09 13:53:40.000000000","message":"What a pain that these are necessary.","commit_id":"37fac649388e0bf39326bdaaefa5a104b6ef264c"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"ed48a17055c1d3cb3c033acaf02435da1b8aa2e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a1ffc041_f183d314","updated":"2022-02-08 11:52:22.000000000","message":"check-rdo","commit_id":"37fac649388e0bf39326bdaaefa5a104b6ef264c"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"f663c59112b1711d05582480ccb3b36092d3deb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ae1f384f_d4cea0fa","updated":"2022-02-08 20:17:28.000000000","message":"check-rdo","commit_id":"37fac649388e0bf39326bdaaefa5a104b6ef264c"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"fe0aa003a6e039c19d055bb2d63faec940ba5767","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"797eef72_e2ac763b","updated":"2022-02-05 02:37:00.000000000","message":"recheck","commit_id":"37fac649388e0bf39326bdaaefa5a104b6ef264c"}],"tripleo_ansible/roles/tripleo_bootstrap/tasks/main.yml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"9a495b2d6901ea1e4f9dd0fa0e7c8048aa907858","unresolved":true,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: Gather the package facts"},{"line_number":36,"context_line":"  package_facts:"},{"line_number":37,"context_line":"    manager: auto"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# Currently only supported on RHEL as tripleo does not have a version package"},{"line_number":40,"context_line":"- name: Deploy release version package"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5588b429_6e297813","line":37,"updated":"2022-02-02 14:54:48.000000000","message":"-2 on this because this will massively bloat facts (perf problems). You need a different way to check if we need to run the package bits","commit_id":"0f683390519d4c43178563f0e8b87b0526feb9ab"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"1e1c4cbbe2586c62292845c97eb8f27025feef23","unresolved":true,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: Gather the package facts"},{"line_number":36,"context_line":"  package_facts:"},{"line_number":37,"context_line":"    manager: auto"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# Currently only supported on RHEL as tripleo does not have a version package"},{"line_number":40,"context_line":"- name: Deploy release version package"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"95e029c6_046ba8b1","line":37,"in_reply_to":"40c80930_793e49bb","updated":"2022-02-02 14:59:12.000000000","message":"ack, rpm -qa + --qf,--queryformat to get just the package name should do.\nI will look into it.","commit_id":"0f683390519d4c43178563f0e8b87b0526feb9ab"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0b9dac3595c754ee22e0b29c1c84c167518f26c1","unresolved":true,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: Gather the package facts"},{"line_number":36,"context_line":"  package_facts:"},{"line_number":37,"context_line":"    manager: auto"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# Currently only supported on RHEL as tripleo does not have a version package"},{"line_number":40,"context_line":"- name: Deploy release version package"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"40c80930_793e49bb","line":37,"in_reply_to":"5588b429_6e297813","updated":"2022-02-02 14:56:06.000000000","message":"I would do like an rpm -qa to a var and then split or something. It\u0027d be much more efficient","commit_id":"0f683390519d4c43178563f0e8b87b0526feb9ab"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"ce2a91765d83af0b5d6c8687e71c6d0da1f00d17","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: Gather the package facts"},{"line_number":36,"context_line":"  package_facts:"},{"line_number":37,"context_line":"    manager: auto"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# Currently only supported on RHEL as tripleo does not have a version package"},{"line_number":40,"context_line":"- name: Deploy release version package"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"50a57d4c_9a72f8fd","line":37,"in_reply_to":"95e029c6_046ba8b1","updated":"2022-02-02 20:45:53.000000000","message":"Done.","commit_id":"0f683390519d4c43178563f0e8b87b0526feb9ab"},{"author":{"_account_id":33176,"name":"Francois Rigault","email":"rigault.francois@gmail.com","username":"frigo"},"change_message_id":"71b89f9e79c1532d7a991933ea989239ef468290","unresolved":true,"context_lines":[{"line_number":59,"context_line":"    - (ansible_facts[\u0027distribution\u0027] | lower) \u003d\u003d \u0027redhat\u0027"},{"line_number":60,"context_line":"    - not ansible_check_mode|bool"},{"line_number":61,"context_line":"    - (tripleo_bootstrap_packages_bootstrap_result.rc | int) \u003d\u003d 1"},{"line_number":62,"context_line":"    - not (\u0027No package openvswitch available.\u0027 in tripleo_bootstrap_packages_bootstrap_result.failures | default([]))"},{"line_number":63,"context_line":"  register: tripleo_bootstrap_packages_bootstrap_result"},{"line_number":64,"context_line":"  when:"},{"line_number":65,"context_line":"    - (tripleo_bootstrap_packages_bootstrap | difference(ansible_facts.packages.keys()) | length) \u003e 0"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"105ef23e_5176870e","line":62,"updated":"2022-02-02 11:47:08.000000000","message":"in fact this case is hit everytime on RHEL (the var file mentions \"openvswitch\" but the package is called openvswitch2.15)\n- if network is set-up correctly, the package is not found but this task does not fail because of the failed_when\n- if network is not set-up correctly, and you\u0027re on rhel (distribution \u003d\u003d redhat), then tripleo_bootstrap_packages_bootstrap | difference(ansible_facts.packages.keys() \u003d  [ openvswitch ], so the package task runs and dnf fails and the whole playbook fails.","commit_id":"0f683390519d4c43178563f0e8b87b0526feb9ab"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"e6b823403f173f95c361adcd7f1bbe0e162727a3","unresolved":true,"context_lines":[{"line_number":59,"context_line":"    - (ansible_facts[\u0027distribution\u0027] | lower) \u003d\u003d \u0027redhat\u0027"},{"line_number":60,"context_line":"    - not ansible_check_mode|bool"},{"line_number":61,"context_line":"    - (tripleo_bootstrap_packages_bootstrap_result.rc | int) \u003d\u003d 1"},{"line_number":62,"context_line":"    - not (\u0027No package openvswitch available.\u0027 in tripleo_bootstrap_packages_bootstrap_result.failures | default([]))"},{"line_number":63,"context_line":"  register: tripleo_bootstrap_packages_bootstrap_result"},{"line_number":64,"context_line":"  when:"},{"line_number":65,"context_line":"    - (tripleo_bootstrap_packages_bootstrap | difference(ansible_facts.packages.keys()) | length) \u003e 0"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"61718786_5f3d9df7","line":62,"in_reply_to":"105ef23e_5176870e","updated":"2022-02-02 14:54:33.000000000","message":"That is well observed.\n\nI guess wee need separate vars file for RHOSP and upstream, maybe a Downstream Only patch setting openvswitch package name to \u0027openvswitch2.15\u0027 in tripleo_bootstrap/vars.","commit_id":"0f683390519d4c43178563f0e8b87b0526feb9ab"},{"author":{"_account_id":33176,"name":"Francois Rigault","email":"rigault.francois@gmail.com","username":"frigo"},"change_message_id":"04dbf35092c76c985399849ddea63929f84b12db","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    - (ansible_facts[\u0027distribution\u0027] | lower) \u003d\u003d \u0027redhat\u0027"},{"line_number":60,"context_line":"    - not ansible_check_mode|bool"},{"line_number":61,"context_line":"    - (tripleo_bootstrap_packages_bootstrap_result.rc | int) \u003d\u003d 1"},{"line_number":62,"context_line":"    - not (\u0027No package openvswitch available.\u0027 in tripleo_bootstrap_packages_bootstrap_result.failures | default([]))"},{"line_number":63,"context_line":"  register: tripleo_bootstrap_packages_bootstrap_result"},{"line_number":64,"context_line":"  when:"},{"line_number":65,"context_line":"    - (tripleo_bootstrap_packages_bootstrap | difference(ansible_facts.packages.keys()) | length) \u003e 0"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"24cc8d41_37ecd0a2","line":62,"in_reply_to":"3c04c609_fbd5ace2","updated":"2022-02-03 04:10:38.000000000","message":"yes sorry I wanted to say I was wrong, \"dnf install openvswitch\" is perfectly correct on RHEL.","commit_id":"0f683390519d4c43178563f0e8b87b0526feb9ab"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"ce2a91765d83af0b5d6c8687e71c6d0da1f00d17","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    - (ansible_facts[\u0027distribution\u0027] | lower) \u003d\u003d \u0027redhat\u0027"},{"line_number":60,"context_line":"    - not ansible_check_mode|bool"},{"line_number":61,"context_line":"    - (tripleo_bootstrap_packages_bootstrap_result.rc | int) \u003d\u003d 1"},{"line_number":62,"context_line":"    - not (\u0027No package openvswitch available.\u0027 in tripleo_bootstrap_packages_bootstrap_result.failures | default([]))"},{"line_number":63,"context_line":"  register: tripleo_bootstrap_packages_bootstrap_result"},{"line_number":64,"context_line":"  when:"},{"line_number":65,"context_line":"    - (tripleo_bootstrap_packages_bootstrap | difference(ansible_facts.packages.keys()) | length) \u003e 0"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3c04c609_fbd5ace2","line":62,"in_reply_to":"61718786_5f3d9df7","updated":"2022-02-02 20:45:53.000000000","message":"I added a check for \"rpm --query --whatprovides openvswitch\", this will give return code 0 in case on of the special version scheme openvswitch packages are installed (rdo-openvswitch or rhel-openvswitch). If some package provides openvswitch I append \u0027openvswitch\u0027 to the installed packages.","commit_id":"0f683390519d4c43178563f0e8b87b0526feb9ab"},{"author":{"_account_id":33176,"name":"Francois Rigault","email":"rigault.francois@gmail.com","username":"frigo"},"change_message_id":"71b89f9e79c1532d7a991933ea989239ef468290","unresolved":true,"context_lines":[{"line_number":80,"context_line":"        name: \"{{ tripleo_bootstrap_legacy_network_packages }}\""},{"line_number":81,"context_line":"        state: present"},{"line_number":82,"context_line":"      when:"},{"line_number":83,"context_line":"        - (tripleo_bootstrap_legacy_network_packages | difference(ansible_facts.packages.keys()) | length) \u003e 0"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    - name: Ensure network service is enabled"},{"line_number":86,"context_line":"      systemd:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c1e84f35_c244e658","line":83,"updated":"2022-02-02 11:47:08.000000000","message":"this is the call that used to fail for centos, it is now working, thanks :)","commit_id":"0f683390519d4c43178563f0e8b87b0526feb9ab"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"e6b823403f173f95c361adcd7f1bbe0e162727a3","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        name: \"{{ tripleo_bootstrap_legacy_network_packages }}\""},{"line_number":81,"context_line":"        state: present"},{"line_number":82,"context_line":"      when:"},{"line_number":83,"context_line":"        - (tripleo_bootstrap_legacy_network_packages | difference(ansible_facts.packages.keys()) | length) \u003e 0"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    - name: Ensure network service is enabled"},{"line_number":86,"context_line":"      systemd:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7bd6397e_9282cecf","line":83,"in_reply_to":"c1e84f35_c244e658","updated":"2022-02-02 14:54:33.000000000","message":"Thank you for testing this Francois!","commit_id":"0f683390519d4c43178563f0e8b87b0526feb9ab"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"03e99b417da7587a53381cfc3b85589753dce305","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    - always"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: Get a list of installed RPM packages"},{"line_number":36,"context_line":"  command: \"rpm --query --all --queryformat \u0027%{NAME}\\n\u0027\""},{"line_number":37,"context_line":"  register: rpm_query_all"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: Check if openvswitch provided by wrapper RPM is installed (rdo-openvswitch or rhel-openvswitch)"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1cd6fd99_3436211a","line":36,"range":{"start_line":36,"start_character":16,"end_line":36,"end_character":29},"updated":"2022-02-02 21:32:55.000000000","message":"So this is kind of slow, ~2-3 seconds.\nI wonder if doing `rpm --query --whatprovides {{ package_list }}` would be faster, and less tasks.","commit_id":"023551d125174ddc516b65f5d9dc0e714d8daef5"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"86adc6bfbe34aec08365fe1fe11e487109fc1748","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    - always"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: Get a list of installed RPM packages"},{"line_number":36,"context_line":"  command: \"rpm --query --all --queryformat \u0027%{NAME}\\n\u0027\""},{"line_number":37,"context_line":"  register: rpm_query_all"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: Check if openvswitch provided by wrapper RPM is installed (rdo-openvswitch or rhel-openvswitch)"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b1b01667_c4bfc2f5","line":36,"range":{"start_line":36,"start_character":16,"end_line":36,"end_character":29},"in_reply_to":"1cd6fd99_3436211a","updated":"2022-02-02 21:40:52.000000000","message":"package_facts is probably even slower.  I think that\u0027s just how long it takes to query/print the rpm db.","commit_id":"023551d125174ddc516b65f5d9dc0e714d8daef5"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"a08bc5ac43150491e6251858b70488e26eb9b7db","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    - always"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: Get a list of installed RPM packages"},{"line_number":36,"context_line":"  command: \"rpm --query --all --queryformat \u0027%{NAME}\\n\u0027\""},{"line_number":37,"context_line":"  register: rpm_query_all"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: Check if openvswitch provided by wrapper RPM is installed (rdo-openvswitch or rhel-openvswitch)"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"466711b1_da25ac14","line":36,"range":{"start_line":36,"start_character":16,"end_line":36,"end_character":29},"in_reply_to":"936771e1_536b269e","updated":"2022-02-02 22:17:27.000000000","message":"Done","commit_id":"023551d125174ddc516b65f5d9dc0e714d8daef5"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"a5fcb9b2be2f00b15031c547780cc1eef119484f","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    - always"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: Get a list of installed RPM packages"},{"line_number":36,"context_line":"  command: \"rpm --query --all --queryformat \u0027%{NAME}\\n\u0027\""},{"line_number":37,"context_line":"  register: rpm_query_all"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: Check if openvswitch provided by wrapper RPM is installed (rdo-openvswitch or rhel-openvswitch)"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"936771e1_536b269e","line":36,"range":{"start_line":36,"start_character":16,"end_line":36,"end_character":29},"in_reply_to":"b1b01667_c4bfc2f5","updated":"2022-02-02 21:48:13.000000000","message":"rpm --query --whatprovides {{ package_list }} does all packages in _tripleo_bootstrap_packages_bootstrap at less than 1 second.","commit_id":"023551d125174ddc516b65f5d9dc0e714d8daef5"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"a5fcb9b2be2f00b15031c547780cc1eef119484f","unresolved":true,"context_lines":[{"line_number":37,"context_line":"  register: rpm_query_all"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: Check if openvswitch provided by wrapper RPM is installed (rdo-openvswitch or rhel-openvswitch)"},{"line_number":40,"context_line":"  command: \"rpm --query --whatprovides openvswitch\""},{"line_number":41,"context_line":"  register: openvswitch_package_provided"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- name: Set fact `installed_packages` - add `openvswitch` since wrapper RPM installed"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"102e037c_ebe59d58","line":40,"range":{"start_line":40,"start_character":2,"end_line":40,"end_character":9},"updated":"2022-02-02 21:48:13.000000000","message":"need a failed_when here. As it is now it fails on this task in case openvswitch is not provided by anything. *doh*","commit_id":"023551d125174ddc516b65f5d9dc0e714d8daef5"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"a08bc5ac43150491e6251858b70488e26eb9b7db","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  register: rpm_query_all"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: Check if openvswitch provided by wrapper RPM is installed (rdo-openvswitch or rhel-openvswitch)"},{"line_number":40,"context_line":"  command: \"rpm --query --whatprovides openvswitch\""},{"line_number":41,"context_line":"  register: openvswitch_package_provided"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- name: Set fact `installed_packages` - add `openvswitch` since wrapper RPM installed"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e1976473_09fbec81","line":40,"range":{"start_line":40,"start_character":2,"end_line":40,"end_character":9},"in_reply_to":"102e037c_ebe59d58","updated":"2022-02-02 22:17:27.000000000","message":"Done","commit_id":"023551d125174ddc516b65f5d9dc0e714d8daef5"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"06bbe2ef9c616afa6116f2444e1bd3767f8b0314","unresolved":true,"context_lines":[{"line_number":99,"context_line":"        name: \"{{ tripleo_bootstrap_legacy_network_packages }}\""},{"line_number":100,"context_line":"        state: present"},{"line_number":101,"context_line":"      when:"},{"line_number":102,"context_line":"        - rpm_query_result !\u003d 0"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    - name: Ensure network service is enabled"},{"line_number":105,"context_line":"      systemd:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f70f6852_5ebbd1e1","line":102,"range":{"start_line":102,"start_character":8,"end_line":102,"end_character":31},"updated":"2022-02-03 14:36:58.000000000","message":"This was missing \u0027.rc\u0027 to compare the return code.\n\nI changed it to use \u0027ignore_errors: yes\u0027, and to use rpm_query_result is failed here instead as suggested my Marios on the follow up change.","commit_id":"68c6db9c292bb0194ebb6a4956db85d98bd41210"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"64de8dead9abe68c098d78aae2797e5771bd00b3","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        name: \"{{ tripleo_bootstrap_legacy_network_packages }}\""},{"line_number":100,"context_line":"        state: present"},{"line_number":101,"context_line":"      when:"},{"line_number":102,"context_line":"        - rpm_query_result !\u003d 0"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    - name: Ensure network service is enabled"},{"line_number":105,"context_line":"      systemd:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"c3933f0e_892c1adc","line":102,"range":{"start_line":102,"start_character":8,"end_line":102,"end_character":31},"in_reply_to":"f70f6852_5ebbd1e1","updated":"2022-02-03 16:55:04.000000000","message":"Done","commit_id":"68c6db9c292bb0194ebb6a4956db85d98bd41210"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"90f2097753f20367c7294fb16870bf490e8b2635","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    - (tripleo_bootstrap_release_version_package |list | length) \u003e 0"},{"line_number":40,"context_line":"  block:"},{"line_number":41,"context_line":"    - name: Check release version package is installed"},{"line_number":42,"context_line":"      command: \"rpm -q --whatprovides {{ tripleo_bootstrap_release_version_package }}\""},{"line_number":43,"context_line":"      register: rpm_query_result"},{"line_number":44,"context_line":"      ignore_errors: true"},{"line_number":45,"context_line":"      failed_when:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"e8c6addc_e5354e84","line":42,"range":{"start_line":42,"start_character":41,"end_line":42,"end_character":82},"updated":"2022-02-03 14:56:05.000000000","message":"do you need to tripleo_bootstrap_release_version_package | join(\u0027 \u0027) here because this var is a list?","commit_id":"30b845d1aa1e29be23530b398cea3142ca6114f5"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"3f78ffa0737dc9e10515e83ffaf27e4fadd4e5e6","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    - (tripleo_bootstrap_release_version_package |list | length) \u003e 0"},{"line_number":40,"context_line":"  block:"},{"line_number":41,"context_line":"    - name: Check release version package is installed"},{"line_number":42,"context_line":"      command: \"rpm -q --whatprovides {{ tripleo_bootstrap_release_version_package }}\""},{"line_number":43,"context_line":"      register: rpm_query_result"},{"line_number":44,"context_line":"      ignore_errors: true"},{"line_number":45,"context_line":"      failed_when:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f657ff17_f6d3d283","line":42,"range":{"start_line":42,"start_character":41,"end_line":42,"end_character":82},"in_reply_to":"e8c6addc_e5354e84","updated":"2022-02-03 16:54:37.000000000","message":"yes, that makes sense. I though it was just a string since var name was not plural. (I should have checked ...)","commit_id":"30b845d1aa1e29be23530b398cea3142ca6114f5"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"82b97cb9c9f5dfd8e575369d36af37946f54afee","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    - name: Check release version package is installed"},{"line_number":42,"context_line":"      command: \"rpm -q --whatprovides {{ tripleo_bootstrap_release_version_package | join(\u0027 \u0027) }}\""},{"line_number":43,"context_line":"      register: rpm_query_result"},{"line_number":44,"context_line":"      ignore_errors: true"},{"line_number":45,"context_line":"      failed_when:"},{"line_number":46,"context_line":"        - rpm_query_result.rc \u003e 0"},{"line_number":47,"context_line":"        - \u0027\"no package provides\" in rpm_query_result.stdout\u0027"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"c82de6c3_18771942","line":44,"updated":"2022-02-04 20:13:02.000000000","message":"If we don’t care if it fails I’d probably remove the ignore_error and just set failed_when: false. ignore errors creates a terrible ux and makes people think there’s a failure when there’s not.","commit_id":"c0f294e9b4aa6f2489694fd1a2a1091ec8a136e6"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"23e0c22ef948c6e3d496491dee9ae25c301d2ebc","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    - name: Check release version package is installed"},{"line_number":42,"context_line":"      command: \"rpm -q --whatprovides {{ tripleo_bootstrap_release_version_package | join(\u0027 \u0027) }}\""},{"line_number":43,"context_line":"      register: rpm_query_result"},{"line_number":44,"context_line":"      ignore_errors: true"},{"line_number":45,"context_line":"      failed_when:"},{"line_number":46,"context_line":"        - rpm_query_result.rc \u003e 0"},{"line_number":47,"context_line":"        - \u0027\"no package provides\" in rpm_query_result.stdout\u0027"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a1c2ef52_d7139adc","line":44,"in_reply_to":"743abc03_a7386215","updated":"2022-02-04 23:41:17.000000000","message":"DONE.","commit_id":"c0f294e9b4aa6f2489694fd1a2a1091ec8a136e6"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"ffd3c3b5c21ef67055e2b6f9c45bcb4c5c15e846","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    - name: Check release version package is installed"},{"line_number":42,"context_line":"      command: \"rpm -q --whatprovides {{ tripleo_bootstrap_release_version_package | join(\u0027 \u0027) }}\""},{"line_number":43,"context_line":"      register: rpm_query_result"},{"line_number":44,"context_line":"      ignore_errors: true"},{"line_number":45,"context_line":"      failed_when:"},{"line_number":46,"context_line":"        - rpm_query_result.rc \u003e 0"},{"line_number":47,"context_line":"        - \u0027\"no package provides\" in rpm_query_result.stdout\u0027"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"743abc03_a7386215","line":44,"in_reply_to":"c82de6c3_18771942","updated":"2022-02-04 23:40:30.000000000","message":"thanks Kevin, `failed_when: false` works if I use `rpm_query_result.rc \u003e 0` as the condition for other tasks. I updated the patch to do this.","commit_id":"c0f294e9b4aa6f2489694fd1a2a1091ec8a136e6"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"68ff3f5702922b53a22533b7bc97bfc7af1396ee","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    - name: Check release version package is installed"},{"line_number":42,"context_line":"      command: \"rpm -q --whatprovides {{ tripleo_bootstrap_release_version_package | join(\u0027 \u0027) }}\""},{"line_number":43,"context_line":"      register: rpm_query_result"},{"line_number":44,"context_line":"      ignore_errors: true"},{"line_number":45,"context_line":"      failed_when:"},{"line_number":46,"context_line":"        - rpm_query_result.rc \u003e 0"},{"line_number":47,"context_line":"        - \u0027\"no package provides\" in rpm_query_result.stdout\u0027"},{"line_number":48,"context_line":"    - name: Deploy release version package"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"f7541f35_6f20478c","line":45,"range":{"start_line":44,"start_character":0,"end_line":45,"end_character":18},"updated":"2022-02-04 13:45:09.000000000","message":"Here we have the same issue I think, these two should not come together","commit_id":"c0f294e9b4aa6f2489694fd1a2a1091ec8a136e6"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"8a79be1892f36d42bfb2e0f76764e8254c6f04ff","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    - name: Check release version package is installed"},{"line_number":42,"context_line":"      command: \"rpm -q --whatprovides {{ tripleo_bootstrap_release_version_package | join(\u0027 \u0027) }}\""},{"line_number":43,"context_line":"      register: rpm_query_result"},{"line_number":44,"context_line":"      ignore_errors: true"},{"line_number":45,"context_line":"      failed_when:"},{"line_number":46,"context_line":"        - rpm_query_result.rc \u003e 0"},{"line_number":47,"context_line":"        - \u0027\"no package provides\" in rpm_query_result.stdout\u0027"},{"line_number":48,"context_line":"    - name: Deploy release version package"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f1c78b0_1abed62c","line":45,"range":{"start_line":44,"start_character":0,"end_line":45,"end_character":18},"in_reply_to":"2831922f_f95a4319","updated":"2022-02-04 23:41:33.000000000","message":"DONE.","commit_id":"c0f294e9b4aa6f2489694fd1a2a1091ec8a136e6"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"7e2dd301ac995750c3e27b4a43de00d690800956","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    - name: Check release version package is installed"},{"line_number":42,"context_line":"      command: \"rpm -q --whatprovides {{ tripleo_bootstrap_release_version_package | join(\u0027 \u0027) }}\""},{"line_number":43,"context_line":"      register: rpm_query_result"},{"line_number":44,"context_line":"      ignore_errors: true"},{"line_number":45,"context_line":"      failed_when:"},{"line_number":46,"context_line":"        - rpm_query_result.rc \u003e 0"},{"line_number":47,"context_line":"        - \u0027\"no package provides\" in rpm_query_result.stdout\u0027"},{"line_number":48,"context_line":"    - name: Deploy release version package"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"2831922f_f95a4319","line":45,"range":{"start_line":44,"start_character":0,"end_line":45,"end_character":18},"in_reply_to":"6c5399de_6498b46a","updated":"2022-02-04 15:04:34.000000000","message":"It seems ansible doc is suggesing \"command || /bin/true\" for shell tasks[1], or using ignore_errors[2].\n\nI fail to see the difference in using \"ignore_errors: yes\" and forcing a shell/command task to return \"0\".\n\n[1] https://docs.ansible.com/ansible/latest/user_guide/playbooks_error_handling.html#ensuring-success-for-command-and-shell\n[2] https://docs.ansible.com/ansible/latest/user_guide/playbooks_error_handling.html#ignoring-failed-commands","commit_id":"c0f294e9b4aa6f2489694fd1a2a1091ec8a136e6"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"5a52df1e4f02417e17da42f7faedc53d61d1c60f","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    - name: Check release version package is installed"},{"line_number":42,"context_line":"      command: \"rpm -q --whatprovides {{ tripleo_bootstrap_release_version_package | join(\u0027 \u0027) }}\""},{"line_number":43,"context_line":"      register: rpm_query_result"},{"line_number":44,"context_line":"      ignore_errors: true"},{"line_number":45,"context_line":"      failed_when:"},{"line_number":46,"context_line":"        - rpm_query_result.rc \u003e 0"},{"line_number":47,"context_line":"        - \u0027\"no package provides\" in rpm_query_result.stdout\u0027"},{"line_number":48,"context_line":"    - name: Deploy release version package"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"6c5399de_6498b46a","line":45,"range":{"start_line":44,"start_character":0,"end_line":45,"end_character":18},"in_reply_to":"8b3afdb5_d97bdd84","updated":"2022-02-04 15:02:09.000000000","message":"It seems ansible doc is suggesing \"command || /bin/true\" for shell tasks.\nI fail to see the difference in using \"ignore_errors: yes\" and forcing a shell/command task to return \"0\".\n\nhttps://docs.ansible.com/ansible/latest/user_guide/playbooks_error_handling.html#ensuring-success-for-command-and-shell","commit_id":"c0f294e9b4aa6f2489694fd1a2a1091ec8a136e6"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"797ab3dc5f7c75d1868770c3e087715423229e27","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    - name: Check release version package is installed"},{"line_number":42,"context_line":"      command: \"rpm -q --whatprovides {{ tripleo_bootstrap_release_version_package | join(\u0027 \u0027) }}\""},{"line_number":43,"context_line":"      register: rpm_query_result"},{"line_number":44,"context_line":"      ignore_errors: true"},{"line_number":45,"context_line":"      failed_when:"},{"line_number":46,"context_line":"        - rpm_query_result.rc \u003e 0"},{"line_number":47,"context_line":"        - \u0027\"no package provides\" in rpm_query_result.stdout\u0027"},{"line_number":48,"context_line":"    - name: Deploy release version package"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"8b3afdb5_d97bdd84","line":45,"range":{"start_line":44,"start_character":0,"end_line":45,"end_character":18},"in_reply_to":"f7541f35_6f20478c","updated":"2022-02-04 14:52:38.000000000","message":"If I remove ignore_errors, and keep just failed_when I get a \u0027fatal\u0027 error and ansible aborts the play-\n\n  - name: Is packages in list installed\n    command: \"rpm -q --whatprovides pkg-not-installed\n    register: rpm_query_result\n    failed_when:\n      - rpm_query_result.rc \u003e 0\n      - \u0027\"no package provides\" in rpm_query_result.stdout\u0027\n\n\nTASK [Is packages in list installed] ******************************************************************************************************************************************************************************************************************************************\nFriday 04 February 2022  14:49:48 +0000 (0:00:00.110)       0:00:00.110 ******* \n[WARNING]: Consider using the yum, dnf or zypper module rather than running \u0027rpm\u0027.  If you need to use command because yum, dnf or zypper is insufficient you can add \u0027warn: false\u0027 to this command task or set \u0027command_warnings\u003dFalse\u0027 in ansible.cfg to get rid of this\nmessage.\nfatal: [localhost]: FAILED! \u003d\u003e {\"changed\": true, \"cmd\": [\"rpm\", \"-q\", \"--whatprovides\", \"pkg-not-installed\"], \"delta\": \"0:00:00.024888\", \"end\": \"2022-02-04 14:49:48.756290\", \"failed_when_result\": true, \"msg\": \"non-zero return code\", \"rc\": 1, \"start\": \"2022-02-04 14:49:48.731402\", \"stderr\": \"\", \"stderr_lines\": [], \"stdout\": \"no package provides pkg-not-installed\", \"stdout_lines\": [\"no package provides pkg-not-installed\"]}","commit_id":"c0f294e9b4aa6f2489694fd1a2a1091ec8a136e6"}]}