)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f78ea018683d0c5f184c5e6adeeb48a0304214b2","unresolved":true,"context_lines":[{"line_number":13,"context_line":"only in the node where the API service is running, but also in"},{"line_number":14,"context_line":"the loadbalancer node where haproxy is running, otherwise the frontend"},{"line_number":15,"context_line":"port in haproxy is not accessible."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Related-Bug: #1961799"},{"line_number":18,"context_line":"Change-Id: I9d79df8a8d0eaf77166b296178b9b0622263998d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9cf2797a_772977ac","line":16,"updated":"2022-03-08 08:49:55.000000000","message":"so is there a patch that depends-on this to enable frontend and wireup some rules? if so can you please add reference to it here?","commit_id":"2bf48757e007e15354c5bc035ab564f238be1527"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8e99d14f7081257e87545c6ab7ede46b0544bedf","unresolved":false,"context_lines":[{"line_number":13,"context_line":"only in the node where the API service is running, but also in"},{"line_number":14,"context_line":"the loadbalancer node where haproxy is running, otherwise the frontend"},{"line_number":15,"context_line":"port in haproxy is not accessible."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Related-Bug: #1961799"},{"line_number":18,"context_line":"Change-Id: I9d79df8a8d0eaf77166b296178b9b0622263998d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9703fa88_ab187899","line":16,"in_reply_to":"9cf2797a_772977ac","updated":"2022-04-13 16:10:46.000000000","message":"Done","commit_id":"2bf48757e007e15354c5bc035ab564f238be1527"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"89f4019262dd2a2e76931aae5f7054e41797870a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"697c669b_91f905e9","updated":"2022-03-09 03:36:20.000000000","message":"Keeping WIP until the implementation in tht is completed.","commit_id":"2bf48757e007e15354c5bc035ab564f238be1527"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f78ea018683d0c5f184c5e6adeeb48a0304214b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"92742e96_ab0d6c0f","updated":"2022-03-08 08:49:55.000000000","message":"molecule needs some attention though","commit_id":"2bf48757e007e15354c5bc035ab564f238be1527"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"7818f0ea47553a4015162a770fd7a19e4e1aff70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"953a8960_74325c92","updated":"2022-03-18 07:50:44.000000000","message":"looks ok.. per earlier comment though canyou reference where this is being wired up somehwere?","commit_id":"e15f252ed8f9f95bc7b31fecf9fa8bf083c9d845"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"890ffe275866dd3bb00702008bec135cbbe6d144","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"b5df1ba5_7f0238ba","updated":"2022-04-28 03:58:09.000000000","message":"I\u0027ve confirmed frontend rules are enabled now in the tht patch.","commit_id":"f2760f5de319c07b233ea6821ef366601e557558"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"a47137683ef1fe10481b187402640b338f333eaf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"306861aa_766c5c7a","updated":"2022-04-15 09:37:27.000000000","message":"imho this one is good! It\u0027s better to maintain than the previous version, and is clearer. Maybe we\u0027ll be able to refactor it a bit in some follow-up, but with the current state of the tripleo_firewall and, especially, tripleo_iptables action, I don\u0027t think we can make it better.","commit_id":"f2760f5de319c07b233ea6821ef366601e557558"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0a4419192ad7eefd821662008d617da076377920","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"066ebdc3_be9426fb","updated":"2022-04-14 07:41:38.000000000","message":"let me put WIP now. until we get some feedback in the tht patch.","commit_id":"f2760f5de319c07b233ea6821ef366601e557558"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2eae371094be136c8fad4dfe784e8f3dcfc86984","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"623e7d77_4e228df2","updated":"2022-04-14 07:35:36.000000000","message":"looks OK, +2 even though not fully confident because I\u0027ve already used the +1 card a couple of times in this review ;)","commit_id":"f2760f5de319c07b233ea6821ef366601e557558"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"ba07679b8ed493bf1e7413c25ab57a4b6e5edd7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"7e864b4b_b64571ff","updated":"2022-04-28 06:14:12.000000000","message":"recheck\n\nSorry for the noise.","commit_id":"f2760f5de319c07b233ea6821ef366601e557558"}],"tripleo_ansible/roles/tripleo_firewall/defaults/main.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"0868cc37465a8916575f9281bfaab36d1e8393c2","unresolved":true,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"tripleo_firewall_frontend_rules: {}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"tripleo_firewall_merge_frontend_rules: false"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"tripleo_firewall_default_rules:"},{"line_number":39,"context_line":"  \u0027000 accept related established rules\u0027:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bae64695_90eb27c5","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":37},"updated":"2022-03-03 08:12:07.000000000","message":"where is it used?","commit_id":"cd7e1de0e3d049dc7a1bbee6ff6f66433e352c7f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ee7d92fd1c6599e05948a0bea903556de8877f27","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"tripleo_firewall_frontend_rules: {}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"tripleo_firewall_merge_frontend_rules: false"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"tripleo_firewall_default_rules:"},{"line_number":39,"context_line":"  \u0027000 accept related established rules\u0027:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a8613b65_7a8ac641","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":37},"in_reply_to":"bae64695_90eb27c5","updated":"2022-03-03 08:34:17.000000000","message":"This is no longer used. I added this initially but decided to use enabled services intead.","commit_id":"cd7e1de0e3d049dc7a1bbee6ff6f66433e352c7f"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"1a04d986fd80e53f954b5c5ac794200a408c5504","unresolved":true,"context_lines":[{"line_number":31,"context_line":"#     ensure: \u0027absent\u0027"},{"line_number":32,"context_line":"tripleo_firewall_rules: {}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"tripleo_firewall_frontend_enabled: false"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"tripleo_firewall_frontend_rules: {}"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ce9a00df_8904e728","line":34,"updated":"2022-04-28 06:06:53.000000000","message":"are the _enabled still needed? I don\u0027t see them set in the t-h-t thing?","commit_id":"f2760f5de319c07b233ea6821ef366601e557558"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"ba07679b8ed493bf1e7413c25ab57a4b6e5edd7d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"#     ensure: \u0027absent\u0027"},{"line_number":32,"context_line":"tripleo_firewall_rules: {}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"tripleo_firewall_frontend_enabled: false"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"tripleo_firewall_frontend_rules: {}"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"e4351525_cc7eec41","line":34,"in_reply_to":"c92fe1be_6e5b304e","updated":"2022-04-28 06:14:12.000000000","message":"Done","commit_id":"f2760f5de319c07b233ea6821ef366601e557558"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"b88f976d16ccbfb68065227eb3347708411276b1","unresolved":true,"context_lines":[{"line_number":31,"context_line":"#     ensure: \u0027absent\u0027"},{"line_number":32,"context_line":"tripleo_firewall_rules: {}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"tripleo_firewall_frontend_enabled: false"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"tripleo_firewall_frontend_rules: {}"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"c92fe1be_6e5b304e","line":34,"in_reply_to":"ce9a00df_8904e728","updated":"2022-04-28 06:11:15.000000000","message":"ah, found it!\nhttps://review.opendev.org/c/openstack/tripleo-heat-templates/+/831549/22/deployment/haproxy/haproxy-container-puppet.yaml\nhttps://review.opendev.org/c/openstack/tripleo-heat-templates/+/831549/22/deployment/haproxy/haproxy-edge-container-puppet.yaml","commit_id":"f2760f5de319c07b233ea6821ef366601e557558"}],"tripleo_ansible/roles/tripleo_firewall/tasks/main.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f78ea018683d0c5f184c5e6adeeb48a0304214b2","unresolved":true,"context_lines":[{"line_number":43,"context_line":"    - tripleo_firewall_frontend_enabled"},{"line_number":44,"context_line":"    - not tripleo_firewall_ssl_frontend_enabled"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- name: Set rule fact (with frontend ssl rules)"},{"line_number":47,"context_line":"  set_fact:"},{"line_number":48,"context_line":"    firewall_rules_sorted: \"{{"},{"line_number":49,"context_line":"      tripleo_firewall_default_rules |"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"723e9cca_4d07d90d","line":46,"updated":"2022-03-08 08:49:55.000000000","message":"this and previous task can go into a block and share the\n\n   when:\n    - tripleo_firewall_frontend_enabled\n\n(just suggestion)","commit_id":"2bf48757e007e15354c5bc035ab564f238be1527"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8e99d14f7081257e87545c6ab7ede46b0544bedf","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    - tripleo_firewall_frontend_enabled"},{"line_number":44,"context_line":"    - not tripleo_firewall_ssl_frontend_enabled"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- name: Set rule fact (with frontend ssl rules)"},{"line_number":47,"context_line":"  set_fact:"},{"line_number":48,"context_line":"    firewall_rules_sorted: \"{{"},{"line_number":49,"context_line":"      tripleo_firewall_default_rules |"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"af87eed7_3fd9e70f","line":46,"in_reply_to":"723e9cca_4d07d90d","updated":"2022-04-13 16:10:46.000000000","message":"Done","commit_id":"2bf48757e007e15354c5bc035ab564f238be1527"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f78ea018683d0c5f184c5e6adeeb48a0304214b2","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    firewall_rules_sorted: \"{{"},{"line_number":49,"context_line":"      tripleo_firewall_default_rules |"},{"line_number":50,"context_line":"      combine(tripleo_firewall_rules) |"},{"line_number":51,"context_line":"      combine(tripleo_firewall_frontend_rules) |"},{"line_number":52,"context_line":"      combine(tripleo_firewall_ssl_frontend_rules) |"},{"line_number":53,"context_line":"      dict2items(key_name\u003d\u0027rule_name\u0027, value_name\u003d\u0027rule\u0027) |"},{"line_number":54,"context_line":"      sort(attribute\u003d\u0027rule_name\u0027) |"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1b859703_7c3e200a","line":51,"range":{"start_line":51,"start_character":14,"end_line":51,"end_character":45},"updated":"2022-03-08 08:49:55.000000000","message":"sanity check do you still want this one here? it seems to be this one should have the tripleo_firewall_ssl_frontend_rules only?\n\n[EDIT]: yeah seems so based on the conditional thanks","commit_id":"2bf48757e007e15354c5bc035ab564f238be1527"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"7818f0ea47553a4015162a770fd7a19e4e1aff70","unresolved":true,"context_lines":[{"line_number":58,"context_line":"        }}\""},{"line_number":59,"context_line":"      when:"},{"line_number":60,"context_line":"        - tripleo_firewall_ssl_frontend_enabled"},{"line_number":61,"context_line":"  when:"},{"line_number":62,"context_line":"    - tripleo_firewall_frontend_enabled"},{"line_number":63,"context_line":"    - not tripleo_firewall_edge_frontend"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"4e4a893f_a7fb64c8","line":61,"range":{"start_line":61,"start_character":2,"end_line":61,"end_character":6},"updated":"2022-03-18 07:50:44.000000000","message":"that\u0027s all fine and correct but for readability/maintenance (tricky spacing) i always prefer the when: just before block: i.e.\n\n - name:\n   when: \n     - one\n     - two\n   block:\n     - stuff","commit_id":"e15f252ed8f9f95bc7b31fecf9fa8bf083c9d845"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f6e749982f9ec9897972f880ab3bbecf5bbfa13a","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        }}\""},{"line_number":59,"context_line":"      when:"},{"line_number":60,"context_line":"        - tripleo_firewall_ssl_frontend_enabled"},{"line_number":61,"context_line":"  when:"},{"line_number":62,"context_line":"    - tripleo_firewall_frontend_enabled"},{"line_number":63,"context_line":"    - not tripleo_firewall_edge_frontend"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"ed368a0b_36cd7aaa","line":61,"range":{"start_line":61,"start_character":2,"end_line":61,"end_character":6},"in_reply_to":"4e4a893f_a7fb64c8","updated":"2022-04-13 15:37:27.000000000","message":"Done","commit_id":"e15f252ed8f9f95bc7b31fecf9fa8bf083c9d845"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"b363254b24a25edf95df554ba966dc8ed4add51d","unresolved":true,"context_lines":[{"line_number":31,"context_line":"- name: Get masquerade rules"},{"line_number":32,"context_line":"  import_tasks: masquerade.yaml"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Set rule fact with frontend rules"},{"line_number":35,"context_line":"  when:"},{"line_number":36,"context_line":"    - tripleo_firewall_frontend_enabled"},{"line_number":37,"context_line":"    - not tripleo_firewall_edge_frontend"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"034e533e_7902ca8b","line":34,"updated":"2022-04-12 15:32:49.000000000","message":"this looks complicated a bit, perhaps an ansible plugin could help here?\nalso using just a single tripleo_firewall_rules data structure instead maybe","commit_id":"714652d2de0e1b34312f49e53ff609acb4b7cae9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8e99d14f7081257e87545c6ab7ede46b0544bedf","unresolved":false,"context_lines":[{"line_number":31,"context_line":"- name: Get masquerade rules"},{"line_number":32,"context_line":"  import_tasks: masquerade.yaml"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Set rule fact with frontend rules"},{"line_number":35,"context_line":"  when:"},{"line_number":36,"context_line":"    - tripleo_firewall_frontend_enabled"},{"line_number":37,"context_line":"    - not tripleo_firewall_edge_frontend"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"a520b661_15ac5eeb","line":34,"in_reply_to":"034e533e_7902ca8b","updated":"2022-04-13 16:10:46.000000000","message":"I\u0027ve refactored the logic. We\u0027d be able to create a plugin but I think the current logic is simple enough to be kept in playbook, I think.","commit_id":"714652d2de0e1b34312f49e53ff609acb4b7cae9"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2eae371094be136c8fad4dfe784e8f3dcfc86984","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Set the default frontend firewall rules"},{"line_number":35,"context_line":"  set_fact:"},{"line_number":36,"context_line":"    tripleo_firewall_frontend_rules_real: {}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"- name: When frontend rules are required"},{"line_number":39,"context_line":"  when: tripleo_firewall_frontend_enabled"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"c9ee4b02_fb82d564","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":3},"updated":"2022-04-14 07:35:36.000000000","message":"this one isn\u0027t really necessary ... if you remove you could just add a |default({})  in the following tasks (the first ones in each block)? k maybe cleaner like that up to you its a matter of preference i guess - marking resolved just a thought.","commit_id":"f2760f5de319c07b233ea6821ef366601e557558"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0a4419192ad7eefd821662008d617da076377920","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Set the default frontend firewall rules"},{"line_number":35,"context_line":"  set_fact:"},{"line_number":36,"context_line":"    tripleo_firewall_frontend_rules_real: {}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"- name: When frontend rules are required"},{"line_number":39,"context_line":"  when: tripleo_firewall_frontend_enabled"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"dd111fd9_d549d216","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":3},"in_reply_to":"c9ee4b02_fb82d564","updated":"2022-04-14 07:41:38.000000000","message":"We\u0027d be able to do that but we should be careful where we set default based on the potential code path (or can add defaults to everywhere)","commit_id":"f2760f5de319c07b233ea6821ef366601e557558"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2eae371094be136c8fad4dfe784e8f3dcfc86984","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        - name: Set frontend rule fact (ssl rules)"},{"line_number":52,"context_line":"          when: tripleo_firewall_ssl_frontend_enabled"},{"line_number":53,"context_line":"          set_fact:"},{"line_number":54,"context_line":"            tripleo_firewall_frontend_rules_real: \"{{"},{"line_number":55,"context_line":"              tripleo_firewall_frontend_rules_real |"},{"line_number":56,"context_line":"              combine(tripleo_firewall_ssl_frontend_rules)"},{"line_number":57,"context_line":"            }}\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7dfc2966_d525fcdd","line":54,"updated":"2022-04-14 07:35:36.000000000","message":"sanity check... this will then include both the non-ssl rules as well as the ssl rules (i think that is OK/makes sense)","commit_id":"f2760f5de319c07b233ea6821ef366601e557558"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0a4419192ad7eefd821662008d617da076377920","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        - name: Set frontend rule fact (ssl rules)"},{"line_number":52,"context_line":"          when: tripleo_firewall_ssl_frontend_enabled"},{"line_number":53,"context_line":"          set_fact:"},{"line_number":54,"context_line":"            tripleo_firewall_frontend_rules_real: \"{{"},{"line_number":55,"context_line":"              tripleo_firewall_frontend_rules_real |"},{"line_number":56,"context_line":"              combine(tripleo_firewall_ssl_frontend_rules)"},{"line_number":57,"context_line":"            }}\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"eb081d38_1f8112c4","line":54,"in_reply_to":"7dfc2966_d525fcdd","updated":"2022-04-14 07:41:38.000000000","message":"Yes. That is the current plan.","commit_id":"f2760f5de319c07b233ea6821ef366601e557558"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ee68cb47cf2698b863953707b9422570db3e7552","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        - name: Set frontend rule fact (ssl rules)"},{"line_number":52,"context_line":"          when: tripleo_firewall_ssl_frontend_enabled"},{"line_number":53,"context_line":"          set_fact:"},{"line_number":54,"context_line":"            tripleo_firewall_frontend_rules_real: \"{{"},{"line_number":55,"context_line":"              tripleo_firewall_frontend_rules_real |"},{"line_number":56,"context_line":"              combine(tripleo_firewall_ssl_frontend_rules)"},{"line_number":57,"context_line":"            }}\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"98b8064a_7b83b42d","line":54,"in_reply_to":"eb081d38_1f8112c4","updated":"2022-04-28 04:03:50.000000000","message":"Done","commit_id":"f2760f5de319c07b233ea6821ef366601e557558"}]}