)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"130b0960b7fc67ef5882a735ed7f747404b576e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"55300c82_720738a8","updated":"2022-04-28 12:03:07.000000000","message":"mmm, double thinking, shouldn\u0027t we rename the pop_defaults function?","commit_id":"abd707114ac5035b12085a6200ea91a9a3b32e75"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"92d4b9f03d2267db31c41ba90472fad9f37e0f15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7a78c339_d4550cb5","in_reply_to":"5242d8ff_3a50f4f2","updated":"2022-05-04 13:04:31.000000000","message":"well, it was just to comment that AFAIK the dns_domain to None is not the default value.\nAnother think to point out is that this might not be needed after this patch https://review.opendev.org/c/openstack/tripleo-heat-templates/+/839911 is merged, however IMHO this should be merged in case some upgrade is done without updating to the last release.","commit_id":"abd707114ac5035b12085a6200ea91a9a3b32e75"},{"author":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"change_message_id":"78474dc49fb93318b2921319acfba743e80caf84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5242d8ff_3a50f4f2","in_reply_to":"55300c82_720738a8","updated":"2022-05-03 23:23:33.000000000","message":"Not sure why, we do pop the defaults, and dns_domain defaults to None, so this change doesn\u0027t make the action of the method any different.","commit_id":"abd707114ac5035b12085a6200ea91a9a3b32e75"}],"tripleo_ansible/ansible_plugins/modules/tripleo_overcloud_network_extract.py":[{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"7686746977e576179c45ffc3f10ab36f30baf060","unresolved":true,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    net_dict \u003d {"},{"line_number":158,"context_line":"        \u0027name_lower\u0027: network.name,"},{"line_number":159,"context_line":"        \u0027dns_domain\u0027: network.dns_domain,"},{"line_number":160,"context_line":"        \u0027mtu\u0027: network.mtu,"},{"line_number":161,"context_line":"        \u0027shared\u0027: network.is_shared,"},{"line_number":162,"context_line":"        \u0027admin_state_up\u0027: network.is_admin_state_up,"}],"source_content_type":"text/x-python","patch_set":1,"id":"104a5488_89b74312","line":159,"updated":"2022-04-27 10:53:02.000000000","message":"Shouldn\u0027t this need to be removed?","commit_id":"abd707114ac5035b12085a6200ea91a9a3b32e75"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"ca1b4330376235bc4c319a15afdc5c810e37ec50","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    net_dict \u003d {"},{"line_number":158,"context_line":"        \u0027name_lower\u0027: network.name,"},{"line_number":159,"context_line":"        \u0027dns_domain\u0027: network.dns_domain,"},{"line_number":160,"context_line":"        \u0027mtu\u0027: network.mtu,"},{"line_number":161,"context_line":"        \u0027shared\u0027: network.is_shared,"},{"line_number":162,"context_line":"        \u0027admin_state_up\u0027: network.is_admin_state_up,"}],"source_content_type":"text/x-python","patch_set":1,"id":"02c60481_c0c67eeb","line":159,"in_reply_to":"104a5488_89b74312","updated":"2022-04-27 10:55:22.000000000","message":"Not if dns_domain is set. We remove it if it is None on L152.","commit_id":"abd707114ac5035b12085a6200ea91a9a3b32e75"}]}