)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"18f71b7adc756faa63c846e0e999fcf8ee74a517","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"03c018c1_ea4aea34","updated":"2022-05-17 04:15:59.000000000","message":"Few cleanups, rest looks good.","commit_id":"8892cf2c077a1f2b2e4869d26959bd233bd298cd"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"8aebd4f92e9a3e2c5f03e3217ab60ba47994c32b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f7041625_b114aa94","updated":"2022-05-24 07:14:09.000000000","message":"job needs to be renamed from centos-8 to centos-stream","commit_id":"dab54683b545c44295caff783941f7526fed3638"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f7828fef99e8ef6a8fb91a593c1ec167629fe046","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"e623ccbc_c49ca5d9","updated":"2022-06-27 15:20:41.000000000","message":"PTAL","commit_id":"076d9f6a5f514e6ebfaf03af71346422d3b145c1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"550f579e47de59ef8709f999583108ffa8eb984f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"4292111b_93826003","updated":"2022-06-27 15:09:54.000000000","message":"just fixed linting issues sitting here and breaking all changes on top","commit_id":"076d9f6a5f514e6ebfaf03af71346422d3b145c1"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"ad9affb53c7686a2de432f5f997a2ebdba5a3fe5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"dcd48245_32507a9b","updated":"2022-07-14 12:00:23.000000000","message":"Some files should really be dropped in order to keep a clean tree.\nAlso wondering about the tasks/main.yml. And that \"omit\" in template. Not sure about the expected effect actually.","commit_id":"35a117a2a886ddb4c6660139d92c75aaf92b73ee"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"9082770ba7850c6c5a05a0a5cf409d0c93286626","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"854b661d_c5c8f7ae","updated":"2022-07-14 15:55:31.000000000","message":"yup, I vaguely recall omit in templates doesn\u0027t work","commit_id":"35a117a2a886ddb4c6660139d92c75aaf92b73ee"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"a7e4e7541bc4f09713f586a768b69b1cfa704937","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"28a4deb1_39d474a4","in_reply_to":"dcd48245_32507a9b","updated":"2022-08-18 20:24:59.000000000","message":"done!","commit_id":"35a117a2a886ddb4c6660139d92c75aaf92b73ee"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"517badf83eb64cd83ade3156619e57625b5f83cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"0e881940_4017358a","updated":"2022-09-21 08:53:11.000000000","message":"Seems good.","commit_id":"6ce1ee4e4af83cd32d64fb43c3fcba0ee2b45bac"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"0a15c3755a1be46559790a4de710b1ca8c8b1f51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"ea7359da_9a152336","updated":"2022-09-20 13:01:01.000000000","message":"Works fine here https://review.opendev.org/c/openstack/tripleo-ci/+/843836","commit_id":"6ce1ee4e4af83cd32d64fb43c3fcba0ee2b45bac"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"2b37ab78a60f16afd1d7e1a024015696f1ed5e3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"11432c24_ee2c8ddc","updated":"2022-10-11 16:03:38.000000000","message":"Code looks good to me. I would like to see it actually run though, which I guess we should see when Zuul runs this change:\nhttps://review.opendev.org/c/openstack/tripleo-ansible/+/840509/50/tripleo_ansible/playbooks/deploy-tripleo-openstack-configure.yml#29","commit_id":"a0baae551526e8ce88ae690d443d41338866a062"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"551a0b365667445ee6d91a9710d511ba7b4e623d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"683288b0_91ba8467","updated":"2022-10-19 02:11:00.000000000","message":"I guess we might want to fix the comments made for the cronie loop package install. But otherwise I think this looks good.\n\nI know this is just a single package. But in general, I would avoid using loop with any of the package related Ansible modules. Each item in the loop is a new invocation of the package install process. So `dnf install package_1; dnf install package_2; dnf install package_3`. This is fairly inefficient, we\u0027re better of putting the list of packages directly into the name field, like they do in the example:\n```\n- name: Install the latest version of Apache and MariaDB\n  ansible.builtin.package:\n    name:\n      - httpd\n      - mariadb-server\n    state: latest\n\n```\n\nWhich gives you a single invocation of `dnf install http mariadb-server -y`","commit_id":"07da592289f10aea677cb7d72cee89cfc1ebbb3d"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"cf615be76a7ed836b4c9d3bdc7da4a2483033fdc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"f7222fc7_a93cb51f","updated":"2022-10-12 20:50:37.000000000","message":"recheck","commit_id":"07da592289f10aea677cb7d72cee89cfc1ebbb3d"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"41c6bb8e1313ee08e11eaa34d4be957e28d7cde3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"f404fd4a_bdcab13c","updated":"2022-10-20 12:31:38.000000000","message":"LGTM, but would love seeing another core on it as well.","commit_id":"f95668bd8ed5c336eae5b4c7cdb7ba7d925401ac"}],"tripleo_ansible/roles/tripleo_logrotate_crond/files/.gitkeep":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"ad9affb53c7686a2de432f5f997a2ebdba5a3fe5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":16,"id":"6aa30cab_4a02991b","updated":"2022-07-14 12:00:23.000000000","message":"we can drop that one imho.","commit_id":"35a117a2a886ddb4c6660139d92c75aaf92b73ee"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"a7e4e7541bc4f09713f586a768b69b1cfa704937","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"3f723193_13b16d02","in_reply_to":"6aa30cab_4a02991b","updated":"2022-08-18 20:24:59.000000000","message":"Done","commit_id":"35a117a2a886ddb4c6660139d92c75aaf92b73ee"}],"tripleo_ansible/roles/tripleo_logrotate_crond/handlers/main.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"bdbfcc2a6870f31958b53a69adfc7861105ae111","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e9568ad6_94bf1f31","updated":"2022-05-19 15:22:48.000000000","message":"delete this file.","commit_id":"1b4f8841e6fc716588d37761d6718dc769d6256c"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"a7e4e7541bc4f09713f586a768b69b1cfa704937","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ad3cec7b_110775c1","in_reply_to":"6a4fecc7_3c3c6840","updated":"2022-08-18 20:24:59.000000000","message":"Done","commit_id":"1b4f8841e6fc716588d37761d6718dc769d6256c"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"ad9affb53c7686a2de432f5f997a2ebdba5a3fe5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6a4fecc7_3c3c6840","in_reply_to":"e9568ad6_94bf1f31","updated":"2022-07-14 12:00:23.000000000","message":"+1","commit_id":"1b4f8841e6fc716588d37761d6718dc769d6256c"}],"tripleo_ansible/roles/tripleo_logrotate_crond/molecule/default/Dockerfile":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"18f71b7adc756faa63c846e0e999fcf8ee74a517","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"79d3d380_f4ab3445","updated":"2022-05-17 04:15:59.000000000","message":"This file is no longer needed in favor of https://opendev.org/openstack/tripleo-ansible/src/branch/master/.config/molecule/Dockerfile.j2","commit_id":"8892cf2c077a1f2b2e4869d26959bd233bd298cd"}],"tripleo_ansible/roles/tripleo_logrotate_crond/molecule/default/molecule.yml":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"18f71b7adc756faa63c846e0e999fcf8ee74a517","unresolved":true,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"log: true"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"platforms:"},{"line_number":8,"context_line":"  - name: centos"},{"line_number":9,"context_line":"    hostname: centos"},{"line_number":10,"context_line":"    image: centos/centos:stream8"},{"line_number":11,"context_line":"    registry:"},{"line_number":12,"context_line":"      url: quay.io"},{"line_number":13,"context_line":"    dockerfile: Dockerfile"},{"line_number":14,"context_line":"    pkg_extras: python*setuptools"},{"line_number":15,"context_line":"    volumes:"},{"line_number":16,"context_line":"      - /etc/ci/mirror_info.sh:/etc/ci/mirror_info.sh:ro"},{"line_number":17,"context_line":"      - /etc/pki/rpm-gpg:/etc/pki/rpm-gpg"},{"line_number":18,"context_line":"      - /etc/dnf/vars:/etc/dnf/vars"},{"line_number":19,"context_line":"    privileged: true"},{"line_number":20,"context_line":"    environment: \u0026env"},{"line_number":21,"context_line":"      http_proxy: \"{{ lookup(\u0027env\u0027, \u0027http_proxy\u0027) }}\""},{"line_number":22,"context_line":"      https_proxy: \"{{ lookup(\u0027env\u0027, \u0027https_proxy\u0027) }}\""},{"line_number":23,"context_line":"    ulimits: \u0026ulimit"},{"line_number":24,"context_line":"      - host"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"provisioner:"},{"line_number":27,"context_line":"  inventory:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"37a25d47_9bc4fea8","line":24,"range":{"start_line":7,"start_character":0,"end_line":24,"end_character":12},"updated":"2022-05-17 04:15:59.000000000","message":"We can remove this one and https://opendev.org/openstack/tripleo-ansible/src/branch/master/.config/molecule/config_podman.yml#L3 will take care of that.","commit_id":"8892cf2c077a1f2b2e4869d26959bd233bd298cd"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"8aebd4f92e9a3e2c5f03e3217ab60ba47994c32b","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"log: true"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"platforms:"},{"line_number":8,"context_line":"  - name: centos"},{"line_number":9,"context_line":"    hostname: centos"},{"line_number":10,"context_line":"    image: centos/centos:stream8"},{"line_number":11,"context_line":"    registry:"},{"line_number":12,"context_line":"      url: quay.io"},{"line_number":13,"context_line":"    dockerfile: Dockerfile"},{"line_number":14,"context_line":"    pkg_extras: python*setuptools"},{"line_number":15,"context_line":"    volumes:"},{"line_number":16,"context_line":"      - /etc/ci/mirror_info.sh:/etc/ci/mirror_info.sh:ro"},{"line_number":17,"context_line":"      - /etc/pki/rpm-gpg:/etc/pki/rpm-gpg"},{"line_number":18,"context_line":"      - /etc/dnf/vars:/etc/dnf/vars"},{"line_number":19,"context_line":"    privileged: true"},{"line_number":20,"context_line":"    environment: \u0026env"},{"line_number":21,"context_line":"      http_proxy: \"{{ lookup(\u0027env\u0027, \u0027http_proxy\u0027) }}\""},{"line_number":22,"context_line":"      https_proxy: \"{{ lookup(\u0027env\u0027, \u0027https_proxy\u0027) }}\""},{"line_number":23,"context_line":"    ulimits: \u0026ulimit"},{"line_number":24,"context_line":"      - host"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"provisioner:"},{"line_number":27,"context_line":"  inventory:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"231cc605_2c9f2ef8","line":24,"range":{"start_line":7,"start_character":0,"end_line":24,"end_character":12},"in_reply_to":"37a25d47_9bc4fea8","updated":"2022-05-24 07:14:09.000000000","message":"Done","commit_id":"8892cf2c077a1f2b2e4869d26959bd233bd298cd"}],"tripleo_ansible/roles/tripleo_logrotate_crond/molecule/default/prepare.yml":[{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"a70bae54b89d7379776140ddb442b8e5650cb289","unresolved":true,"context_lines":[{"line_number":26,"context_line":"        name: \"{{ item }}\""},{"line_number":27,"context_line":"        state: latest"},{"line_number":28,"context_line":"      loop:"},{"line_number":29,"context_line":"        - cronie"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"6b77e41c_9f2e5c90","line":29,"updated":"2022-09-22 10:24:29.000000000","message":"Why not put directly the list in package ansible module? Only one item and package can take a list directly.","commit_id":"3ef8f8ec910a806be21889459538c3b3e4c4c638"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f7bfb0834f3168fc3dd3b3f1c67a85bd7313c4fc","unresolved":true,"context_lines":[{"line_number":26,"context_line":"        name: \"{{ item }}\""},{"line_number":27,"context_line":"        state: latest"},{"line_number":28,"context_line":"      loop:"},{"line_number":29,"context_line":"        - cronie"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"9fc171b0_5bb2d500","line":29,"in_reply_to":"68385cfb_8c4c6bde","updated":"2022-10-17 15:28:50.000000000","message":"so WDYT, can this be removed?","commit_id":"3ef8f8ec910a806be21889459538c3b3e4c4c638"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4492ce940abb68d8564ea564f6beb71170206097","unresolved":true,"context_lines":[{"line_number":26,"context_line":"        name: \"{{ item }}\""},{"line_number":27,"context_line":"        state: latest"},{"line_number":28,"context_line":"      loop:"},{"line_number":29,"context_line":"        - cronie"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"68385cfb_8c4c6bde","line":29,"in_reply_to":"6b77e41c_9f2e5c90","updated":"2022-10-07 14:51:22.000000000","message":"do we still need this after https://review.opendev.org/c/openstack/tripleo-ansible/+/841997/18..21/tripleo_ansible/roles/tripleo_logrotate_crond/tasks/install.yml#18 has beeb added?","commit_id":"3ef8f8ec910a806be21889459538c3b3e4c4c638"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"5bd41c087ebbb38d8d2264f70bc74228baca11d1","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        name: \"{{ item }}\""},{"line_number":27,"context_line":"        state: latest"},{"line_number":28,"context_line":"      loop:"},{"line_number":29,"context_line":"        - cronie"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"70d8209e_170390a3","line":29,"in_reply_to":"9fc171b0_5bb2d500","updated":"2022-10-19 14:43:57.000000000","message":"removed it, and added calling install.yml from converge.yml","commit_id":"3ef8f8ec910a806be21889459538c3b3e4c4c638"}],"tripleo_ansible/roles/tripleo_logrotate_crond/tasks/configure.yml":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"3b552ac8d771842f7b5aa2739b8e15dca81362d8","unresolved":true,"context_lines":[{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: configure tmpwatch on the host"},{"line_number":19,"context_line":"  block:"},{"line_number":20,"context_line":"    - name: Push script"},{"line_number":21,"context_line":"      copy:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"f5125313_b24fe253","line":18,"updated":"2022-09-07 08:26:21.000000000","message":"I\u0027d ensure we\u0027re running as root by adding a \"become: true\" for the different blocks.","commit_id":"6ce1ee4e4af83cd32d64fb43c3fcba0ee2b45bac"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"1766856f182b3bf9566e3442dda1c9a3ccd6136b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: configure tmpwatch on the host"},{"line_number":19,"context_line":"  block:"},{"line_number":20,"context_line":"    - name: Push script"},{"line_number":21,"context_line":"      copy:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"e27bbdd8_85c7d691","line":18,"in_reply_to":"9c5be361_6fb6e6e1","updated":"2022-10-11 20:59:11.000000000","message":"i think we\u0027ve assumed running with --become in the past as the tripleo-admin user was only used for the SSH connection. However, for the sake of standalone-roles, we should probably add become:true where it\u0027s needed.","commit_id":"6ce1ee4e4af83cd32d64fb43c3fcba0ee2b45bac"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"2b37ab78a60f16afd1d7e1a024015696f1ed5e3f","unresolved":true,"context_lines":[{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: configure tmpwatch on the host"},{"line_number":19,"context_line":"  block:"},{"line_number":20,"context_line":"    - name: Push script"},{"line_number":21,"context_line":"      copy:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9c5be361_6fb6e6e1","line":18,"in_reply_to":"f5125313_b24fe253","updated":"2022-10-11 16:03:38.000000000","message":"Given that everything here seems to be writing to files outside of the users home dir. I assume this entire playbook will be ran with `become: true`?\n\nMaybe slagle can confirm?","commit_id":"6ce1ee4e4af83cd32d64fb43c3fcba0ee2b45bac"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"3b552ac8d771842f7b5aa2739b8e15dca81362d8","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        - \"{{ tripleo_logrotate_crond_config_dir }}/var/spool/cron\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    - name: Render logrotate-crond.conf"},{"line_number":54,"context_line":"      ansible.builtin.template:"},{"line_number":55,"context_line":"        src: logrotate-crond.conf.j2"},{"line_number":56,"context_line":"        dest: \"{{ tripleo_logrotate_crond_config_dir }}/etc/logrotate-crond.conf\""},{"line_number":57,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"46edb332_89fd7617","line":54,"range":{"start_line":54,"start_character":6,"end_line":54,"end_character":22},"updated":"2022-09-07 08:26:21.000000000","message":"iirc there\u0027s no need to prefix with \"ansible.builtin\". Else you\u0027d need to prefix the \"cron\" as well as \"copy\" and others to be consistent.","commit_id":"6ce1ee4e4af83cd32d64fb43c3fcba0ee2b45bac"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"6abaa9dde73670bf029b00dba3eb242d8e096f79","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        - \"{{ tripleo_logrotate_crond_config_dir }}/var/spool/cron\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    - name: Render logrotate-crond.conf"},{"line_number":54,"context_line":"      ansible.builtin.template:"},{"line_number":55,"context_line":"        src: logrotate-crond.conf.j2"},{"line_number":56,"context_line":"        dest: \"{{ tripleo_logrotate_crond_config_dir }}/etc/logrotate-crond.conf\""},{"line_number":57,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"664cb4be_0579b29c","line":54,"range":{"start_line":54,"start_character":6,"end_line":54,"end_character":22},"in_reply_to":"46edb332_89fd7617","updated":"2022-09-29 01:38:26.000000000","message":"Yeah, I agree that this should be consistent within the role. But tbh, I lean the opposite way and generally prefer FQCN for all module references. This is also in-line with Ansible recommendations, if we take file as an example:\nhttps://docs.ansible.com/ansible/latest/collections/ansible/builtin/file_module.html\n\nMy preference would be that we use FQCN everywhere. But if we don\u0027t want to do that, we should at least be consistent.","commit_id":"6ce1ee4e4af83cd32d64fb43c3fcba0ee2b45bac"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"1766856f182b3bf9566e3442dda1c9a3ccd6136b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        - \"{{ tripleo_logrotate_crond_config_dir }}/var/spool/cron\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    - name: Render logrotate-crond.conf"},{"line_number":54,"context_line":"      ansible.builtin.template:"},{"line_number":55,"context_line":"        src: logrotate-crond.conf.j2"},{"line_number":56,"context_line":"        dest: \"{{ tripleo_logrotate_crond_config_dir }}/etc/logrotate-crond.conf\""},{"line_number":57,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"541bd3f5_e0299929","line":54,"range":{"start_line":54,"start_character":6,"end_line":54,"end_character":22},"in_reply_to":"664cb4be_0579b29c","updated":"2022-10-11 20:59:11.000000000","message":"i\u0027ve removed it for now. we can always revisit the convention later.","commit_id":"6ce1ee4e4af83cd32d64fb43c3fcba0ee2b45bac"}],"tripleo_ansible/roles/tripleo_logrotate_crond/tasks/install.yml":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"84d0563f9a66a5284689992997cd83db6d495733","unresolved":true,"context_lines":[{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: allow logrotate to read inside containers"},{"line_number":19,"context_line":"  seboolean:"},{"line_number":20,"context_line":"    name: logrotate_read_inside_containers"},{"line_number":21,"context_line":"    persistent: true"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"4986c948_0eef9607","line":18,"updated":"2022-09-14 15:36:08.000000000","message":"https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_a5a/843836/28/check/tripleo-ci-centos-9-singlenode-external-compute-standalone/a5a5a7b/logs/undercloud/home/zuul/overcloud_compute.log\n```\nTASK [tripleo_logrotate_crond : allow logrotate to read inside containers] *****\nfatal: [localhost]: FAILED! \u003d\u003e {\"changed\": false, \"msg\": \"Cannot set persistent booleans; please try as root\"}\n```","commit_id":"6ce1ee4e4af83cd32d64fb43c3fcba0ee2b45bac"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"0a15c3755a1be46559790a4de710b1ca8c8b1f51","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: allow logrotate to read inside containers"},{"line_number":19,"context_line":"  seboolean:"},{"line_number":20,"context_line":"    name: logrotate_read_inside_containers"},{"line_number":21,"context_line":"    persistent: true"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ee237380_bacbc224","line":18,"in_reply_to":"4986c948_0eef9607","updated":"2022-09-20 13:01:01.000000000","message":"Done","commit_id":"6ce1ee4e4af83cd32d64fb43c3fcba0ee2b45bac"}],"tripleo_ansible/roles/tripleo_logrotate_crond/tasks/main.yml":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"ad9affb53c7686a2de432f5f997a2ebdba5a3fe5","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2022 Red Hat, Inc."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"8a274f13_a9212330","line":1,"updated":"2022-07-14 12:00:23.000000000","message":"really useful? since it doesn\u0027t import any of the other task files, we can more than probably drop main.yml (unless it\u0027s needed for some obscure reasons, of course).","commit_id":"35a117a2a886ddb4c6660139d92c75aaf92b73ee"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"a7e4e7541bc4f09713f586a768b69b1cfa704937","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Copyright 2022 Red Hat, Inc."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"8fd9cc74_d269d496","line":1,"in_reply_to":"8a274f13_a9212330","updated":"2022-08-18 20:24:59.000000000","message":"Done","commit_id":"35a117a2a886ddb4c6660139d92c75aaf92b73ee"}],"tripleo_ansible/roles/tripleo_logrotate_crond/templates/logrotate-crond.conf.j2":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"bdbfcc2a6870f31958b53a69adfc7861105ae111","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/var/log/containers/*/*log /var/log/containers/*/*/*log /var/log/containers/*/*err {                  "},{"line_number":2,"context_line":"  {{ tripleo_logrotate_crond_rotation }}"},{"line_number":3,"context_line":"  rotate {{ tripleo_logrotate_crond_rotate }}"},{"line_number":4,"context_line":"  maxage {{ tripleo_logrotate_crond_purge_after_days }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"363e456d_e1f65ec0","line":1,"range":{"start_line":1,"start_character":84,"end_line":1,"end_character":102},"updated":"2022-05-19 15:22:48.000000000","message":"white space?","commit_id":"1b4f8841e6fc716588d37761d6718dc769d6256c"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"6abaa9dde73670bf029b00dba3eb242d8e096f79","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/var/log/containers/*/*log /var/log/containers/*/*/*log /var/log/containers/*/*err {                  "},{"line_number":2,"context_line":"  {{ tripleo_logrotate_crond_rotation }}"},{"line_number":3,"context_line":"  rotate {{ tripleo_logrotate_crond_rotate }}"},{"line_number":4,"context_line":"  maxage {{ tripleo_logrotate_crond_purge_after_days }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9bc3e864_60c5dee6","line":1,"range":{"start_line":1,"start_character":84,"end_line":1,"end_character":102},"in_reply_to":"0be85908_e9cb4d90","updated":"2022-09-29 01:38:26.000000000","message":"Done","commit_id":"1b4f8841e6fc716588d37761d6718dc769d6256c"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"a70bae54b89d7379776140ddb442b8e5650cb289","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/var/log/containers/*/*log /var/log/containers/*/*/*log /var/log/containers/*/*err {                  "},{"line_number":2,"context_line":"  {{ tripleo_logrotate_crond_rotation }}"},{"line_number":3,"context_line":"  rotate {{ tripleo_logrotate_crond_rotate }}"},{"line_number":4,"context_line":"  maxage {{ tripleo_logrotate_crond_purge_after_days }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"0be85908_e9cb4d90","line":1,"range":{"start_line":1,"start_character":84,"end_line":1,"end_character":102},"in_reply_to":"363e456d_e1f65ec0","updated":"2022-09-22 10:24:29.000000000","message":"This one seems resolved.","commit_id":"1b4f8841e6fc716588d37761d6718dc769d6256c"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2bff0f52640b2353981e90ddf96efb58322a98f3","unresolved":true,"context_lines":[{"line_number":12,"context_line":"  {{ tripleo_logrotate_crond_notifempty | ternary(\u0027notifempty\u0027, \u0027\u0027, omit) }}"},{"line_number":13,"context_line":"  {{ tripleo_logrotate_crond_copytruncate | ternary(\u0027copytruncate\u0027, \u0027\u0027, omit) }}"},{"line_number":14,"context_line":"  {{ tripleo_logrotate_crond_delaycompress | ternary(\u0027delaycompress\u0027, \u0027\u0027, omit) }}"},{"line_number":15,"context_line":"  {{ tripleo_logrotate_crond_compress | ternary(\u0027compress\u0027, \u0027\u0027, omit) }}"},{"line_number":16,"context_line":"{% if tripleo_logrotate_crond_dateext -%}"},{"line_number":17,"context_line":"  dateext"},{"line_number":18,"context_line":"  {% if tripleo_logrotate_crond_dateformat -%}"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"b8265b84_3e8b806d","line":15,"updated":"2022-06-27 15:23:35.000000000","message":"the last time I checked using omit in templates, it was leaving a weird python object link as the value, instead of omitting it","commit_id":"076d9f6a5f514e6ebfaf03af71346422d3b145c1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"0f58a6e1e562912a91edc9d2ccff1052aef095da","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  {{ tripleo_logrotate_crond_notifempty | ternary(\u0027notifempty\u0027, \u0027\u0027, omit) }}"},{"line_number":13,"context_line":"  {{ tripleo_logrotate_crond_copytruncate | ternary(\u0027copytruncate\u0027, \u0027\u0027, omit) }}"},{"line_number":14,"context_line":"  {{ tripleo_logrotate_crond_delaycompress | ternary(\u0027delaycompress\u0027, \u0027\u0027, omit) }}"},{"line_number":15,"context_line":"  {{ tripleo_logrotate_crond_compress | ternary(\u0027compress\u0027, \u0027\u0027, omit) }}"},{"line_number":16,"context_line":"{% if tripleo_logrotate_crond_dateext -%}"},{"line_number":17,"context_line":"  dateext"},{"line_number":18,"context_line":"  {% if tripleo_logrotate_crond_dateformat -%}"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"ac27bb1e_caab91c3","line":15,"in_reply_to":"6efb6b20_134edd8b","updated":"2022-09-01 14:24:38.000000000","message":"Done","commit_id":"076d9f6a5f514e6ebfaf03af71346422d3b145c1"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"ad9affb53c7686a2de432f5f997a2ebdba5a3fe5","unresolved":true,"context_lines":[{"line_number":12,"context_line":"  {{ tripleo_logrotate_crond_notifempty | ternary(\u0027notifempty\u0027, \u0027\u0027, omit) }}"},{"line_number":13,"context_line":"  {{ tripleo_logrotate_crond_copytruncate | ternary(\u0027copytruncate\u0027, \u0027\u0027, omit) }}"},{"line_number":14,"context_line":"  {{ tripleo_logrotate_crond_delaycompress | ternary(\u0027delaycompress\u0027, \u0027\u0027, omit) }}"},{"line_number":15,"context_line":"  {{ tripleo_logrotate_crond_compress | ternary(\u0027compress\u0027, \u0027\u0027, omit) }}"},{"line_number":16,"context_line":"{% if tripleo_logrotate_crond_dateext -%}"},{"line_number":17,"context_line":"  dateext"},{"line_number":18,"context_line":"  {% if tripleo_logrotate_crond_dateformat -%}"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"c1cdd27e_c568547f","line":15,"in_reply_to":"b8265b84_3e8b806d","updated":"2022-07-14 12:00:23.000000000","message":"indeed - it wasn\u0027t that a good experience for me and created many issues...","commit_id":"076d9f6a5f514e6ebfaf03af71346422d3b145c1"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"a7e4e7541bc4f09713f586a768b69b1cfa704937","unresolved":true,"context_lines":[{"line_number":12,"context_line":"  {{ tripleo_logrotate_crond_notifempty | ternary(\u0027notifempty\u0027, \u0027\u0027, omit) }}"},{"line_number":13,"context_line":"  {{ tripleo_logrotate_crond_copytruncate | ternary(\u0027copytruncate\u0027, \u0027\u0027, omit) }}"},{"line_number":14,"context_line":"  {{ tripleo_logrotate_crond_delaycompress | ternary(\u0027delaycompress\u0027, \u0027\u0027, omit) }}"},{"line_number":15,"context_line":"  {{ tripleo_logrotate_crond_compress | ternary(\u0027compress\u0027, \u0027\u0027, omit) }}"},{"line_number":16,"context_line":"{% if tripleo_logrotate_crond_dateext -%}"},{"line_number":17,"context_line":"  dateext"},{"line_number":18,"context_line":"  {% if tripleo_logrotate_crond_dateformat -%}"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"6efb6b20_134edd8b","line":15,"in_reply_to":"c1cdd27e_c568547f","updated":"2022-08-18 20:24:59.000000000","message":"This worked for me in the generated config. Can you share any of the issues?","commit_id":"076d9f6a5f514e6ebfaf03af71346422d3b145c1"}],"tripleo_ansible/roles/tripleo_logrotate_crond/vars/main.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"bdbfcc2a6870f31958b53a69adfc7861105ae111","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e329f25b_c5f8fb9b","updated":"2022-05-19 15:22:48.000000000","message":"delete this file.","commit_id":"1b4f8841e6fc716588d37761d6718dc769d6256c"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"a7e4e7541bc4f09713f586a768b69b1cfa704937","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5c3651d8_1d9e151e","in_reply_to":"21e0ac9d_125afdd1","updated":"2022-08-18 20:24:59.000000000","message":"Done","commit_id":"1b4f8841e6fc716588d37761d6718dc769d6256c"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"ad9affb53c7686a2de432f5f997a2ebdba5a3fe5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"21e0ac9d_125afdd1","in_reply_to":"e329f25b_c5f8fb9b","updated":"2022-07-14 12:00:23.000000000","message":"+1","commit_id":"1b4f8841e6fc716588d37761d6718dc769d6256c"}],"zuul.d/molecule.yaml":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"8aebd4f92e9a3e2c5f03e3217ab60ba47994c32b","unresolved":true,"context_lines":[{"line_number":34,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_hieradata"},{"line_number":35,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_hosts_entries"},{"line_number":36,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_image_serve"},{"line_number":37,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_iscsid"},{"line_number":38,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_kernel"},{"line_number":39,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_keystone"},{"line_number":40,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_keystone_resources"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"0bb061ec_ebfb4f59","line":37,"range":{"start_line":37,"start_character":8,"end_line":37,"end_character":56},"updated":"2022-05-24 07:14:09.000000000","message":"It needs to be renamed to tripleo-ansible-centos-stream-molecule-tripleo_iscsid","commit_id":"dab54683b545c44295caff783941f7526fed3638"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"77616968a6fae78a621d08751664a9c23567f510","unresolved":false,"context_lines":[{"line_number":34,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_hieradata"},{"line_number":35,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_hosts_entries"},{"line_number":36,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_image_serve"},{"line_number":37,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_iscsid"},{"line_number":38,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_kernel"},{"line_number":39,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_keystone"},{"line_number":40,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_keystone_resources"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"17a70324_78091f8c","line":37,"range":{"start_line":37,"start_character":8,"end_line":37,"end_character":56},"in_reply_to":"0bb061ec_ebfb4f59","updated":"2022-10-19 14:45:21.000000000","message":"Done","commit_id":"dab54683b545c44295caff783941f7526fed3638"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"8aebd4f92e9a3e2c5f03e3217ab60ba47994c32b","unresolved":true,"context_lines":[{"line_number":38,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_kernel"},{"line_number":39,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_keystone"},{"line_number":40,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_keystone_resources"},{"line_number":41,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_logrotate_crond"},{"line_number":42,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_lvmfilter"},{"line_number":43,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_metrics_qdr"},{"line_number":44,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_module_load"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ffb843d1_22974b2d","line":41,"range":{"start_line":41,"start_character":8,"end_line":41,"end_character":65},"updated":"2022-05-24 07:14:09.000000000","message":"ditto","commit_id":"dab54683b545c44295caff783941f7526fed3638"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"77616968a6fae78a621d08751664a9c23567f510","unresolved":false,"context_lines":[{"line_number":38,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_kernel"},{"line_number":39,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_keystone"},{"line_number":40,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_keystone_resources"},{"line_number":41,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_logrotate_crond"},{"line_number":42,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_lvmfilter"},{"line_number":43,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_metrics_qdr"},{"line_number":44,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_module_load"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"982b00f5_77cf681c","line":41,"range":{"start_line":41,"start_character":8,"end_line":41,"end_character":65},"in_reply_to":"ffb843d1_22974b2d","updated":"2022-10-19 14:45:21.000000000","message":"resolved","commit_id":"dab54683b545c44295caff783941f7526fed3638"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"8aebd4f92e9a3e2c5f03e3217ab60ba47994c32b","unresolved":true,"context_lines":[{"line_number":102,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_hieradata"},{"line_number":103,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_hosts_entries"},{"line_number":104,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_image_serve"},{"line_number":105,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_iscsid"},{"line_number":106,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_kernel"},{"line_number":107,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_keystone"},{"line_number":108,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_keystone_resources"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"8b8b15ed_1e4e5f4e","line":105,"range":{"start_line":105,"start_character":8,"end_line":105,"end_character":56},"updated":"2022-05-24 07:14:09.000000000","message":"ditto","commit_id":"dab54683b545c44295caff783941f7526fed3638"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"77616968a6fae78a621d08751664a9c23567f510","unresolved":false,"context_lines":[{"line_number":102,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_hieradata"},{"line_number":103,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_hosts_entries"},{"line_number":104,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_image_serve"},{"line_number":105,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_iscsid"},{"line_number":106,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_kernel"},{"line_number":107,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_keystone"},{"line_number":108,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_keystone_resources"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"11cb3d02_f6e160d3","line":105,"range":{"start_line":105,"start_character":8,"end_line":105,"end_character":56},"in_reply_to":"8b8b15ed_1e4e5f4e","updated":"2022-10-19 14:45:21.000000000","message":"Done","commit_id":"dab54683b545c44295caff783941f7526fed3638"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"8aebd4f92e9a3e2c5f03e3217ab60ba47994c32b","unresolved":true,"context_lines":[{"line_number":106,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_kernel"},{"line_number":107,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_keystone"},{"line_number":108,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_keystone_resources"},{"line_number":109,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_logrotate_crond"},{"line_number":110,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_lvmfilter"},{"line_number":111,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_metrics_qdr"},{"line_number":112,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_module_load"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"672c3844_1ec04892","line":109,"range":{"start_line":109,"start_character":8,"end_line":109,"end_character":65},"updated":"2022-05-24 07:14:09.000000000","message":"ditto","commit_id":"dab54683b545c44295caff783941f7526fed3638"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"77616968a6fae78a621d08751664a9c23567f510","unresolved":false,"context_lines":[{"line_number":106,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_kernel"},{"line_number":107,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_keystone"},{"line_number":108,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_keystone_resources"},{"line_number":109,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_logrotate_crond"},{"line_number":110,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_lvmfilter"},{"line_number":111,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_metrics_qdr"},{"line_number":112,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_module_load"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"82112b77_e587a658","line":109,"range":{"start_line":109,"start_character":8,"end_line":109,"end_character":65},"in_reply_to":"672c3844_1ec04892","updated":"2022-10-19 14:45:21.000000000","message":"Done","commit_id":"dab54683b545c44295caff783941f7526fed3638"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"8aebd4f92e9a3e2c5f03e3217ab60ba47994c32b","unresolved":true,"context_lines":[{"line_number":169,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_hieradata"},{"line_number":170,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_hosts_entries"},{"line_number":171,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_image_serve"},{"line_number":172,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_iscsid"},{"line_number":173,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_kernel"},{"line_number":174,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_keystone"},{"line_number":175,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_keystone_resources"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"dc0f643b_fbf2f3f3","line":172,"range":{"start_line":172,"start_character":7,"end_line":172,"end_character":56},"updated":"2022-05-24 07:14:09.000000000","message":"s/8/stream","commit_id":"dab54683b545c44295caff783941f7526fed3638"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"77616968a6fae78a621d08751664a9c23567f510","unresolved":false,"context_lines":[{"line_number":169,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_hieradata"},{"line_number":170,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_hosts_entries"},{"line_number":171,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_image_serve"},{"line_number":172,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_iscsid"},{"line_number":173,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_kernel"},{"line_number":174,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_keystone"},{"line_number":175,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_keystone_resources"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7de483e4_4e0c9b80","line":172,"range":{"start_line":172,"start_character":7,"end_line":172,"end_character":56},"in_reply_to":"dc0f643b_fbf2f3f3","updated":"2022-10-19 14:45:21.000000000","message":"Done","commit_id":"dab54683b545c44295caff783941f7526fed3638"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"8aebd4f92e9a3e2c5f03e3217ab60ba47994c32b","unresolved":true,"context_lines":[{"line_number":173,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_kernel"},{"line_number":174,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_keystone"},{"line_number":175,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_keystone_resources"},{"line_number":176,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_logrotate_crond"},{"line_number":177,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_lvmfilter"},{"line_number":178,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_module_load"},{"line_number":179,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_multipathd"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"f56d5993_828a919a","line":176,"range":{"start_line":176,"start_character":8,"end_line":176,"end_character":65},"updated":"2022-05-24 07:14:09.000000000","message":"s/8/stream","commit_id":"dab54683b545c44295caff783941f7526fed3638"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"77616968a6fae78a621d08751664a9c23567f510","unresolved":false,"context_lines":[{"line_number":173,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_kernel"},{"line_number":174,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_keystone"},{"line_number":175,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_keystone_resources"},{"line_number":176,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_logrotate_crond"},{"line_number":177,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_lvmfilter"},{"line_number":178,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_module_load"},{"line_number":179,"context_line":"      - tripleo-ansible-centos-8-molecule-tripleo_multipathd"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"db4b63a4_e33e5e35","line":176,"range":{"start_line":176,"start_character":8,"end_line":176,"end_character":65},"in_reply_to":"f56d5993_828a919a","updated":"2022-10-19 14:45:21.000000000","message":"Done","commit_id":"dab54683b545c44295caff783941f7526fed3638"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"8aebd4f92e9a3e2c5f03e3217ab60ba47994c32b","unresolved":true,"context_lines":[{"line_number":436,"context_line":"      tripleo_role_name: tripleo_image_serve"},{"line_number":437,"context_line":"- job:"},{"line_number":438,"context_line":"    files:"},{"line_number":439,"context_line":"    - ^tripleo_ansible/roles/tripleo_iscsid/(?!meta).*"},{"line_number":440,"context_line":"    name: tripleo-ansible-centos-8-molecule-tripleo_iscsid"},{"line_number":441,"context_line":"    parent: tripleo-ansible-centos-8-base"},{"line_number":442,"context_line":"    vars:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"b7f6e7a5_c1cbb031","line":439,"updated":"2022-05-24 07:14:09.000000000","message":"centos-8 needs to be renamed to centos-stream","commit_id":"dab54683b545c44295caff783941f7526fed3638"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"471f66088aa95585d8bb80edccda0278c4485202","unresolved":false,"context_lines":[{"line_number":436,"context_line":"      tripleo_role_name: tripleo_image_serve"},{"line_number":437,"context_line":"- job:"},{"line_number":438,"context_line":"    files:"},{"line_number":439,"context_line":"    - ^tripleo_ansible/roles/tripleo_iscsid/(?!meta).*"},{"line_number":440,"context_line":"    name: tripleo-ansible-centos-8-molecule-tripleo_iscsid"},{"line_number":441,"context_line":"    parent: tripleo-ansible-centos-8-base"},{"line_number":442,"context_line":"    vars:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a4df607a_420464b5","line":439,"in_reply_to":"b7f6e7a5_c1cbb031","updated":"2022-10-19 14:45:29.000000000","message":"Done","commit_id":"dab54683b545c44295caff783941f7526fed3638"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"8aebd4f92e9a3e2c5f03e3217ab60ba47994c32b","unresolved":true,"context_lines":[{"line_number":465,"context_line":"- job:"},{"line_number":466,"context_line":"    files:"},{"line_number":467,"context_line":"    - ^tripleo_ansible/roles/tripleo_logrotate_crond/(?!meta).*"},{"line_number":468,"context_line":"    name: tripleo-ansible-centos-8-molecule-tripleo_logrotate_crond"},{"line_number":469,"context_line":"    parent: tripleo-ansible-centos-8-base"},{"line_number":470,"context_line":"    vars:"},{"line_number":471,"context_line":"      tripleo_role_name: tripleo_logrotate_crond"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba71fc3d_8d514583","line":468,"updated":"2022-05-24 07:14:09.000000000","message":"ditto","commit_id":"dab54683b545c44295caff783941f7526fed3638"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"77616968a6fae78a621d08751664a9c23567f510","unresolved":false,"context_lines":[{"line_number":465,"context_line":"- job:"},{"line_number":466,"context_line":"    files:"},{"line_number":467,"context_line":"    - ^tripleo_ansible/roles/tripleo_logrotate_crond/(?!meta).*"},{"line_number":468,"context_line":"    name: tripleo-ansible-centos-8-molecule-tripleo_logrotate_crond"},{"line_number":469,"context_line":"    parent: tripleo-ansible-centos-8-base"},{"line_number":470,"context_line":"    vars:"},{"line_number":471,"context_line":"      tripleo_role_name: tripleo_logrotate_crond"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"53cf14bd_5b8fe3c9","line":468,"in_reply_to":"ba71fc3d_8d514583","updated":"2022-10-19 14:45:21.000000000","message":"Done","commit_id":"dab54683b545c44295caff783941f7526fed3638"}]}