)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"40d91041eeb71a2a3ec81dbd44909cee2570980d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"b0be9f0f_df885fdb","updated":"2022-06-27 15:17:55.000000000","message":"In which ways does this address the ssh configuration server/client split we have today in ansible vs puppet? The latter is only used for live migration IIRC?..","commit_id":"f88c77e6a799038a66a4499868596a6d7e86083d"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"30779263a6284c0bde811dbb8ad1748b2ef95cac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"d5682f6b_ef030543","in_reply_to":"659cbaf8_187562e4","updated":"2022-10-12 13:53:39.000000000","message":"there is no such item there yet...","commit_id":"f88c77e6a799038a66a4499868596a6d7e86083d"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"3b292cb4a997f98674f5b8a2ac370cc7cb57e658","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"659cbaf8_187562e4","in_reply_to":"a27df05d_d2b3596b","updated":"2022-10-11 21:03:26.000000000","message":"This only addresses sshd configuration for the host. It\u0027s meant to be the same functionality as deployment/sshd/sshd-baremetal-ansible.yaml from tripleo-heat-templates. \n\nConfiguring the individual sshd daemons for migration would be a different role, or we could adapt this role to handle different instance configurations later.\n\nDo you know if we have a work item for migration on the etherpad?","commit_id":"f88c77e6a799038a66a4499868596a6d7e86083d"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"5ffbb4adb11d8de8c78cc0d3b14536c897ce2255","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"a27df05d_d2b3596b","in_reply_to":"b0be9f0f_df885fdb","updated":"2022-10-07 14:45:04.000000000","message":"could you please comment?","commit_id":"f88c77e6a799038a66a4499868596a6d7e86083d"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"61bafa1e1a7550425d16ba519e9a112a406a768c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"0a120fac_3f26ea27","updated":"2022-09-26 06:24:35.000000000","message":"Cool, looks good now.","commit_id":"212936fb33533bd79fc2852992f9a9ac77a10d2c"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"9f919b23bbe4b07199bd4c1871fb4b5289e32fe5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"febd0667_0332de88","updated":"2022-10-12 20:51:05.000000000","message":"recheck","commit_id":"212936fb33533bd79fc2852992f9a9ac77a10d2c"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"63ea833cd707c1f56ad4d9dfb637978a162ca6ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"2d1f8299_0ee8a16c","updated":"2022-10-13 10:47:31.000000000","message":"recheck unrelated error","commit_id":"212936fb33533bd79fc2852992f9a9ac77a10d2c"}],"tripleo_ansible/roles/tripleo_sshd/tasks/configure.yml":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"ec90cd65d44f6a7155b79af14420853b7e4e8559","unresolved":true,"context_lines":[{"line_number":41,"context_line":"          should be reviewed to ensure general user access is functional and"},{"line_number":42,"context_line":"          meeting expectations."},{"line_number":43,"context_line":"      when:"},{"line_number":44,"context_line":"        - (tripleo_sshd_password_authentication !\u003d \u0027no\u0027) and"},{"line_number":45,"context_line":"          not (\u0027PermitRootLogin\u0027 in tripleo_sshd_server_options)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    - name: PasswordAuthentication duplication notice"},{"line_number":48,"context_line":"      debug:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"f7e2c0ca_73a469b7","line":45,"range":{"start_line":44,"start_character":7,"end_line":45,"end_character":64},"updated":"2022-07-14 12:04:26.000000000","message":"this can be set as a standard list:\nwhen:\n - first condition\n - second condition\n \nWould be more readable imho.","commit_id":"5310c40eb79a1c19182bf361cac932e6c6e17c7b"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"ebc7fcf67af6b6268256ccd9d6ee3cfe32d7f65d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"          should be reviewed to ensure general user access is functional and"},{"line_number":42,"context_line":"          meeting expectations."},{"line_number":43,"context_line":"      when:"},{"line_number":44,"context_line":"        - (tripleo_sshd_password_authentication !\u003d \u0027no\u0027) and"},{"line_number":45,"context_line":"          not (\u0027PermitRootLogin\u0027 in tripleo_sshd_server_options)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    - name: PasswordAuthentication duplication notice"},{"line_number":48,"context_line":"      debug:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"47bcde6b_c8e1db85","line":45,"range":{"start_line":44,"start_character":7,"end_line":45,"end_character":64},"in_reply_to":"f7e2c0ca_73a469b7","updated":"2022-09-23 00:26:21.000000000","message":"copied from t-h-t, but i\u0027ll fix it","commit_id":"5310c40eb79a1c19182bf361cac932e6c6e17c7b"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"ec90cd65d44f6a7155b79af14420853b7e4e8559","unresolved":true,"context_lines":[{"line_number":51,"context_line":"          `tripleo_sshd_server_options` but the values are different."},{"line_number":52,"context_line":"          The `tripleo_sshd_password_authentication` value will be used."},{"line_number":53,"context_line":"      when:"},{"line_number":54,"context_line":"        - (\u0027PasswordAuthentication\u0027 in tripleo_sshd_server_options and"},{"line_number":55,"context_line":"          tripleo_sshd_password_authentication !\u003d tripleo_sshd_server_options[\u0027PasswordAuthentication\u0027])"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    - name: Motd duplication notice"},{"line_number":58,"context_line":"      debug:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"1709312a_0dcddaae","line":55,"range":{"start_line":54,"start_character":7,"end_line":55,"end_character":104},"updated":"2022-07-14 12:04:26.000000000","message":"ditto","commit_id":"5310c40eb79a1c19182bf361cac932e6c6e17c7b"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"ebc7fcf67af6b6268256ccd9d6ee3cfe32d7f65d","unresolved":false,"context_lines":[{"line_number":51,"context_line":"          `tripleo_sshd_server_options` but the values are different."},{"line_number":52,"context_line":"          The `tripleo_sshd_password_authentication` value will be used."},{"line_number":53,"context_line":"      when:"},{"line_number":54,"context_line":"        - (\u0027PasswordAuthentication\u0027 in tripleo_sshd_server_options and"},{"line_number":55,"context_line":"          tripleo_sshd_password_authentication !\u003d tripleo_sshd_server_options[\u0027PasswordAuthentication\u0027])"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    - name: Motd duplication notice"},{"line_number":58,"context_line":"      debug:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"dba29c0e_387adebe","line":55,"range":{"start_line":54,"start_character":7,"end_line":55,"end_character":104},"in_reply_to":"1709312a_0dcddaae","updated":"2022-09-23 00:26:21.000000000","message":"ditto","commit_id":"5310c40eb79a1c19182bf361cac932e6c6e17c7b"}],"tripleo_ansible/roles/tripleo_sshd/tasks/install.yml":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"ec90cd65d44f6a7155b79af14420853b7e4e8559","unresolved":true,"context_lines":[{"line_number":38,"context_line":"        state: \"{{ tripleo_sshd_package_state }}\""},{"line_number":39,"context_line":"      register: _sshd_install_result"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    # NOTE(mwhahaha): we need this here because in order to validate our generated"},{"line_number":42,"context_line":"    # config, we need to ensure the host keys exist"},{"line_number":43,"context_line":"    - name: Generate sshd host keys"},{"line_number":44,"context_line":"      shell: ssh-keygen -A"},{"line_number":45,"context_line":"      when:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"4f76824e_ee692096","line":42,"range":{"start_line":41,"start_character":4,"end_line":42,"end_character":51},"updated":"2022-07-14 12:04:26.000000000","message":"is that comment still relevant?","commit_id":"5310c40eb79a1c19182bf361cac932e6c6e17c7b"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"ebc7fcf67af6b6268256ccd9d6ee3cfe32d7f65d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        state: \"{{ tripleo_sshd_package_state }}\""},{"line_number":39,"context_line":"      register: _sshd_install_result"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    # NOTE(mwhahaha): we need this here because in order to validate our generated"},{"line_number":42,"context_line":"    # config, we need to ensure the host keys exist"},{"line_number":43,"context_line":"    - name: Generate sshd host keys"},{"line_number":44,"context_line":"      shell: ssh-keygen -A"},{"line_number":45,"context_line":"      when:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"602509f2_9e1f4b24","line":42,"range":{"start_line":41,"start_character":4,"end_line":42,"end_character":51},"in_reply_to":"4f76824e_ee692096","updated":"2022-09-23 00:26:21.000000000","message":"yes","commit_id":"5310c40eb79a1c19182bf361cac932e6c6e17c7b"}],"tripleo_ansible/roles/tripleo_sshd/tasks/run.yml":[{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"c3059f475fd5a73cb62213ad1ea7c15a01b03207","unresolved":true,"context_lines":[{"line_number":42,"context_line":"        name: sshd"},{"line_number":43,"context_line":"        state: started"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    - name: Restart sshd due to config change"},{"line_number":46,"context_line":"      systemd:"},{"line_number":47,"context_line":"        name: sshd"},{"line_number":48,"context_line":"        state: reloaded"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"75f365ad_0e8f9336","line":45,"updated":"2022-08-10 10:43:40.000000000","message":"This kind of _sshd_config_result_changed condition task looks to me as candidate for ansible handler type task. What do you think about starting using handlers in standalone roles? Will this work with togther with tht mechanism or by introducing this we will break some compatiblity.","commit_id":"5310c40eb79a1c19182bf361cac932e6c6e17c7b"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"ebc7fcf67af6b6268256ccd9d6ee3cfe32d7f65d","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        name: sshd"},{"line_number":43,"context_line":"        state: started"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    - name: Restart sshd due to config change"},{"line_number":46,"context_line":"      systemd:"},{"line_number":47,"context_line":"        name: sshd"},{"line_number":48,"context_line":"        state: reloaded"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"418bb419_6ecab5cc","line":45,"in_reply_to":"75f365ad_0e8f9336","updated":"2022-09-23 00:26:21.000000000","message":"this was copied from t-h-t. personally, i don\u0027t like handlers, just for the sake of using handlers. makes it harder to read, and you have to logically jump around. It\u0027s easier to visualize the task order by just looking at it.\n\nif there was going to be a lot of task de-duplication by switching to a handler, i could see it. but this is just one task.","commit_id":"5310c40eb79a1c19182bf361cac932e6c6e17c7b"},{"author":{"_account_id":30073,"name":"Brendan Shephard","email":"bshephar@bne-home.net","username":"bshephar"},"change_message_id":"42053b7b727d15cbb5894e13f2f0fb20393a6bc5","unresolved":true,"context_lines":[{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# found within the \"vars/\" path. If no OS files are found the task will skip."},{"line_number":18,"context_line":"- name: Gather variables for each operating system"},{"line_number":19,"context_line":"  include_vars: \"{{ item }}\""},{"line_number":20,"context_line":"  with_first_found:"},{"line_number":21,"context_line":"    - skip: true"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"441e20c2_d9f0e65a","line":18,"updated":"2022-09-23 03:33:55.000000000","message":"We don\u0027t use any vars in this playbook. Seems we could drop this task here.","commit_id":"1b965db11ea2dd42542bc48cd052fa392c4fca0b"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"4695840e4292ed66273dfd65c153853e22f5ced0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# found within the \"vars/\" path. If no OS files are found the task will skip."},{"line_number":18,"context_line":"- name: Gather variables for each operating system"},{"line_number":19,"context_line":"  include_vars: \"{{ item }}\""},{"line_number":20,"context_line":"  with_first_found:"},{"line_number":21,"context_line":"    - skip: true"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"c2168ff7_83fa7524","line":18,"in_reply_to":"441e20c2_d9f0e65a","updated":"2022-09-23 17:50:22.000000000","message":"Done","commit_id":"1b965db11ea2dd42542bc48cd052fa392c4fca0b"}]}